Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: don't hardcode numberic fields in user search

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2019-09-10 20:40:49 -04:00
parent 0843497dd4
commit 09410ff1c5
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/user/search.js
View File

@@ -4,6 +4,7 @@
const meta = require('../meta'); const meta = require('../meta');
const plugins = require('../plugins'); const plugins = require('../plugins');
const db = require('../database'); const db = require('../database');
const utils = require('../utils');
module.exports = function (User) { module.exports = function (User) {
User.search = async function (data) { User.search = async function (data) {
@@ -108,7 +109,11 @@ module.exports = function (User) {
} }
function sortUsers(userData, sortBy) { function sortUsers(userData, sortBy) {
if (sortBy === 'joindate' || sortBy === 'postcount' || sortBy === 'reputation') { if (!userData || !userData.length) {
return;
}
const isNumeric = utils.isNumber(userData[0][sortBy]);
if (isNumeric) {
userData.sort((u1, u2) => u2[sortBy] - u1[sortBy]); userData.sort((u1, u2) => u2[sortBy] - u1[sortBy]);
} else { } else {
userData.sort(function (u1, u2) { userData.sort(function (u1, u2) {