Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: guard against multiple resolves

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2021-04-29 10:47:23 -04:00
parent 8789716ae4
commit 084c985117
2 changed files with 33 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/plugins/hooks.js
View File

@@ -128,19 +128,28 @@ async function fireFilterHook(hook, hookList, params) {
return await hookObj.method(params);
}
return new Promise((resolve, reject) => {
let resolved = false;
function _resolve(result) {
if (resolved) {
winston.warn(`[plugins] ${hook} already resolved in plugin ${hookObj.id}`);
return;
}
resolved = true;
resolve(result);
}
const returned = hookObj.method(params, (err, result) => {
if (err) reject(err); else resolve(result);
if (err) reject(err); else _resolve(result);
});
if (utils.isPromise(returned)) {
returned.then(
payload => resolve(payload),
payload => _resolve(payload),
err => reject(err)
);
return;
}
if (returned) {
resolve(returned);
_resolve(returned);
}
});
}