Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-02 12:05:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix uploading a file with no extension resulting in invalid-extension even if the file extension list is blank (allow all)

Browse Source
This commit is contained in:
Ben Lubar
2017-06-16 10:37:23 -05:00
parent f4fb9ee04b
commit 07982a3fa2
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/controllers/uploads.js
View File

@@ -217,13 +217,10 @@ uploadsController.uploadFile = function (uid, uploadedFile, callback) {
}; };
function saveFileToLocal(uploadedFile, callback) { function saveFileToLocal(uploadedFile, callback) {
var extension = path.extname(uploadedFile.name);
if (!extension || extension === '.') {
return callback(new Error('[[error:invalid-extension]]'));
}
var filename = uploadedFile.name || 'upload'; var filename = uploadedFile.name || 'upload';
var extension = path.extname(filename) || '';
filename = Date.now() + '-' + validator.escape(filename.replace(path.extname(uploadedFile.name) || '', '')).substr(0, 255) + extension; filename = Date.now() + '-' + validator.escape(filename.substr(0, filename.length - extension.length)).substr(0, 255) + extension;
async.waterfall([ async.waterfall([
function (next) { function (next) {