Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-01 19:46:01 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: #8120, bubble errors from static hooks

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2020-01-17 13:30:57 -05:00
parent b0f3e48ac2
commit 01d1ae78c8
2 changed files with 35 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/plugins.js
View File

@@ -120,7 +120,7 @@ describe('Plugins', function () {
});
});
it('should register and fire a static hook returning a promise that gets rejected with a warning only', function (done) {
it('should register and fire a static hook returning a promise that gets rejected with a error', function (done) {
function method(data) {
assert.equal(data.bar, 'test');
return new Promise(function (resolve, reject) {
@@ -129,7 +129,8 @@ describe('Plugins', function () {
}
plugins.registerHook('test-plugin', { hook: 'static:test.hook', method: method });
plugins.fireHook('static:test.hook', { bar: 'test' }, function (err) {
assert.ifError(err);
assert.strictEqual(err.message, 'just because');
plugins.unregisterHook('test-plugin', 'static:test.hook', method);
done();
});
});
@@ -144,6 +145,7 @@ describe('Plugins', function () {
plugins.registerHook('test-plugin', { hook: 'static:test.hook', method: method });
plugins.fireHook('static:test.hook', { bar: 'test' }, function (err) {
assert.ifError(err);
plugins.unregisterHook('test-plugin', 'static:test.hook', method);
done();
});
});