Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-09 07:25:46 +01:00
Code Issues Packages Projects Releases Wiki Activity

perf: make digests a little bit faster

Browse Source 
and use batch.processArray
dont load data for users who have no email or have not confirmed their emails
This commit is contained in:
Barış Soner Uşaklı
2021-02-09 15:27:08 -05:00
parent b6493f896f
commit 0185ea1b4f
2 changed files with 54 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/emailer.js
View File

@@ -216,22 +216,22 @@ Emailer.send = async (template, uid, params) => {
throw Error('[emailer] App not ready!');
}
const [userData, userSettings] = await Promise.all([
User.getUserFields(uid, ['email', 'username', 'email:confirmed']),
User.getSettings(uid),
]);
const userData = await User.getUserFields(uid, ['email', 'username', 'email:confirmed']);
if (!userData || !userData.email) {
winston.warn(`uid : ${uid} has no email, not sending "${template}" email.`);
if (process.env.NODE_ENV === 'development') {
winston.warn(`uid : ${uid} has no email, not sending "${template}" email.`);
}
return;
}
const allowedTpls = ['verify_email', 'welcome', 'registration_accepted'];
if (meta.config.requireEmailConfirmation && !userData['email:confirmed'] && !allowedTpls.includes(template)) {
winston.warn(`uid : ${uid} (${userData.email}) has not confirmed email, not sending "${template}" email.`);
if (process.env.NODE_ENV === 'development') {
winston.warn(`uid : ${uid} (${userData.email}) has not confirmed email, not sending "${template}" email.`);
}
return;
}
const userSettings = await User.getSettings(uid);
// Combined passed-in payload with default values
params = { ...Emailer._defaultPayload, ...params };
params.uid = uid;