Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-03 20:45:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: closes #12365, staticHooks with callbacks

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2024-02-26 00:50:22 -05:00
parent c61b3bbd25
commit 00e29403f0
1 changed files with 30 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

59
src/plugins/hooks.js
View File

@@ -207,22 +207,7 @@ Hooks.hasListeners = function (hook) {
return !!(plugins.loadedHooks[hook] && plugins.loadedHooks[hook].length > 0);
};
async function fireFilterHook(hook, hookList, params) {
if (!Array.isArray(hookList) || !hookList.length) {
return params;
}
async function fireMethod(hookObj, params) {
if (typeof hookObj.method !== 'function') {
if (global.env === 'development') {
winston.warn(`[plugins] Expected method for hook '${hook}' in plugin '${hookObj.id}' not found, skipping.`);
}
return params;
}
if (hookObj.method.constructor && hookObj.method.constructor.name === 'AsyncFunction') {
return await hookObj.method(params);
}
function hookHandlerPromise(hook, hookObj, params) {
return new Promise((resolve, reject) => {
let resolved = false;
function _resolve(result) {
@@ -248,6 +233,25 @@ async function fireFilterHook(hook, hookList, params) {
_resolve(returned);
}
});
}
async function fireFilterHook(hook, hookList, params) {
if (!Array.isArray(hookList) || !hookList.length) {
return params;
}
async function fireMethod(hookObj, params) {
if (typeof hookObj.method !== 'function') {
if (global.env === 'development') {
winston.warn(`[plugins] Expected method for hook '${hook}' in plugin '${hookObj.id}' not found, skipping.`);
}
return params;
}
if (hookObj.method.constructor && hookObj.method.constructor.name === 'AsyncFunction') {
return await hookObj.method(params);
}
return hookHandlerPromise(hook, hookObj, params);
}
for (const hookObj of hookList) {
@@ -303,28 +307,7 @@ async function fireStaticHook(hook, hookList, params) {
return timeout(hookObj.method(params), 10000, 'timeout');
}
return new Promise((resolve, reject) => {
let resolved = false;
function _resolve(result) {
if (resolved) {
return;
}
resolved = true;
resolve(result);
}
const returned = hookObj.method(params, (err, result) => {
if (err) reject(err); else _resolve(result);
});
if (utils.isPromise(returned)) {
returned.then(
payload => _resolve(payload),
err => reject(err)
);
return;
}
_resolve();
});
return hookHandlerPromise(hook, hookObj, params);
}
for (const hookObj of hookList) {