Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: topic postercount field if owner is changed

Browse Source 
also fix when posts are purged
This commit is contained in:
Barış Soner Uşaklı
2023-07-18 12:38:17 -04:00
parent 86dd04d5fd
commit 00be053e94
3 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/posts/delete.js
View File

@@ -116,7 +116,9 @@ module.exports = function (Posts) {
const topicPostCountTasks = [];
const topicTasks = [];
const zsetIncrBulk = [];
const tids = [];
for (const [tid, posts] of Object.entries(postsByTopic)) {
tids.push(tid);
incrObjectBulk.push([`topic:${tid}`, { postcount: -posts.length }]);
if (posts.length && posts[0]) {
const topicData = posts[0].topic;
@@ -142,6 +144,14 @@ module.exports = function (Posts) {
user.updatePostCount(_.uniq(postData.map(p => p.uid))),
notifications.rescind(...postData.map(p => `new_post:tid:${p.tid}:pid:${p.pid}:uid:${p.uid}`)),
]);
const tidPosterZsets = tids.map(tid => `tid:${tid}:posters`);
await db.sortedSetsRemoveRangeByScore(tidPosterZsets, '-inf', 0);
const posterCounts = await db.sortedSetsCard(tidPosterZsets);
await db.setObjectBulk(
tids.map((tid, idx) => (
[`topic:${tid}`, { postercount: posterCounts[idx] || 0 }]
))
);
}
async function deleteFromCategoryRecentPosts(postData) {

3
src/posts/user.js
View File

@@ -206,6 +206,9 @@ module.exports = function (Posts) {
await async.eachOf(postsByUser, async (posts, uid) => {
await db.sortedSetIncrBy(`tid:${tid}:posters`, -posts.length, uid);
});
await db.sortedSetsRemoveRangeByScore([`tid:${tid}:posters`], '-inf', 0);
const posterCount = await db.sortedSetCard(`tid:${tid}:posters`);
await topics.setTopicField(tid, 'postercount', posterCount);
});
}

4
test/posts.js
View File

@@ -114,7 +114,7 @@ describe('Post\'s', () => {
await posts.changeOwner([pid1, pid2], newUid);
assert.deepStrictEqual(await db.sortedSetScores(`tid:${postResult.topicData.tid}:posters`, [oldUid, newUid]), [0, 2]);
assert.deepStrictEqual(await db.sortedSetScores(`tid:${postResult.topicData.tid}:posters`, [oldUid, newUid]), [null, 2]);
assert.deepStrictEqual(await posts.isOwner([pid1, pid2], oldUid), [false, false]);
assert.deepStrictEqual(await posts.isOwner([pid1, pid2], newUid), [true, true]);
@@ -130,6 +130,8 @@ describe('Post\'s', () => {
assert.strictEqual(await topics.isOwner(postResult.topicData.tid, oldUid), false);
assert.strictEqual(await topics.isOwner(postResult.topicData.tid, newUid), true);
assert.strictEqual(await topics.getTopicField(postResult.topicData.tid, 'postercount'), 1);
});
it('should fail to change owner if new owner does not exist', async () => {