Shafi Ahmed
0a0baeb3b0
fix: auto-expand and auto-scroll for actions logs ( #35570 ) ( #35583 )
...
Implements reliable auto-expand and auto-scroll behavior for the Actions
logs view.
* Expands running or unfinished steps automatically.
* Smoothly scrolls to the latest log line during execution.
* Controlled via existing “Always auto-scroll” and “Expand running
steps” options.
Fixes #35570 .
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-10-05 10:31:06 +08:00
silverwind
f6f6aedd4f
Update JS deps, regenerate SVGs ( #34640 )
...
Result of `make update-js svg`.
2025-06-07 17:59:36 +00:00
wxiaoguang
e8d8984f7c
Fix some trivial problems ( #34579 )
2025-06-02 15:22:43 +00:00
NorthRealm
6b2c506e05
Grey out expired artifact on Artifacts list ( #34314 )
...
Grey out expired artifact on Artifacts list.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-05-05 21:53:17 -07:00
Kerwin Bryant
c2c04ffff7
Add fullscreen mode as a more efficient operation way to view projects ( #34081 )
...
Maybe fix #33482 , maybe fix #34015
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-04-23 13:42:22 +08:00
Kerwin Bryant
02e49a0f47
Fix vertical centering of file tree icons and use entryIcon for submodules/symlinks ( #34137 )
...
In the file tree, the icons are not vertically centered, which affects
the overall visual consistency.
Currently, the icons of submodules and symlinks do not adopt the value
of entryIcon, resulting in inconsistent icon display.
before:
after:
---------
Co-authored-by: silverwind <me@silverwind.io >
2025-04-09 18:10:16 -07:00
wxiaoguang
a62ed19da6
Use overflow-wrap: anywhere to replace word-break: break-all ( #34126 )
2025-04-06 17:13:02 +08:00
wxiaoguang
555d64d024
Always show the "rerun" button for action jobs ( #33692 )
...
And improve the mock code.
2025-02-24 08:40:46 +00:00
silverwind
c7f4ca2653
Enable Typescript noImplicitAny ( #33322 )
...
Enable `noImplicitAny` and fix all issues.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-01-22 15:11:51 +08:00
silverwind
4b21a6c792
Enable Typescript noImplicitThis ( #33250 )
...
- Enable https://www.typescriptlang.org/tsconfig/#noImplicitThis
- Wrap Vue Template-Syntax SFCs in
[`defineComponent`](https://vuejs.org/api/general#definecomponent ) which
makes type inference and linter work better
- Move `createApp` calls outside the SFCs into separate files
- Use [`PropType`](https://vuejs.org/api/utility-types#proptype-t ) where
appropriate
- Some top-level component properties changed order as dictated by the
linter
- Fix all tsc and lint issues that popped up during these refactors
2025-01-16 04:26:17 +08:00
bytedream
6279646ee4
Add auto-expanding running actions step ( #30058 )
...
Auto-expands the currently running action step.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-12-22 18:57:17 +00:00
bytedream
5d6d62493b
Add action auto-scroll ( #30057 )
...
Adds an auto-scroll/follow feature to running actions (fix #25186 , fix
#28535 ).
When new log lines are appended and the bottom of the logs container
(`.action-view-right`) is visible at this time, the page automatically
scrolls down to the bottom of the logs.
---------
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-12-21 14:49:26 -08:00
wxiaoguang
d28a4843b8
Fix incomplete Actions status aggregations ( #32859 )
...
fix #32857
2024-12-16 11:18:00 +08:00
Lunny Xiao
6370d2fb93
Detect whether action view branch was deleted ( #32764 )
...
Fix #32761
2024-12-12 19:28:23 +00:00
wxiaoguang
1b069dc94a
Make RepoActionView.vue support ##[group] ( #32770 )
2024-12-10 01:57:20 +00:00
metiftikci
ad994780af
fix: render job title as commit message ( #32748 )
...
resolves #32724
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-12-08 03:23:09 +00:00
wxiaoguang
f7f68e4cc0
Refactor RepoActionView.vue, add ::group:: support ( #32713 )
...
1. make it able to "force reload", then the previous pending request
won't block the new request
2. make it support `::group::`
3. add some TS types (but there are still many variables untyped, this
PR is large enough, the remaining types could be added in the future)
2024-12-06 12:04:16 +08:00
Adrian Hirt
61aaf34401
Fix overflowing content in action run log ( #31842 )
...
When a long line with characters such as dots is returned by a step in
an action (e.g. by the output of the Ruby on Rails test runner), it
overflows the log container, causing the page to scroll sideways.
This PR adds the CSS `overflow-wrap: anywhere;` to the
`.job-step-section .job-step-logs .job-log-line .log-msg` selector,
which causes such lines to wrap as well
2024-08-16 23:34:27 -04:00
silverwind
5791a73e75
Convert frontend code to typescript ( #31559 )
...
None of the frontend js/ts files was touched besides these two commands
(edit: no longer true, I touched one file in
61105d0618
2024-07-07 15:32:30 +00:00
silverwind
2c92c7c522
Add typescript guideline and typescript-specific eslint plugins and fix issues ( #31521 )
...
1. Add some general guidelines how to write our typescript code
2. Add `@typescript-eslint/eslint-plugin`, general typescript rules
3. Add `eslint-plugin-deprecation` to detect deprecated code
4. Fix all new lint issues that came up
2024-07-03 17:48:14 +02:00
silverwind
08579d6cbb
Add initial typescript config and use it for eslint,vitest,playwright ( #31186 )
...
This enables eslint to use the typescript parser and resolver which
brings some benefits that eslint rules now have type information
available and a tsconfig.json is required for the upcoming typescript
migration as well. Notable changes done:
- Add typescript parser and resolver
- Move the vue-specific config into the root file
- Enable `vue-scoped-css/enforce-style-type` rule, there was only one
violation and I added a inline disable there.
- Fix new lint errors that were detected because of the parser change
- Update `i/no-unresolved` to remove now-unnecessary workaround for the
resolver
- Disable `i/no-named-as-default` as it seems to raise bogus issues in
the webpack config
- Change vitest config to typescript
- Change playwright config to typescript
- Add `eslint-plugin-playwright` and fix issues
- Add `tsc` linting to `make lint-js`
2024-06-28 16:15:51 +00:00
silverwind
507fbf4c3c
Use querySelector over alternative DOM methods ( #31280 )
...
As per
https://github.com/go-gitea/gitea/pull/30115#discussion_r1626060164 ,
prefer `querySelector` by enabling
[`unicorn/prefer-query-selector`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-query-selector.md )
and autofixing all except 10 issues.
According to
[this](https://old.reddit.com/r/learnjavascript/comments/i0f5o8/performance_of_getelementbyid_vs_queryselector/ ),
querySelector may be faster as well, so it's a win-win.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: Giteabot <teabot@gitea.io >
2024-06-10 22:49:33 +02:00
yp05327
2a3906d755
Improve job commit description ( #30579 )
...
Fix https://github.com/go-gitea/gitea/issues/30567
When job is a schedule:
When it is a normal one:
also add a 'space' behind `:`
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-04-26 02:22:45 +00:00
silverwind
b9f69b4a4d
Fix various overflows on actions view ( #30344 )
...
Fix a number of text overflow issues in actions view and run list. Also
improve mobile view of run list.
Fixes: https://github.com/go-gitea/gitea/issues/30328
<img width="782" alt="Screenshot 2024-04-08 at 23 10 16"
src="https://github.com/go-gitea/gitea/assets/115237/3d9f9f88-3eab-44a0-8144-30c2b58b24cb ">
<img width="935" alt="Screenshot 2024-04-08 at 23 17 46"
src="https://github.com/go-gitea/gitea/assets/115237/581d73ea-a31d-416b-be3a-47313b879b12 ">
<img width="1008" alt="Screenshot 2024-04-08 at 23 49 05"
src="https://github.com/go-gitea/gitea/assets/115237/c5d10565-f285-477f-8659-1caf94797647 ">
<img width="397" alt="Screenshot 2024-04-08 at 23 55 30"
src="https://github.com/go-gitea/gitea/assets/115237/368aaa75-1903-4058-9d75-d1fe91c564d6 ">
2024-04-15 19:46:52 +00:00
silverwind
0178eaec25
Action view mobile improvements and fixes ( #30309 )
...
Fix the action issue in https://github.com/go-gitea/gitea/issues/30303 ,
specifically:
- Use opaque step header hover background to avoid transparency issue
- Un-sticky the `action-view-left` on mobile, it would otherwise overlap
into right view
- Improve commit summary, let it wrap
- Fix and comment z-indexes
- Tweak width for run-list-item-right so it wastes less space on desktop
- Synced latest changes to console colors from dark to light theme
<img width="467" alt="Screenshot 2024-04-06 at 18 58 15"
src="https://github.com/go-gitea/gitea/assets/115237/8ad26b72-6cd9-4522-8ad1-6fd86b2d0d53 ">
2024-04-07 12:41:42 +00:00
silverwind
57539bcdc0
Fix click handler in job-step-summary ( #30122 )
...
Fix mistake from https://github.com/go-gitea/gitea/pull/29977 where the
click handler wasn't updated for the change with the `isExpandable`
function.
2024-03-27 03:50:24 +00:00
silverwind
a4455d313e
Fix alignment in actions right view ( #29979 )
...
Fixes: https://github.com/go-gitea/gitea/issues/29974 , Regression from
https://github.com/go-gitea/gitea/pull/29640 .
Depending on the number of steps on the left side, the right side will
vertically expand. Collapse it with `align-self`.
<img width="1308" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/9bcede9c-d869-4f3f-8a10-026c74c03f71 ">
2024-03-26 07:56:44 +00:00
silverwind
8fe26fb314
Refactor all .length === 0 patterns in JS ( #30045 )
...
This pattern comes of often during review, so let's fix it once and for
all. Did not test, but changes are trivial enough imho.
2024-03-25 18:37:55 +00:00
silverwind
68ec9b4859
Migrate margin and padding helpers to tailwind ( #30043 )
...
This will conclude the refactor of 1:1 class replacements to tailwind,
except `gt-hidden`. Commands ran:
```bash
perl -p -i -e 's#gt-(p|m)([lrtbxy])?-0#tw-$1$2-0#g' {web_src/js,templates,routers,services}/**/*
perl -p -i -e 's#gt-(p|m)([lrtbxy])?-1#tw-$1$2-0.5#g' {web_src/js,templates,routers,services}/**/*
perl -p -i -e 's#gt-(p|m)([lrtbxy])?-2#tw-$1$2-1#g' {web_src/js,templates,routers,services}/**/*
perl -p -i -e 's#gt-(p|m)([lrtbxy])?-3#tw-$1$2-2#g' {web_src/js,templates,routers,services}/**/*
perl -p -i -e 's#gt-(p|m)([lrtbxy])?-4#tw-$1$2-4#g' {web_src/js,templates,routers,services}/**/*
perl -p -i -e 's#gt-(p|m)([lrtbxy])?-5#tw-$1$2-8#g' {web_src/js,templates,routers,services}/**/*
```
2024-03-24 17:42:49 +01:00
silverwind
5bd0773741
Dont show expansion for empty actions steps ( #29977 )
...
This hides the chevron icon and makes the step header unclickable for
skipped steps because there is no content to expand on those.
Before:
<img width="272" alt="Screenshot 2024-03-21 at 20 06 47"
src="https://github.com/go-gitea/gitea/assets/115237/9bb328d1-6f74-48a9-af19-de9b351e3707 ">
After:
<img width="295" alt="Screenshot 2024-03-21 at 20 03 07"
src="https://github.com/go-gitea/gitea/assets/115237/72a26e14-5a28-4606-8c3c-184b405872c8 ">
---------
Co-authored-by: Giteabot <teabot@gitea.io >
2024-03-24 13:38:10 +00:00
silverwind
3d751b6ec1
Enforce trailing comma in JS on multiline ( #30002 )
...
To keep blame info accurate and to avoid [changes like
this](https://github.com/go-gitea/gitea/pull/29977/files#diff-c3422631a14edbe1e508c4b22f0c718db318be08a6e889427802f9b6165d88d6R359 ),
it's good to always have a trailing comma, so let's enforce it in JS.
This rule is completely automatically fixable with `make lint-js-fix`
and that's what I did here.
2024-03-22 14:06:53 +00:00
silverwind
43aa914b17
fix double border and border-radius on empty action steps ( #29845 )
...
Before, double border-bottom and incorrect border-radius:
<img width="914" alt="Screenshot 2024-03-16 at 14 46 31"
src="https://github.com/go-gitea/gitea/assets/115237/6ea63c42-754c-420c-a0f5-c889a8507d9f ">
After, both fixed:
<img width="917" alt="Screenshot 2024-03-16 at 14 45 59"
src="https://github.com/go-gitea/gitea/assets/115237/9d3f2dba-6b22-441d-8e99-5809d5f1f1c0 ">
2024-03-16 17:03:56 +00:00
silverwind
eb8c34fc36
Tweak actions view sticky ( #29781 )
...
Add some space when the left side items are sticky due to scrolling the
right side.
<img width="419" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/292e1b03-a071-4744-bb79-e50d109056c8 ">
2024-03-14 04:30:10 +00:00
Lunny Xiao
171d3d9a3c
Use Get but not Post to get actions artifacts ( #29734 )
2024-03-12 11:53:53 +01:00
silverwind
f86e9a0367
Set user's 24h preference from their current OS locale ( #29651 )
...
Fixes: https://github.com/go-gitea/gitea/issues/28371
Fixed by using a JS solution that formats according to `lang`, but alters the 24h format setting as per user's locale. This will work for all tooltips:
<img width="243" alt="Screenshot 2024-03-07 at 23 03 35" src="https://github.com/go-gitea/gitea/assets/115237/6d16c71c-6786-4eda-8cdc-50ec68ba62c6 ">
<img width="250" alt="Screenshot 2024-03-07 at 23 03 17" src="https://github.com/go-gitea/gitea/assets/115237/4e26bbb7-12df-4b81-bd37-14705e87e8f7 ">
<img width="310" alt="Screenshot 2024-03-07 at 23 14 34" src="https://github.com/go-gitea/gitea/assets/115237/1ef599f0-6401-4e19-b1da-59cdfc09b0f6 ">
I think there is only one other place in the UI where we render such absolute dates, which is in the actions view and which I've also fixed:
<img width="275" alt="Screenshot 2024-03-07 at 23 04 00" src="https://github.com/go-gitea/gitea/assets/115237/df0fbe1f-96ee-4338-ab5e-2b10e215005d ">
2024-03-08 16:07:56 +08:00
silverwind
16f1326514
Tweak actions color and borders ( #29640 )
...
- Increase contrast overall
- Unalias the ansi color in dark theme and copy them to light
- Add outer border
- Add border radius
<img width="1337" alt="Screenshot 2024-03-06 at 22 30 03"
src="https://github.com/go-gitea/gitea/assets/115237/11407c0f-0bb2-435e-a034-22b1f106d9b0 ">
<img width="1335" alt="Screenshot 2024-03-06 at 22 36 59"
src="https://github.com/go-gitea/gitea/assets/115237/267db442-0979-4acc-a79e-8579b4cb0262 ">
2024-03-06 22:44:24 +01:00
wxiaoguang
ea164aba4b
Make actions animation rotate counterclockwisely ( #29378 )
...
Because the icon is:
So it must rotate counterclockwisely
2024-02-25 21:37:35 +08:00
FuXiaoHei
67adc5c1dc
Artifact deletion in actions ui ( #27172 )
...
Add deletion link in runs view page.
Fix #26315
When click deletion button. It marks this artifact `need-delete`.
This artifact would be deleted when actions cleanup cron task.
2024-02-18 10:33:50 +00:00
silverwind
709c2fad8a
Add missed return to actions view fetch ( #27289 )
...
Should fix : #27213
2023-09-27 08:34:52 +08:00
silverwind
6d96f0b0d1
Add fetch wrappers, ignore network errors in actions view ( #26985 )
...
1. Introduce lightweight `fetch` wrapper functions that automatically
sets csfr token, content-type and use it in `RepoActionView.vue`.
2. Fix a specific issue on `RepoActionView.vue` where a fetch network
error is shortly visible during page reload sometimes. It can be
reproduced by F5-in in quick succession on the actions view page and was
also producing a red error box on the page.
Once approved, we can replace all current `fetch` uses in UI with this
in another PR.
---------
Co-authored-by: Giteabot <teabot@gitea.io >
2023-09-11 10:25:10 +02:00
silverwind
9a3de436f4
Reorder blocks in vue SFCs ( #26874 )
...
The [recommended order](https://vuejs.org/guide/scaling-up/sfc.html ) for
SFC blocks is script -> template -> style, which we were violating
because template and script were swapped. I do find script first also
easier to read because the imports are on top, letting me immideatly see
a component's dependencies.
This is a pure cut-paste refactor with some removal of some empty lines.
---------
Co-authored-by: Lauris BH <lauris@nix.lv >
2023-09-02 14:59:07 +00:00
silverwind
21b8ec29aa
Add eslint-plugin-vue-scoped-css ( #26720 )
...
Adds
[eslint-plugin-vue-scoped-css](https://github.com/future-architect/eslint-plugin-vue-scoped-css )
and fixes discovered issues which are:
- 1 unused selector
- 3 selectors with `.full.height` parent in a `<style scoped>` block so
the rule could not find the parent. Move these into the unscoped block
instead. They worked before and after.
2023-08-25 13:47:27 +00:00
yp05327
a4a567f29f
Check disabled workflow when rerun jobs ( #26535 )
...
In GitHub, we can not rerun jobs if the workflow is disabled.
---------
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-08-22 10:30:02 +08:00
silverwind
30e5278d1b
Allow text selection in actions step header ( #26588 )
2023-08-18 18:38:29 +00:00
yp05327
8703b6c954
Improve clickable area in repo action view page ( #26115 )
...
Before:
After:
In current design, the clickable area is too small, and it is hard to
find the correct clickable area as the area with background color (div
with class name `job-brief-item selected`) is bigger than it.
---------
Co-authored-by: Giteabot <teabot@gitea.io >
2023-08-16 00:44:43 +02:00
silverwind
2fc0eb913c
Tweak actions menu ( #26278 )
...
Ressurect lost changes from
https://github.com/go-gitea/gitea/pull/24451 .
- Always show icons for each entry in the menu
- Make all checkboxes toggle only their feature, e.g. "seconds" and
"timestamps" can now be toggled on together.
- Reorder the items
<img width="845" alt="Screenshot 2023-08-01 at 19 19 27"
src="https://github.com/go-gitea/gitea/assets/115237/8a76e9bf-7966-42a6-87c9-e88cdddaec82 ">
---------
Co-authored-by: Giteabot <teabot@gitea.io >
2023-08-12 08:26:53 +00:00
yp05327
36732005b4
Disable download action logs button when there's no logs ( #26114 )
...
If there's no logs, you can also click the download button, then you
will get `job is not started` page
https://gitea.com/yp05327/testrepo/actions/runs/38
After:
If there's no steps displayed, the download button will be disabled.
2023-07-26 20:51:26 +02:00
FuXiaoHei
f3d293d2bb
Actions Artifacts support uploading multiple files and directories ( #24874 )
...
current actions artifacts implementation only support single file
artifact. To support multiple files uploading, it needs:
- save each file to each db record with same run-id, same artifact-name
and proper artifact-path
- need change artifact uploading url without artifact-id, multiple files
creates multiple artifact-ids
- support `path` in download-artifact action. artifact should download
to `{path}/{artifact-path}`.
- in repo action view, it provides zip download link in artifacts list
in summary page, no matter this artifact contains single or multiple
files.
2023-07-21 10:42:01 +08:00
Denys Konovalov
00dbba7f42
Several fixes for mobile UI ( #25634 )
...
Resolves #25622
<details>
<summary>Screenshots</summary>
</details>
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: silverwind <me@silverwind.io >
2023-07-04 17:45:45 +00:00
silverwind
0006169f38
Actions list enhancements ( #25601 )
...
Various small enhancements to the actions list. Before and after:
<img width="1264" alt="Screenshot 2023-06-30 at 00 11 40"
src="https://github.com/go-gitea/gitea/assets/115237/bb4162ee-cdcf-4a73-b05e-f9521562edbb ">
<img width="1264" alt="Screenshot 2023-06-30 at 00 09 51"
src="https://github.com/go-gitea/gitea/assets/115237/52a70ea9-4bb3-406e-904b-0fdaafde9582 ">
---------
Co-authored-by: Giteabot <teabot@gitea.io >
2023-07-04 09:59:47 +00:00
