Nemcio/Gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2025-11-03 20:36:07 +01:00
Code Issues Packages Projects Releases Wiki Activity

Use querySelector over alternative DOM methods (#31280)

Browse Source 
As per
https://github.com/go-gitea/gitea/pull/30115#discussion_r1626060164,
prefer `querySelector` by enabling
[`unicorn/prefer-query-selector`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-query-selector.md)
and autofixing all except 10 issues.

According to
[this](https://old.reddit.com/r/learnjavascript/comments/i0f5o8/performance_of_getelementbyid_vs_queryselector/),
querySelector may be faster as well, so it's a win-win.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io>
This commit is contained in:
silverwind
2024-06-10 22:49:33 +02:00
committed by GitHub
parent a2304cb163
commit 507fbf4c3c
47 changed files with 165 additions and 168 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
web_src/js/features/sshkey-helper.js
View File

@@ -1,8 +1,8 @@
export function initSshKeyFormParser() {
// Parse SSH Key
document.getElementById('ssh-key-content')?.addEventListener('input', function () {
document.querySelector('#ssh-key-content')?.addEventListener('input', function () {
const arrays = this.value.split(' ');
const title = document.getElementById('ssh-key-title');
const title = document.querySelector('#ssh-key-title');
if (!title.value && arrays.length === 3 && arrays[2] !== '') {
title.value = arrays[2];
}