Compare commits

...

953 Commits

Author SHA1 Message Date
Naoki Takezoe
1ceace5539 Release 4.21.0 2018-01-27 00:30:42 +09:00
Naoki Takezoe
f13a473b4e Merge pull request #1856 from int128/oidc
OpenID Connect authentication
2018-01-25 16:25:48 +09:00
Hidetake Iwata
4e7c10c0dc Add a test 2018-01-25 14:41:59 +09:00
Hidetake Iwata
6db34cbb6b Refactor
- Use self type annotation instead of extending
- Aggregate OIDC context to a case class
- Use companion object instead of dedicated utility class
2018-01-25 12:19:47 +09:00
Naoki Takezoe
10205a8f9b Merge pull request #1857 from gitbucket/autherror-redirection
Return 401 for non-browsers when authentication is failed
2018-01-25 11:57:19 +09:00
Naoki Takezoe
d6df35f072 Return 401 for non-browsers when authentication is failed 2018-01-25 02:24:51 +09:00
Hidetake Iwata
ab10b77c50 Add OpenID Connect authentication feature 2018-01-24 12:24:16 +09:00
Naoki Takezoe
fb34b0909e Allow empty query for repository search 2018-01-24 03:15:17 +09:00
Naoki Takezoe
1a869f47e0 Merge pull request #1852 from int128/jrebel
Add support for new JRebel agent
2018-01-24 02:02:09 +09:00
Naoki Takezoe
d9aebbda62 Merge pull request #1851 from kounoike/pr-includegroups-option
Add "include group accounts" checkbox in User management
2018-01-24 01:53:20 +09:00
KOUNOIKE Yuusuke
987407909e fixed by review comment. 2018-01-23 21:33:42 +09:00
Hidetake Iwata
ba9c780602 Add support for new JRebel agent 2018-01-22 10:35:30 +09:00
Naoki Takezoe
ea5834f236 Merge pull request #1849 from McFoggy/issue-1844
add 'state' attribute to ApiPullRequest object
2018-01-21 01:13:06 +09:00
Naoki Takezoe
c3400f1091 Merge pull request #1853 from kounoike/pr-fix-1707
Fix #1707.
2018-01-21 01:10:30 +09:00
KOUNOIKE Yuusuke
7bd4d0970e Fix #1707. 2018-01-20 22:12:29 +09:00
KOUNOIKE Yuusuke
4a9303d7a7 Add "include group accounts" checkbox in User management 2018-01-20 13:00:43 +09:00
Naoki Takezoe
5f0cacd7c1 (refs #1846) Fix repository creation indicator's condition 2018-01-20 05:33:21 +09:00
Naoki Takezoe
f075132878 (refs #1848) Response refs which are started from specified ref string
when a exactly matched ref doesn't exist
2018-01-20 04:29:49 +09:00
Naoki Takezoe
b72556c007 (refs #1848) Partial fix get a reference API 2018-01-19 22:19:24 +09:00
Matthieu Brouillard
47489d9cb1 add 'state' attribute to ApiPullRequest object
fixes #1844
2018-01-19 11:37:13 +01:00
Naoki Takezoe
2ee70dc1b2 Merge pull request #1845 from bviktor/selinux
SELinux policy module, deploy script and instructions
2018-01-19 01:11:59 +09:00
Viktor Berke
3400b9a0ab SELinux policy module, deploy script and instructions 2018-01-17 23:08:44 +01:00
Naoki Takezoe
ad054d2f80 Delete removed release files when the release is updated 2018-01-14 02:12:09 +09:00
Naoki Takezoe
b0c2e5588c Fix downloading at the release page 2018-01-14 00:42:21 +09:00
Naoki Takezoe
1fe379111c Delete RELEASE_ID column from RELEASE and RELEASE_ASSET 2018-01-14 00:35:18 +09:00
Naoki Takezoe
2180e31d13 Escape in JavaScript 2018-01-13 16:50:06 +09:00
Naoki Takezoe
275772ad00 Merge branch 'pr-add-release' 2018-01-13 16:31:45 +09:00
Naoki Takezoe
e80da63515 Merge tags and releases 2018-01-13 16:30:59 +09:00
Naoki Takezoe
71cce5b470 Fix user interface of releases 2018-01-13 16:30:50 +09:00
Naoki Takezoe
bb188ec948 Merge branch 'master' into pr-add-release 2018-01-13 16:30:18 +09:00
Naoki Takezoe
281522fc88 (refs #1836) Make same behavior with H2 console when table is clicked 2018-01-12 02:25:22 +09:00
Naoki Takezoe
a045fc6ae4 (refs #1838) Fix rebase merge 2018-01-11 15:58:17 +09:00
Naoki Takezoe
8e8e794574 Merge pull request #1829 from kounoike/pr-dropdown-close-and-comment-button
Change Close/Reopen button to dropdown-selectable button.
2018-01-11 13:22:27 +09:00
Naoki Takezoe
735e425984 Merge pull request #1833 from xuwei-k/sbt-1.1.0
sbt 1.1.0
2018-01-11 13:21:07 +09:00
Naoki Takezoe
5f47b126e3 (refs #1808) Specify medium color for text in the sidemenu 2018-01-08 22:41:08 +09:00
KOUNOIKE Yuusuke
33d82beb72 set maxFilesize for dropzone 2018-01-08 18:29:18 +09:00
Naoki Takezoe
3de5d806b5 (refs #1836) Add context menu to the database viewer
Also "Run query" button runs only selected text if some text is selected.
2018-01-08 01:00:55 +09:00
Naoki Takezoe
8eb522fb38 (refs #1836) Add "Clear" button to the database viewer 2018-01-07 21:32:26 +09:00
KOUNOIKE Yuusuke
370e4339f3 Change tag-based list to release-based list (releases page) 2018-01-07 16:53:19 +09:00
KOUNOIKE Yuusuke
5b0eb7ece5 Change icon to octicon-gift 2018-01-07 16:52:16 +09:00
KOUNOIKE Yuusuke
18434854d8 Update migrate filename 2018-01-07 14:16:07 +09:00
KOUNOIKE Yuusuke
d3f57bdb45 fix imports 2018-01-07 14:14:54 +09:00
KOUNOIKE Yuusuke
37734ce26b Merge remote-tracking branch 'upstream/master' into pr-add-release
# Conflicts:
#	build.sbt
#	src/main/scala/ScalatraBootstrap.scala
#	src/main/scala/gitbucket/core/GitBucketCoreModule.scala
#	src/main/scala/gitbucket/core/controller/FileUploadController.scala
#	src/main/scala/gitbucket/core/controller/RepositorySettingsController.scala
#	src/main/scala/gitbucket/core/service/RepositoryService.scala
#	src/main/twirl/gitbucket/core/menu.scala.html
2018-01-07 13:22:56 +09:00
Naoki Takezoe
b6cf080822 Merge pull request #1834 from gitbucket/submodule-link
Links submodule to the online repository viewer
2018-01-07 04:56:38 +09:00
Naoki Takezoe
bbc817d86d (refs #1823) Link submodule to the online repository viewer
Supports following services:
- GitBucket (need to set the base url at the system settings)
- GitHub
- BitBucket
- GitLab.com
If a repository url doesn't match above services, generate a link to the git repository as before.
2018-01-07 04:41:00 +09:00
Naoki Takezoe
5e88f3f787 (refs #1808) Fix inline CSS styles 2018-01-07 02:26:16 +09:00
Naoki Takezoe
f64d4843f3 (refs #1816) Apply max_file_size to dropzone as well 2018-01-07 02:01:40 +09:00
kenji yoshida
bcb3450e2b sbt 1.1.0 2018-01-06 17:54:08 +09:00
Naoki Takezoe
c607045b7c Merge pull request #1825 from gitbucket/features/dbviewer
Replace H2 console
2018-01-06 17:40:35 +09:00
Naoki Takezoe
f8e9093273 Display primary keys in the tree 2018-01-06 17:32:01 +09:00
Naoki Takezoe
40c06417e5 Merge pull request #1830 from xuwei-k/addSbtCoursier
use addSbtCoursier
2018-01-06 02:20:50 +09:00
Naoki Takezoe
c3c5535022 Merge pull request #1824 from yaroot/lfs
Treat LFS files as large binaries in the web viewer
2018-01-05 13:52:08 +09:00
xuwei-k
b7fc76d932 use addSbtCoursier
- https://github.com/coursier/coursier/blob/v1.0.0/sbt-coursier/src/main/scala/coursier/CoursierPlugin.scala#L57-L59
- a743f1183e
2018-01-04 13:46:07 +09:00
KOUNOIKE Yuusuke
c8d666baba Change Close/Reopen button to dropdown-selectable button. 2018-01-04 00:49:13 +09:00
Naoki Takezoe
a64741011c Implement displaying result as a scrollable table 2017-12-30 01:02:09 +09:00
Naoki Takezoe
ae9ee4779f Add tables tree 2017-12-29 04:50:58 +09:00
Naoki Takezoe
5fd2d61861 Database viewer (replacement of H2 console) 2017-12-28 18:55:55 +09:00
Yan Su
939c9156ad treat LFS files as large binaries in the web viewer 2017-12-28 16:27:09 +08:00
Naoki Takezoe
d17aed2357 (refs #1819) Restore sbt-coursier for the nested project 2017-12-28 12:00:47 +09:00
Naoki Takezoe
13382b47d1 Merge pull request #1819 from stevegk/dependencies
Update Dependencies and Plugins
2017-12-28 11:32:26 +09:00
Steve K
5e5a1ea5a8 Update dependencies
Updates dependencies except scalatra and jetty

  Includes fix for Cache2K api breaking change
2017-12-27 18:49:22 +00:00
Steve K
cf6d1ea137 Update plugins 2017-12-27 18:49:22 +00:00
Steve K
f735e4a133 Remove redundent project directory 2017-12-27 18:49:22 +00:00
Naoki Takezoe
86b67863f8 (refs #1263) Fix BLOB download in Wiki 2017-12-28 03:15:40 +09:00
Naoki Takezoe
718582af44 Merge pull request #1822 from uli-heller/mariadb-java-client-2.2.1
Upgraded to mariadb-java-client-2.2.1
2017-12-27 21:01:03 +09:00
Naoki Takezoe
23024cacaa Merge pull request #1821 from uli-heller/jgit-4.9.2.201712150930-r
jgit-4.9.2.201712150930-r
2017-12-27 21:00:46 +09:00
Uli Heller
f62cf409eb Upgraded to mariadb-java-client-2.2.1 2017-12-27 10:07:49 +01:00
Uli Heller
47845dfe1b jgit-4.9.2.201712150930-r 2017-12-27 10:01:34 +01:00
Naoki Takezoe
b7bb6b0787 Update plugins.json schema 2017-12-23 04:31:01 +09:00
Naoki Takezoe
ea41786f8c Fixup 2017-12-23 02:43:11 +09:00
Naoki Takezoe
962ae2130e Update README and CHANGELOG for GitBucket 4.20.0 release 2017-12-23 02:43:11 +09:00
Naoki Takezoe
90ea05f2a1 Merge pull request #1814 from gageas/fix-typo
Fix typo in style attribute
2017-12-22 03:27:37 +09:00
gageas
f8bda516d6 Fix typo in style attribute
Because of the typo, image displayed in unintended aspect ratio, in some case.
2017-12-21 22:49:01 +09:00
Naoki Takezoe
378c031ecb Merge pull request #1813 from atware/WIP-webhook-create-event
support CreateEvent in webhook
2017-12-21 18:42:58 +09:00
Naoki Takezoe
9a5db80dea (refs #1783) hide overflowed chars in the sidebar 2017-12-21 18:41:19 +09:00
Naoki Takezoe
992eb0ceda Bump to 4.20.0 2017-12-21 15:22:07 +09:00
guyon
39e1ac2398 support CreateEvent in webhook 2017-12-21 15:21:51 +09:00
Naoki Takezoe
d1c77de5a0 Bump to 4.19.3 2017-12-21 15:21:07 +09:00
Naoki Takezoe
3f8069638c Merge pull request #1807 from uli-heller/mariadb-java-client-2.2.0
Upgraded to mariadb-java-client-2.2.0
2017-12-15 13:58:26 +00:00
Uli Heller
d62fc1185c Upgraded to mariadb-java-client-2.2.0 2017-12-14 07:59:19 +01:00
Naoki Takezoe
768706e1d1 Resurrect the pages plugin 2017-12-12 19:25:34 +09:00
Naoki Takezoe
8cc9771237 Merge pull request #1804 from gitbucket/show-conflict-files
Show conflicting files if pull request can't be merged
2017-12-12 13:32:31 +09:00
Naoki Takezoe
8df30ef01b Fix message 2017-12-12 13:06:04 +09:00
Naoki Takezoe
dd2e5bfedf Fix testcase 2017-12-12 12:04:24 +09:00
Naoki Takezoe
e3c7eb092f Fix merge failure 2017-12-12 12:02:04 +09:00
Naoki Takezoe
5b3c3e2e7c Merge branch 'master' into show-conflict-files 2017-12-12 11:58:57 +09:00
Naoki Takezoe
0e04925b6b Merge pull request #1802 from gitbucket/merge-strategy
Add a pulldown menu to choose the merge strategy
2017-12-12 11:48:12 +09:00
Naoki Takezoe
9a127256f3 Update reflog message 2017-12-12 11:39:00 +09:00
Naoki Takezoe
1033122fec Show conflicting files 2017-12-12 03:20:50 +09:00
Naoki Takezoe
847f96d537 Filter proposed branches which have been already raised as pull request 2017-12-12 02:25:36 +09:00
Naoki Takezoe
70f40846bb Show pull request proposals for the current repository
if the repository doesn't have a parent repository.
2017-12-12 00:39:30 +09:00
Naoki Takezoe
3a540aa660 Merge pull request #1803 from uli-heller/jgit-4.9.1.201712030800-r
jgit-4.9.1.201712030800-r
2017-12-12 00:14:52 +09:00
Naoki Takezoe
1adc9b3223 Refactoring 2017-12-11 20:20:58 +09:00
Naoki Takezoe
0309496df6 Fix rebase process 2017-12-11 20:16:11 +09:00
Uli Heller
f83ecac7ae jgit-4.9.1.201712030800-r 2017-12-11 08:52:00 +01:00
Naoki Takezoe
cd4d75e35e Format code 2017-12-11 12:33:06 +09:00
Naoki Takezoe
eb61bc50d6 Implemented squash merge strategy 2017-12-11 12:32:52 +09:00
Naoki Takezoe
4bbb22f73b Fix branch selector presentation 2017-12-11 03:47:02 +09:00
Naoki Takezoe
fcb374c5c2 Implemented rebase strategy 2017-12-10 18:04:45 +09:00
Naoki Takezoe
a03d1c97c2 Format code 2017-12-10 17:39:45 +09:00
Naoki Takezoe
2d58b7f2d7 Add a pulldown menu to choose the merge strategy 2017-12-10 14:59:53 +09:00
Naoki Takezoe
332a1b4b0b Add "Compare & pull request" button on the top of the repository viewer (#1476) 2017-12-09 04:52:21 +09:00
Naoki Takezoe
6bd58b0c45 Don't filter pull request target repositories
because users who can access the forked repository should see the
original repositories and other forked repositories basically.
2017-12-08 15:10:41 +09:00
Naoki Takezoe
fb175df851 (refs #1797) Fix accessible check for pull request repositories 2017-12-08 03:05:21 +09:00
Naoki Takezoe
b41aad92f2 Increase wait before refreshing the screen 2017-12-08 02:02:09 +09:00
Naoki Takezoe
aabae2ef7f Fix compilation error 2017-12-07 20:07:16 +09:00
Naoki Takezoe
0c3d1fd86d (refs #1799) Fix permalinks for pull request comments 2017-12-07 20:03:47 +09:00
Naoki Takezoe
adba849ec5 (refs #1798) Fix specification method of offset 2017-12-07 14:37:48 +09:00
Naoki Takezoe
8539486c6e Update README.md 2017-12-07 02:19:44 +09:00
Naoki Takezoe
86f4b41beb Fix comment reply form behavior in the diff view (#1796) 2017-12-06 14:38:05 +09:00
Naoki Takezoe
aa54eff3d6 Fix diff class attribute in split mode 2017-12-06 10:46:37 +09:00
Naoki Takezoe
27ab21c9a7 Fix file uploading issue 2017-12-06 03:53:43 +09:00
Naoki Takezoe
557ed827d0 Merge pull request #1792 from gitbucket/create-patch
Add a Patch button to the diff view
2017-12-05 18:42:05 +09:00
Naoki Takezoe
9cc466a727 Add a Patch button to the diff view 2017-12-05 13:06:17 +09:00
Naoki Takezoe
9a9be12324 Fix error 2017-12-05 12:37:18 +09:00
Naoki Takezoe
8e91b9f0b5 Improve DiffEntry searching and add download patch endpoint 2017-12-05 03:31:23 +09:00
Naoki Takezoe
2862ceb5ad Merge pull request #1790 from gitbucket/copy-repository
Create new repository from existing git repository
2017-12-05 01:40:51 +09:00
Naoki Takezoe
d157426d66 Fix error page for repository creation 2017-12-04 20:55:11 +09:00
Naoki Takezoe
58635674cb Asynchronize repository forking 2017-12-04 20:18:39 +09:00
Naoki Takezoe
f6a048e0f7 FeedAdd validation for sourceUrl 2017-12-04 19:59:48 +09:00
Naoki Takezoe
c4dc1d7334 Feedback error in repository creation to users 2017-12-04 16:42:15 +09:00
Naoki Takezoe
efd5a64749 Asynchronize repository creation 2017-12-04 16:12:43 +09:00
Naoki Takezoe
13800a7023 Implement repository cloning 2017-12-04 14:00:57 +09:00
Naoki Takezoe
43d19d7d52 Add create new repository from existing git repository option 2017-12-04 01:32:35 +09:00
Naoki Takezoe
8a8278906a Bump to 4.19.2 2017-12-03 05:28:49 +09:00
Naoki Takezoe
d15b3fb2f6 Modify id of "Test Hook" button 2017-12-03 05:20:32 +09:00
Naoki Takezoe
bcd92916ca Fix routing in CompositeScalatraFilter 2017-12-03 04:36:05 +09:00
Naoki Takezoe
810cbda123 Update README.md 2017-12-03 02:17:27 +09:00
Naoki Takezoe
fee7cebdf1 Update README.md 2017-12-03 02:16:57 +09:00
Naoki Takezoe
28105d6d3a Update notification plugin 2017-12-03 01:00:40 +09:00
Naoki Takezoe
1673832607 Merge pull request #1786 from guyon/fix-repository-update-redirect-urlencode
fix redirect URL path encode
2017-12-02 18:39:45 +09:00
Naoki Takezoe
298e43e612 Update README.md and CHANGELOG.md 2017-12-02 18:26:52 +09:00
Naoki Takezoe
00b88d6b6e Update README.md and CHANGELOG.md 2017-12-02 18:16:17 +09:00
Naoki Takezoe
735123b93e Drop pages plugin from bundled plugins 2017-12-02 18:01:09 +09:00
Naoki Takezoe
fce3b3749c Update README.md and CHANGELOG.md 2017-12-02 03:11:22 +09:00
guyon
0a12b82b48 fix redirect URL path encode 2017-12-01 17:40:15 +09:00
Naoki Takezoe
9061d6bf7f (refs #1777) Bump gist plugin to 4.11.0 2017-11-29 11:23:43 +09:00
Naoki Takezoe
9ed8b554f3 Fix build.sbt 2017-11-29 10:17:48 +09:00
Naoki Takezoe
e306303cc8 Fix artifacts filter 2017-11-29 03:41:30 +09:00
Naoki Takezoe
c4bea091fe Update version to 4.19.0 2017-11-29 03:13:21 +09:00
Naoki Takezoe
2b383d79f1 Merge pull request #1778 from gitbucket/composite-filter
Introduce CompositeScalatraFilter to merge controllers to one filter
2017-11-29 00:43:30 +09:00
Naoki Takezoe
788e90469c Merge pull request #1784 from xuwei-k/sbt-1.0.4
sbt 1.0.4
2017-11-26 22:15:48 +09:00
kenji yoshida
f37711c816 sbt 1.0.4 2017-11-26 20:52:28 +09:00
Naoki Takezoe
f2c9d99f30 Merge branch 'master' into composite-filter 2017-11-23 14:05:55 +09:00
Naoki Takezoe
6073497e5e Fix validation rules for scalatra-forms 2017-11-23 14:00:55 +09:00
Naoki Takezoe
5d2ccfb0df Refactoring 2017-11-17 21:18:53 +09:00
Naoki Takezoe
3745243078 Mount filters with path 2017-11-17 18:23:41 +09:00
Naoki Takezoe
30a1968793 Handle plugin controllers by loop as same as CompositeScalatraFilter 2017-11-17 18:20:12 +09:00
Naoki Takezoe
581bcb3dc8 Introduce CompositeScalatraFilter to merge controllers to one filter 2017-11-17 17:44:35 +09:00
Naoki Takezoe
cd243f910a Merge pull request #1760 from gitbucket/scalatra-2.6
Bump to Scalatra 2.6.0
2017-11-16 16:53:10 +09:00
Naoki Takezoe
0b420177c4 Bump to Scalatra 2.6.1 2017-11-16 16:15:50 +09:00
Naoki Takezoe
0d8e022a0d Merge pull request #1773 from reap3r119/sidebar-post
Use POST for /sidebar-collapse
2017-11-15 13:27:42 +09:00
Naoki Takezoe
2f87d30359 Merge pull request #1775 from SIkebe/port-release-notes
Port Release Notes to CHANGELOG.md
2017-11-12 01:00:00 +09:00
Shodai Ikebe
98a5263a07 Port release notes to CHANGELOG.md 2017-11-11 02:42:16 +09:00
reap3r119
208f08c552 Use POST for /sidebar-collapse 2017-11-10 02:34:51 -05:00
Naoki Takezoe
b66852ec28 Fix for jQuery update 2017-11-10 16:15:41 +09:00
Naoki Takezoe
8d687660a9 Bump sbt to 1.0.3 2017-11-10 03:53:09 +09:00
Naoki Takezoe
c7749b281f Bump sbt-coursier to 1.0.0-RC13 2017-11-10 03:40:09 +09:00
Naoki Takezoe
ad5a0bb442 Use ex.toString instead of ex.getMessage to show exception type as well 2017-11-04 23:20:14 +01:00
Naoki Takezoe
6056642f69 Merge pull request #1765 from reap3r119/fix-proposals
Fix user proposals and update typeahead
2017-11-04 23:15:59 +01:00
Naoki Takezoe
21dcbf20b4 Merge pull request #1756 from reap3r119/admin-settings
Layout changes for System settings page
2017-11-04 22:41:53 +01:00
Naoki Takezoe
d92f0080ff Merge pull request #1759 from JD557/use-java-time
Replace joda-time with java.time
2017-11-04 22:36:27 +01:00
Naoki Takezoe
035cb170e0 Merge pull request #1764 from kounoike/pr-fix-1763
fix #1763 Don't delete close_comment
2017-11-04 22:35:25 +01:00
reap3r119
de5b2a9704 Resize labels, organize skins and add skin previewing 2017-11-03 09:12:54 -06:00
reap3r119
55f4b8c124 Fix user proposals and update typeahead 2017-11-03 09:10:27 -06:00
Naoki Takezoe
887baf2f08 Merge pull request #1761 from JD557/truncate-branch-name
Truncate long branch names
2017-11-02 15:02:02 +09:00
KOUNOIKE Yuusuke
bd63e1e75e fix #1763 when deleting comment, close_comment => close / reopen_comment => reopen. not delete. 2017-10-31 22:39:19 +09:00
João Costa
bc8dd4b3c2 Truncate long branch names
Fix #1135
2017-10-29 11:25:07 +00:00
Naoki Takezoe
15b348fd3d Bump to Scalatra 2.6.0 2017-10-29 14:47:25 +09:00
João Costa
5b5a644baa Replace joda-time with java.time
Fix #1513
2017-10-28 18:57:05 +01:00
Naoki Takezoe
fa2d7db0ca Merge pull request #1757 from reap3r119/patch-1
Rename PluginRegistory.scala to PluginRegistry.scala
2017-10-26 08:34:18 +09:00
Reap3r119
1893c212f3 Rename PluginRegistory.scala to PluginRegistry.scala 2017-10-25 11:39:46 -06:00
Naoki Takezoe
3c2dcb7b08 Bump to Scalatra 2.5.3 2017-10-25 12:24:37 +09:00
Naoki Takezoe
3d95679a1d Merge branch 'master' of https://github.com/gitbucket/gitbucket 2017-10-24 12:25:31 +09:00
Naoki Takezoe
29f380efa0 Bump to Scalatra 2.5.2 2017-10-24 12:23:58 +09:00
Naoki Takezoe
1da17940a2 Merge pull request #1755 from uli-heller/jetty947
Updated to jetty-9.4.7
2017-10-24 09:27:24 +09:00
Naoki Takezoe
348eada5b3 Merge pull request #1754 from uli-heller/mariadb212
Updated mariadb-java-client to 2.1.2
2017-10-24 01:30:51 +09:00
Naoki Takezoe
6f9450fece Fix bug in rendering of system menu icons 2017-10-23 15:27:29 +09:00
Uli Heller
2344ef7583 Updated to jetty-9.4.7 2017-10-22 20:32:51 +02:00
Uli Heller
b7b1befb27 Updated mariadb-java-client to 2.1.2 2017-10-22 19:21:40 +02:00
Naoki Takezoe
902f7ef95f Fix testcase 2017-10-22 21:33:42 +09:00
Naoki Takezoe
6bf71827f0 Fix plain text readme rendering 2017-10-22 20:31:01 +09:00
Naoki Takezoe
5a005cf5a6 Requests to H2 console don't need transaction 2017-10-22 19:45:43 +09:00
Naoki Takezoe
25729e3193 Merge pull request #1751 from kounoike/pr-delmove-from-repofilesdir
Delete/Move RepositoryFilesDir, instead of LFS/comments dir.
2017-10-22 02:25:54 +09:00
Naoki Takezoe
450b598f1f Bump notifications plugin to 1.3.0 2017-10-22 02:08:55 +09:00
Naoki Takezoe
f36bcef50c (refs #1748) Exclude gitbucket.war from published artifacts 2017-10-22 01:24:43 +09:00
Naoki Takezoe
86ff842eb2 Merge pull request #1752 from gitbucket/exclude-war-from-publish
(refs #1748) Exclude gitbucket.war from published artifacts
2017-10-21 19:10:11 +09:00
Naoki Takezoe
94ca597cf8 (refs #1748) Exclude gitbucket.war from published artifacts 2017-10-21 17:04:35 +09:00
Naoki Takezoe
e46e55f985 bump sbt-twirl to 1.3.12 2017-10-21 16:04:39 +09:00
Naoki Takezoe
50a63a8c87 Removed cancel button from the account settings page 2017-10-21 01:34:47 +09:00
KOUNOIKE Yuusuke
029d1a3a11 Delete/Move RepositoryFilesDir, instead of LFS/comments dir. 2017-10-20 20:12:10 +09:00
Naoki Takezoe
6df1b005bf Bump to 4.19.0-SNAPSHOT 2017-10-20 14:43:50 +09:00
Naoki Takezoe
e50082a9dd Merge pull request #1750 from uli-heller/scala2124
Updated to scala-2.12.4
2017-10-20 14:41:25 +09:00
Naoki Takezoe
9c4beca998 (refs #1749) Fix executable configuration 2017-10-20 14:40:14 +09:00
Uli Heller
d73cb094b6 Updated to scala-2.12.4 2017-10-20 07:13:00 +02:00
Naoki Takezoe
9e83882c6f Merge pull request #1742 from gitbucket/ssh-command-provider
Add new extension point: sshCommandProvider
2017-10-20 10:36:43 +09:00
Naoki Takezoe
d109ac0327 Merge pull request #1716 from gitbucket/sbt-1.0
Move to sbt 1.0
2017-10-20 01:41:34 +09:00
Naoki Takezoe
695fda4a73 Merge pull request #1746 from uli-heller/jgit490
jgit-4.9.0.201710071750-r
2017-10-20 01:22:59 +09:00
Naoki Takezoe
439d51bec1 Merge branch 'master' into sbt-1.0 2017-10-20 01:21:03 +09:00
Uli Heller
c3b89c96e0 jgit-4.9.0.201710071750-r 2017-10-19 13:53:38 +02:00
Naoki Takezoe
eb83c5713c Bump sbt-scalatra plugin to 1.0.1 2017-10-19 16:37:12 +09:00
Naoki Takezoe
58c22274ef Merge pull request #1738 from reap3r119/update-deps
Update dependencies for the web interface
2017-10-19 15:58:27 +09:00
reap3r119
bfd8c3a958 Use AdminLTE classes for logo
Use AdminLTE's 'logo-lg' and 'logo-mini' classes for the logo
instead of relying on hidden overflow
2017-10-17 15:05:05 -06:00
reap3r119
f402587a9a Update dependencies for the web interface 2017-10-17 09:07:01 -06:00
Naoki Takezoe
7736747d68 Add new extension point: sshCommandProvider 2017-10-17 17:11:26 +09:00
Naoki Takezoe
e6ee55e0a0 Merge pull request #1741 from gitbucket/encode-url-path
Encode file paths in URL
2017-10-16 21:15:05 +09:00
Naoki Takezoe
a2e8d24fdb Fix path encoding in JavaScript 2017-10-16 18:23:48 +09:00
Naoki Takezoe
9fb0d7eb40 Encode file paths in URL 2017-10-16 18:14:51 +09:00
Naoki Takezoe
24d4763fc8 Update README.md 2017-10-14 01:22:17 +09:00
Naoki Takezoe
e14a67e56d Merge pull request #1736 from reap3r119/local-fonts
Add local version of Source Sans Pro
2017-10-13 16:48:37 +09:00
reap3r119
d8fac332ab Remove nonexistent entries 2017-10-12 09:39:45 -06:00
reap3r119
c3ae06751e Move Source Sans to vendors and standardize folder layout 2017-10-12 09:38:11 -06:00
reap3r119
63ab1e3566 Fix EOT font file 2017-10-12 09:30:21 -06:00
reap3r119
c552b922b3 Delete unnecessary duplicates 2017-10-12 09:30:04 -06:00
reap3r119
d26f16ebdc Add local Source Sans Pro 2017-10-11 13:18:54 -06:00
Naoki Takezoe
cf18550a2c Bump emoji plugin to 4.5.0 2017-10-11 02:53:06 +09:00
Naoki Takezoe
8d2d3571b8 Update version to 4.18.0 2017-10-10 14:31:31 +09:00
Naoki Takezoe
d2ac5aa0bf Merge pull request #1734 from gitbucket/license-report
Create license report using sbt-license-report plugin
2017-10-10 14:15:50 +09:00
Naoki Takezoe
f1ae6784f5 Create license report 2017-10-10 13:09:20 +09:00
Naoki Takezoe
8a6448c64f Merge pull request #1733 from masterwto/master
Removes imports of external links so that gitbucket can be used in off-internet-environments
2017-10-10 10:17:23 +09:00
masterwto
98ccd4b1d4 Update AdminLTE.min.css
removes fonts.googleapis
2017-10-09 18:38:20 +08:00
masterwto
71b4a313e2 Update AdminLTE.css
removes fonts.googleapis
2017-10-09 18:37:48 +08:00
Naoki Takezoe
1bf6939fc3 Merge pull request #1732 from gitbucket/reply-diff-comment
Add reply comment form to diff view
2017-10-09 12:48:38 +09:00
Naoki Takezoe
0000949966 Adding reply comment form to diff view 2017-10-09 12:29:32 +09:00
Naoki Takezoe
f767e621a4 Fix CSS style 2017-10-09 03:31:38 +09:00
Naoki Takezoe
d40c8ff6eb Merge pull request #1731 from gitbucket/enhance-suggestion-provider
Enhance SuggestionProvider to be able to supply label and value
2017-10-09 00:30:36 +09:00
Naoki Takezoe
e6838d8891 Enhance SuggestionProvider to be able to supply label and value 2017-10-08 14:35:23 +09:00
Naoki Takezoe
440dd0386b Merge pull request #1715 from kounoike/pr-use-fullname-for-edit
Use account.fullName instead of userName for Web UI edit, Wiki uploads.
2017-10-08 13:06:46 +09:00
Naoki Takezoe
37b181c5d0 (refs #1725) Allow administrators in collaborators to force to merge PR 2017-10-08 04:17:20 +09:00
Naoki Takezoe
5e7afa0f41 (refs #1727) Repair the commit diff view 2017-10-04 18:16:56 +09:00
Naoki Takezoe
badc9b5117 Merge pull request #1726 from reap3r119/patch-1
Add additional system paths to reserved names
2017-10-03 01:55:00 +09:00
Naoki Takezoe
5257c4fc2c Apply commit hook to online editing (#1729)
Apply commit hook to online file editing
2017-10-03 01:52:30 +09:00
Reap3r119
f47e389a9b Reserve "groups" and "new" 2017-09-29 12:34:30 -06:00
Reap3r119
8327333305 Reserve additional system paths 2017-09-29 12:13:15 -06:00
Reap3r119
4bd05835a5 Reserve "assets" and "plugin-assets" 2017-09-29 11:57:56 -06:00
Naoki Takezoe
a51b57af2a Update README.md 2017-09-24 14:23:43 +09:00
Naoki Takezoe
17ff024166 Update README.md 2017-09-24 14:14:00 +09:00
Naoki Takezoe
ed0c8e3f2c Bump gitbucket-notifications-plugin to 1.2.0 2017-09-24 14:00:33 +09:00
Naoki Takezoe
6b762b0693 Fix version as 4.17.0 2017-09-24 12:34:00 +09:00
Naoki Takezoe
62e6d0d6e8 (refs #1722)Bump markedj to 1.0.15 2017-09-24 12:30:44 +09:00
Naoki Takezoe
6947f57bd8 Merge pull request #1719 from gitbucket/drop-file-upload-limitation
Drop uploadable file type limitation
2017-09-22 01:18:19 +09:00
Naoki Takezoe
08295afb51 (refs #1714)Drop uploadable file type limitation 2017-09-21 16:51:15 +09:00
Naoki Takezoe
8d5b494785 Update doc for JRebel 2017-09-21 16:09:52 +09:00
Naoki Takezoe
8d52fc06ed Update doc for JRebel 2017-09-21 16:01:07 +09:00
Naoki Takezoe
1a9982446f Move to sbt 1.0 2017-09-21 13:27:14 +09:00
Naoki Takezoe
85b83af73f Merge pull request #1717 from gitbucket/refuse-delete-default-branch
Refuse deletion of the default branch
2017-09-21 02:20:29 +09:00
Naoki Takezoe
d99898e191 Implement checking whether a deleting branch is the default branch 2017-09-21 02:08:19 +09:00
Naoki Takezoe
2044f5b838 Refuse deletion of the default branch 2017-09-20 17:46:53 +09:00
Naoki Takezoe
bb804f6597 Merge pull request #1696 from gitbucket/api_repository_ssh_url
Add ssh_url to web hook request and API response
2017-09-20 16:18:35 +09:00
KOUNOIKE Yuusuke
407c742596 Use account.fullName instead of userName for Web UI edit, Wiki uploads. 2017-09-19 23:06:04 +09:00
Naoki Takezoe
4d3756ac0a Merge pull request #1712 from kounoike/pr-fix-1701
Allow anonymous access to github style git url redirect. fix #1701
2017-09-19 09:02:28 +09:00
Naoki Takezoe
0739b3048b Merge pull request #1713 from kounoike/pr-gc-call
repo > Settings > Danger Zone > Garbage collection doesn't executed.
2017-09-18 17:21:29 +09:00
KOUNOIKE Yuusuke
ff5a05511d git.gc() doesn't called. 2017-09-18 14:38:14 +09:00
KOUNOIKE Yuusuke
186ce769a2 allow anonymous access to git redirect. fix #1701 2017-09-18 14:03:04 +09:00
Naoki Takezoe
848c698491 Update sbt plugins 2017-09-18 02:18:28 +09:00
Naoki Takezoe
41ea2087d1 Fix guideline to accept any languages 2017-09-17 21:30:46 +09:00
Naoki Takezoe
1d77727867 Merge pull request #1711 from gitbucket/improve-mail-api
Make Mailer API more general
2017-09-17 01:32:16 +09:00
Naoki Takezoe
051d059e5c Improve Mailer API 2017-09-17 00:49:10 +09:00
Naoki Takezoe
324107beef Change the setting icon 2017-09-16 11:06:44 +09:00
Naoki Takezoe
801d71b6d2 Update Mailer.send() signature 2017-09-16 03:11:40 +09:00
Naoki Takezoe
106f7a41d8 Add Mailer.send() method without login account 2017-09-15 20:57:50 +09:00
Naoki Takezoe
1b46651c32 Merge pull request #1709 from kounoike/PR-keep-hash-at-signin
Keep hash when sign in.
2017-09-15 00:11:22 +09:00
KOUNOIKE Yuusuke
459b25e075 Change hash field to Option[String]. 2017-09-14 21:42:29 +09:00
Naoki Takezoe
e3c3a61f0b Fix NullPointerException in the first run from source code 2017-09-14 11:29:41 +09:00
KOUNOIKE Yuusuke
a311ee5ef5 Keep hash when sign in. fix #1706 2017-09-14 04:48:31 +09:00
Naoki Takezoe
b13decf0e9 (refs #1702)Implement keyboard shortcut "y"
which transfers a browser to URL with commit id.
2017-09-13 14:10:00 +09:00
Naoki Takezoe
f6b92ef40b Fix style of buttons 2017-09-13 03:36:04 +09:00
Naoki Takezoe
919b1d01e3 Fix labels and priorities styles 2017-09-13 03:23:15 +09:00
Naoki Takezoe
fe73c11611 Fix styles 2017-09-12 20:57:35 +09:00
Naoki Takezoe
c8af6c4b5a Fix styles 2017-09-12 20:54:15 +09:00
Naoki Takezoe
5d2d36dccf Fix styles 2017-09-12 20:48:37 +09:00
Naoki Takezoe
a11f711778 Merge pull request #1703 from kounoike/pr-switch-to-commitid-url
Change URL with commit ID when user selects line(s).
2017-09-12 18:52:28 +09:00
Naoki Takezoe
6920704caa Fix pull request title edit button 2017-09-12 16:19:57 +09:00
Naoki Takezoe
451a6ef359 Fix button style 2017-09-12 11:58:48 +09:00
KOUNOIKE Yuusuke
a93f4cc780 Transfer to URL with commit ID when select line(s). 2017-09-12 11:24:13 +09:00
Naoki Takezoe
f9fda26e7a Add RepositoryService#hasOwnerRole() 2017-09-11 02:27:22 +09:00
Naoki Takezoe
7435902b70 Generate submodule link only when url starts with http:// or https:// 2017-09-07 02:15:10 +09:00
Naoki Takezoe
feb57c97b9 Bump to 4.17.0-SNAPSHOT 2017-09-06 15:34:09 +09:00
Naoki Takezoe
7021942a6e Merge branch 'add_assignee_to_pr_api' 2017-09-05 20:37:03 +09:00
Naoki Takezoe
9251d64de8 Avoid database access in model
Modified to pass assignee from outside of model instead.
2017-09-05 19:47:41 +09:00
Naoki Takezoe
d0c99727e9 Fix testcases 2017-09-05 16:06:06 +09:00
Naoki Takezoe
1fbfcfb446 Add ssh_url to API response 2017-09-05 15:14:54 +09:00
Naoki Takezoe
38328b2ffe What charset should be used to make patch? 2017-09-05 12:02:23 +09:00
Naoki Takezoe
3cce4e5308 Merge pull request #1670 from gitbucket/feature/get-single-commit-api
Get single commit API
2017-09-05 11:57:04 +09:00
Naoki Takezoe
757292d670 Fix response of get single commit API
Fix response of get single commit API
2017-09-05 11:41:43 +09:00
Naoki Takezoe
ef16804b49 Make patch from DiffEntry 2017-09-05 11:27:59 +09:00
Naoki Takezoe
dafabb6278 Fix import 2017-09-05 09:31:45 +09:00
Naoki Takezoe
1f37362da4 Merge branch 'master' into feature/get-single-commit-api
# Conflicts:
#	src/main/scala/gitbucket/core/controller/ApiController.scala
2017-09-05 09:28:36 +09:00
Naoki Takezoe
1dba28d153 (refs #1643)Create issue reference comment
even if it can't relate committer’s email with GitBucket account
2017-09-04 19:17:25 +09:00
Naoki Takezoe
e83b017ef2 (refs #1695)Fix plugin controllers mapping 2017-09-04 18:46:07 +09:00
Naoki Takezoe
eeabbfd599 Fix plugin reloading from PluginWatchThread 2017-09-03 22:36:03 +09:00
Naoki Takezoe
55a8602bba (#1685)Call PullRequestHook.addedComment for PR code comment 2017-09-03 04:39:20 +09:00
Naoki Takezoe
2e80e3baaf Fix testcase 2017-09-03 03:52:00 +09:00
Naoki Takezoe
3134bb0428 (refs #1687)Bump notification plugin to 1.1.0 2017-09-02 13:43:44 +09:00
Naoki Takezoe
134b5df6a2 (refs #1675)Drop debug option because it can't be configure at settings form 2017-09-02 13:43:21 +09:00
Naoki Takezoe
aab84d9275 Update README.md 2017-09-02 01:35:13 +09:00
Naoki Takezoe
5209c29d0f Update README.md 2017-09-02 01:32:34 +09:00
Naoki Takezoe
cc975f8ffa Release 4.16.0 2017-09-02 01:30:06 +09:00
Naoki Takezoe
125040f90b (refs #1688)Fix regex which is used to extract user and repository name from URL 2017-09-01 00:58:49 +09:00
Naoki Takezoe
7009aaeb24 Merge pull request #1675 from kounoike/pr-handle-errors
Handle errors to show errors prettify and logging it.
2017-08-29 01:26:21 +09:00
Naoki Takezoe
a135c6977f Merge pull request #1683 from int128/fix-api-branch-with-slash
Fix branch API did not accept branch name with slash
2017-08-29 01:23:18 +09:00
Naoki Takezoe
55991a6f17 Merge pull request #1690 from uli-heller/blocking-slick-32-0.0.10
blocking-slick-32: 0.0.9 -> 0.0.10
2017-08-29 01:20:18 +09:00
Naoki Takezoe
17e1de6174 Bump to 4.16.0-SNAPSHOT 2017-08-28 19:24:06 +09:00
Uli Heller
12a58f393e blocking-slick-32: 0.0.9 -> 0.0.10 2017-08-25 08:18:59 +02:00
Hidetake Iwata
ebb57a80e3 Fix branch API did not accept branch name with slash 2017-08-21 17:58:22 +09:00
Naoki Takezoe
7a53bd8766 Merge pull request #1672 from kounoike/pr-support-textmsg-in-email
Add support to MIME Text part in Email notification.
2017-08-21 01:04:00 +09:00
Naoki Takezoe
d8b46b194d Merge branch 'master' into pr-support-textmsg-in-email 2017-08-20 23:39:05 +09:00
Yuusuke KOUNOIKE
5db7d863ff Merge branch 'master' into pr-handle-errors 2017-08-20 22:28:34 +09:00
Naoki Takezoe
7d7c11aa1a Merge AnonymousAccessController and GitHubCompatibleAccessController 2017-08-20 22:18:36 +09:00
Naoki Takezoe
95748a2f2f Merge pull request #1678 from int128/github-compat-url
Improve GitHub compatible URL
2017-08-20 22:02:58 +09:00
KOUNOIKE Yuusuke
e77045abe3 Merge remote-tracking branch 'upstream/master' into pr-handle-errors
# Conflicts:
#	src/main/scala/gitbucket/core/controller/SystemSettingsController.scala
#	src/main/scala/gitbucket/core/service/SystemSettingsService.scala
#	src/test/scala/gitbucket/core/view/AvatarImageProviderSpec.scala
2017-08-20 21:50:34 +09:00
Naoki Takezoe
d73ddbdbcb Merge branch 'master' into github-compat-url 2017-08-20 21:41:10 +09:00
Naoki Takezoe
8893a4a456 Merge pull request #1681 from gitbucket/drop-jdk9-build
Drop JDK9 build
2017-08-20 21:40:21 +09:00
Naoki Takezoe
608112ce22 Drop JDK9 build 2017-08-20 21:29:36 +09:00
Naoki Takezoe
2e9155fbcc Merge branch 'master' into pr-support-textmsg-in-email 2017-08-19 01:59:14 +09:00
Naoki Takezoe
f33a30c697 Merge pull request #1676 from kounoike/pr-skin-selectable
add AdminLTE skin selection feature.
2017-08-18 20:15:22 +09:00
Hidetake Iwata
e208dd5966 Implement as controller instead of filter 2017-08-18 18:56:01 +09:00
KOUNOIKE Yuusuke
a6cb71f9c3 remove helpers.skinName. (by review comment) 2017-08-18 01:55:56 +09:00
Naoki Takezoe
91deeb969b Merge branch 'master' into pr-skin-selectable 2017-08-18 01:00:20 +09:00
KOUNOIKE Yuusuke
040d812f2a add debug option to SystemSettings. and error page shows stacktrace only for admin or debug settings. 2017-08-17 17:48:53 +09:00
Hidetake Iwata
772ac80764 Improve GitHub compatible URL 2017-08-16 10:09:08 +09:00
Yuusuke KOUNOIKE
ef67c94272 Merge branch 'master' into pr-support-textmsg-in-email 2017-08-15 03:26:17 +09:00
KOUNOIKE Yuusuke
fdb4a6bdc6 change interface to textMsg: String, htmlMsg: Option[String].
SystemSettingsController calls Mailer.send directly. fix it too.
2017-08-15 03:25:27 +09:00
Naoki Takezoe
57902af87c (refs #1553)Fixup 2017-08-15 03:25:27 +09:00
KOUNOIKE Yuusuke
92fea3ff01 fix test. 2017-08-15 02:44:52 +09:00
Naoki Takezoe
cbd16169e4 (refs #1553)Fixup 2017-08-15 02:02:17 +09:00
KOUNOIKE Yuusuke
299df34bf4 add AdminLTE skin selection feature. 2017-08-14 22:12:17 +09:00
KOUNOIKE Yuusuke
48a92df719 Handle errors to show errors prettify and logging it. 2017-08-14 18:50:02 +09:00
shimamoto
b806439e2f Merge branch 'master' into pr-support-textmsg-in-email 2017-08-14 18:45:34 +09:00
Naoki Takezoe
1db586c0bd Merge pull request #1671 from kounoike/pr-send-comment-at-merged
Call addedComment hook(send notification) at PR merged.
2017-08-14 18:08:57 +09:00
KOUNOIKE Yuusuke
26e2bfbf43 Call addedComment hook(send notification) at PR merged. 2017-08-14 14:02:30 +09:00
KOUNOIKE Yuusuke
28c4ac6a19 Add support to MIME Text part. 2017-08-14 13:25:25 +09:00
Naoki Takezoe
c0d9d68fca Merge pull request #1553 from kounoike/pr-show-commitstaus-in-commits
Show CommitStatus in commits page.
2017-08-14 12:01:40 +09:00
Yuusuke KOUNOIKE
122ed1dd0f Merge branch 'master' into pr-show-commitstaus-in-commits 2017-08-14 01:14:49 +09:00
Naoki Takezoe
f18b83999a Merge remote-tracking branch 'origin/master' 2017-08-13 01:59:17 +09:00
Naoki Takezoe
fc28aacb52 (refs #1664)Bump to markedj 1.0.14 2017-08-13 01:59:00 +09:00
Naoki Takezoe
efdfe2b1b5 Implementing get single commit API 2017-08-13 01:15:18 +09:00
Naoki Takezoe
2872da4f94 Merge pull request #1669 from kounoike/pr-fix-1552
Add query string for redirect, required by git-2.11-1.
2017-08-12 20:34:03 +09:00
KOUNOIKE Yuusuke
5d3c5e7f3c Add query string for redirect, it required by git-2.12. close #1552 2017-08-12 15:16:55 +09:00
Naoki Takezoe
a86fb480b2 Merge pull request #1668 from gitbucket/thread-safe-collection
Improve concurrency of initializaton of the plugin system
2017-08-12 04:45:59 +09:00
Naoki Takezoe
7daf33c149 Merge branch 'master' into thread-safe-collection 2017-08-12 04:37:14 +09:00
Naoki Takezoe
0d9afdc939 (refs #1664)Bump to markedj 1.0.14-SNAPSHOT 2017-08-12 03:46:47 +09:00
Naoki Takezoe
a9a26193cd Improve shutdown of the plugin system 2017-08-12 03:38:07 +09:00
Naoki Takezoe
684973ea85 Merge pull request #1666 from HairyFotr/patch-8
Fix lint and typos
2017-08-09 08:18:55 +09:00
HairyFotr
0149593272 Fix lint and typos 2017-08-08 21:37:35 +02:00
Naoki Takezoe
1ae3df76bd Use thread-safe collection 2017-08-07 17:53:32 +09:00
Naoki Takezoe
d8e0a06d93 Add the support guidelines 2017-08-06 14:07:40 +09:00
Naoki Takezoe
b2d842ddd0 (refs #1654)Add --validate_password option 2017-08-06 03:49:04 +09:00
Naoki Takezoe
580374208f Merge remote-tracking branch 'origin/master' 2017-08-06 03:38:25 +09:00
Naoki Takezoe
8ab96f09cb Update ISSUES.UPDATED_DATE column when issue attriibutes are updated 2017-08-06 03:38:22 +09:00
Naoki Takezoe
f5b6728358 Merge pull request #1659 from kounoike/pr-api-pr-merged
fix getMergedComment for PR API merged field.
2017-08-06 03:20:12 +09:00
Naoki Takezoe
c7d46ee18f Merge branch 'master' into pr-api-pr-merged 2017-08-06 02:59:51 +09:00
Naoki Takezoe
eafdd0fb61 Update README.md 2017-08-05 11:45:45 +09:00
Naoki Takezoe
a14394dd88 Gist, Emoji and Pages plugin are disabled in default 2017-07-31 11:59:19 +09:00
Naoki Takezoe
e28b0394ec Update README.md 2017-07-31 09:35:43 +09:00
Naoki Takezoe
11903e9728 Update README.md 2017-07-31 09:34:04 +09:00
Naoki Takezoe
0e498d1a81 Add a special rule for pages-plugin's url 2017-07-31 01:29:13 +09:00
KOUNOIKE Yuusuke
f073112814 fixup 2017-07-30 13:52:27 +09:00
KOUNOIKE Yuusuke
9ee71e9f25 fix getMergedComment for PR API merged field. 2017-07-30 11:39:36 +09:00
kenji yoshida
0aafc16648 Merge pull request #1657 from uli-heller/scala-2.12.3
scala-2.12.3
2017-07-29 16:59:09 +09:00
Uli Heller
58246a91b0 scala-2.12.3 2017-07-28 11:51:42 +02:00
Naoki Takezoe
53ae59271a Add pages plugin 2017-07-27 07:34:42 +09:00
Naoki Takezoe
1a2e4e72bd Update bundle plugin information 2017-07-26 00:53:23 +09:00
Naoki Takezoe
2a83c1b9ba Add null check 2017-07-25 12:35:41 +09:00
Naoki Takezoe
5b245978d4 Update README.md 2017-07-25 02:14:00 +09:00
Naoki Takezoe
1463cee2a4 Log bundle plugins downloading 2017-07-24 20:29:20 +09:00
Naoki Takezoe
f4b910c268 Download bundle plugins from plugins.json 2017-07-24 20:26:30 +09:00
Naoki Takezoe
d39c371635 Bundling plugins is executed in packaging of the executable war file 2017-07-24 14:26:45 +09:00
Naoki Takezoe
19b3c2a265 Update bundled plugins 2017-07-23 01:05:43 +09:00
Naoki Takezoe
28efc38fc4 Fixup 2017-07-22 16:00:51 +09:00
Naoki Takezoe
6a7e948e89 Tweak copy button style 2017-07-22 15:40:35 +09:00
Naoki Takezoe
645d23b531 (refs #1635)Fix scrollbar issue 2017-07-22 15:08:26 +09:00
Naoki Takezoe
50ae5bb7cc Bump to blocking-slick 0.0.9 (Slick 3.2.1) 2017-07-22 02:36:39 +09:00
Naoki Takezoe
38728910cb Merge pull request #1652 from aruneko/support_ed25519_key
support ed25519 key
2017-07-22 01:42:04 +09:00
Aruneko
e2f695777d support ed25519 key 2017-07-21 22:36:03 +09:00
Naoki Takezoe
06a98d0f94 (refs #1644)Bump markedj to 1.0.13 2017-07-19 03:16:04 +09:00
Naoki Takezoe
944cbf04ed Enhance --plugin_dir option behavior
It became an option to specify an extra plugin jars directory, not to overwrite PLUGIN_HOME.
2017-07-18 13:04:32 +09:00
Naoki Takezoe
84891abc04 Merge pull request #1648 from gitbucket/travis-java9-build
Test for oraclejdk9 build on Travis
2017-07-18 01:37:03 +09:00
Naoki Takezoe
a848bb43b6 Scraping JDK file name 2017-07-18 01:13:49 +09:00
Naoki Takezoe
d57a2e5eae Test for oraclejdk9 build 2017-07-18 00:48:51 +09:00
Naoki Takezoe
d1adcb876d Merge pull request #1647 from gitbucket/feature/preview-comment-edit
Make preview-able comment editing forms
2017-07-17 23:15:12 +09:00
Naoki Takezoe
8505d8ae0e Change position of buttons in comment editing forms 2017-07-17 22:44:53 +09:00
Naoki Takezoe
3a567cb4a7 Make preview-able comment editing form 2017-07-17 22:35:53 +09:00
Naoki Takezoe
20dbba116a Bump gist-plugin to 4.9.1 2017-07-17 19:52:42 +09:00
Naoki Takezoe
f7d7b5bd7b Call prettyprint() after issue content editing 2017-07-17 14:47:30 +09:00
Naoki Takezoe
dd15420f2c (refs #1644)Bump markedj to 1.0.13-SNAPSHOT 2017-07-17 14:43:05 +09:00
Naoki Takezoe
31945533c2 (refs #1645)Ignore tagged object is not commit 2017-07-17 03:07:54 +09:00
shimamoto
9288e0abe0 Remove notification.md (move to plugins). 2017-07-13 20:35:09 +09:00
Naoki Takezoe
5641fee39a Fix plugin controller handling 2017-07-13 01:52:26 +09:00
Naoki Takezoe
db88458a14 Remove unnecessary semicolon 2017-07-12 18:42:14 +09:00
Naoki Takezoe
3ff89bc648 (refs #1484)Add --plugin_dir option 2017-07-12 18:33:43 +09:00
Naoki Takezoe
61f3d2d513 Fixup 2017-07-12 13:07:41 +09:00
Naoki Takezoe
788f253ad0 Merge pull request #1487 from gitbucket/feature/plugin-hotdeploy
Plugin hot deployment and bundle some plugins
2017-07-12 11:20:27 +09:00
Naoki Takezoe
947d93ddc7 Remove extra information from plugins.json 2017-07-09 02:31:13 +09:00
Naoki Takezoe
74063885b1 Don't check semver for unmanaged plugins 2017-07-09 01:55:00 +09:00
Naoki Takezoe
554fd6d700 Add emoji plugin 2017-07-09 01:49:57 +09:00
Naoki Takezoe
1fb6861565 Add notifications plugin 2017-07-08 20:01:16 +09:00
Naoki Takezoe
6c5350a51b Drop issue and pull request notification because it will be provided as plugin 2017-07-08 19:37:48 +09:00
Naoki Takezoe
00da7e9a82 Merge branch 'master' into feature/plugin-hotdeploy 2017-07-08 14:05:27 +09:00
Naoki Takezoe
e18bed12c0 Update version to 4.15.0-SNAPSHOT 2017-07-08 14:04:50 +09:00
Naoki Takezoe
d2bb7e912f Merge pull request #1638 from gitbucket/feature/repository-header-plugin
Add repositoryHeaderComponent extension point
2017-07-08 14:00:15 +09:00
Naoki Takezoe
73ed69a4ad Add repositoryHeaderComponent extension point 2017-07-08 13:28:44 +09:00
Naoki Takezoe
d8fe6a0a55 Capability of installing from the local repository 2017-07-07 11:47:43 +09:00
Naoki Takezoe
b278bfd159 (refs #1633)Bugfix for --max_file_size parameter 2017-07-07 01:54:20 +09:00
Naoki Takezoe
872beb777f Merge pull request #1634 from kazuki43zoo/gh-1629_add-repo-link
Add repo-link class to repository link at sidebar menu
2017-07-06 13:48:53 +09:00
Naoki Takezoe
aebcf5d183 Make possible to install bundled plugins in default
and use JSON for defining bundled plugin metadata
2017-07-06 03:25:06 +09:00
Kazuki Shimizu
aab9b71901 Add repo-link class to repository link at sidebar menu
Fixes #1629
2017-07-06 00:04:41 +09:00
Naoki Takezoe
9cbab137fc Make possible to install and uninstall bundled plugins 2017-07-05 18:01:03 +09:00
Naoki Takezoe
358bc23931 Fix compilation error 2017-07-05 16:58:28 +09:00
Naoki Takezoe
7396bf0675 Merge branch 'feature/bundle-plugins' into feature/plugin-hotdeploy 2017-07-05 16:42:20 +09:00
Naoki Takezoe
61166c4388 Add enabled flag to plugin info list 2017-07-05 16:40:35 +09:00
Naoki Takezoe
4b9f2c7728 Merge pull request #1628 from uli-heller/jgit-4.8.0.201706111038-r
Updated to jgit-4.8.0.201706111038-r
2017-07-05 10:57:00 +09:00
Naoki Takezoe
6b496bdef2 Merge branch 'master' into jgit-4.8.0.201706111038-r 2017-07-05 02:18:39 +09:00
Naoki Takezoe
0e795f58dd Remove unnecessary semicolon 2017-07-05 02:17:37 +09:00
Naoki Takezoe
e2ac8e29fe Adopt latest version if different versions of same plugin are found 2017-07-05 02:17:02 +09:00
Naoki Takezoe
bc80adc412 Merge branch 'master' into feature/bundle-plugins 2017-07-05 02:00:28 +09:00
Naoki Takezoe
2f634625ea Copy only LFS dir and insert default priorities in forking repository 2017-07-05 00:36:24 +09:00
Naoki Takezoe
d80774d8d0 Release 4.14.1 2017-07-05 00:36:12 +09:00
Naoki Takezoe
ecf3e97518 (refs #1631)Copy repository files directory only if it exists 2017-07-04 23:52:39 +09:00
Naoki Takezoe
3758d1f5ad Fix typo 2017-07-04 23:49:56 +09:00
Uli Heller
3e53008d35 Updated to jgit-4.8.0.201706111038-r 2017-07-04 06:45:48 +02:00
Naoki Takezoe
afde5c2685 (refs #1625)Copy bundled plugins in initialization process 2017-07-02 13:16:18 +09:00
Naoki Takezoe
224c355d44 (refs #1575)Use MaridDB JDBC driver instead of MySQL driver
to solve license issue
2017-07-02 04:53:57 +09:00
Naoki Takezoe
269718bfa6 Merge branch 'kounoike-pr-svg-logo' 2017-07-02 04:32:42 +09:00
KOUNOIKE Yuusuke
d145fdbb23 use svg icon for top-left logo. 2017-07-01 09:32:06 +09:00
KOUNOIKE Yuusuke
a60848b16c add svg icon to solve jaggy image in IE11. it also closes #747 (gray logo) 2017-07-01 09:32:06 +09:00
Naoki Takezoe
e6d6843a37 Release 4.14 2017-07-01 02:42:31 +09:00
Naoki Takezoe
0b44c794f9 Small template fix 2017-06-29 19:00:14 +09:00
Naoki Takezoe
5346db93e1 (refs #1618)Fix error message position 2017-06-29 18:49:17 +09:00
Naoki Takezoe
a0a7c7f428 (refs #1618)Check conflict on the online editor in validation 2017-06-29 18:47:12 +09:00
Naoki Takezoe
57228147ce Fix layout of comment form 2017-06-29 18:23:34 +09:00
Naoki Takezoe
d122c92db1 (refs #1618)Reject online editing if new commits have been pushed already 2017-06-29 18:05:35 +09:00
Naoki Takezoe
7761946ec0 (refs #1623)Copy attached / LFS files when repository is forked 2017-06-27 14:52:37 +09:00
Naoki Takezoe
47a131c232 Merge pull request #1617 from gitbucket/feature/external-config
Make all settings configurable by system property or environment variable
2017-06-25 23:32:36 +09:00
Naoki Takezoe
c6e095d066 Delete unused methods 2017-06-25 18:33:10 +09:00
Naoki Takezoe
282d5fe239 Make all settings configurable by system property or environment variable 2017-06-25 18:33:10 +09:00
Naoki Takezoe
5164d57787 Update version to 4.14.0-SNAPSHOT 2017-06-25 18:16:55 +09:00
Yasuhiro Takagi
884fc5318a Add assignee entry for the result of pull request related api 2017-06-25 13:33:27 +09:00
Naoki Takezoe
626e68eae8 Tweak group editing form template 2017-06-24 18:59:00 +09:00
Naoki Takezoe
0b76307354 Fix TODO 2017-06-24 18:50:08 +09:00
Naoki Takezoe
3f9892f12f Small fix of group editing form 2017-06-24 18:14:05 +09:00
Naoki Takezoe
b525c0ede7 Fix regression in group editing in admin console 2017-06-24 18:00:14 +09:00
Naoki Takezoe
902e7513d9 Share group creating / editing form template 2017-06-24 17:51:43 +09:00
Naoki Takezoe
6b824a47f5 Add sidebar to group configuration 2017-06-24 17:36:07 +09:00
Naoki Takezoe
d14a5df3fe Fix html markup 2017-06-24 15:04:57 +09:00
Naoki Takezoe
0a4b78160f Refactor account level web hook entirely 2017-06-24 14:58:58 +09:00
Naoki Takezoe
54be93b0da Move account level web hook settings to account settings 2017-06-24 14:13:22 +09:00
Naoki Takezoe
59c9de9f41 Update CSS 2017-06-24 13:19:24 +09:00
xuwei-k
1631c1f147 fix .travis.yml
- install java9 explicitly https://github.com/travis-ci/travis-ci/issues/7944
- restore main java8 build (bug or change specifications? https://twitter.com/xuwei_k/status/873104018100244480 )
- "sudo apt-get install libaio1" fail. use apt addons https://github.com/travis-ci/apt-package-whitelist/pull/3698
2017-06-23 11:28:49 +09:00
Naoki Takezoe
0bd833a6b7 (refs #1620) Bump AdminLTE to 2.3.11 2017-06-21 01:11:38 +09:00
Naoki Takezoe
cf69a67029 Merge pull request #1488 from kounoike/pr-add-account-webhook
Add account(group/user)'s webhooks feature.
2017-06-19 02:13:55 +09:00
Naoki Takezoe
3b1a359367 Fix compilation error 2017-06-19 00:09:31 +09:00
Naoki Takezoe
880c6ac554 Merge branch 'master' into pr-add-account-webhook 2017-06-18 18:15:41 +09:00
Naoki Takezoe
8e732c68bc Merge pull request #1616 from imeszaros/issue-priorities
Issue priorities
2017-06-12 14:11:36 +09:00
Istvan Meszaros
9799735420 Eliminate manual emtpy to none conversion. This may close #1396 2017-06-12 06:52:49 +02:00
Istvan Meszaros
9ffae4241d Having a default priority is now optional. 2017-06-11 15:45:23 +02:00
Istvan Meszaros
68cb95e758 Show errors related to priority description. 2017-06-11 15:45:22 +02:00
Istvan Meszaros
967dafb87e Priority description is now optional. 2017-06-11 15:45:21 +02:00
Istvan Meszaros
743bb94e83 Prefer external styles instead of inline. 2017-06-11 15:45:20 +02:00
Istvan Meszaros
c461e6ac0b Default priority feature implemented. 2017-06-11 15:45:19 +02:00
Istvan Meszaros
b2b31da80b Added the 'is default' column to priorities table. 2017-06-11 15:45:18 +02:00
Istvan Meszaros
0f6453cb26 Fix: added handling of priorities on repository rename/delete. 2017-06-11 15:45:17 +02:00
Istvan Meszaros
c2eece31b0 Default priorities changed according to the wishlist spec. 2017-06-11 15:45:16 +02:00
Istvan Meszaros
4fa28e9040 Priorities now have a description that appears as a standard HTML
tooltip across the app.
2017-06-11 15:45:15 +02:00
Istvan Meszaros
889e94a494 Priorities now integrated with issues. 2017-06-11 15:45:14 +02:00
Istvan Meszaros
c908b5e642 Added foreign key to issue table, extended the issue outline view to
include the priority.
2017-06-11 15:45:13 +02:00
Istvan Meszaros
26f6d25481 Priorities CRUD interface implemented. 2017-06-11 15:45:12 +02:00
Istvan Meszaros
034870ba19 jQuery UI sortable plugin added to the app. 2017-06-11 13:39:30 +02:00
Istvan Meszaros
54f6a68a8a Added model classes for priorities. 2017-06-11 13:39:29 +02:00
Istvan Meszaros
626113affa Added table for priorities. 2017-06-11 13:39:29 +02:00
Naoki Takezoe
4e299b2ad5 Merge remote-tracking branch 'origin/kounoike-pr-sidebar-mini' 2017-06-11 17:12:23 +09:00
kenji yoshida
cb7c91f666 fix sbt version when oraclejdk9 test 2017-06-09 13:59:54 +09:00
Naoki Takezoe
50208c2df3 Merge pull request #1615 from gitbucket/feature/plugin-notification
Add hook for issue and pull request
2017-06-09 11:56:18 +09:00
shimamoto
8a49870822 Implement existing email notification using plugin hooks. 2017-06-08 19:52:58 +09:00
Naoki Takezoe
bf7c93cd91 Fixup 2017-06-05 20:02:51 +09:00
KOUNOIKE Yuusuke
6c5777801f Show icons when sidebar is collapsed. 2017-06-05 13:39:34 +09:00
shimamoto
6887dab787 Change the endpoint of notification feature for plugin. 2017-06-02 20:21:37 +09:00
Naoki Takezoe
150531a1e2 Merge pull request #1614 from gitbucket/feature/gollum-webhook
Support gollum event in web hook
2017-06-02 18:54:49 +09:00
Naoki Takezoe
a7a53610e6 Add Gollum event option to web hook configuration page 2017-06-02 18:46:15 +09:00
Naoki Takezoe
2ec8189d47 Call wiki web hook in pushing via git client 2017-06-02 17:46:25 +09:00
Naoki Takezoe
d75d1eed10 Support gollum event in web hook 2017-06-02 13:06:13 +09:00
Naoki Takezoe
2f426990b7 (refs #1612)Add password validation to form for registering and editing user. 2017-06-02 07:53:23 +09:00
Naoki Takezoe
2e6c8f7054 Merge pull request #1611 from wy193777/maxFileSize-config
made maxFileSize in FileUploadController configurable
2017-06-01 15:35:54 +09:00
Naoki Takezoe
206a8f5afc Not delete repositories when group is deleted 2017-05-30 16:03:08 +09:00
Naoki Takezoe
e340207cac Not delete repositories when group is deleted 2017-05-30 15:43:30 +09:00
Shenghan Gao
12857ae6a3 made maxFileSize in FileUploadController configurable 2017-05-28 00:12:03 -07:00
Naoki Takezoe
43c8518a40 (refs #1610)Redirect if the issue is a pull request 2017-05-28 13:26:06 +09:00
takezoe
1b65ae2062 Don't render contents of Commits tab and Files tab if commits is empty. 2017-05-28 12:22:18 +09:00
Naoki Takezoe
3ba31f205e Avoid NoSuchElementException for pull request from behinded branch 2017-05-28 05:15:09 +09:00
Naoki Takezoe
bf28c2aacc Add 4.13 2017-05-27 10:51:04 +09:00
Naoki Takezoe
80834220b3 Update version number to 4.13.0 2017-05-27 10:45:57 +09:00
shimamoto
d8aacdaa94 Add account hook (deleted only). 2017-05-26 14:45:01 +09:00
Naoki Takezoe
cf763993cf Merge pull request #1609 from shiena/load-plugins-alphabetically
Load plugins alphabetically
2017-05-25 18:30:13 +09:00
shimamoto
89006a8720 Add issue hook and pull request hook. 2017-05-25 18:07:18 +09:00
Naoki Takezoe
4d9e1a83c8 Fix octicons style 2017-05-25 17:22:11 +09:00
Mitsuhiro Koga
850ebf2877 Load plugins alphabetically 2017-05-25 17:01:22 +09:00
Naoki Takezoe
7923bde014 Reformat gitbucket.css 2017-05-25 16:52:08 +09:00
Naoki Takezoe
1eab821f9a Fix size of buttons and labels in the branch liost view 2017-05-25 16:37:50 +09:00
Naoki Takezoe
042e76348a Merge pull request #1605 from gitbucket/feature/file-upload-to-repo
File upload into repository
2017-05-25 16:06:56 +09:00
Naoki Takezoe
7d0b8dc1ec Remove unused CSS styles 2017-05-25 15:39:40 +09:00
Naoki Takezoe
b0057481d8 (refs #1608)Fix updating parent repository relationship bug when repository is renamed or transferred. 2017-05-25 08:31:29 +09:00
Naoki Takezoe
d70c5947fa Fix CSS 2017-05-24 18:31:20 +09:00
Naoki Takezoe
43f7a61c4b Implementing file upload on the repository viewer 2017-05-24 18:19:41 +09:00
Naoki Takezoe
5a8516e8e5 Bump markedj to 1.0.12 2017-05-24 10:08:39 +09:00
Naoki Takezoe
4727aa90ab Merge branch 'feature/file-upload-to-repo' of https://github.com/devagorilla/gitbucket into devagorilla-feature/file-upload-to-repo 2017-05-23 15:33:01 +09:00
Naoki Takezoe
dcdc0cfa55 Fix view 2017-05-23 14:48:34 +09:00
Naoki Takezoe
27dc5597bc Merge pull request #1601 from tkgdsg/dropdown_filter
dropdown menu filter applied to "variable length" dropdown.
2017-05-22 11:40:42 +09:00
Yasuhiro Takagi
af37d23a0d dropdown menu filter applied to "variable length" dropdown
1. dropdown menu filter applied where that length is variable.
2. In compare.scala.html, use default dropdown menu function for filter.
2017-05-21 17:47:53 +09:00
Naoki Takezoe
2143760185 Merge pull request #1597 from tkgdsg/dropdown_filter_modification
function helper.html.dropdown supports filter placeholder
2017-05-18 11:19:15 +09:00
Yasuhiro Takagi
e919505f4e function helper.html.dropdown supports filter placeholder
developer can specify filter input placeholder in dropdown menu.
2017-05-17 21:40:30 +09:00
Naoki Takezoe
4fc221f4f9 Take first 5 commits to store activity 2017-05-15 17:15:49 +09:00
Naoki Takezoe
532f418c2f (refs #1591)Bump markedj to 1.0.11 to allow HTML in markdown 2017-05-13 20:54:20 +09:00
Naoki Takezoe
19016aa14a (refs #1594)Filter the comparing dropdown based on user’s right 2017-05-13 16:06:36 +09:00
Naoki Takezoe
6016844327 Merge pull request #1592 from t-tsutsumi/pr/fix-conditional-expression-default-branch
Fix conditional expression for determining whether it is default branch
2017-05-12 14:46:19 +09:00
t-tsutsumi
352438ee0a Fix conditional expression for determining whether it is default branch 2017-05-12 02:49:25 +09:00
Naoki Takezoe
d1dbdb1642 Merge pull request #1590 from t-tsutsumi/pr/fix-delete-branch-feature-of-pr
Fix delete branch feature of PR does not work at all
2017-05-11 11:26:07 +09:00
t-tsutsumi
29da986b9f Fix delete branch feature of PR does not work at all 2017-05-11 03:32:40 +09:00
Naoki Takezoe
0b819ea762 Merge pull request #1588 from t-tsutsumi/pr/fix-incorrect-redirect-url-and-authorization
Fix incorrect redirect URL and authorization in Update branch feature
2017-05-10 10:06:21 +09:00
Naoki Takezoe
b3dbaaae7a Merge pull request #1587 from t-tsutsumi/pr/disabling-directory-listing-feature
Disabling directory listing feature on Jetty
2017-05-10 10:05:15 +09:00
t-tsutsumi
2dcc14b4d9 Fix incorrect redirect URL and authorization in Update branch feature 2017-05-09 04:55:55 +09:00
t-tsutsumi
fe728baee7 Disabling directory listing feature on Jetty 2017-05-09 04:12:03 +09:00
Naoki Takezoe
d6f49eb442 Merge pull request #1585 from t-tsutsumi/pr/add-scala-ide-specific-files-to-.gitignore
Add Scala-IDE specific files to .gitignore
2017-05-08 02:19:41 +09:00
t-tsutsumi
890dbf99a7 Add Scala-IDE specific files to .gitignore 2017-05-08 00:58:32 +09:00
Naoki Takezoe
61853a474a Rolled back to Jetty 9.3.19.v20170502
because Scalatra 2.5.0 does not work with Jetty 9.4.
2017-05-06 09:52:14 +09:00
Naoki Takezoe
447183c779 Merge pull request #1583 from t-tsutsumi/pr/fix-incorrect-font-color-when-screen-size-768px-or-less
Fix incorrect font color when screen size 768px or less
2017-05-06 09:34:46 +09:00
t-tsutsumi
b371f76cb6 Fix incorrect font color when screen size 768px or less 2017-05-06 08:10:07 +09:00
Naoki Takezoe
a5971bbdde https://github.com/travis-ci/travis-ci/issues/7703 2017-05-06 01:44:20 +09:00
Naoki Takezoe
0827fef978 Merge pull request #1533 from aadrian/dependency_updates
Dependency updates
2017-05-06 00:05:37 +09:00
Naoki Takezoe
a66fcb3a77 Remove uniqId from template arguments 2017-05-05 23:46:07 +09:00
Naoki Takezoe
ac9b93bbba Merge pull request #1579 from tkgdsg/dropdown_filter_improve_and_fix
dropdown helper function improvement & modification
2017-05-05 23:35:09 +09:00
aadrian
7917483dfc Merge branch 'master' into dependency_updates 2017-05-04 15:44:38 +02:00
aadrian
c0a2c8a235 change back to jldap "2009-10-07" until a replacement library is used. 2017-05-04 15:26:32 +02:00
Yasuhiro Takagi
f28dc15252 dropdown helper function improvement & modification
helper can specify placeholder for it's filter.
to identify each dropdown input filter by id, use unique Id.
2017-05-04 12:31:41 +09:00
Naoki Takezoe
9faa3e8402 Bump to 4.12.1 2017-05-04 10:41:46 +09:00
Naoki Takezoe
0f33d66cc2 Merge pull request #1576 from t-tsutsumi/pr/remove-slf4j-jdk14
Remove SLF4J JDK14 binding
2017-05-04 10:04:27 +09:00
t-tsutsumi
5f9fd23c47 Remove SLF4J JDK14 binding 2017-05-04 04:11:04 +09:00
Naoki Takezoe
e98d275de3 Merge pull request #1571 from t-tsutsumi/pr/fix-incorrect-initial-height
Fix incorrect initial height of textarea
2017-05-03 09:39:51 +09:00
t-tsutsumi
6ffb2dbad7 Fix incorrect initial height of textarea 2017-05-02 20:23:34 +09:00
aadrian
eb2bef824d use postgresql-embedded 2.0 (that is supposed to work with Java 9) 2017-05-02 11:17:15 +02:00
Naoki Takezoe
45db917ee7 Create plugins directory if it does not exist 2017-05-02 15:27:07 +09:00
Naoki Takezoe
42494ce58a Improve logging 2017-05-02 15:22:25 +09:00
Naoki Takezoe
93c75a3ffd Retry copying plugin jar file if it can't get write lock
to avoid copying during file is creating or updating.
2017-05-02 15:03:47 +09:00
Naoki Takezoe
b9283fb544 Merge branch 'master' into feature/plugin-hotdeploy 2017-05-02 14:21:53 +09:00
Naoki Takezoe
16ccf83f7a Merge pull request #1568 from dbronecki/issue/1567
Fix redirect issue - fixes #1567
2017-05-02 12:40:18 +09:00
aadrian
f60685117d remove sbt-dependency-graph plugin. 2017-05-01 23:35:29 +02:00
aadrian
a830b80965 update jetty, h2 and akka again 2017-05-01 23:33:48 +02:00
Damian Bronecki
3795de97a4 Fix redirect issue by partially reverting to 956af54 - fixes #1567 2017-05-01 22:18:12 +02:00
aadrian
c972782053 use SBT 0.13.15 2017-04-30 18:09:48 +02:00
aadrian
52f05a911b Merge remote-tracking branch 'origin/master' into dependency_updates 2017-04-30 18:06:41 +02:00
Naoki Takezoe
0a007dd4eb Merge pull request #1512 from UprootStaging/safeOpt
Enable safe optimisations in scalac
2017-05-01 00:13:51 +09:00
Naoki Takezoe
6223503511 Merge pull request #1566 from xuwei-k/ApiRepository-watchers-param-unused
fix ApiRepository#apply
2017-05-01 00:03:13 +09:00
Naoki Takezoe
2e499e88a6 Merge pull request #1564 from t-tsutsumi/pr/disabling-server-header
Disabling Server header on Jetty
2017-04-30 19:14:29 +09:00
t-tsutsumi
658fe94d0f Avoid use functional looping style 2017-04-30 17:20:59 +09:00
xuwei-k
7c2cf86674 fix ApiRepository#apply 2017-04-30 16:33:49 +09:00
Naoki Takezoe
0db4cd35f1 Merge remote-tracking branch 'origin/master' 2017-04-30 13:27:28 +09:00
Naoki Takezoe
289c38edeb Update document 2017-04-30 13:27:12 +09:00
Naoki Takezoe
650e9f0d0b Drop sbt launcher 2017-04-30 13:23:59 +09:00
Takuma Tsutsumi
755419fd56 Merge branch 'master' into pr/disabling-server-header 2017-04-30 01:40:51 +09:00
Naoki Takezoe
458f1521b6 Merge pull request #1563 from t-tsutsumi/pr/fix-graceful-shutdown
Graceful shutdown on Jetty requires StatisticsHandler
2017-04-30 01:37:32 +09:00
Naoki Takezoe
18fa77a25c Fixup 2017-04-30 00:27:24 +09:00
hrj
db0b1d28bc Merge remote-tracking branch 'origin/master' into safeOpt 2017-04-29 17:46:14 +05:30
t-tsutsumi
518861ac0f Disabling Server header on Jetty 2017-04-29 20:54:36 +09:00
t-tsutsumi
fbb4f33b18 Graceful shutdown on Jetty requires StatisticsHandler 2017-04-29 20:31:04 +09:00
Naoki Takezoe
dc2cf05e8b Update docs 2017-04-29 09:39:20 +09:00
Naoki Takezoe
df4b1d6f01 Merge remote-tracking branch 'origin/master' 2017-04-29 09:25:42 +09:00
Naoki Takezoe
c5a53f0719 Release 4.12 2017-04-29 09:25:14 +09:00
Naoki Takezoe
961e21e5a7 Merge pull request #1562 from tkgdsg/filter_branch
dropdown menu filter method modified
2017-04-29 02:15:53 +09:00
Yasuhiro Takagi
e33e304644 dropdown menu filter method modified
intermediate match & case insensitive not using regexp
2017-04-28 21:05:44 +09:00
Naoki Takezoe
46896da46e Fix to avoid regular expression error in the filter box 2017-04-28 08:26:50 +09:00
Naoki Takezoe
207aa8b8c1 Merge pull request #1555 from tkgdsg/dropdown_menu_filter_in_compare
dropdown menu filter in branch compare page
2017-04-27 10:06:19 +09:00
Yasuhiro Takagi
8b4017a082 dropdown menu filter in compare page
filter applied "base fork:" "base:" "head fork:" "compare:" menus.
2017-04-26 21:22:46 +09:00
Naoki Takezoe
f46f5909f1 (refs #1554)Enable DB session for plugin git repo authentication 2017-04-25 13:53:50 +09:00
Naoki Takezoe
5337b29532 Disable dock icon 2017-04-25 09:41:42 +09:00
Naoki Takezoe
7010b316fd (refs #1551)Fix validation for repository name 2017-04-25 09:32:13 +09:00
Naoki Takezoe
6128258cfb Bump to 4.12.0 2017-04-23 23:32:24 +09:00
KOUNOIKE Yuusuke
68d090f81a Show CommitStatus in commits page. 2017-04-22 21:17:37 +09:00
Yuusuke KOUNOIKE
7ef74ac3ee Merge branch 'master' into pr-add-release 2017-04-22 19:46:22 +09:00
KOUNOIKE Yuusuke
5853691844 care db entry for delete/rename/transfer repo and delete dir when delete repo. 2017-04-22 10:49:28 +09:00
KOUNOIKE Yuusuke
3a8b93d44a Delete asset entry and files. 2017-04-22 10:33:30 +09:00
KOUNOIKE Yuusuke
806a5aecef fix delete release action. 2017-04-22 09:23:43 +09:00
KOUNOIKE Yuusuke
44d2918dee error-title to error-name. 2017-04-22 09:19:43 +09:00
KOUNOIKE Yuusuke
64f7db6585 change repository-wide release Id numbering to system-wide numbering. 2017-04-22 09:19:20 +09:00
KOUNOIKE Yuusuke
fb0cd272ce change to col-md-12 https://github.com/gitbucket/gitbucket/pull/1543#discussion_r112392040 2017-04-22 08:55:15 +09:00
Naoki Takezoe
83e619ecd4 Merge pull request #1550 from tkgdsg/branch_filter_improve
modify branch filter method
2017-04-21 10:07:46 +09:00
YT
3af89a7897 modify branch filter method 2017-04-20 20:26:45 +09:00
Naoki Takezoe
1e94b69a68 Merge pull request #1548 from kounoike/pr-fix-1525
Fix #1525 move attached directory when rename/transfer repo.
2017-04-20 11:21:33 +09:00
Naoki Takezoe
95b1945bc1 Merge pull request #1547 from tkgdsg/archive_root_dir
root dir in archive file
2017-04-20 11:20:59 +09:00
Naoki Takezoe
8aaba606bc Merge pull request #1545 from motohacy/master
dropdown-menu become scrollable
2017-04-20 11:18:59 +09:00
Naoki Takezoe
f40657a7ff Merge pull request #1546 from xuwei-k/Scala-2.12.2
Scala 2.12.2
2017-04-20 11:15:45 +09:00
KOUNOIKE Yuusuke
239c7371a8 Add moveDirectory for releases directory. 2017-04-19 21:13:43 +09:00
KOUNOIKE Yuusuke
788e56d926 Fix #1525 move attached directory when rename/transfer repo. 2017-04-19 20:46:52 +09:00
YT
37303a8c5a make dir in archive 2017-04-19 20:19:03 +09:00
KOUNOIKE Yuusuke
981b228a88 Add RELEASE_ASSET_ID 2017-04-19 19:59:51 +09:00
xuwei-k
c6449d4c10 Scala 2.12.2 2017-04-19 10:30:11 +02:00
KOUNOIKE Yuusuke
0f70e5b1d6 Change release files direcoty to releaseId from tagname. 2017-04-18 23:04:56 +09:00
Naoki Takezoe
9c078971ab Don't retrieve unused repository information when withoutPhysicalInfo is true 2017-04-18 18:42:56 +09:00
motohacy
0f0c3c1b1d dropdown-menu become scrollable
dropdown-menu become scrollable.
2017-04-18 17:24:07 +09:00
Naoki Takezoe
835f35393e Don't retrieve unused repository information when withoutPhysicalInfo is true 2017-04-18 11:31:03 +09:00
KOUNOIKE Yuusuke
fd30facd8f Add Release page. (close #607) 2017-04-16 21:27:53 +09:00
adrian
72c79542b7 update solidbase and mockito again 2017-04-16 09:53:12 +02:00
Naoki Takezoe
e576e14460 Update database configuration warning message 2017-04-16 15:30:29 +09:00
Naoki Takezoe
a839e9eab5 Merge pull request #1518 from kounoike/pr-caution-for-h2
Add caution message when using H2 database
2017-04-16 14:54:29 +09:00
Naoki Takezoe
e7b368ced2 Merge pull request #1537 from tkgdsg/archivefile_naming_rule_when_sha1
To have compatibility with GitHub/GitHubEnterprise
2017-04-16 14:53:22 +09:00
Naoki Takezoe
d662df5a7d Merge pull request #1542 from dbronecki/fix/1539
Word wrap commit descriptions
2017-04-16 14:36:38 +09:00
Damian Bronecki
7c4a286937 Fixes #1539 2017-04-15 23:20:57 +02:00
Naoki Takezoe
2164b8ce31 Merge pull request #1534 from aadrian/patch-1
improve workding
2017-04-14 10:16:31 +09:00
Naoki Takezoe
71737eb018 Merge pull request #1540 from dbronecki/fix-1481
Fixes #1481
2017-04-14 08:28:54 +09:00
Damian Bronecki
ed543847a8 Fixes #1481 2017-04-13 20:43:20 +02:00
Yasuhiro Takagi
c0320d3139 I refactor some code. 2017-04-11 22:41:55 +09:00
Yasuhiro Takagi
b218c2284e To have compatibility with GitHub/GitHubEnterprise
when archive downloading with sha1, even if supplied part of sha1,
GH/GHE gives a filename with full(long) sha1.

This patch make GitBucket to be compatible with GH/GHE behaviour.

You can check that difference by following url.
I upload same repo as in GitHuB to GitBucket demo site.
 
GitHub:  
https://github.com/MunGell/awesome-for-beginners/archive/fc7d067.tar.gz
GitBucket:
http://gitbucket.herokuapp.com/root/awesome-for-beginners/archive/fc7d067.tar.gz

GH returns,
awesome-for-beginners-fc7d067cb13559f248bb362253ff2fa3b2617aba.tar.gz
Otherwise GitBucket returns,
awesome-for-beginners-fc7d067.tar.gz
2017-04-10 21:21:47 +09:00
aadrian
fce8cbdaef improve workding 2017-04-09 18:55:02 +02:00
Naoki Takezoe
f40bdb6494 Update issues guideline 2017-04-10 01:17:43 +09:00
Naoki Takezoe
74e940ea3c Update support policy 2017-04-10 01:13:28 +09:00
Naoki Takezoe
650aff5649 (refs #1383)Add demo site information 2017-04-10 01:08:58 +09:00
Naoki Takezoe
9793bfc074 Remove plugins outside the gitbucket organization 2017-04-10 00:54:43 +09:00
Naoki Takezoe
0cba10994b Merge pull request #1532 from aadrian/wording
Wording improvements.
2017-04-10 00:19:05 +09:00
adrian
ff7b0ca13f add graph sbt-plug-in to better visualize dependencies.
(cherry picked from commit 4718381d7f)
2017-04-09 15:40:36 +02:00
adrian
18b39fb868 update some dependencies
(cherry picked from commit 60cf09b313)
2017-04-09 15:24:24 +02:00
adrian
b181aeb5ab remove launcher, since a working SBT version is a prerequisite for most projects.
(cherry picked from commit 3fb420e000)
2017-04-09 15:23:32 +02:00
adrian
9df2c221df improve wording.
(cherry picked from commit a184767d9c)
2017-04-09 15:19:29 +02:00
adrian
e3c6621398 improve wording.
(cherry picked from commit ce7d7340f7)
2017-04-09 15:18:54 +02:00
Naoki Takezoe
b736f904e9 (refs #1333)Bump to JGit 4.7.0 2017-04-09 21:43:58 +09:00
Naoki Takezoe
00093728ee Merge pull request #1530 from tkgdsg/modify_slash_escape_to_hyphen
archive naming rule modification to have comatibility with GitHub/GitHubEnerprise.
2017-04-09 20:11:26 +09:00
Yasuhiro Takagi
34c1fce8a2 To have comatibility with GitHub/GitHubEnerprise.
When downloding archive file,
GH/GHE use "-" as escape character for "/" in brach name.
2017-04-09 16:57:52 +09:00
kenji yoshida
6a520061cf s/2.11/2.12 2017-04-06 07:10:35 +09:00
Naoki Takezoe
c581d9e6b9 Remove unused import statement 2017-04-05 01:48:36 +09:00
Naoki Takezoe
956af54d4f Remove outdated TODO 2017-04-05 01:48:24 +09:00
Naoki Takezoe
d5a0ade5d9 Merge remote-tracking branch 'origin/master' 2017-04-05 01:47:07 +09:00
Naoki Takezoe
68c2f832ac (refs #1523)Eliminate CR and LF in public key 2017-04-05 01:46:57 +09:00
Naoki Takezoe
614bba4a0f Merge pull request #1520 from xuwei-k/refactoring
some refactoring
2017-04-02 16:36:07 +09:00
Naoki Takezoe
fde075f067 Merge pull request #1521 from xuwei-k/test-MySQL-version
update MySQL v5_7_latest in test
2017-04-02 16:35:15 +09:00
Naoki Takezoe
ea6bc9ccf0 Merge pull request #1522 from xuwei-k/Class-newInstance-deprecated
s/newInstance()/getDeclaredConstructor().newInstance()
2017-04-02 16:35:04 +09:00
Naoki Takezoe
b99c1c3f6e Merge pull request #1517 from kounoike/pr-fix-1516
Fix #1516 send noimage.png if user is removed.
2017-04-02 16:34:42 +09:00
xuwei-k
1e715d8b06 s/newInstance()/getDeclaredConstructor().newInstance()
java.lang.Class#newInstance deprecated since Java 9

http://download.java.net/java/jdk9/docs/api/java/lang/Class.html#newInstance--
2017-04-02 16:07:23 +09:00
xuwei-k
2a3e4af082 update MySQL v5_7_latest in test
v5_7_10 does not work Sierra

https://github.com/wix/wix-embedded-mysql/blob/wix-embedded-mysql-2.1.4/src/main/java/com/wix/mysql/distribution/Version.java#L86
2017-04-02 15:58:43 +09:00
xuwei-k
968c45c77d use "exists" instead of "find().isEmpty" 2017-04-02 15:49:10 +09:00
xuwei-k
ee8be37f55 use "contains" instead of "find().isEmpty" 2017-04-02 15:48:46 +09:00
xuwei-k
2d9727a695 use "contains" instead of "find().isDefined" 2017-04-02 15:43:24 +09:00
xuwei-k
0aa6e674e9 use exists instead of "filter().nonEmpty" 2017-04-02 15:42:22 +09:00
xuwei-k
445bf1cc34 remove return 2017-04-02 15:42:22 +09:00
xuwei-k
cfae6d76b2 use count instead of "filter().length" 2017-04-02 15:42:22 +09:00
KOUNOIKE Yuusuke
83a27809ef remove .get 2017-04-02 15:42:21 +09:00
xuwei-k
5eb41d5b25 use "Map#getOrElse" instead of "get().getOrElse" 2017-04-02 15:28:44 +09:00
xuwei-k
fe5961c59e use switch 2017-04-02 15:28:44 +09:00
xuwei-k
114c50a354 use "contains(key)" instead of "exists(_ == key)" 2017-04-02 15:28:44 +09:00
xuwei-k
56a39775e8 use "forall" instead of "filterNot().isEmpty" 2017-04-02 15:17:21 +09:00
KOUNOIKE Yuusuke
d0fa4da45a Remove message on sign-in dialog. and change message in System settings. 2017-04-02 15:11:38 +09:00
KOUNOIKE Yuusuke
dcd4c55fb9 Add caution message in System settings. 2017-04-01 21:42:30 +09:00
KOUNOIKE Yuusuke
a7920a7dd7 When using H2, caution message shows at sign-in. 2017-04-01 21:42:30 +09:00
KOUNOIKE Yuusuke
3bb32f11d7 Fix #1516 send noimage.png when user is not exist or removed. 2017-04-01 21:26:32 +09:00
Naoki Takezoe
0a08879d8c 4.11 release 2017-04-01 02:48:40 +09:00
hrj
5cb644279c Enable safe optimisations in scalac 2017-03-29 10:57:58 +05:30
Naoki Takezoe
c0e04ab0dc (refs #1511)Fix bug in updating group information 2017-03-27 20:52:21 +09:00
Naoki Takezoe
977e8e2472 Merge pull request #1509 from shiena/fix-broken-diffstat-layout
Fix broken diffstat layout at zoom in/out
2017-03-23 23:32:19 +09:00
Mitsuhiro Koga
9ba43071de Delete duplicate css style 2017-03-23 21:39:10 +09:00
Mitsuhiro Koga
37f940350f Fix broken diffstat layout at zoom in/out 2017-03-23 21:37:52 +09:00
Naoki Takezoe
f3271846ea Merge branch 'master' into feature/plugin-hotdeploy 2017-03-23 20:45:52 +09:00
Naoki Takezoe
d39d6691e6 Added Plugin.uninstall() method to cleanup, but remove for now 2017-03-23 20:39:33 +09:00
Naoki Takezoe
832b33f949 Fix error message 2017-03-23 20:07:33 +09:00
Naoki Takezoe
1373a93c75 Check plugin duplication 2017-03-23 20:06:07 +09:00
Naoki Takezoe
b65f7d9423 Merge pull request #1497 from kounoike/pr-textavatar
Add support auto-generated icon for default avatar.
2017-03-23 19:37:13 +09:00
Naoki Takezoe
b91263ffb3 Merge pull request #1506 from shiena/view-recursive-diffstat
Diffstat displays only top-level files in the first commit.
2017-03-19 13:18:09 +09:00
KOUNOIKE Yuusuke
d27b9222ba Different style of avatar for groups. 2017-03-19 02:14:26 +09:00
Mitsuhiro Koga
c41c15dbc1 Display the recursive diffstat on the first commit. 2017-03-19 02:14:12 +09:00
Naoki Takezoe
25b4b90633 Merge pull request #1504 from uli-heller/jgit-4.6.1.201703071140-r
Upgraded to jgit-4.6.1.201703071140-r
2017-03-18 21:46:41 +09:00
Naoki Takezoe
cdea9475c1 Merge pull request #1505 from shiena/fix-align-diffstat
fix to align diffstat positions (refs #1503)
2017-03-18 21:39:59 +09:00
Mitsuhiro Koga
a76d14d81f fix to align diffstat positions 2017-03-18 18:54:53 +09:00
Uli Heller
81b7c142d8 Upgraded to jgit-4.6.1.201703071140-r 2017-03-18 08:21:57 +01:00
KOUNOIKE Yuusuke
4d0e0b7bd2 Change TextAvatarService to TextAvatarUtil, color detection algorithm, Add fallback to username feature when FullName can't draw by default font. 2017-03-18 10:40:48 +09:00
Naoki Takezoe
4e3c88f1f4 Merge pull request #1501 from garbagetown/pr_add_permalink_to_issue_comment
add permalink to issue comments
2017-03-18 01:36:05 +09:00
Naoki Takezoe
f29c80acae Merge pull request #1500 from kounoike/fix-1366
fix CSS for PR comments layout (refs. #1366)
2017-03-18 01:18:49 +09:00
garbagetown
a2e150817c add permalink to issue comment 2017-03-18 01:06:52 +09:00
KOUNOIKE Yuusuke
e3aa9d739d fix #1366. 2017-03-18 00:45:28 +09:00
Naoki Takezoe
faa8f8aade (refs #1499)Allow guest users to read private repositories via HTTP 2017-03-17 21:44:18 +09:00
Naoki Takezoe
f165e89a8d (refs #1498) Fix record inserting and deletion of repository related tables 2017-03-17 21:38:21 +09:00
KOUNOIKE Yuusuke
620c3161cf Add support TextAvatar feature and _avatar returns it. 2017-03-16 23:50:46 +09:00
Naoki Takezoe
05739f60ce Update LICENSE 2017-03-15 07:21:16 +09:00
Naoki Takezoe
57e260df6d Merge pull request #1492 from xuwei-k/Java9
add Java 9 test
2017-03-14 13:18:42 +09:00
Naoki Takezoe
2cff3884e2 Remove copy buttons from the pull request merge guide to simplify 2017-03-14 12:51:30 +09:00
Naoki Takezoe
5ac01a0617 Add Scaladoc 2017-03-14 12:51:04 +09:00
xuwei-k
4344228b92 add Java 9 test 2017-03-14 12:49:25 +09:00
xuwei-k
8f91499132 use latest mockito
because does not work with Java 9
2017-03-14 12:48:54 +09:00
Naoki Takezoe
5b68ca1416 (refs #1491)Code format 2017-03-14 12:27:39 +09:00
Naoki Takezoe
2cb29654e9 (refs #1491)Note helper.assets as deprecated.
Use assets(path: String)(implicit context: Context) instead. It adds the hash value which is generated from bootstrap timestamp to the resource url automatically.
2017-03-14 10:07:16 +09:00
Naoki Takezoe
43aff74ad2 Merge pull request #1491 from kounoike/pr-cache-control
Add Cache-Control header for _avatar and /plugin-assets (refs #777)
2017-03-14 09:52:03 +09:00
KOUNOIKE Yuusuke
0d5964bd22 Merge remote-tracking branch 'origin/pr-cache-control' into pr-cache-control
# Conflicts:
#	src/test/scala/gitbucket/core/view/AvatarImageProviderSpec.scala
2017-03-14 07:38:45 +09:00
KOUNOIKE Yuusuke
8087531d64 fix test. 2017-03-14 07:36:07 +09:00
KOUNOIKE Yuusuke
c939456f21 fix test. 2017-03-14 07:18:16 +09:00
KOUNOIKE Yuusuke
1312276151 Add query parameter for cache control.
TODO: PluginAssetsServlet should add Last-Modified header instead of Cache-Control header.
2017-03-14 06:48:35 +09:00
KOUNOIKE Yuusuke
8fa3bf7850 Change from Cache-Control based control to Last-Modified based cache control for _avatar. 2017-03-14 06:08:03 +09:00
KOUNOIKE Yuusuke
cdc8431865 Add query parameter by updatedDate for _avatar image for cache control. 2017-03-14 05:36:02 +09:00
Naoki Takezoe
f4da49b5bd (#1490)Use java.util.Base64 instead of sun.misc or commons-codec 2017-03-14 02:17:34 +09:00
KOUNOIKE Yuusuke
3e4e278778 Add Cache-Control header for _avatar and /plugin-assets contents for reduce network connection and CPU usage. 2017-03-13 23:58:49 +09:00
Naoki Takezoe
7b8a5a482a (refs #1479)Url encode the branch name 2017-03-13 13:00:54 +09:00
Naoki Takezoe
0401488ab1 Fix styles 2017-03-13 13:00:06 +09:00
Naoki Takezoe
a024491296 Remove optimization option once 2017-03-13 11:24:02 +09:00
Naoki Takezoe
b2773ff5b7 Load plugin classes from the copied jar file 2017-03-12 02:32:21 +09:00
Naoki Takezoe
8ee017c3fa Add uninstall plugin button 2017-03-11 22:59:55 +09:00
KOUNOIKE Yuusuke
0eab5295db Fix test. 2017-03-11 20:31:59 +09:00
Naoki Takezoe
11fccf38a6 Automatic plugin reloading 2017-03-11 18:01:43 +09:00
KOUNOIKE Yuusuke
1d0180c436 Add account(group/user)'s webhooks feature. 2017-03-11 17:50:03 +09:00
Naoki Takezoe
7e7e45e794 Add the plugin reload button to the plugin list page 2017-03-11 12:13:59 +09:00
Naoki Takezoe
c760af7810 Add adapter filter for plugin controllers 2017-03-11 11:19:57 +09:00
Naoki Takezoe
a684fa8a8e Fixup 2017-03-10 10:03:33 +09:00
Naoki Takezoe
c5a5c737bf Introduce syntax suger to tuple extraction 2017-03-10 09:53:48 +09:00
Naoki Takezoe
dfe2e8dda5 (refs #1486)Remove reference to fonts.googleapis.com from AdminLTE 2017-03-10 03:16:40 +09:00
Naoki Takezoe
994d897b5b (refs #1485)Update scalac options to use "-opt:_" 2017-03-09 17:03:44 +09:00
Naoki Takezoe
ec66a79e2b Merge pull request #1480 from kounoike/pr-editorconfig
Add .editorconfig
2017-03-09 16:55:25 +09:00
Naoki Takezoe
d611aa8737 Merge pull request #1478 from kounoike/pr-compat-jenkins-github-scm-2.0
Improve GitHub API compatibility for Jenkins Integration.
2017-03-08 09:09:19 +09:00
KOUNOIKE Yuusuke
07bbbe8ad0 Add .editorconfig 2017-03-07 22:56:19 +09:00
KOUNOIKE Yuusuke
3d9e3d8456 Improve GitHub API compatibility for Jenkins Integration. 2017-03-07 19:48:48 +09:00
Naoki Takezoe
e56c7472c4 (refs #1477)Add RepositoryHook extension point
It makes possible to hook repository creation, deletion, renaming, transferring and forking by plug-ins.
2017-03-07 16:34:14 +09:00
Naoki Takezoe
0f8ee0d57d (refs #1475)Allow to create pull request by readable users 2017-03-06 16:18:06 +09:00
Naoki Takezoe
99f1a0b400 Bump markedj to 1.0.10 to fix a problem in emoji-plugin:
https://github.com/gitbucket/gitbucket-emoji-plugin/issues/2
2017-03-06 11:08:31 +09:00
Naoki Takezoe
c039b763c5 Merge pull request #1471 from gitbucket/feature/deploykeys
Deploy key support
2017-03-03 11:54:41 +09:00
Naoki Takezoe
bc69a67b05 (refs #474)Fix authorization for cloning repository
Allows cloning a repository for users who can read access to that repository.
2017-03-03 11:48:08 +09:00
Naoki Takezoe
37d2a38517 (refs #474)Add “Allow write access” flag 2017-03-03 11:13:30 +09:00
Naoki Takezoe
b5f287d75e (refs #474)Add authentication and authronization by deploy key 2017-03-03 10:47:21 +09:00
Naoki Takezoe
629aaa78d6 Code formatting 2017-03-02 18:15:39 +09:00
Naoki Takezoe
5a1ec385a8 (refs #474)Add controller to maintain deploy keys 2017-03-02 17:51:22 +09:00
Naoki Takezoe
42d3585df5 (refs #474)Define DB and models for deploy key support 2017-03-02 16:48:54 +09:00
Naoki Takezoe
b6390ac383 (refs #1470)Fix branch indicator 2017-03-02 16:31:23 +09:00
Naoki Takezoe
32c307b5a5 Bump to blocking-slick 0.0.8 2017-03-02 12:42:16 +09:00
Naoki Takezoe
b0056bc942 Merge pull request #1467 from McFoggy/issue-1466
add anchors in 'System Adminsitration > Plugins' page
2017-03-01 00:38:45 +09:00
Matthieu Brouillard
3fa6652415 add anchors in 'System Adminsitration > Plugins' page
fixes #1466
2017-02-28 14:30:17 +01:00
Naoki Takezoe
ae4da97ece (refs #1463)Copy collaborators form source repository for private fork 2017-02-26 15:07:19 +09:00
Naoki Takezoe
16f0b68490 (refs #1462)Rolled back a0c5414a93 2017-02-26 12:40:51 +09:00
Naoki Takezoe
a0c5414a93 (refs #1462)Fix permission checking 2017-02-26 12:09:40 +09:00
Naoki Takezoe
be3fc923fc Remove unnecessary file 2017-02-25 06:46:03 +09:00
Naoki Takezoe
684cd714e5 Update README.md 2017-02-25 06:19:47 +09:00
Naoki Takezoe
ea498f269e 4.10 release 2017-02-25 06:13:57 +09:00
Naoki Takezoe
98b6d16de7 (refs #1461)Fix mail link rendering in markdown 2017-02-24 01:17:13 +09:00
Naoki Takezoe
4bcfe837b1 (refs #1438) Fix repository viewer for annotated tag 2017-02-21 14:35:30 +09:00
Naoki Takezoe
5721cbf6f4 (refs #1390)Fix permission control in attachment to wiki page 2017-02-21 11:00:21 +09:00
Naoki Takezoe
200760cc56 Merge pull request #1459 from xuwei-k/mock-package-warning
fix deprecation warnings
2017-02-20 12:47:00 +09:00
Naoki Takezoe
28f77e7357 Merge pull request #1460 from xuwei-k/JsonParseException-warn
fix deprecation warning
2017-02-20 12:46:47 +09:00
xuwei-k
c0d9689022 fix deprecation warning
https://github.com/FasterXML/jackson-core/blob/jackson-core-2.8.4/src/main/java/com/fasterxml/jackson/core/JsonParseException.java#L31
2017-02-20 11:45:09 +09:00
xuwei-k
7f436831fe fix deprecation warnings
https://github.com/scalatest/scalatest/blob/release-3.0.0/scalatest/src/main/scala/org/scalatest/mock/package.scala#L38
2017-02-20 11:34:02 +09:00
Naoki Takezoe
96360f1266 Merge pull request #1458 from xuwei-k/remove-scala-java8-compat
remove scala-java8-compat
2017-02-20 11:26:33 +09:00
Naoki Takezoe
4eb31b9ecc Merge pull request #1457 from xuwei-k/Scala-2.12.1
Scala 2.12.1
2017-02-20 11:26:05 +09:00
kenji yoshida
1e24cc4daf remove scala-java8-compat
I have added this for new Java8 backend.
https://github.com/gitbucket/gitbucket/commit/2bcab3052964343a54d79357c04
I think no longer needed because githbucket updated Scala 2.12.
2017-02-20 10:56:18 +09:00
xuwei-k
cf64f9e64f Scala 2.12.1 2017-02-20 10:51:26 +09:00
Naoki Takezoe
a538d030e9 Shutdown ActorSystem which is used for Quartz scheduler in application destroying 2017-02-20 10:40:14 +09:00
Naoki Takezoe
b13e70e787 Merge remote-tracking branch 'origin/master' 2017-02-20 10:12:14 +09:00
Naoki Takezoe
aacfb091b2 Improve textarea resizing 2017-02-20 10:11:53 +09:00
Naoki Takezoe
768a3b1756 Improve textarea resizing 2017-02-20 10:11:26 +09:00
Naoki Takezoe
925408db31 Merge pull request #1381 from gitbucket/scala-2.12
Scala 2.12 support
2017-02-18 16:54:31 +09:00
Naoki Takezoe
31e0c6aa1d (refs #1431) Update default branch if repository is empty and pushed branch is not current default branch 2017-02-18 16:28:14 +09:00
Naoki Takezoe
4de80c3027 Merge pull request #1455 from JLofgren/1454-pr-text-fix
(refs #1454) Clarify text for PR permission settings
2017-02-18 15:07:11 +09:00
John Lofgren
2b986609bf (refs #1454) Clarify text for PR permission settings 2017-02-15 23:17:51 -05:00
Naoki Takezoe
43b932304d (refs #1426)Don't redirect non git clients to GitHub like repository URL 2017-02-16 03:01:33 +09:00
Naoki Takezoe
fcc015a0f8 Correct text 2017-02-16 02:44:32 +09:00
kenji yoshida
67eaf19add Fix typo 2017-02-15 22:07:30 +09:00
Naoki Takezoe
3008b51dbe (refs #1454)Fix typo 2017-02-15 22:00:51 +09:00
Naoki Takezoe
ee65ae3e49 Tweak directory processing 2017-02-14 16:57:51 +09:00
Naoki Takezoe
da64cf8800 Merge pull request #1453 from shiena/move_lfs_dir
Failure to clone LFS file when repository rename or transfer
2017-02-14 16:36:19 +09:00
Mitsuhiro Koga
ca0302723d Delete if parent folder is empty 2017-02-14 13:02:20 +09:00
Mitsuhiro Koga
026f5e2f26 Also move the LFS directory 2017-02-14 12:14:40 +09:00
Naoki Takezoe
ea4414f1a5 Bump blocking-slick to 0.0.7 2017-02-12 23:12:27 +09:00
Naoki Takezoe
53977bdf80 Merge pull request #1448 from peccu/patch-2
Add "owner" to notification subject
2017-02-12 20:50:00 +09:00
Naoki Takezoe
952d1954d9 Merge pull request #1452 from shiena/display-file-size
Display file size in file viewer
2017-02-12 20:48:43 +09:00
Mitsuhiro Koga
fbd34dc89f Apply label style to file size 2017-02-12 14:38:56 +09:00
Naoki Takezoe
79d41ba57b Bump blocking-slick 2017-02-12 11:37:04 +09:00
Mitsuhiro Koga
ab1adc48f8 Move readableSize to view helpers 2017-02-12 01:53:25 +09:00
Mitsuhiro Koga
422eda927e Display file size in file viewer 2017-02-11 23:51:37 +09:00
Mitsuhiro Koga
39e55bde2d Add file size to ContentInfo 2017-02-11 23:49:55 +09:00
Mitsuhiro Koga
6ec533990f Extract method to getLfsObjects 2017-02-11 23:47:14 +09:00
Naoki Takezoe
7a6a2471b1 Fix issues sorting 2017-02-10 01:55:34 +09:00
Naoki Takezoe
7d9f308492 Cleaned up code around webhook 2017-02-08 14:51:20 +09:00
Naoki Takezoe
e8888ac191 Fix import statements 2017-02-08 14:23:38 +09:00
Naoki Takezoe
afad27ee01 Bump to blocking-slick 0.0.6 2017-02-08 02:12:26 +09:00
peccu
1ed8e287b3 Add owner to notification subject 2017-02-07 13:39:53 +09:00
Naoki Takezoe
202f56b6a0 Bump blocking-slick 2017-02-06 14:25:25 +09:00
Naoki Takezoe
e72a192e4a Merge branch 'master'
Conflicts:
	build.sbt
	src/main/scala/gitbucket/core/model/CommitStatus.scala
	src/main/scala/gitbucket/core/service/CommitStatusService.scala
	src/main/scala/gitbucket/core/service/CommitsService.scala
	src/main/scala/gitbucket/core/service/IssuesService.scala
	src/main/scala/gitbucket/core/service/RepositoryService.scala
	src/main/scala/gitbucket/core/util/Notifier.scala
2017-02-06 10:32:29 +09:00
Naoki Takezoe
d3afb35fb0 Merge pull request #1445 from kounoike/pr-404
404 for non-implemented api
2017-02-06 09:34:50 +09:00
KOUNOIKE Yuusuke
306c9e45be return 404 for non-implemented api calls 2017-02-04 16:14:23 +09:00
Naoki Takezoe
fd8add4fcd (refs #1439)Fix pattern matching for assemble GitLFS URL 2017-02-01 08:03:02 +09:00
Naoki Takezoe
5a510d5703 (refs #1439)Fix path extraction for GitLFS 2017-02-01 07:13:58 +09:00
Naoki Takezoe
6c66fb130b Delete lfs directory when repository is deleted 2017-02-01 00:36:32 +09:00
Naoki Takezoe
7bb860dcd8 Update README.md 2017-01-29 12:33:21 +09:00
Naoki Takezoe
b64caa8f06 Update README.md 2017-01-29 02:43:52 +09:00
Naoki Takezoe
c7ece57842 (refs #1398)Fix commit layout overlapping again 2017-01-29 02:39:57 +09:00
Naoki Takezoe
161c5513df 4.9.0 release 2017-01-29 02:02:17 +09:00
Naoki Takezoe
538c1d7a9a Merge pull request #1436 from ritschwumm/patch-1
fix typo in log message
2017-01-29 01:46:02 +09:00
ritschwumm
123c17d442 fix typo in log message 2017-01-28 11:49:49 +01:00
Naoki Takezoe
6b7fd7fb7b (refs #499)Log authentication failure 2017-01-26 09:59:32 +09:00
Naoki Takezoe
0c0fde3077 Merge pull request #1434 from tomoki1207/login-failed-message
Show login failed message
2017-01-26 00:31:39 +09:00
tomoki1207
1cf6950e70 Show login failed message 2017-01-25 12:58:04 +09:00
Naoki Takezoe
5eddeba3ef Merge pull request #1432 from dariko/add_temp_dir_parameter
add temp_dir option
2017-01-24 14:01:46 +09:00
dariko
75f4903ffb --temp_dir parameter documentation 2017-01-23 12:48:57 +01:00
dariko
9727259d0c add temp_dir parameter 2017-01-22 10:21:56 +01:00
Naoki Takezoe
6bb664e592 Sort issue comments by commentId 2017-01-22 02:00:17 +09:00
Naoki Takezoe
f106dea3d9 Remove comment lines 2017-01-22 01:46:42 +09:00
Naoki Takezoe
982cc15052 (refs #1013)Create an upload directory if it doesn't exist 2017-01-19 15:56:20 +09:00
Naoki Takezoe
1ef3299574 Merge pull request #1428 from xuwei-k/value-class
use value class
2017-01-18 01:22:16 +09:00
xuwei-k
49f0795b5f use value class 2017-01-17 20:35:53 +09:00
Naoki Takezoe
af697d8155 Merge pull request #1013 from DrDub/master
Added automatic rescaling to avatar images (Fixes #835)
2017-01-16 20:15:16 +09:00
Naoki Takezoe
81a779d1d9 Merge pull request #1419 from tomoki1207/issue-pr-template
Issue and PR template per repository
2017-01-16 16:58:51 +09:00
Naoki Takezoe
7c484297d7 Merge pull request #1424 from team-lab/account-description
Account description
2017-01-16 13:17:04 +09:00
nazoking
a91e46f3e9 unite the first character of labels as uppercase. 2017-01-16 10:35:21 +09:00
Naoki Takezoe
5f18de06f5 Merge pull request #1425 from team-lab/fix-security-window-on-test
Prevents security warning dialog from being displayed during testing.
2017-01-16 09:47:32 +09:00
tomoki1207
bef5b5f22e Issue and PR template per repository 2017-01-16 09:41:09 +09:00
nazoking
092e832d21 Prevents security warning dialog from being displayed during testing. 2017-01-16 02:06:39 +09:00
nazoking
cd836f331e use description as bio in user account type 2017-01-16 01:37:19 +09:00
nazoking
53537eaa09 rewrite sql to LiquibaseMigration 2017-01-15 04:11:14 +09:00
nazoking
8515ef5b26 Merge branch 'master' into group-description 2017-01-15 04:01:54 +09:00
Naoki Takezoe
a2524608c7 (refs #1417)Use native hashchange event instead of jQuery plugin 2017-01-14 21:04:17 +09:00
Naoki Takezoe
127ddcef6d Merge pull request #1423 from xuwei-k/remove-unused-imports
remove unused imports
2017-01-14 02:25:03 +09:00
xuwei-k
076bc9e2d6 remove unused imports 2017-01-13 15:09:27 +09:00
Naoki Takezoe
d19b2778fe Merge pull request #1422 from xuwei-k/sbt-launcher-cache
cache sbt launcher
2017-01-13 14:23:30 +09:00
xuwei-k
4d947aef7b cache sbt launcher 2017-01-13 14:06:00 +09:00
Naoki Takezoe
1f3fc62a0e Merge pull request #1413 from bviktor/ssl-label
Fix erroneous label for definition, assumably caused by copy-paste
2017-01-13 11:36:47 +09:00
Naoki Takezoe
8b089837f9 Merge pull request #1420 from team-lab/bump-embedded-mysql
bump embedded-mysql for windows support
2017-01-13 11:35:26 +09:00
nazoking
4c4327b569 bump embedded-mysql for windows support 2017-01-13 01:55:24 +09:00
Naoki Takezoe
d72e9b2692 Fix GitHub spelling 2017-01-13 01:52:53 +09:00
Naoki Takezoe
e021868a96 (refs #1398)Fix commit layout overlapping 2017-01-12 10:08:57 +09:00
Naoki Takezoe
0c3cf5b140 Merge pull request #1415 from gitbucket/issue-1414
make it clear that issues must be closed via commit message, fix #1414
2017-01-12 01:21:13 +09:00
Naoki Takezoe
32bd52d74d Merge pull request #1412 from bviktor/smtp-starttls
Add support for SMTP STARTTLS
2017-01-12 00:53:16 +09:00
Matthieu Brouillard
55f52b7f78 make it clear that issues must be closed via commit message, fix #1414 2017-01-11 15:37:30 +01:00
Viktor Berke
4ef45d3987 Fix erroneous label for definition, assumably caused by copy-paste 2017-01-11 15:03:23 +01:00
Viktor Berke
ebc6121526 Add support for SMTP STARTTLS
Fixes #1410
2017-01-11 14:49:34 +01:00
Matthieu Brouillard
8a36acb673 Merge branch 'geek1011-master' 2017-01-10 10:10:12 +01:00
Patrick G
9efe438697 Spelling and grammar fixes 2017-01-10 10:05:34 +01:00
nazoking
4c7540451e fix format 2017-01-09 01:56:40 +09:00
Naoki Takezoe
cdeaede8bf Remove context.loginAccount.get in services 2017-01-08 21:49:05 +09:00
Naoki Takezoe
ad73e1d529 Fixup 2017-01-08 21:27:30 +09:00
Naoki Takezoe
68e858541d Fixup 2017-01-08 20:56:45 +09:00
Naoki Takezoe
709e423a6d Merge pull request #1408 from team-lab/feature-list-issues-for-a-repository-api
add api 'List issues for a repository'
2017-01-08 19:26:27 +09:00
nazoking
392139c061 add api 'List issues for a repository' 2017-01-08 05:21:06 +09:00
Naoki Takezoe
64db3e7842 Merge pull request #1404 from team-lab/feature-create-an-issue-api
add api 'create an issue'
2017-01-06 15:09:58 +09:00
Naoki Takezoe
14e8071713 Merge pull request #1407 from gitbucket/bugfix-clone-sql-timeout
(refs #1406)Don't begin database session in TransactionFilter for git…
2017-01-06 14:00:05 +09:00
Naoki Takezoe
cea09fa766 (refs #1406)Don't start database session in TransactionFilter for git access 2017-01-06 12:01:37 +09:00
Naoki Takezoe
019767e8c3 Update README.md 2017-01-06 10:16:08 +09:00
Naoki Takezoe
3c34689e7d Merge pull request #1401 from gitbucket/git-lfs-support
GitLFS support
2017-01-06 01:48:22 +09:00
nazoking
d3cca0685a (refs #1404) apply review 2017-01-05 20:14:05 +09:00
Naoki Takezoe
72049c5bdf (refs #1403)Bump bootstrap-datetimepicker and moment.js 2017-01-05 16:19:02 +09:00
Naoki Takezoe
d636413471 Merge pull request #1405 from gitbucket/sbt-coursier
Add sbt-coursier and enable travis cache
2017-01-05 15:15:44 +09:00
Naoki Takezoe
d1c6cbf55a Enable travis cache 2017-01-05 13:50:06 +09:00
Naoki Takezoe
e439a2f5f7 Add sbt-coursier 2017-01-05 11:46:29 +09:00
nazoking
ecde6aefbf add api 'create an issue' 2017-01-05 05:20:37 +09:00
Naoki Takezoe
b95d912542 (refs #1101)Fix variable names 2017-01-04 20:46:50 +09:00
Naoki Takezoe
eb50b74b4a (refs #1101)Store LFS files under GITBUCKET_HOME/repositories/<owner>/<name>/lfs 2017-01-04 20:31:22 +09:00
Naoki Takezoe
d460185317 (refs #1101)Authentication for Transfer API by one-time token 2017-01-04 16:12:44 +09:00
Naoki Takezoe
2297ef0bec Fix typo 2017-01-04 14:25:41 +09:00
Naoki Takezoe
8d7ec16ed0 (refs #1101)Remove debug code 2017-01-04 14:13:09 +09:00
Naoki Takezoe
4dfc9fc456 (refs #1101)No need transaction for /git-lfs 2017-01-04 07:47:23 +09:00
Naoki Takezoe
3b99e619db (refs #1101)Remove LFS setting 2017-01-04 07:34:04 +09:00
Naoki Takezoe
9cded1b4de (refs #1101)Add original GitLFS Transfer API implementation 2017-01-04 07:09:56 +09:00
Naoki Takezoe
bfc88a489a (refs #1101)Fix Batch API url mapping 2017-01-04 06:18:05 +09:00
Naoki Takezoe
f2a213f32a Merge pull request #1402 from team-lab/fix-1075-display-webhook-test-error
(refs #1075)show alert on webhook ajax error.
2017-01-04 05:32:48 +09:00
nazoking
9663d21ce8 (refs #1075)show alert on webhook ajax error. 2017-01-04 03:38:01 +09:00
Naoki Takezoe
30c8d3c39c (refs #1101)Fix testcase 2017-01-03 22:44:30 +09:00
Naoki Takezoe
88e72bee2c (refs #1101)Support LFS files in the blob view 2017-01-03 22:38:09 +09:00
Naoki Takezoe
c67441b6d4 (refs #1101)Add GitLFS setting 2017-01-03 13:40:35 +09:00
Naoki Takezoe
e1802978d3 (refs #1101)Experimental implementation of GitLFS Batch API 2017-01-03 03:09:50 +09:00
Naoki Takezoe
1ccdc79051 Set RevCommit as as archiving target instead of RevTree 2016-12-30 14:13:22 +09:00
Naoki Takezoe
3ca0d35a1b (refs #1399)Allow editing label color code 2016-12-30 14:04:53 +09:00
Naoki Takezoe
7bbeceec97 Merge pull request #1393 from xuwei-k/build-sbt-warning
avoid deprecated method since sbt 0.13.13
2016-12-29 23:23:23 +09:00
xuwei-k
1295e621ce avoid deprecated method since sbt 0.13.13
```
build.sbt:168: warning: `<<=` operator is deprecated. Use `key := { x.value }` or `key ~= (old => { newValue })`.
See http://www.scala-sbt.org/0.13/docs/Migrating-from-sbt-012x.html
publishTo <<= version { (v: String) =>
          ^
```
2016-12-29 14:43:48 +09:00
Naoki Takezoe
5f4580399b Update CONTRIBUTING.md 2016-12-29 02:53:36 +09:00
Naoki Takezoe
8d735205aa Merge pull request #1391 from uli-heller/jgit-4.6
Upgrade JGIT to jgit: 4.6.0.201612231935-r
2016-12-29 02:52:42 +09:00
Naoki Takezoe
64f15e015f Remove temporary directory for file downloading 2016-12-28 17:39:13 +09:00
Uli Heller
a95abf7397 Fixed deprecation warning: I decided to use exactRef although findRef might be a more appropriate replacement 2016-12-28 09:06:54 +01:00
Uli Heller
3054834b91 jgit: 4.6.0.201612231935-r 2016-12-28 08:44:13 +01:00
Naoki Takezoe
572ea5bf47 (refs #1379)Prepend "/" if specified prefix does not start with it 2016-12-28 12:11:43 +09:00
Naoki Takezoe
cad4d76138 Merge branch 'master'
Conflicts:
	build.sbt
	src/main/scala/gitbucket/core/service/CommitsService.scala
	src/main/scala/gitbucket/core/service/PullRequestService.scala
	src/main/scala/gitbucket/core/service/RepositoryService.scala
	src/main/scala/gitbucket/core/service/WebHookService.scala
2016-12-28 02:08:27 +09:00
Naoki Takezoe
892f2d5f41 (refs #1346)Fix tests 2016-12-28 01:45:23 +09:00
Naoki Takezoe
1e3bd9ebc0 (refs #1346)Fix warnings 2016-12-28 01:41:36 +09:00
Naoki Takezoe
e93e32b349 (refs #1346)Update libraries 2016-12-28 01:23:02 +09:00
Naoki Takezoe
9c9876c918 Merge pull request #1389 from uli-heller/patch-3
Update README.md - fixed another typo
2016-12-28 01:02:19 +09:00
Naoki Takezoe
8d30d68a4a Merge pull request #1388 from philippefichet/master
add support plugin when edit file on repository want preview instead …
2016-12-28 01:00:50 +09:00
uli-heller
88a8552d4d Update README.md - fixed another typo
...to the servlet container... -> ...to a servlet container...
2016-12-27 16:52:44 +01:00
Naoki Takezoe
7608a41f9c Fix typo 2016-12-27 20:32:34 +09:00
Naoki Takezoe
7f7c55aeee Update README.md 2016-12-27 20:13:18 +09:00
philippefichet
2ebed8ef94 add support plugin when edit file on repository want preview instead only markdown 2016-12-26 21:47:51 +01:00
Naoki Takezoe
2904bcf4a7 GitBucket 4.8 release 2016-12-23 18:07:15 +09:00
Naoki Takezoe
6630fa2f37 Fix file attachement bug 2016-12-22 15:49:15 +09:00
Naoki Takezoe
351e63e7b6 (refs #1386)Bump jQuery to 1.12.2 2016-12-22 14:24:16 +09:00
Naoki Takezoe
ea0f35a0a1 (refs #1375)Remove debug log 2016-12-19 19:39:20 +09:00
Naoki Takezoe
623c53e169 (refs #1375)Cache commit count 2016-12-19 19:38:07 +09:00
Naoki Takezoe
3e6fd2caf8 Merged branch master into master 2016-12-19 11:51:17 +09:00
Naoki Takezoe
39f1aa4487 (refs #1378)Don't apply text decorator plugins to formatted text 2016-12-19 11:51:02 +09:00
Naoki Takezoe
8ffd905a9f Merge pull request #1385 from kw-udon/single-issue-api
Add API to get a single issue
2016-12-19 10:58:28 +09:00
Keiichi Watanabe
668f9ef919 Fix content-type of get-contents API 2016-12-19 01:56:42 +09:00
Keiichi Watanabe
ffb9bb10f5 Add API to get a single issue
cf. https://developer.github.com/v3/issues/#get-a-single-issue
2016-12-19 01:42:13 +09:00
Naoki Takezoe
2618f54442 Add search form on issues and wiki 2016-12-19 00:09:16 +09:00
Naoki Takezoe
6b3218dd43 (refs #1370)Update search interface 2016-12-18 10:22:08 +09:00
Naoki Takezoe
56a9b7b0f1 (refs #1370)Search repository by name 2016-12-18 00:41:18 +09:00
Naoki Takezoe
4f4afc5686 Show the number of commits of selected branch 2016-12-17 20:22:30 +09:00
Naoki Takezoe
1d03e83d95 (refs #1346)Update to use blocking-slick for Scala 2.12 support 2016-12-14 12:36:27 +09:00
Naoki Takezoe
5698692b26 Merge branch 'slick-3.1-blocking'
Conflicts:
	build.sbt
2016-12-14 10:57:21 +09:00
Naoki Takezoe
87fb136b85 Merge pull request #1376 from gitbucket/cut-down-too-long-text
(refs #1282) Fix text-ellipsis which does't work
2016-12-14 09:46:57 +09:00
Naoki Takezoe
7af271e14a Format code 2016-12-12 22:54:43 +09:00
Naoki Takezoe
f44d44cb4a Merge pull request #1373 from gitbucket/keep_pull_request_comment
(refs #1348)Keep pull request comment if new commits are pushed
2016-12-12 22:36:42 +09:00
Shunsuke Tadokoro
e7fc5f1753 (refs #1282) Fix text-ellipsis which does't work 2016-12-12 21:25:45 +09:00
Naoki Takezoe
f0e2775861 (refs #1348)Show commentted filename, commit id and pull request id on the header 2016-12-12 17:50:59 +09:00
Naoki Takezoe
2488ab9bd4 Merge pull request #1374 from gitbucket/improve-search-peformance
Don't search for undisplayed tabs
2016-12-12 14:18:52 +09:00
Naoki Takezoe
f0872d410c Replace the search tabs with the select box 2016-12-12 13:59:01 +09:00
Naoki Takezoe
9d69cc9d45 Don't search for undisplayed tabs 2016-12-12 12:15:41 +09:00
Naoki Takezoe
1c66052372 (refs #1348)Keep comments on the old line 2016-12-12 01:30:10 +09:00
Naoki Takezoe
158f799ca1 (refs #1348)Improve efficiency of updating comment positions 2016-12-11 21:57:37 +09:00
Naoki Takezoe
907532fd13 (refs #1348)Clean up 2016-12-11 17:17:41 +09:00
Naoki Takezoe
0f6a433623 (refs #1348)Fix testcase 2016-12-11 16:49:47 +09:00
Naoki Takezoe
00eab5d584 (refs #1348)Keep pull request comment if new commits are pushed 2016-12-11 14:17:11 +09:00
Naoki Takezoe
5d928b1a62 Fix code format 2016-12-10 23:40:40 +09:00
Naoki Takezoe
50d6f0c96f Merge pull request #1371 from gitbucket/api_pull_request_model
(refs #1271)Add some properties to ApiPullRequest model
2016-12-10 12:24:40 +09:00
Naoki Takezoe
a60b43b862 (refs #1271)Fix testcase 2016-12-10 12:14:24 +09:00
Naoki Takezoe
4b1235b484 (refs #1271)Fixup 2016-12-10 11:25:16 +09:00
Naoki Takezoe
f354b9cfd7 (refs #1271)Add merged_by property 2016-12-10 02:25:39 +09:00
Naoki Takezoe
0c2283ce28 (refs #1271)Add some properties to ApiPullRequest model 2016-12-09 20:19:55 +09:00
Naoki Takezoe
840479a022 Merge pull request #1368 from tomoki1207/master
Fixed username suggestion on issue/PR.
2016-12-09 02:23:30 +09:00
Naoki Takezoe
1bceaaab1d (refs #1337)Fixup 2016-12-08 21:43:10 +09:00
Naoki Takezoe
65ece3292a (refs #1337)Use the specified port number as the SSL port number as well 2016-12-08 21:34:12 +09:00
Naoki Takezoe
e410623cac (refs #1367)Allow fast-forward push even if branch is protected 2016-12-08 21:06:18 +09:00
tomoki1207
09f7f036aa Fixed user name suggestion on issue/PR. 2016-12-06 18:58:02 +09:00
Naoki Takezoe
5249224dec Merge pull request #1365 from uli-heller/issue-1364-inconsistent-labels
Use lowercase for the first character of most 2nd words
2016-12-04 21:42:41 +09:00
Naoki Takezoe
00def3a46d (refs #1357)Fix error page 2016-12-04 13:28:26 +09:00
Uli Heller
134c0010b5 Use lowercase for the first character of most 2nd words
Unchanged: Mail Address, Full Name
2016-12-03 10:39:38 +01:00
Naoki Takezoe
fe3b40557a Tweak arguments of copy.scala.html 2016-12-01 14:58:30 +09:00
Naoki Takezoe
d3cdc5d5fc (refs #1359)Fix AdminLTE JavaScript importing 2016-12-01 09:27:20 +09:00
Naoki Takezoe
7ebb28be74 Remove ZeroClipboard 2016-12-01 02:07:24 +09:00
Naoki Takezoe
707cd3c5c3 Merge pull request #1359 from UprootStaging/adminlte-update
Updated admin lte to 2.3.8
2016-12-01 00:33:48 +09:00
Naoki Takezoe
4c5017d108 Merge pull request #1358 from tksugimoto/enable-copy-button-without-flash
Enable copy button without flash if JavaScript copy command is enable
2016-12-01 00:32:40 +09:00
hrj
fdd91b1e0e Updated admin lte to 2.3.8 2016-11-29 10:33:08 +05:30
Naoki Takezoe
9124777ce7 Merge pull request #1354 from mark-velez/fix-apostrophe-in-issue-text
Prevent LinkConverter matching escaped apostrophe (fixes #1148)
2016-11-28 18:41:53 +09:00
Takashi Sugimoto
64248d1fce Enable copy button without flash 2016-11-27 23:18:35 +09:00
Mark Velez
b5ca7ca0e1 Prevent LinkConverter matching escaped apostrophe (fixes #1148) 2016-11-26 02:17:51 -05:00
Naoki Takezoe
7fa921e7e5 Merge branch 'master' into slick-3.1-blocking
Conflicts:
	src/main/scala/gitbucket/core/service/IssuesService.scala
	src/main/scala/gitbucket/core/service/RepositoryService.scala
	src/main/scala/gitbucket/core/util/DatabaseConfig.scala
	src/test/scala/gitbucket/core/service/ServiceSpecBase.scala
2016-11-11 16:29:34 +09:00
Naoki Takezoe
47a55354fe (refs #1346) Update libraries for Scala 2.12 2016-11-11 11:53:53 +09:00
Pablo Duboue
c64428e37f Added automatic rescaling to avatar images (Fixes #835) 2016-11-03 13:28:21 -04:00
Naoki Takezoe
5a94125585 Merge branch 'master' into slick-3.1-blocking 2016-09-10 17:31:53 +09:00
Naoki Takezoe
34bcc85dcc Revert to Rep[U].run 2016-08-15 00:19:01 +09:00
Naoki Takezoe
2b5f74b9f3 Fix test case 2016-08-13 17:55:44 +09:00
Naoki Takezoe
c2538e772f Fix runtime error in issue sorting 2016-08-13 17:35:13 +09:00
Naoki Takezoe
f4a489f4e6 Bump blocking-slick to 0.0.2 2016-08-13 17:19:38 +09:00
Naoki Takezoe
6370a72d81 Fix test case 2016-08-13 13:58:09 +09:00
Naoki Takezoe
e612991424 Remove unused code 2016-08-13 13:40:13 +09:00
Naoki Takezoe
4bef6a4eeb Remove unused code 2016-08-13 13:32:49 +09:00
Naoki Takezoe
4eba7070da Use Rep[U].run method 2016-08-13 13:05:08 +09:00
Naoki Takezoe
161e6dc809 Use Slick2 compatible API 2016-08-13 11:46:41 +09:00
Naoki Takezoe
7937944c10 Move dataColumnType import statement to the top 2016-08-13 11:05:40 +09:00
Naoki Takezoe
89dfaeeb93 Turn to use returning instead of returningId 2016-08-13 04:31:22 +09:00
Naoki Takezoe
77641185af Fix all compilation error and it works! 2016-08-13 04:21:59 +09:00
Naoki Takezoe
4f78a3615c Fix for date columns 2016-08-13 03:35:44 +09:00
Naoki Takezoe
bfbf90158b Replace returning with returningId which is provided by blocking-slick 2016-08-12 20:51:59 +09:00
Naoki Takezoe
825b2f9ebf Experiment of blocking-slick 2016-08-12 15:31:38 +09:00
Roy Li
d6f8a45889 added helper case class for json body 2016-07-27 11:33:38 -07:00
Roy Li
3fdb444961 Added new API to handle file upload to repository 2016-07-27 11:23:29 -07:00
Boris Bera
82b056bd43 Group description now displayed on group page
It gets displayed instead of the account username
2015-07-04 15:04:15 -04:00
Boris Bera
4c417daee5 Group creation/edit froms now handle group description 2015-07-04 14:54:08 -04:00
Boris Bera
28c47dd9c7 AccountService.updateGroup now handles group description 2015-07-04 14:42:55 -04:00
Boris Bera
cd62220ba0 AccountService.createGroup now handles group description 2015-07-04 02:35:02 -04:00
Boris Bera
96e6aa89e3 Added group description field to account 2015-07-04 02:17:14 -04:00
491 changed files with 33799 additions and 25056 deletions

13
.editorconfig Normal file
View File

@@ -0,0 +1,13 @@
root = true
[*]
trim_trailing_whitespace = true
insert_final_newline = true
indent_style = space
indent_size = 2
[*.java]
trim_trailing_whitespace = true
insert_final_newline = true
indent_style = space
indent_size = 4

View File

@@ -1,7 +1,6 @@
# Guideline for Issues
# The guidelines for contributing
- At first, See [FAQ](https://github.com/gitbucket/gitbucket/wiki/FAQ) and check issues whether there is a same question or request in the past.
- If you can't find same question and report, send it to [gitter room](https://gitter.im/gitbucket/gitbucket) before raising an issue.
- We can also support in Japaneses other than English at [gitter room for Japanese](https://gitter.im/gitbucket/gitbucket_ja).
- Write an issue in English. At least, write subject in English.
- First priority of GitBucket is easy installation and reproduce GitHub behavior, so we might reject if your request is against it.
- At first, see [Wiki](https://github.com/gitbucket/gitbucket/wiki) and check issues and pull requests whether there is a same request in the past.
- The highest priority of GitBucket is the ease of installation and API compatibility with GitHub, so your feature request might be rejected if they go against those principles. If you don't wanna waste your time to make a pull request, ask us about your idea at [gitter room](https://gitter.im/gitbucket/gitbucket) before staring your work.
- You can edit the GitBucket documentation on Wiki if you have a GitHub account. When you find any mistakes or lacks in the documentation, please update it directly.
- All your contributions are handled as [Apache Software License, Version 2.0](https://github.com/gitbucket/gitbucket/blob/master/LICENSE). When you create a pull request or update the documentation, we assume you agreed this clause.

View File

@@ -1,4 +1,4 @@
### Before submitting an issue to Gitbucket I have first:
### Before submitting an issue to GitBucket I have first:
- [] read the [contribution guidelines](https://github.com/gitbucket/gitbucket/blob/master/.github/CONTRIBUTING.md)
- [] searched for similar already existing issue
@@ -9,11 +9,10 @@
## Issue
**Impacted version**: xxxx
**Deployment mode**: *explain here how you use gitbucket : standalone app, under webcontainer (which one), with an http frontend (nginx, httpd, ...)*
**Deployment mode**: *explain here how you use GitBucket : standalone app, under webcontainer (which one), with an http frontend (nginx, httpd, ...)*
**Problem description**:
- *be as explicit has you can*
- *describe the problem and its symptoms*
- *explain how to reproduce*
- *attach whatever information that can help understanding the context (screen capture, log files)*
- *do your best to use a correct english (re-read yourself)*

View File

@@ -1,8 +1,8 @@
### Before submitting a pull-request to Gitbucket I have first:
### Before submitting a pull-request to GitBucket I have first:
- [] read the [contribution guidelines](https://github.com/gitbucket/gitbucket/blob/master/.github/CONTRIBUTING.md)
- [] rebased my branch over master
- [] verified that project is compiling
- [] verified that tests are passing
- [] squashed my commits as appropriate *(keep several commits if it is relevant to understand the PR)*
- [] [marked as closed](https://help.github.com/articles/closing-issues-via-commit-messages/) all issue ID that this PR should correct
- [] [marked as closed using commit message](https://help.github.com/articles/closing-issues-via-commit-messages/) all issue ID that this PR should correct

5
.github/SUPPORT.md vendored Normal file
View File

@@ -0,0 +1,5 @@
# The support guidelines
- At first, see [Wiki](https://github.com/gitbucket/gitbucket/wiki) and check issues whether there is a same question or request in the past.
- If you can't find same question and report, send it to [gitter room](https://gitter.im/gitbucket/gitbucket) before raising an issue.
- Write issues in English if it's possible. It enables many of contributors to help you.

3
.gitignore vendored
View File

@@ -16,8 +16,11 @@ project/plugins/project/
.classpath
.project
.cache
.cache-main
.cache-tests
.settings
# IntelliJ specific
.idea/
.idea_modules/
*.iml

View File

@@ -1,11 +1,18 @@
language: scala
sudo: true
jdk:
- oraclejdk8
script:
- sbt test
jdk:
- oraclejdk8
before_script:
- sudo apt-get install libaio1
- sudo /etc/init.d/mysql stop
- sudo /etc/init.d/postgresql stop
- sudo chmod +x /usr/local/bin/sbt
cache:
directories:
- $HOME/.ivy2/cache
- $HOME/.sbt/boot
- $HOME/.sbt/launchers
- $HOME/.coursier
- $HOME/.embedmysql
- $HOME/.embedpostgresql

465
CHANGELOG.md Normal file
View File

@@ -0,0 +1,465 @@
# Changelog
All changes to the project will be documented in this file.
## 4.21.1 - 01 Jan 2018
- Release page
- OpenID Connect support
- New database viewer
- Submodule links to web page
- Clarify close/reopen button
## 4.20.0 - 23 Dec 2017
- Squash and rebase merge strategy for pull requests
- Quick pull request creation
- Download patch from the diff view
- Fork and create repository are proceeded asynchronously
- Create new repository by copying existing git repository
- Hide overflowed repository names in the sidebar
- Support CreateEvent web hook
- Display conflicting files if pull request can't be merged
## 4.19.3 - 7 Dec 2017
- Fix file uploading bug
- Fix reply comment form behavior in the diff view
## 4.19.2 - 3 Dec 2017
- Fix routing bug in `CompositeScalatraFilter`
- Resolve id attribute collision in the web hook editing form
## 4.19.1 - 2 Dec 2017
- Update gitbucket-notifications-plugin because it had a version compatibility issue
## 4.19.0 - 2 Dec 2017
- [gitbucket-maven-repository-plugin](https://github.com/takezoe/gitbucket-maven-repository-plugin) is available
- Upgrade to Scalatra 2.6
- Improve layout of the system settings page
- New extension point (`sshCommandProvider`)
- Dropped [gitbucket-pages-plugin](https://github.com/gitbucket/gitbucket-pages-plugin) from bundled plugins temporary because we couldn't complete update for Scalatra 2.6 before this release.
## 4.18.0 - 14 Oct 2017
- Form to reply to review comment
- Display fullname in username suggestion
- Commit hook plugins are applied to online editing
- Improve gitbucket-ci-plugin
## 4.17.0 - 30 Sep 2017
- [gitbucket-ci-plugin](https://github.com/takezoe/gitbucket-ci-plugin) is available
- Transferring to URL with commit ID
- Drop uploadable file type limitation
- Improve Mailer API
- Web API and webhook enhancement
## 4.16.0 - 2 Sep 2017
- Support AdminLTE color skin
- Improve unexpected error handling
- Show commit status on the commits list
## 4.15.0 - 5 Aug 2017
- Bundle GitBucket organization plugins
- Notifications plugin
- Plugin hot deployment
- Update Slick to 3.2.1 from 3.2.0
- Support ed25519 keys for SSH
- Markdown preview in comment editing forms
## 4.14.1 - 4 Jul 2017
- Bug fix: Possibility of error in forking repository
## 4.14 - 1 Jul 2017
- Support priority in issues and pull requests
- Show icons when the sidebar is collapsed
- Support gollum events in web hook
- Support account (user / group) level web hook
- Add `--max_file_size` option
- Configuration by system property or environment variable
## 4.13 - 29 May 2017
- Uploading files into the repository
- HTML is available in Markdown
- Added filter box to dropdown menus
## 4.12 - 30 Apr 2017
- [Gist plug-in](https://github.com/gitbucket/gitbucket-gist-plugin) provides JavaScript to embed snippet
- Dropdown menu filter in the branch comparing page
- Caution for the embedded H2 database
## 4.11 - 1 Apr 2017
- Deploy keys support
- Auto generate avatar images
- Collaborators of the private forked repository are copied from the original repository
- Cache avatar images in the browser
- New extension point to receive events about repository
## 4.10 - 25 Feb 2017
- Update to Scala 2.12, Scalatra 2.5 and Slick 3.2
- Display file size in the file viewer
## 4.9 - 29 Jan 2017
- GitLFS support
- Template for issues and pull requests
- Manual label color editing
- Account description
- `--tmp-dir` option for standalone mode
- More APIs for issues
- [List issues for a repository](https://developer.github.com/v3/issues/#list-issues-for-a-repository)
- [Create an issue](https://developer.github.com/v3/issues/#create-an-issue)
## 4.8 - 23 Dec 2016
- Search for repository names from the global header
- Filter repositories on the sidebar of the dashboard
- Search issues and wiki
- Keep pull request comments after new commits are pushed
- New web API to get a single issue
- Performance improvement for the repository viewer
## 4.7.1 - 28 Nov 2016
- Bug fix: group repositories are not shown in the your repositories list on the sidebar
- Small performance improvement of the dashboard
## 4.7 - 26 Nov 2016
- New permission system
- Dropdown filter for issue labels, milestones and assignees
- Keep sidebar folding status
- Link from milestone label to the issue list
## 4.6 - 29 Oct 2016
- Add disable option for forking
- Add History button to wiki page
- Git repository URL redirection for GitHub compatibility
- Get-Content API improvement
- Indicate who is group master in Members tab in group view
## 4.5 - 29 Sep 2016
- Attach files by dropping into textarea
- Issues / Pull requests switcher in dashboard
- HikariCP could be configured in `GITBUCKET_HOME/database.conf`
- Improve Cookie security
- Display commit count on the history button
- Improve mobile view
## 4.4 - 28 Aug 2016
- Import a SQL dump file to the database
- `go get` support in private repositories
- Sort milestones by due date
- apache-sshd has been updated to 1.2.0
## 4.3 - 30 Jul 2016
- Emoji support by [gitbucket-emoji-plugin](https://github.com/gitbucket/gitbucket-emoji-plugin)
- User name suggestion
- Add new web APIs and basic authentication support for API access
- Root Endpoint
- [List endpoints](https://developer.github.com/v3/#root-endpoint)
- [List Branches](https://developer.github.com/v3/repos/branches/#list-branches)
- [Get contents](https://developer.github.com/v3/repos/contents/#get-contents)
- [Get a Reference](https://developer.github.com/v3/git/refs/#get-a-reference)
- [List Collaborators](https://developer.github.com/v3/repos/collaborators/#list-collaborators)
- [List user repositories](https://developer.github.com/v3/repos/#list-user-repositories)
- [Get a group](https://developer.github.com/v3/orgs/#get-an-organization)
- [List group repositories](https://developer.github.com/v3/repos/#list-organization-repositories)
- Add new extension points
- `assetsMapping` : Supplies resources in plugin classpath as web assets
- `suggestionProvider` : Provides suggestion in the Markdown editing textarea
- `textDecorator` : Decorate text nodes in HTML which is converted from Markdown
## 4.2.1 - 3 Jul 2016
- Fix migration bug
This is hotfix for a critical bug in migration. If you are new installation, use 4.2.0. But if you have an exisiting installation and it had been updated to 4.0 from 3.x, you must update to 4.2.1.
## 4.2 - 2 Jul 2016
- New UI based on [AdminLTE](https://github.com/almasaeed2010/AdminLTE)
- git gc
- Issues and Wiki have been possible to be disabled
- SMTP configuration test mail
## 4.1 - 4 Jun 2016
- Generic ssh user
- Improve branch protection UI
- Default value of pull request title
## 4.0 - 30 Apr 2016
- MySQL and PostgreSQL support
- Data export and import
- Migration system has been switched to [solidbase](https://github.com/gitbucket/solidbase)
**Note:** You can upgrade to GitBucket 4.0 from 3.14. If your GitBucket is 3.13 or before, you have to upgrade 3.14 at first.
## 3.14 - 30 Apr 2016
- File attachment and search for wiki pages
- New extension points to add menus
- Content-Type of webhooks has been choosable
## 3.13 - 1 Apr 2016
- Refresh user interface for wide screen
- Add `pull_request` key in list issues API for pull requests
- Add `X-Hub-Signature` security to webhooks
- Provide SHA-256 checksum for `gitbucket.war`
## 3.12 - 27 Feb 2016
- New GitHub UI
- Improve mobile view
- Improve printing style
- Individual URL for pull request tabs
- SSH host configuration is separated from HTTP base URL
## 3.11 - 30 Jan 2016
- Upgrade Scalatra to 2.4
- Sidebar and Footer for Wiki
- Branch protection and receive hook extension point for plug-in
- Limit recent updated repositories list
- Issue actions look-alike GitHub
- Web API for labels
- Requires Java 8
## 3.10 - 30 Dec 2015
- Move to Bootstrap3
- New URL for raw contents (`raw/master/doc/activity.md` instead of `blob/master/doc/activity.md?raw=true`)
- Update xsbt-web-plugin
- Update H2 database
## 3.9 - 5 Dec 2015
- GFM inline breaks support in Markdown
- WebHook on create review comment is available
- WebHook event trigger is selectable
## 3.8 - 31 Oct 2015
- Moved to GitHub organization
- Omit diff view for large differences
- Repository creation API
- Render url as link in repository description
- Expand attachable file types
## 3.7 - 3 Oct 2015
- Markdown processor has been switched to [markedj](https://github.com/gitbucket/markedj) from pegdown
- Clone in desktop button
- Providing MD5 and SHA-1 checksum for `gitbucket.war` has started
## 3.6 - 30 Aug 2015
- User interface Improvements: Especially, commit list, issues and pull request have been updated largely.
- Installed plugins list has been available at the system administration console.
- Pages and repository list in the sidebar have been limited and more pages and repositories link is available.
- More reference link notation in Markdown has been supported.
## 3.5 - 1 Aug 2015
- Octicons has been applied
- Global header has been enhanced. Now it's further similar to GitHub.
- Default compare / pull request target has been changed to the parent repository
- A lot of updates for [gitbucket-gist-plugin](https://github.com/gitbucket/gitbucket-gist-plugin)
## 3.4 - 27 Jun 2015
- Declarative style plug-in definition
- New extension point to add markup render
- go-import support
## 3.3 - 31 May 2015
- Rich graphical diff for images
- File finder is available in the repository viewer
- Blame is displayed at the source viewer
- Remain user data and repositories even if user is disabled
- Mobile view improvement
## 3.2 - 3 May 2015
- Directory history button
- Compare / pull request button
- Limit of activity log
## 3.1.1 - 4 Apr 2015
- Rolled back H2 version to avoid version compatibility issue
- Plug-ins became possible to access ServletContext
## 3.1 - 28 Mar 2015
- Web APIs for Jenkins github pull-request builder
- Improved diff view
- Bump Scalatra to 2.3.1, sbt to 0.13.8
## 3.0 - 3 Mar 2015
- New plug-in system is available
- Connection pooling by c3p0
- New branch UI
- Compare between specified commit ids
## 2.8 - 1 Feb 2015
- New logo and icons
- New system setting options to control visibility
- Comment on side-by-side diff
- Information message on sign-in page
- Fork repository by group account
## 2.7 - 29 Dec 2014
- Comment for commit and diff
- Fix security issue in markdown rendering
- Some bug fix and improvements
## 2.6 - 24 Nov 2014
- Search box at issues and pull requests
- Information from administrator
- Pull request UI has been updated
- Move to TravisCI from Buildhive
- Some bug fix and improvements
## 2.5 - 4 Nov 2014
- New Dashboard
- Change datetime format
- Create branch from Web UI
- Task list in Markdown
- Some bug fix and improvements
## 2.4.1 - 6 Oct 2014
- Bug fix
## 2.4 - 6 Oct 2014
- New UI is applied to Issues and Pull requests
- Side-by-side diff is available
- Fix relative path problem in Markdown links and images
- Plugin System is disabled in default
- Some bug fix and improvements
## 2.3 - 1 Sep 2014
- Scala based plugin system
- Embedded Jetty war extraction directory moved to `GITBUCKET_HOME/tmp`
- Some bug fix and improvements
## 2.2.1 - 5 Aug 2014
- Bug fix
## 2.2 - 4 Aug 2014
- Plug-in system is available
- Move to Scala 2.11, Scalatra 2.3 and Slick 2.1
- tar.gz export for repository contents
- LDAP authentication improvement (mail address became optional)
- Show news feed of a private repository to members
- Some bug fix and improvements
## 2.1 - 6 Jul 2014
- Upgrade to Slick 2.0 from 1.9
- Base part of the plug-in system is merged
- Many bug fix and improvements
## 2.0 - 31 May 2014
- Modern Github UI
- Preview in AceEditor
- Select lines by clicking line number in blob view
## 1.13 - 29 Apr 2014
- Direct file editing in the repository viewer using AceEditor
- File attachment for issues
- Atom feed of user activity
- Fix some bugs
## 1.12 - 29 Mar 2014
- SSH repository access is available
- Allow users can create and management their groups
- Git submodule support
- Close issues via commit messages
- Show repository description below the name on repository page
- Fix presentation of the source viewer
- Upgrade to sbt 0.13
- Fix some bugs
## 1.11.1 - 06 Mar 2014
- Bug fix
## 1.11 - 01 Mar 2014
- Base URL for redirection, notification and repository URL box is configurable
- Remove ```--https``` option because it's possible to substitute in the base url
- Headline anchor is available for Markdown contents such as Wiki page
- Improve H2 connectivity
- Label is available for pull requests not only issues
- Delete branch button is added
- Repository icons are updated
- Select lines of source code by URL hash like `#L10` or `#L10-L15` in repository viewer
- Display reference to issue from others in comment list
- Fix some bugs
## 1.10 - 01 Feb 2014
- Rename repository
- Transfer repository owner
- Change default data directory to `HOME/.gitbucket` from `HOME/gitbucket` to avoid problem like #243, but if data directory already exist at HOME/gitbucket, it continues being used.
- Add LDAP display name attribute
- Response performance improvement
- Fix some bugs
## 1.9 - 28 Dec 2013
- Display GITBUCKET_HOME on the system settings page
- Fix some bugs
## 1.8 - 30 Nov 2013
- Add user and group deletion
- Improve pull request performance
- Pull request synchronization (when source repository is updated after pull request, it's applied to the pull request)
- LDAP StartTLS support
- Enable hard wrapping in Markdown
- Add new some options to specify the data directory. See details in [Wiki](https://github.com/takezoe/gitbucket/wiki/DirectoryStructure).
- Fix some bugs
## 1.7 - 26 Oct 2013
- Support working on Java6 in embedded Jetty mode
- Add `--host` option to bind specified host name in embedded Jetty mode
- Add `--https=true` option to force https scheme when using embedded Jetty mode at the back of https proxy
- Add full name as user property
- Change link color for absent Wiki pages
- Add ZIP download button to the repository viewer tab
- Improve ZIP exporting performance
- Expand issue and comment textarea for long text automatically
- Add conflict detection in Wiki
- Add reverting wiki page from history
- Match committer to user name by email address
- Mail notification sender is customizable
- Add link to changeset in refs comment for issues
- Fix some bugs
## 1.6 - 1 Oct 2013
- Web hook
- Performance improvement for pull request
- Executable war file
- Specify suitable Content-Type for downloaded files in the repository viewer
- Fix some bugs
## 1.5 - 4 Sep 2013
- Fork and pull request
- LDAP authentication
- Mail notification
- Add an option to turn off the gravatar support
- Add the branch tab in the repository viewer
- Encoding auto detection for the file content in the repository viewer
- Add favicon, header logo and icons for the timeline
- Specify data directory via environment variable GITBUCKET_HOME
- Fix some bugs
## 1.4 - 31 Jul 2013
- Group management
- Repository search for code and issues
- Display user related issues on the dashboard
- Display participants avatar of issues on the issue page
- Performance improvement for repository viewer
- Alert by milestone due date
- H2 database administration console
- Fix some bugs
## 1.3 - 18 Jul 2013
- Batch updating for issues
- Display assigned user on issue list
- User icon and Gravatar support
- Convert @xxxx to link to the account page
- Add copy to clipboard button for git clone URL
- Allow multi-byte characters as wiki page name
- Allow to create the empty repository
- Fix some bugs
## 1.2 - 09 Jul 2013
- Add activity timeline
- Bugfix for Git 1.8.1.5 or later
- Allow multi-byte characters as label
- Fix some bugs
## 1.1 - 05 Jul 2013
- Fix some bugs
- Upgrade to JGit 3.0
## 1.0 - 04 Jul 2013
- This is a first public release

View File

@@ -1,4 +1,3 @@
Apache License
Version 2.0, January 2004
http://www.apache.org/licenses/
@@ -179,7 +178,7 @@
APPENDIX: How to apply the Apache License to your work.
To apply the Apache License to your work, attach the following
boilerplate notice, with the fields enclosed by brackets "[]"
boilerplate notice, with the fields enclosed by brackets "{}"
replaced with your own identifying information. (Don't include
the brackets!) The text should be enclosed in the appropriate
comment syntax for the file format. We also recommend that a
@@ -187,7 +186,7 @@
same "printed page" as the copyright notice for easier
identification within third-party archives.
Copyright 2013-2016 GitBucket Team
Copyright {yyyy} {name of copyright owner}
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.

433
README.md
View File

@@ -1,413 +1,82 @@
GitBucket [![Gitter chat](https://badges.gitter.im/gitbucket/gitbucket.png)](https://gitter.im/gitbucket/gitbucket) [![Build Status](https://travis-ci.org/gitbucket/gitbucket.svg?branch=master)](https://travis-ci.org/gitbucket/gitbucket)
=========
GitBucket is a Git platform powered by Scala offering:
- easy installation
- high extensibility by plugins
- API compatibility with Github
GitBucket is a Git web platform powered by Scala offering:
- Easy installation
- Intuitive UI
- High extensibility by plugins
- API compatibility with GitHub
You can try an [online demo](https://gitbucket.herokuapp.com/) *(ID: root / Pass: root)* of GitBucket, and also get the latest information at [GitBucket News](https://gitbucket.github.io/gitbucket-news/).
Features
--------
The current version of GitBucket provides a basic features below:
The current version of GitBucket provides many features such as:
- Public / Private Git repository (http and ssh access)
- Repository viewer and online file editing
- Wiki
- Issues / Pull request
- Email notification
- Simple user and group management with LDAP integration
- Plug-in system
- Public / Private Git repositories (with http/https and ssh access)
- GitLFS support
- Repository viewer including an online file editor
- Issues, Pull Requests and Wiki for repositories
- Activity timeline and email notifications
- Account and group management with LDAP integration
- a Plug-in system
If you want to try the development version of GitBucket, see [Developer's Guide](https://github.com/gitbucket/gitbucket/blob/master/doc/how_to_run.md).
If you want to try the development version of GitBucket, see the [Developer's Guide](https://github.com/gitbucket/gitbucket/blob/master/doc/how_to_run.md).
Installation
--------
GitBucket requires **Java8**. You have to install beforehand when it's not installed.
GitBucket requires **Java8**. You have to install it, if it is not already installed.
1. Download latest **gitbucket.war** from [the release page](https://github.com/gitbucket/gitbucket/releases).
2. Deploy it to the Servlet 3.0 container such as Tomcat 7.x, Jetty 8.x, GlassFish 3.x or higher.
3. Access **http://[hostname]:[port]/gitbucket/** using your web browser and logged-in with **root** / **root**.
1. Download the latest **gitbucket.war** from [the releases page](https://github.com/gitbucket/gitbucket/releases) and run it by `java -jar gitbucket.war`.
2. Go to `http://[hostname]:8080/` and log in with ID: **root** / Pass: **root**.
or you can start GitBucket by `java -jar gitbucket.war` without servlet container. In this case, GitBucket URL is **http://[hostname]:8080/**. You can specify following options.
You can specify following options:
- --port=[NUMBER]
- --prefix=[CONTEXTPATH]
- --host=[HOSTNAME]
- --gitbucket.home=[DATA_DIR]
- `--port=[NUMBER]`
- `--prefix=[CONTEXTPATH]`
- `--host=[HOSTNAME]`
- `--gitbucket.home=[DATA_DIR]`
- `--temp_dir=[TEMP_DIR]`
- `--max_file_size=[MAX_FILE_SIZE]`
To upgrade GitBucket, only replace gitbucket.war after stop GitBucket. All GitBucket data is stored in HOME/.gitbucket. So if you want to back up GitBucket data, copy this directory to the other disk.
`TEMP_DIR` is used as the [temporary directory for the jetty application context](https://www.eclipse.org/jetty/documentation/9.3.x/ref-temporary-directories.html). This is the directory into which the `gitbucket.war` file is unpacked, the source files are compiled, etc. If given this parameter **must** match the path of an existing directory or the application will quit reporting an error; if not given the path used will be a `tmp` directory inside the gitbucket home.
About installation on Mac or Windows Server (with IIS), configuration of Apache or Nginx and also integration with other tools or services such as Jenkins or Slack, see [Wiki](https://github.com/gitbucket/gitbucket/wiki).
`MAX_FILE_SIZE` is the max file size for upload files.
Plug-ins
You can also deploy `gitbucket.war` to a servlet container which supports Servlet 3.0 (like Jetty, Tomcat, JBoss, etc)
For more information about installation on Mac or Windows Server (with IIS), or configuration of Apache or Nginx and also integration with other tools or services such as Jenkins or Slack, see [Wiki](https://github.com/gitbucket/gitbucket/wiki).
To upgrade GitBucket, replace `gitbucket.war` with the new version, after stopping GitBucket. All GitBucket data is stored in `HOME/.gitbucket` by default. So if you want to back up GitBucket's data, copy this directory to the backup location.
Plugins
--------
GitBucket has the plug-in system to extend GitBucket from outside of GitBucket. Some plug-ins are available now:
GitBucket has a plug-in system that allows extra functionality. Officially the following plug-ins are provided:
- [gitbucket-gist-plugin](https://github.com/gitbucket/gitbucket-gist-plugin)
- [gitbucket-announce-plugin](https://github.com/gitbucket-plugins/gitbucket-announce-plugin)
- [gitbucket-h2-backup-plugin](https://github.com/gitbucket-plugins/gitbucket-h2-backup-plugin)
- [gitbucket-desktopnotify-plugin](https://github.com/yoshiyoshifujii/gitbucket-desktopnotify-plugin)
- [gitbucket-commitgraphs-plugin](https://github.com/yoshiyoshifujii/gitbucket-commitgraphs-plugin)
- [gitbucket-asciidoctor-plugin](https://github.com/lefou/gitbucket-asciidoctor-plugin)
- [gitbucket-network-plugin](https://github.com/mrkm4ntr/gitbucket-network-plugin)
- [gitbucket-emoji-plugin](https://github.com/gitbucket/gitbucket-emoji-plugin)
- [gitbucket-pages-plugin](https://github.com/gitbucket/gitbucket-pages-plugin)
- [gitbucket-notifications-plugin](https://github.com/gitbucket/gitbucket-notifications-plugin)
You can find community plugins other than them at [gitbucket community plugins](http://gitbucket-plugins.github.io/).
You can find more plugins made by the community at [GitBucket community plugins](https://gitbucket-plugins.github.io/).
Support
--------
- If you have any question about GitBucket, send it to [gitter room](https://gitter.im/gitbucket/gitbucket) before raise an issue.
- Make sure check whether there is a same question or request in the past.
- When raise a new issue, write subject in **English** at least.
- We can also support in Japaneses other than English at [gitter room for Japanese](https://gitter.im/gitbucket/gitbucket_ja).
- First priority of GitBucket is easy installation and API compatibility with GitHub, so we might reject if your request is against it.
- If you have any questions about GitBucket, see [Wiki](https://github.com/gitbucket/gitbucket/wiki) and check issues whether there is a same question or request in the past.
- If you can't find same question and report, send it to [gitter room](https://gitter.im/gitbucket/gitbucket) before raising an issue.
- The highest priority of GitBucket is the ease of installation and API compatibility with GitHub, so your feature request might be rejected if they go against those principles.
Release Notes
What's New in 4.20.x
-------------
### 4.7.1 - 28 Nov 2016
- Bug fix: group repositories are not shown in the your repositories list on the sidebar
- Small performance improvement of the dashboard
### 4.7 - 26 Nov 2016
- New permission system
- Dropdown filter for issue labels, milestones and assignees
- Keep sidebar folding status
- Link from milestone label to the issue list
### 4.21.1 - 01 Jan 2018
### 4.6 - 29 Oct 2016
- Add disable option for forking
- Add History button to wiki page
- Git repository URL redirection for GitHub compatibility
- Get-Content API improvement
- Indicate who is group master in Members tab in group view
- Release page
- OpenID Connect support
- New database viewer
- Submodule links to web page
- Clarify close/reopen button
### 4.5 - 29 Sep 2016
- Attach files by dropping into textarea
- Issues / Pull requests switcher in dashboard
- HikariCP could be configured in `GITBUCKET_HOME/database.conf`
- Improve Cookie security
- Display commit count on the history button
- Improve mobile view
### 4.4 - 28 Aug 2016
- Import a SQL dump file to the database
- `go get` support in private repositories
- Sort milestones by due date
- apache-sshd has been updated to 1.2.0
### 4.3 - 30 Jul 2016
- Emoji support by [gitbucket-emoji-plugin](https://github.com/gitbucket/gitbucket-emoji-plugin)
- User name suggestion
- Add new web APIs and basic authentication support for API access
- Root Endpoint
- [List endpoints](https://developer.github.com/v3/#root-endpoint)
- [List Branches](https://developer.github.com/v3/repos/branches/#list-branches)
- [Get contents](https://developer.github.com/v3/repos/contents/#get-contents)
- [Get a Reference](https://developer.github.com/v3/git/refs/#get-a-reference)
- [List Collaborators](https://developer.github.com/v3/repos/collaborators/#list-collaborators)
- [List user repositories](https://developer.github.com/v3/repos/#list-user-repositories)
- [Get a group](https://developer.github.com/v3/orgs/#get-an-organization)
- [List group repositories](https://developer.github.com/v3/repos/#list-organization-repositories)
- Add new extension points
- `assetsMapping` : Supplies resources in plugin classpath as web assets
- `suggestionProvider` : Provides suggestion in the Markdown editing textarea
- `textDecorator` : Decorate text nodes in HTML which is converted from Markdown
### 4.2.1 - 3 Jul 2016
- Fix migration bug
This is hotfix for a critical bug in migration. If you are new installation, use 4.2.0. But if you have an exisiting installation and it had been updated to 4.0 from 3.x, you must update to 4.2.1.
### 4.2 - 2 Jul 2016
- New UI based on [AdminLTE](https://github.com/almasaeed2010/AdminLTE)
- git gc
- Issues and Wiki have been possible to be disabled
- SMTP configuration test mail
### 4.1 - 4 Jun 2016
- Generic ssh user
- Improve branch protection UI
- Default value of pull request title
### 4.0 - 30 Apr 2016
- MySQL and PostgreSQL support
- Data export and import
- Migration system has been switched to [solidbase](https://github.com/gitbucket/solidbase)
**Note:** You can upgrade to GitBucket 4.0 from 3.14. If your GitBucket is 3.13 or before, you have to upgrade 3.14 at first.
### 3.14 - 30 Apr 2016
- File attachment and search for wiki pages
- New extension points to add menus
- Content-Type of webhooks has been choosable
### 3.13 - 1 Apr 2016
- Refresh user interface for wide screen
- Add `pull_request` key in list issues API for pull requests
- Add `X-Hub-Signature` security to webhooks
- Provide SHA-256 checksum for `gitbucket.war`
### 3.12 - 27 Feb 2016
- New GitHub UI
- Improve mobile view
- Improve printing style
- Individual URL for pull request tabs
- SSH host configuration is separated from HTTP base URL
### 3.11 - 30 Jan 2016
- Upgrade Scalatra to 2.4
- Sidebar and Footer for Wiki
- Branch protection and receive hook extension point for plug-in
- Limit recent updated repositories list
- Issue actions look-alike GitHub
- Web API for labels
- Requires Java 8
### 3.10 - 30 Dec 2015
- Move to Bootstrap3
- New URL for raw contents (`raw/master/doc/activity.md` instead of `blob/master/doc/activity.md?raw=true`)
- Update xsbt-web-plugin
- Update H2 database
### 3.9 - 5 Dec 2015
- GFM inline breaks support in Markdown
- WebHook on create review comment is available
- WebHook event trigger is selectable
### 3.8 - 31 Oct 2015
- Moved to GitHub organization
- Omit diff view for large differences
- Repository creation API
- Render url as link in repository description
- Expand attachable file types
### 3.7 - 3 Oct 2015
- Markdown processor has been switched to [markedj](https://github.com/gitbucket/markedj) from pegdown
- Clone in desktop button
- Providing MD5 and SHA-1 checksum for `gitbucket.war` has started
### 3.6 - 30 Aug 2015
- User interface Improvements: Especially, commit list, issues and pull request have been updated largely.
- Installed plugins list has been available at the system administration console.
- Pages and repository list in the sidebar have been limited and more pages and repositories link is available.
- More reference link notation in Markdown has been supported.
### 3.5 - 1 Aug 2015
- Octicons has been applied
- Global header has been enhanced. Now it's further similar to GitHub.
- Default compare / pull request target has been changed to the parent repository
- A lot of updates for [gitbucket-gist-plugin](https://github.com/gitbucket/gitbucket-gist-plugin)
### 3.4 - 27 Jun 2015
- Declarative style plug-in definition
- New extension point to add markup render
- go-import support
### 3.3 - 31 May 2015
- Rich graphical diff for images
- File finder is available in the repository viewer
- Blame is displayed at the source viewer
- Remain user data and repositories even if user is disabled
- Mobile view improvement
### 3.2 - 3 May 2015
- Directory history button
- Compare / pull request button
- Limit of activity log
### 3.1.1 - 4 Apr 2015
- Rolled back H2 version to avoid version compatibility issue
- Plug-ins became possible to access ServletContext
### 3.1 - 28 Mar 2015
- Web APIs for Jenkins github pull-request builder
- Improved diff view
- Bump Scalatra to 2.3.1, sbt to 0.13.8
### 3.0 - 3 Mar 2015
- New plug-in system is available
- Connection pooling by c3p0
- New branch UI
- Compare between specified commit ids
### 2.8 - 1 Feb 2015
- New logo and icons
- New system setting options to control visibility
- Comment on side-by-side diff
- Information message on sign-in page
- Fork repository by group account
### 2.7 - 29 Dec 2014
- Comment for commit and diff
- Fix security issue in markdown rendering
- Some bug fix and improvements
### 2.6 - 24 Nov 2014
- Search box at issues and pull requests
- Information from administrator
- Pull request UI has been updated
- Move to TravisCI from Buildhive
- Some bug fix and improvements
### 2.5 - 4 Nov 2014
- New Dashboard
- Change datetime format
- Create branch from Web UI
- Task list in Markdown
- Some bug fix and improvements
### 2.4.1 - 6 Oct 2014
- Bug fix
### 2.4 - 6 Oct 2014
- New UI is applied to Issues and Pull requests
- Side-by-side diff is available
- Fix relative path problem in Markdown links and images
- Plugin System is disabled in default
- Some bug fix and improvements
### 2.3 - 1 Sep 2014
- Scala based plugin system
- Embedded Jetty war extraction directory moved to `GITBUCKET_HOME/tmp`
- Some bug fix and improvements
### 2.2.1 - 5 Aug 2014
- Bug fix
### 2.2 - 4 Aug 2014
- Plug-in system is available
- Move to Scala 2.11, Scalatra 2.3 and Slick 2.1
- tar.gz export for repository contents
- LDAP authentication improvement (mail address became optional)
- Show news feed of a private repository to members
- Some bug fix and improvements
### 2.1 - 6 Jul 2014
- Upgrade to Slick 2.0 from 1.9
- Base part of the plug-in system is merged
- Many bug fix and improvements
### 2.0 - 31 May 2014
- Modern Github UI
- Preview in AceEditor
- Select lines by clicking line number in blob view
### 1.13 - 29 Apr 2014
- Direct file editing in the repository viewer using AceEditor
- File attachment for issues
- Atom feed of user activity
- Fix some bugs
### 1.12 - 29 Mar 2014
- SSH repository access is available
- Allow users can create and management their groups
- Git submodule support
- Close issues via commit messages
- Show repository description below the name on repository page
- Fix presentation of the source viewer
- Upgrade to sbt 0.13
- Fix some bugs
### 1.11.1 - 06 Mar 2014
- Bug fix
### 1.11 - 01 Mar 2014
- Base URL for redirection, notification and repository URL box is configurable
- Remove ```--https``` option because it's possible to substitute in the base url
- Headline anchor is available for Markdown contents such as Wiki page
- Improve H2 connectivity
- Label is available for pull requests not only issues
- Delete branch button is added
- Repository icons are updated
- Select lines of source code by URL hash like `#L10` or `#L10-L15` in repository viewer
- Display reference to issue from others in comment list
- Fix some bugs
### 1.10 - 01 Feb 2014
- Rename repository
- Transfer repository owner
- Change default data directory to `HOME/.gitbucket` from `HOME/gitbucket` to avoid problem like #243, but if data directory already exist at HOME/gitbucket, it continues being used.
- Add LDAP display name attribute
- Response performance improvement
- Fix some bugs
### 1.9 - 28 Dec 2013
- Display GITBUCKET_HOME on the system settings page
- Fix some bugs
### 1.8 - 30 Nov 2013
- Add user and group deletion
- Improve pull request performance
- Pull request synchronization (when source repository is updated after pull request, it's applied to the pull request)
- LDAP StartTLS support
- Enable hard wrapping in Markdown
- Add new some options to specify the data directory. See details in [Wiki](https://github.com/takezoe/gitbucket/wiki/DirectoryStructure).
- Fix some bugs
### 1.7 - 26 Oct 2013
- Support working on Java6 in embedded Jetty mode
- Add `--host` option to bind specified host name in embedded Jetty mode
- Add `--https=true` option to force https scheme when using embedded Jetty mode at the back of https proxy
- Add full name as user property
- Change link color for absent Wiki pages
- Add ZIP download button to the repository viewer tab
- Improve ZIP exporting performance
- Expand issue and comment textarea for long text automatically
- Add conflict detection in Wiki
- Add reverting wiki page from history
- Match committer to user name by email address
- Mail notification sender is customizable
- Add link to changeset in refs comment for issues
- Fix some bugs
### 1.6 - 1 Oct 2013
- Web hook
- Performance improvement for pull request
- Executable war file
- Specify suitable Content-Type for downloaded files in the repository viewer
- Fix some bugs
### 1.5 - 4 Sep 2013
- Fork and pull request
- LDAP authentication
- Mail notification
- Add an option to turn off the gravatar support
- Add the branch tab in the repository viewer
- Encoding auto detection for the file content in the repository viewer
- Add favicon, header logo and icons for the timeline
- Specify data directory via environment variable GITBUCKET_HOME
- Fix some bugs
### 1.4 - 31 Jul 2013
- Group management
- Repository search for code and issues
- Display user related issues on the dashboard
- Display participants avatar of issues on the issue page
- Performance improvement for repository viewer
- Alert by milestone due date
- H2 database administration console
- Fix some bugs
### 1.3 - 18 Jul 2013
- Batch updating for issues
- Display assigned user on issue list
- User icon and Gravatar support
- Convert @xxxx to link to the account page
- Add copy to clipboard button for git clone URL
- Allow multi-byte characters as wiki page name
- Allow to create the empty repository
- Fix some bugs
### 1.2 - 09 Jul 2013
- Add activity timeline
- Bugfix for Git 1.8.1.5 or later
- Allow multi-byte characters as label
- Fix some bugs
### 1.1 - 05 Jul 2013
- Fix some bugs
- Upgrade to JGit 3.0
### 1.0 - 04 Jul 2013
- This is a first public release
See the [change log](CHANGELOG.md) for all of the updates.

148
build.sbt
View File

@@ -1,61 +1,74 @@
import com.typesafe.sbt.license.{DepModuleInfo, LicenseInfo}
import com.typesafe.sbt.pgp.PgpKeys._
val Organization = "io.github.gitbucket"
val Name = "gitbucket"
val GitBucketVersion = "4.7.1"
val ScalatraVersion = "2.4.1"
val JettyVersion = "9.3.9.v20160517"
val GitBucketVersion = "4.21.0"
val ScalatraVersion = "2.6.1"
val JettyVersion = "9.4.7.v20170914"
lazy val root = (project in file(".")).enablePlugins(SbtTwirl, JettyPlugin)
lazy val root = (project in file(".")).enablePlugins(SbtTwirl, ScalatraPlugin, JRebelPlugin).settings(
)
sourcesInBase := false
organization := Organization
name := Name
version := GitBucketVersion
scalaVersion := "2.11.8"
scalaVersion := "2.12.4"
// dependency settings
resolvers ++= Seq(
Classpaths.typesafeReleases,
Resolver.jcenterRepo,
"amateras" at "http://amateras.sourceforge.jp/mvn/",
"sonatype-snapshot" at "https://oss.sonatype.org/content/repositories/snapshots/",
"amateras-snapshot" at "http://amateras.sourceforge.jp/mvn-snapshot/"
)
libraryDependencies ++= Seq(
"org.scala-lang.modules" %% "scala-java8-compat" % "0.7.0",
"org.eclipse.jgit" % "org.eclipse.jgit.http.server" % "4.1.2.201602141800-r",
"org.eclipse.jgit" % "org.eclipse.jgit.archive" % "4.1.2.201602141800-r",
"org.scalatra" %% "scalatra" % ScalatraVersion,
"org.scalatra" %% "scalatra-json" % ScalatraVersion,
"org.json4s" %% "json4s-jackson" % "3.3.0",
"io.github.gitbucket" %% "scalatra-forms" % "1.0.0",
"commons-io" % "commons-io" % "2.4",
"io.github.gitbucket" % "solidbase" % "1.0.0",
"io.github.gitbucket" % "markedj" % "1.0.9",
"org.apache.commons" % "commons-compress" % "1.11",
"org.apache.commons" % "commons-email" % "1.4",
"org.apache.httpcomponents" % "httpclient" % "4.5.1",
"org.apache.sshd" % "apache-sshd" % "1.2.0",
"org.apache.tika" % "tika-core" % "1.13",
"com.typesafe.slick" %% "slick" % "2.1.0",
"com.novell.ldap" % "jldap" % "2009-10-07",
"com.h2database" % "h2" % "1.4.192",
"mysql" % "mysql-connector-java" % "5.1.39",
"org.postgresql" % "postgresql" % "9.4.1208",
"ch.qos.logback" % "logback-classic" % "1.1.7",
"com.zaxxer" % "HikariCP" % "2.4.6",
"com.typesafe" % "config" % "1.3.0",
"com.typesafe.akka" %% "akka-actor" % "2.3.15",
"fr.brouillard.oss.security.xhub" % "xhub4j-core" % "1.0.0",
"com.enragedginger" %% "akka-quartz-scheduler" % "1.4.0-akka-2.3.x" exclude("c3p0","c3p0"),
"org.eclipse.jetty" % "jetty-webapp" % JettyVersion % "provided",
"javax.servlet" % "javax.servlet-api" % "3.1.0" % "provided",
"junit" % "junit" % "4.12" % "test",
"org.scalatra" %% "scalatra-scalatest" % ScalatraVersion % "test",
"com.wix" % "wix-embedded-mysql" % "1.0.3" % "test",
"ru.yandex.qatools.embed" % "postgresql-embedded" % "1.14" % "test"
"org.eclipse.jgit" % "org.eclipse.jgit.http.server" % "4.9.2.201712150930-r",
"org.eclipse.jgit" % "org.eclipse.jgit.archive" % "4.9.2.201712150930-r",
"org.scalatra" %% "scalatra" % ScalatraVersion,
"org.scalatra" %% "scalatra-json" % ScalatraVersion,
"org.scalatra" %% "scalatra-forms" % ScalatraVersion,
"org.json4s" %% "json4s-jackson" % "3.5.3",
"commons-io" % "commons-io" % "2.6",
"io.github.gitbucket" % "solidbase" % "1.0.2",
"io.github.gitbucket" % "markedj" % "1.0.15",
"org.apache.commons" % "commons-compress" % "1.15",
"org.apache.commons" % "commons-email" % "1.5",
"org.apache.httpcomponents" % "httpclient" % "4.5.4",
"org.apache.sshd" % "apache-sshd" % "1.6.0" exclude("org.slf4j","slf4j-jdk14"),
"org.apache.tika" % "tika-core" % "1.17",
"com.github.takezoe" %% "blocking-slick-32" % "0.0.10",
"com.novell.ldap" % "jldap" % "2009-10-07",
"com.h2database" % "h2" % "1.4.196",
"org.mariadb.jdbc" % "mariadb-java-client" % "2.2.1",
"org.postgresql" % "postgresql" % "42.1.4",
"ch.qos.logback" % "logback-classic" % "1.2.3",
"com.zaxxer" % "HikariCP" % "2.7.4",
"com.typesafe" % "config" % "1.3.2",
"com.typesafe.akka" %% "akka-actor" % "2.5.8",
"fr.brouillard.oss.security.xhub" % "xhub4j-core" % "1.0.0",
"com.github.bkromhout" % "java-diff-utils" % "2.1.1",
"org.cache2k" % "cache2k-all" % "1.0.1.Final",
"com.enragedginger" %% "akka-quartz-scheduler" % "1.6.1-akka-2.5.x" exclude("c3p0","c3p0"),
"net.coobird" % "thumbnailator" % "0.4.8",
"com.github.zafarkhaja" % "java-semver" % "0.9.0",
"com.nimbusds" % "oauth2-oidc-sdk" % "5.45",
"org.eclipse.jetty" % "jetty-webapp" % JettyVersion % "provided",
"javax.servlet" % "javax.servlet-api" % "3.1.0" % "provided",
"junit" % "junit" % "4.12" % "test",
"org.scalatra" %% "scalatra-scalatest" % ScalatraVersion % "test",
"org.mockito" % "mockito-core" % "2.13.0" % "test",
"com.wix" % "wix-embedded-mysql" % "3.0.0" % "test",
"ru.yandex.qatools.embed" % "postgresql-embedded" % "2.6" % "test",
"net.i2p.crypto" % "eddsa" % "0.2.0",
"is.tagomor.woothee" % "woothee-java" % "1.7.0"
)
// Compiler settings
scalacOptions := Seq("-deprecation", "-language:postfixOps", "-Ybackend:GenBCode", "-Ydelambdafy:method", "-target:jvm-1.8")
scalacOptions := Seq("-deprecation", "-language:postfixOps", "-opt:l:method")
javacOptions in compile ++= Seq("-target", "8", "-source", "8")
javaOptions in Jetty += "-Dlogback.configurationFile=/logback-dev.xml"
@@ -80,17 +93,28 @@ assemblyMergeStrategy in assembly := {
}
// JRebel
Seq(jrebelSettings: _*)
//Seq(jrebelSettings: _*)
jrebel.webLinks += (target in webappPrepare).value
jrebel.enabled := System.getenv().get("JREBEL") != null
//jrebel.webLinks += (target in webappPrepare).value
//jrebel.enabled := System.getenv().get("JREBEL") != null
javaOptions in Jetty ++= Option(System.getenv().get("JREBEL")).toSeq.flatMap { path =>
Seq("-noverify", "-XX:+UseConcMarkSweepGC", "-XX:+CMSClassUnloadingEnabled", s"-javaagent:${path}")
if (path.endsWith(".jar")) {
// Legacy JRebel agent
Seq("-noverify", "-XX:+UseConcMarkSweepGC", "-XX:+CMSClassUnloadingEnabled", s"-javaagent:${path}")
} else {
// New JRebel agent
Seq(s"-agentpath:${path}")
}
}
// Exclude a war file from published artifacts
signedArtifacts := {
signedArtifacts.value.filterNot { case (_, file) => file.getName.endsWith(".war") || file.getName.endsWith(".war.asc") }
}
// Create executable war file
val executableConfig = config("executable").hide
Keys.ivyConfigurations += executableConfig
val ExecutableConfig = config("executable").hide
Keys.ivyConfigurations += ExecutableConfig
libraryDependencies ++= Seq(
"org.eclipse.jetty" % "jetty-security" % JettyVersion % "executable",
"org.eclipse.jetty" % "jetty-webapp" % JettyVersion % "executable",
@@ -105,8 +129,8 @@ libraryDependencies ++= Seq(
val executableKey = TaskKey[File]("executable")
executableKey := {
import java.util.jar.{ Manifest => JarManifest }
import java.util.jar.Attributes.{ Name => AttrName }
import java.util.jar.Attributes.{Name => AttrName}
import java.util.jar.{Manifest => JarManifest}
val workDir = Keys.target.value / "executable"
val warName = Keys.name.value + ".war"
@@ -119,7 +143,7 @@ executableKey := {
IO delete temp
// include jetty classes
val jettyJars = Keys.update.value select configurationFilter(name = executableConfig.name)
val jettyJars = Keys.update.value select configurationFilter(name = ExecutableConfig.name)
jettyJars foreach { jar =>
IO unzip (jar, temp, (name:String) =>
(name startsWith "javax/") ||
@@ -138,14 +162,25 @@ executableKey := {
IO copyFile (classDir / name, temp / name)
}
// include plugins
val pluginsDir = temp / "WEB-INF" / "classes" / "plugins"
IO createDirectory (pluginsDir)
IO copyFile(Keys.baseDirectory.value / "plugins.json", pluginsDir / "plugins.json")
val json = IO read(Keys.baseDirectory.value / "plugins.json")
PluginsJson.getUrls(json).foreach { url =>
log info s"Download: ${url}"
IO transfer(new java.net.URL(url).openStream, pluginsDir / url.substring(url.lastIndexOf("/") + 1))
}
// zip it up
IO delete (temp / "META-INF" / "MANIFEST.MF")
val contentMappings = (temp.*** --- PathFinder(temp)).get pair relativeTo(temp)
val contentMappings = (temp.allPaths --- PathFinder(temp)).get pair { file => IO.relativizeFile(temp, file) }
val manifest = new JarManifest
manifest.getMainAttributes put (AttrName.MANIFEST_VERSION, "1.0")
manifest.getMainAttributes put (AttrName.MAIN_CLASS, "JettyLauncher")
manifest.getMainAttributes put (AttrName.MANIFEST_VERSION, "1.0")
manifest.getMainAttributes put (AttrName.MAIN_CLASS, "JettyLauncher")
val outputFile = workDir / warName
IO jar (contentMappings, outputFile, manifest)
IO jar (contentMappings.map { case (file, path) => (file, path.toString) } , outputFile, manifest)
// generate checksums
Seq(
@@ -162,10 +197,10 @@ executableKey := {
log info s"built executable webapp ${outputFile}"
outputFile
}
publishTo <<= version { (v: String) =>
publishTo := {
val nexus = "https://oss.sonatype.org/"
if (v.trim.endsWith("SNAPSHOT")) Some("snapshots" at nexus + "content/repositories/snapshots")
else Some("releases" at nexus + "service/local/staging/deploy/maven2")
if (version.value.trim.endsWith("SNAPSHOT")) Some("snapshots" at nexus + "content/repositories/snapshots")
else Some("releases" at nexus + "service/local/staging/deploy/maven2")
}
publishMavenStyle := true
pomIncludeRepository := { _ => false }
@@ -214,3 +249,8 @@ pomExtra := (
</developer>
</developers>
)
licenseOverrides := {
case DepModuleInfo("com.github.bkromhout", "java-diff-utils", _) =>
LicenseInfo(LicenseCategory.Apache, "Apache-2.0", "http://www.apache.org/licenses/LICENSE-2.0")
}

View File

@@ -1,2 +0,0 @@
%~d0
cmd /k cd %~p0

View File

@@ -3,6 +3,7 @@
RPM spec file and init script for Red Hat Enterprise Linux 6.x.
To create RPM:
1. Edit `../../gitbucket.conf` to suit.
2. Edit `gitbucket.init` to suit.
3. Edit `gitbucket.spec` to suit.

View File

@@ -0,0 +1,21 @@
module gitbucket 1.0;
require {
type smtp_port_t;
type tomcat_t;
type tomcat_var_lib_t;
type unreserved_port_t;
class file { execute };
class tcp_socket { name_bind };
class tcp_socket { name_connect };
}
# allow tomcat to send emails
allow tomcat_t smtp_port_t:tcp_socket { name_connect };
# allow file executes, required during repo creation
allow tomcat_t tomcat_var_lib_t:file { execute };
# allow tomcat to serve repositories via SSH
allow tomcat_t unreserved_port_t:tcp_socket { name_bind };

View File

@@ -0,0 +1,32 @@
# Red Hat Enterprise Linux / CentOS SELinux policy module for GitBucket
One way to run GitBucket on Enterprise Linux is under Tomcat. Since EL 7.4, Tomcat is no longer unconfined.
Thus since 7.4, Enterprise Linux blocks certain operations that are required for GitBucket to work properly:
* Tomcat is not allowed to connect to SMTP ports, which is required to send email notifications.
* Tomcat is not allowed to execute files, which is required for creating repositories.
* Tomcat is not allowed to act as a server on unreserved ports, which is required for serving repositories via SSH.
To mitigate this, you can use the SELinux policy module provided as `gitbucket.te`. You can deploy the module with the
attached script, e.g.:
~~~
./sedeploy.sh gitbucket
~~~
You most likely also need to fix file contexts on your system. Assuming a new, default Tomcat installation on 7.4, you
can do so by issuing the following commands:
~~~
GITBUCKET_HOME='/usr/share/tomcat/.gitbucket'
mkdir -p ${GITBUCKET_HOME}
chown tomcat.tomcat ${GITBUCKET_HOME}
semanage fcontext -a -t tomcat_var_lib_t "${GITBUCKET_HOME}(/.*)?"
restorecon -rv ${GITBUCKET_HOME}
JAVA_CONF='/usr/share/tomcat/.java'
mkdir -p ${JAVA_CONF}
chown tomcat.tomcat ${JAVA_CONF}
semanage fcontext -a -t tomcat_cache_t "${JAVA_CONF}(/.*)?"
restorecon -rv ${JAVA_CONF}
~~~

View File

@@ -0,0 +1,14 @@
#!/bin/sh
set -e
MODULE=${1}
# this will create a .mod file
checkmodule -M -m -o ${MODULE}.mod ${MODULE}.te
# this will create a compiled semodule
semodule_package -m ${MODULE}.mod -o ${MODULE}.pp
# this will install the module
semodule -i ${MODULE}.pp

View File

@@ -1,18 +1,24 @@
How to run from the source tree
========
Install [sbt](http://www.scala-sbt.org/index.html) at first.
```
$ brew install sbt
```
Run for Development
--------
If you want to test GitBucket, input following command at the root directory of the source tree.
If you want to test GitBucket, type the following command in the root directory of the source tree.
```
$ sbt ~jetty:start
```
Then access to `http://localhost:8080/` by your browser. The default administrator account is `root` and password is `root`.
Then access `http://localhost:8080/` in your browser. The default administrator account is `root` and password is `root`.
Source code modification is detected and reloaded automatically. You can modify logging configuration by editing `src/main/resources/logback-dev.xml`.
Source code modifications are detected and a reloaded happens automatically. You can modify the logging configuration by editing `src/main/resources/logback-dev.xml`.
Build war file
--------
@@ -23,9 +29,9 @@ To build war file, run the following command:
$ sbt package
```
`gitbucket_2.11-x.x.x.war` is generated into `target/scala-2.11`.
`gitbucket_2.12-x.x.x.war` is generated into `target/scala-2.12`.
To build executable war file, run
To build an executable war file, run
```
$ sbt executable
@@ -35,8 +41,8 @@ at the top of the source tree. It generates executable `gitbucket.war` into `tar
Run tests spec
---------
To run the full serie of tests, run the following command:
To run the full series of tests, run the following command:
```
sbt test
$ sbt test
```

View File

@@ -1,35 +1,25 @@
JRebel integration (optional)
=============================
[JRebel](http://zeroturnaround.com/software/jrebel/) is a JVM plugin that makes developing web apps much faster.
JRebel is generally able to eliminate the need for the following slow "app restart" in sbt following a code change:
[JRebel](https://zeroturnaround.com/software/jrebel/) is a JVM plugin that makes developing web apps much faster.
JRebel is generally able to eliminate the need for the slow "app restart" per modification of codes. Alsp it's only used during development, and doesn't change your deployed app in any way.
```
> jetty:start
```
While JRebel is not open source, it does reload your code faster than the `~;copy-resources;aux-compile` way of doing things using `sbt`.
It's only used during development, and doesn't change your deployed app in any way.
JRebel used to be free for Scala developers, but that changed recently, and now there's a cost associated with usage for Scala. There are trial plans and free non-commercial licenses available if you just want to try it out.
JRebel is not open source, but we can use it free for non-commercial use.
----
## 1. Get a JRebel license
Sign up for a [usage plan](https://my.jrebel.com/). You will need to create an account.
Sign up for a [myJRebel](https://my.jrebel.com/register). You will need to create an account.
## 2. Download JRebel
Download the most recent ["nosetup" JRebel zip](http://zeroturnaround.com/software/jrebel/download/prev-releases/).
Download the most recent ["nosetup" JRebel zip](https://zeroturnaround.com/software/jrebel/download/prev-releases/).
Next, unzip the downloaded file.
## 3. Activate
Follow the [instructions on the JRebel website](http://zeroturnaround.com/software/jrebel/download/prev-releases/) to activate your downloaded JRebel.
You can use the default settings for all the configurations.
Follow `readme.txt` in the extracted directory to activate your downloaded JRebel.
You don't need to integrate with your IDE, since we're using sbt to do the servlet deployment.
@@ -38,17 +28,16 @@ You don't need to integrate with your IDE, since we're using sbt to do the servl
Fortunately, the gitbucket project is already set up to use JRebel.
You only need to tell jvm where to find the jrebel jar.
To do so, edit your shell resource file (usually `~/.bash_profile` on Mac, and `~/.bashrc` on Linux), and add the following line:
To do so, edit your shell resource file (usually `~/.bash_profile` on Mac, and `~/.bashrc` on Linux) and set the environment variable `JREBEL`.
For example, if you unzipped your JRebel download in your home directory, you would use:
```bash
export JREBEL=/path/to/jrebel/jrebel.jar
export JREBEL=~/jrebel/legacy/jrebel.jar # legacy agent
export JREBEL=~/jrebel/lib/libjrebel64.dylib # new agent
```
For example, if you unzipped your JRebel download in your home directory, you whould use:
```bash
export JREBEL=~/jrebel/jrebel.jar
```
You can choose the legacy JRebel agent or the new one.
See [the document](https://zeroturnaround.com/software/jrebel/jrebel7-agent-upgrade-cli/) for details.
Now reload your shell:
@@ -73,39 +62,26 @@ $ ./sbt
You will start the servlet container slightly differently now that you're using sbt.
```
> jetty:start
> jetty:quickstart
:
[info] starting server ...
[success] Total time: 3 s, completed Jan 3, 2016 9:47:55 PM
2016-01-03 21:47:57 JRebel:
2016-01-03 21:47:57 JRebel: A newer version '6.3.1' is available for download
2016-01-03 21:47:57 JRebel: from http://zeroturnaround.com/software/jrebel/download/
2016-01-03 21:47:57 JRebel:
2016-01-03 21:47:58 JRebel: Contacting myJRebel server ..
2016-01-03 21:47:59 JRebel: Directory '/git/gitbucket/target/scala-2.11/classes' will be monitored for changes.
2016-01-03 21:47:59 JRebel: Directory '/git/gitbucket/target/scala-2.11/test-classes' will be monitored for changes.
2016-01-03 21:47:59 JRebel: Directory '/git/gitbucket/target/webapp' will be monitored for changes.
2016-01-03 21:48:00 JRebel:
2016-01-03 21:48:00 JRebel: #############################################################
2016-01-03 21:48:00 JRebel:
2016-01-03 21:48:00 JRebel: JRebel Legacy Agent 6.2.5 (201509291538)
2016-01-03 21:48:00 JRebel: (c) Copyright ZeroTurnaround AS, Estonia, Tartu.
2016-01-03 21:48:00 JRebel:
2016-01-03 21:48:00 JRebel: Over the last 30 days JRebel prevented
2016-01-03 21:48:00 JRebel: at least 182 redeploys/restarts saving you about 7.4 hours.
2016-01-03 21:48:00 JRebel:
2016-01-03 21:48:00 JRebel: Over the last 324 days JRebel prevented
2016-01-03 21:48:00 JRebel: at least 1538 redeploys/restarts saving you about 62.4 hours.
2016-01-03 21:48:00 JRebel:
2016-01-03 21:48:00 JRebel: Licensed to nazo king (using myJRebel).
2016-01-03 21:48:00 JRebel:
2016-01-03 21:48:00 JRebel:
2016-01-03 21:48:00 JRebel: #############################################################
2016-01-03 21:48:00 JRebel:
2017-09-21 15:46:35 JRebel:
2017-09-21 15:46:35 JRebel: #############################################################
2017-09-21 15:46:35 JRebel:
2017-09-21 15:46:35 JRebel: Legacy Agent 7.0.15 (201709080836)
2017-09-21 15:46:35 JRebel: (c) Copyright ZeroTurnaround AS, Estonia, Tartu.
2017-09-21 15:46:35 JRebel:
2017-09-21 15:46:35 JRebel: Over the last 2 days JRebel prevented
2017-09-21 15:46:35 JRebel: at least 8 redeploys/restarts saving you about 0.3 hours.
2017-09-21 15:46:35 JRebel:
2017-09-21 15:46:35 JRebel: Licensed to Naoki Takezoe (using myJRebel).
2017-09-21 15:46:35 JRebel:
2017-09-21 15:46:35 JRebel:
2017-09-21 15:46:35 JRebel: #############################################################
2017-09-21 15:46:35 JRebel:
:
> ~ copy-resources
[success] Total time: 0 s, completed Jan 3, 2016 9:13:54 PM
> ~compile
[success] Total time: 2 s, completed 2017/09/21 15:50:06
1. Waiting for source changes... (press enter to interrupt)
```
@@ -114,12 +90,11 @@ For example, you can change the title on `src/main/twirl/gitbucket/core/main.sca
```html
:
<a class="navbar-brand" href="@path/">
<img src="@assets/common/images/gitbucket.png" style="width: 24px; height: 24px;"/>GitBucket
@defining(AutoUpdate.getCurrentVersion){ version =>
<span class="header-version">@version.majorVersion.@version.minorVersion</span>
}
<a href="@context.path/" class="logo">
<img src="@helpers.assets("/common/images/gitbucket.svg")" style="width: 24px; height: 24px; display: inline;"/>
GitBucket
change code !!!!!!!!!!!!!!!!
<span class="header-version">@gitbucket.core.GitBucketCoreModule.getVersions.last.getVersion</span>
</a>
:
```
@@ -128,21 +103,17 @@ If JRebel is doing is correctly installed you will see a notice for you:
```
1. Waiting for source changes... (press enter to interrupt)
2016-01-03 21:48:42 JRebel: Reloading class 'gitbucket.core.html.main$'.
[info] Wrote rebel.xml to /git/gitbucket/target/scala-2.11/resource_managed/main/rebel.xml
[info] Compiling 1 Scala source to /git/gitbucket/target/scala-2.11/classes...
[success] Total time: 3 s, completed Jan 3, 2016 9:48:55 PM
2. Waiting for source changes... (press enter to interrupt)
[info] Compiling 1 Scala source to /Users/naoki.takezoe/gitbucket/target/scala-2.12/classes...
[success] Total time: 1 s, completed 2017/09/21 15:55:40
```
And you reload browser, JRebel give notice of that it has reloaded classes:
```
[success] Total time: 3 s, completed Jan 3, 2016 9:48:55 PM
2. Waiting for source changes... (press enter to interrupt)
2016-01-03 21:49:13 JRebel: Reloading class 'gitbucket.core.html.main$'.
2017-09-21 15:55:40 JRebel: Reloading class 'gitbucket.core.html.main$'.
```
## 6. Limitations
JRebel is nearly always able to eliminate the need to explicitly reload your container after a code change. However, if you change any of your routes patterns, there is nothing JRebel can do, you will have to run `jetty:start`.
JRebel is nearly always able to eliminate the need to explicitly reload your container after a code change. However, if you change any of your routing patterns, there is nothing JRebel can do, you will have to restart by `jetty:quickstart`.

101
doc/licenses.md Normal file
View File

@@ -0,0 +1,101 @@
# gitbucket-licenses
Category | License | Dependency | Notes
--- | --- | --- | ---
Apache | [ Apache License, Version 2.0 ]( http://opensource.org/licenses/apache2.0.php ) | org.osgi # org.osgi.core # 4.3.1 | <notextile></notextile>
Apache | [Apache 2](http://www.apache.org/licenses/LICENSE-2.0.txt) | com.googlecode.javaewah # JavaEWAH # 1.1.6 | <notextile></notextile>
Apache | [Apache 2](http://www.apache.org/licenses/LICENSE-2.0) | org.cache2k # cache2k-all # 1.0.0.CR1 | <notextile></notextile>
Apache | [Apache 2](http://www.apache.org/licenses/LICENSE-2.0.txt) | org.objenesis # objenesis # 2.5 | <notextile></notextile>
Apache | [Apache 2.0 License](http://www.apache.org/licenses/LICENSE-2.0) | org.apache.sshd # apache-sshd # 1.4.0 | <notextile></notextile>
Apache | [Apache 2.0 License](http://www.apache.org/licenses/LICENSE-2.0) | org.apache.sshd # sshd-core # 1.4.0 | <notextile></notextile>
Apache | [Apache License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0) | com.typesafe # config # 1.3.1 | <notextile></notextile>
Apache | [Apache License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0) | com.typesafe.akka # akka-actor_2.12 # 2.5.0 | <notextile></notextile>
Apache | [Apache License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | commons-io # commons-io # 2.5 | <notextile></notextile>
Apache | [Apache License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | fr.brouillard.oss.security.xhub # xhub4j-core # 1.0.0 | <notextile></notextile>
Apache | [Apache License, Version 2.0](https://www.apache.org/licenses/LICENSE-2.0.txt) | org.apache.commons # commons-compress # 1.13 | <notextile></notextile>
Apache | [Apache License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | org.apache.commons # commons-email # 1.4 | <notextile></notextile>
Apache | [Apache License, Version 2.0](https://www.apache.org/licenses/LICENSE-2.0.txt) | org.apache.commons # commons-lang3 # 3.5 | <notextile></notextile>
Apache | [Apache License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | org.apache.httpcomponents # httpclient # 4.5.3 | <notextile></notextile>
Apache | [Apache License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | org.apache.httpcomponents # httpcore # 4.4.6 | <notextile></notextile>
Apache | [Apache License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | org.apache.httpcomponents # httpmime # 4.5.2 | <notextile></notextile>
Apache | [Apache License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | org.apache.tika # tika-core # 1.14 | <notextile></notextile>
Apache | [Apache License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0) | org.liquibase # liquibase-core # 3.4.1 | <notextile></notextile>
Apache | [Apache Software License - Version 2.0](http://www.apache.org/licenses/LICENSE-2.0) | org.eclipse.jetty # jetty-http # 9.2.19.v20160908 | <notextile></notextile>
Apache | [Apache Software License - Version 2.0](http://www.apache.org/licenses/LICENSE-2.0) | org.eclipse.jetty # jetty-io # 9.2.19.v20160908 | <notextile></notextile>
Apache | [Apache Software License - Version 2.0](http://www.apache.org/licenses/LICENSE-2.0) | org.eclipse.jetty # jetty-security # 9.2.19.v20160908 | <notextile></notextile>
Apache | [Apache Software License - Version 2.0](http://www.apache.org/licenses/LICENSE-2.0) | org.eclipse.jetty # jetty-server # 9.2.19.v20160908 | <notextile></notextile>
Apache | [Apache Software License - Version 2.0](http://www.apache.org/licenses/LICENSE-2.0) | org.eclipse.jetty # jetty-servlet # 9.2.19.v20160908 | <notextile></notextile>
Apache | [Apache Software License - Version 2.0](http://www.apache.org/licenses/LICENSE-2.0) | org.eclipse.jetty # jetty-util # 9.2.19.v20160908 | <notextile></notextile>
Apache | [Apache Software License - Version 2.0](http://www.apache.org/licenses/LICENSE-2.0) | org.eclipse.jetty # jetty-webapp # 9.2.19.v20160908 | <notextile></notextile>
Apache | [Apache Software License - Version 2.0](http://www.apache.org/licenses/LICENSE-2.0) | org.eclipse.jetty # jetty-xml # 9.2.19.v20160908 | <notextile></notextile>
Apache | [Apache Software License, Version 1.1](http://www.apache.org/licenses/LICENSE-1.1) | org.bouncycastle # bcpg-jdk15on # 1.56 | <notextile></notextile>
Apache | [Apache-2.0](http://www.apache.org/licenses/LICENSE-2.0) | com.github.bkromhout # java-diff-utils # 2.1.1 | <notextile></notextile>
Apache | [Apache-2.0](http://www.apache.org/licenses/LICENSE-2.0.html) | com.typesafe.play # twirl-api_2.12 # 1.3.7 | <notextile></notextile>
Apache | [Apache-2.0](http://www.apache.org/licenses/LICENSE-2.0) | org.json4s # json4s-ast_2.12 # 3.5.1 | <notextile></notextile>
Apache | [Apache-2.0](http://www.apache.org/licenses/LICENSE-2.0) | org.json4s # json4s-core_2.12 # 3.5.1 | <notextile></notextile>
Apache | [Apache-2.0](http://www.apache.org/licenses/LICENSE-2.0) | org.json4s # json4s-jackson_2.12 # 3.5.1 | <notextile></notextile>
Apache | [Apache-2.0](http://www.apache.org/licenses/LICENSE-2.0) | org.json4s # json4s-scalap_2.12 # 3.5.1 | <notextile></notextile>
Apache | [The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | com.enragedginger # akka-quartz-scheduler_2.12 # 1.6.0-akka-2.4.x | <notextile></notextile>
Apache | [The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | com.fasterxml.jackson.core # jackson-annotations # 2.8.0 | <notextile></notextile>
Apache | [The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | com.fasterxml.jackson.core # jackson-core # 2.8.4 | <notextile></notextile>
Apache | [The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | com.fasterxml.jackson.core # jackson-databind # 2.8.4 | <notextile></notextile>
Apache | [The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | com.github.takezoe # blocking-slick-32_2.12 # 0.0.10 | <notextile></notextile>
Apache | [The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | com.google.code.findbugs # jsr305 # 3.0.0 | <notextile></notextile>
Apache | [The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | com.zaxxer # HikariCP # 2.6.1 | <notextile></notextile>
Apache | [The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | commons-codec # commons-codec # 1.9 | <notextile></notextile>
Apache | [The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | commons-logging # commons-logging # 1.2 | <notextile></notextile>
Apache | [The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | de.flapdoodle.embed # de.flapdoodle.embed.process # 2.0.1 | <notextile></notextile>
Apache | [The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | eu.medsea.mimeutil # mime-util # 2.1.3 | <notextile></notextile>
Apache | [The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | io.github.gitbucket # markedj # 1.0.15 | <notextile></notextile>
Apache | [The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | io.github.gitbucket # scalatra-forms_2.12 # 1.1.0 | <notextile></notextile>
Apache | [The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | io.github.gitbucket # solidbase # 1.0.2 | <notextile></notextile>
Apache | [The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | net.bytebuddy # byte-buddy # 1.6.11 | <notextile></notextile>
Apache | [The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | net.bytebuddy # byte-buddy-agent # 1.6.11 | <notextile></notextile>
Apache | [The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | org.quartz-scheduler # quartz # 2.2.3 | <notextile></notextile>
Apache | [The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | ru.yandex.qatools.embed # postgresql-embedded # 2.0 | <notextile></notextile>
Apache | [The Apache Software License, Version 2.0](http://www.apache.org/licenses/LICENSE-2.0.txt) | tomcat # tomcat-apr # 5.5.23 | <notextile></notextile>
Apache | [the Apache License, ASL Version 2.0](http://www.apache.org/licenses/LICENSE-2.0) | org.scalactic # scalactic_2.12 # 3.0.0 | <notextile></notextile>
Apache | [the Apache License, ASL Version 2.0](http://www.apache.org/licenses/LICENSE-2.0) | org.scalatest # scalatest_2.12 # 3.0.0 | <notextile></notextile>
BSD | [BSD](LICENSE.txt) | com.thoughtworks.paranamer # paranamer # 2.8 | <notextile></notextile>
BSD | [BSD](http://software.clapper.org/grizzled-slf4j/license.html) | org.clapper # grizzled-slf4j_2.12 # 1.3.0 | <notextile></notextile>
BSD | [BSD](http://github.com/scalatra/scalatra/raw/HEAD/LICENSE) | org.scalatra # scalatra-common_2.12 # 2.5.0 | <notextile></notextile>
BSD | [BSD](http://github.com/scalatra/scalatra/raw/HEAD/LICENSE) | org.scalatra # scalatra-json_2.12 # 2.5.0 | <notextile></notextile>
BSD | [BSD](http://github.com/scalatra/scalatra/raw/HEAD/LICENSE) | org.scalatra # scalatra-scalatest_2.12 # 2.5.0 | <notextile></notextile>
BSD | [BSD](http://github.com/scalatra/scalatra/raw/HEAD/LICENSE) | org.scalatra # scalatra-test_2.12 # 2.5.0 | <notextile></notextile>
BSD | [BSD](http://github.com/scalatra/scalatra/raw/HEAD/LICENSE) | org.scalatra # scalatra_2.12 # 2.5.0 | <notextile></notextile>
BSD | [BSD 3-Clause](http://www.scala-lang.org/license.html) | org.scala-lang # scala-library # 2.12.3 | <notextile></notextile>
BSD | [BSD 3-Clause](http://www.scala-lang.org/license.html) | org.scala-lang # scala-reflect # 2.12.3 | <notextile></notextile>
BSD | [BSD 3-clause](http://opensource.org/licenses/BSD-3-Clause) | org.scala-lang.modules # scala-java8-compat_2.12 # 0.8.0 | <notextile></notextile>
BSD | [BSD 3-clause](http://opensource.org/licenses/BSD-3-Clause) | org.scala-lang.modules # scala-parser-combinators_2.12 # 1.0.4 | <notextile></notextile>
BSD | [BSD 3-clause](http://opensource.org/licenses/BSD-3-Clause) | org.scala-lang.modules # scala-xml_2.12 # 1.0.6 | <notextile></notextile>
BSD | [BSD License](http://www.opensource.org/licenses/bsd-license.php) | com.wix # wix-embedded-mysql # 2.1.4 | <notextile></notextile>
BSD | [BSD-2-Clause](https://jdbc.postgresql.org/about/license.html) | org.postgresql # postgresql # 42.0.0 | <notextile></notextile>
BSD | [Eclipse Distribution License (New BSD License)](null) | org.eclipse.jgit # org.eclipse.jgit # 4.8.0.201706111038-r | <notextile></notextile>
BSD | [Eclipse Distribution License (New BSD License)](null) | org.eclipse.jgit # org.eclipse.jgit.archive # 4.8.0.201706111038-r | <notextile></notextile>
BSD | [Eclipse Distribution License (New BSD License)](null) | org.eclipse.jgit # org.eclipse.jgit.http.server # 4.8.0.201706111038-r | <notextile></notextile>
BSD | [New BSD License](http://www.opensource.org/licenses/bsd-license.php) | org.hamcrest # hamcrest-core # 1.3 | <notextile></notextile>
BSD | [Revised BSD](http://www.jcraft.com/jsch/LICENSE.txt) | com.jcraft # jsch # 0.1.54 | <notextile></notextile>
BSD | [Two-clause BSD-style license](http://github.com/slick/slick/blob/master/LICENSE.txt) | com.typesafe.slick # slick_2.12 # 3.2.1 | <notextile></notextile>
CC0 | [CC0](http://creativecommons.org/publicdomain/zero/1.0/) | org.reactivestreams # reactive-streams # 1.0.0 | <notextile></notextile>
CDDL | [COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) Version 1.0](https://glassfish.dev.java.net/public/CDDLv1.0.html) | javax.activation # activation # 1.1.1 | <notextile></notextile>
GPL | [CDDL/GPLv2+CE](https://glassfish.java.net/public/CDDL+GPL_1_1.html) | com.sun.mail # javax.mail # 1.5.2 | <notextile></notextile>
GPL with Classpath Extension | [CDDL + GPLv2 with classpath exception](https://glassfish.dev.java.net/nonav/public/CDDL+GPL.html) | javax.servlet # javax.servlet-api # 3.1.0 | <notextile></notextile>
LGPL | [GNU Lesser General Public License](http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html) | ch.qos.logback # logback-classic # 1.2.3 | <notextile></notextile>
LGPL | [GNU Lesser General Public License](http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html) | ch.qos.logback # logback-core # 1.2.3 | <notextile></notextile>
LGPL | [LGPL, version 2.1](http://www.gnu.org/licenses/licenses.html) | net.java.dev.jna # jna # 4.0.0 | <notextile></notextile>
LGPL | [LGPL, version 2.1](http://www.gnu.org/licenses/licenses.html) | net.java.dev.jna # jna-platform # 4.0.0 | <notextile></notextile>
LGPL | [LGPL-2.1](null) | org.mariadb.jdbc # mariadb-java-client # 2.0.3 | <notextile></notextile>
MIT | [MIT License](http://www.opensource.org/licenses/mit-license.php) | org.slf4j # slf4j-api # 1.7.25 | <notextile></notextile>
MIT | [The MIT License](http://www.opensource.org/licenses/mit-license.php) | com.github.zafarkhaja # java-semver # 0.9.0 | <notextile></notextile>
MIT | [The MIT License](https://jsoup.org/license) | org.jsoup # jsoup # 1.10.2 | <notextile></notextile>
MIT | [The MIT License](http://github.com/mockito/mockito/blob/master/LICENSE) | org.mockito # mockito-all # 1.10.19 | <notextile></notextile>
MIT | [The MIT License](http://github.com/mockito/mockito/blob/master/LICENSE) | org.mockito # mockito-core # 2.7.22 | <notextile></notextile>
MIT | [The MIT License (MIT)](http://www.opensource.org/licenses/mit-license.html) | net.coobird # thumbnailator # 0.4.8 | <notextile></notextile>
Mozilla | [MPL 2.0 or EPL 1.0](http://h2database.com/html/license.html) | com.h2database # h2 # 1.4.195 | <notextile></notextile>
Mozilla | [Mozilla Public License 1.1 (MPL 1.1)](http://www.mozilla.org/MPL/MPL-1.1.html) | com.googlecode.juniversalchardet # juniversalchardet # 1.0.3 | <notextile></notextile>
Public Domain | [Public Domain](http://en.wikipedia.org/wiki/Public_domain) | net.i2p.crypto # eddsa # 0.1.0 | <notextile></notextile>
unrecognized | [Bouncy Castle Licence](http://www.bouncycastle.org/licence.html) | org.bouncycastle # bcpkix-jdk15on # 1.56 | <notextile></notextile>
unrecognized | [Bouncy Castle Licence](http://www.bouncycastle.org/licence.html) | org.bouncycastle # bcprov-jdk15on # 1.56 | <notextile></notextile>
unrecognized | [Eclipse Public License 1.0](http://www.eclipse.org/legal/epl-v10.html) | junit # junit # 4.12 | <notextile></notextile>
unrecognized | [The OpenLDAP Public License](http://www.openldap.org/software/release/license.html) | com.novell.ldap # jldap # 2009-10-07 | <notextile></notextile>

View File

@@ -1,23 +0,0 @@
Notification Email
========
GitBucket sends email to target users by enabling the notification email by an administrator.
The timing of the notification are as follows:
##### at the issue registration (new issue, new pull request)
When a record is saved into the ```ISSUE``` table, GitBucket does the notification.
##### at the comment registration
Among the records in the ```ISSUE_COMMENT``` table, them to be counted as a comment (i.e. the record ```ACTION``` column value is "comment" or "close_comment" or "reopen_comment") are saved, GitBucket does the notification.
##### at the status update (close, reopen, merge)
When the ```CLOSED``` column value is updated, GitBucket does the notification.
Notified users are as follows:
* individual repository's owner
* collaborators
* participants
However, the operation in person is excluded from the target.

View File

@@ -6,7 +6,7 @@ Developer's Guide
* [Authentication in Controller](authenticator.md)
* [About Action in Issue Comment](comment_action.md)
* [Activity Types](activity.md)
* [Notification Email](notification.md)
* [Automatic Schema Updating](auto_update.md)
* [Release Operation](release.md)
* [JRebel integration (optional)](jrebel.md)
* [Licenses](licenses.md)

View File

@@ -34,8 +34,6 @@ object GitBucketCoreModule extends Module("gitbucket-core",
Generate release files
--------
Note: Release operation requires [Ant](http://ant.apache.org/) and [Maven](https://maven.apache.org/).
### Make release war file
Run `sbt executable`. The release war file and fingerprint are generated into `target/executable/gitbucket.war`.
@@ -52,4 +50,12 @@ For plug-in development, we have to publish the GitBucket jar file to the Maven
$ sbt publish-signed
```
Then operate release sequence at https://oss.sonatype.org/.
Then logged-in https://oss.sonatype.org/ and delete following files from the staging repository:
- gitbucket_2.12-x.x.x.war
- gitbucket_2.12-x.x.x.war.asc
- gitbucket_2.12-x.x.x.war.asc.md5
- gitbucket_2.12-x.x.x.war.asc.sha1
- gitbucket_2.12-x.x.x.war.md5
At last, close and release the repository.

54
plugins.json Normal file
View File

@@ -0,0 +1,54 @@
[
{
"id": "notifications",
"name": "Notifications Plugin",
"description": "Provides notifications feature on GitBucket.",
"versions": [
{
"version": "1.4.0",
"range": ">=4.19.0",
"url": "https://github.com/gitbucket/gitbucket-notifications-plugin/releases/download/1.4.0/gitbucket-notifications-plugin_2.12-1.4.0.jar"
}
],
"default": true
},
{
"id": "emoji",
"name": "Emoji Plugin",
"description": "Provides Emoji support for GitBucket.",
"versions": [
{
"version": "4.5.0",
"range": ">=4.18.0",
"url": "https://github.com/gitbucket/gitbucket-emoji-plugin/releases/download/4.5.0/gitbucket-emoji-plugin_2.12-4.5.0.jar"
}
],
"default": false
},
{
"id": "gist",
"name": "Gist Plugin",
"description": "Provides Gist feature on GitBucket.",
"versions": [
{
"version": "4.11.0",
"range": ">=4.19.0",
"url": "https://github.com/gitbucket/gitbucket-gist-plugin/releases/download/4.11.0/gitbucket-gist-plugin-assembly-4.11.0.jar"
}
],
"default": false
},
{
"id": "pages",
"name": "Pages Plugin",
"description": "Project pages for gitbucket",
"versions": [
{
"version": "1.6.0",
"range": ">=4.19.0",
"url": "https://github.com/gitbucket/gitbucket-pages-plugin/releases/download/v1.6.0/gitbucket-pages-plugin_2.12-1.6.0.jar"
}
],
"default": false
}
]

View File

@@ -1,13 +1,13 @@
import java.security.MessageDigest;
import java.security.MessageDigest
import scala.annotation._
import sbt._
import sbt.Using._
import io._
object Checksums {
private val bufferSize = 2048
def generate(source:File, target:File, algorithm:String):Unit =
IO write (target, compute(source, algorithm))
sbt.IO write (target, compute(source, algorithm))
def compute(file:File, algorithm:String):String =
hex(raw(file, algorithm))

16
project/PluginsJson.scala Normal file
View File

@@ -0,0 +1,16 @@
import com.eclipsesource.json.Json
import scala.collection.JavaConverters._
object PluginsJson {
def getUrls(json: String): Seq[String] = {
val value = Json.parse(json)
value.asArray.values.asScala.map { plugin =>
val pluginObject = plugin.asObject
val latestVersionObject = pluginObject.get("versions").asArray.asScala.head.asObject
latestVersionObject.get("url").asString
}
}
}

View File

@@ -1 +1 @@
sbt.version=0.13.12
sbt.version=1.1.0

1
project/build.sbt Normal file
View File

@@ -0,0 +1 @@
libraryDependencies += "com.eclipsesource.minimal-json" % "minimal-json" % "0.9.4"

View File

@@ -1,7 +1,10 @@
scalacOptions ++= Seq("-unchecked", "-deprecation", "-feature")
addSbtPlugin("com.typesafe.sbt" % "sbt-twirl" % "1.0.4")
addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "0.12.0")
addSbtPlugin("com.earldouglas" % "xsbt-web-plugin" % "2.1.0")
addSbtPlugin("fi.gekkio.sbtplugins" % "sbt-jrebel-plugin" % "0.10.0")
addSbtPlugin("com.typesafe.sbt" % "sbt-pgp" % "0.8.3")
addSbtPlugin("com.typesafe.sbt" % "sbt-twirl" % "1.3.13")
addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "0.14.5")
//addSbtPlugin("com.earldouglas" % "xsbt-web-plugin" % "4.0.0")
//addSbtPlugin("fi.gekkio.sbtplugins" % "sbt-jrebel-plugin" % "0.10.0")
addSbtPlugin("org.scalatra.sbt" % "sbt-scalatra" % "1.0.1")
addSbtPlugin("com.jsuereth" % "sbt-pgp" % "1.1.0")
addSbtCoursier
addSbtPlugin("com.typesafe.sbt" % "sbt-license-report" % "1.2.0")

View File

@@ -0,0 +1 @@
addSbtPlugin("io.get-coursier" % "sbt-coursier" % "1.0.0")

Binary file not shown.

View File

@@ -1,2 +0,0 @@
set SCRIPT_DIR=%~dp0
java %JAVA_OPTS% -Dsbt.log.noformat=true -XX:+CMSClassUnloadingEnabled -Xmx512M -Xss2M -Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=5005 -jar "%SCRIPT_DIR%\sbt-launch-0.13.12.jar" %*

2
sbt.sh
View File

@@ -1,2 +0,0 @@
#!/bin/sh
java $JAVA_OPTS -Dsbt.log.noformat=true -XX:+CMSClassUnloadingEnabled -Xmx512M -Xss2M -Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=5005 -jar `dirname $0`/sbt-launch-0.13.12.jar "$@"

View File

@@ -1,4 +1,9 @@
import org.eclipse.jetty.server.ConnectionFactory;
import org.eclipse.jetty.server.Connector;
import org.eclipse.jetty.server.Handler;
import org.eclipse.jetty.server.HttpConnectionFactory;
import org.eclipse.jetty.server.Server;
import org.eclipse.jetty.server.handler.StatisticsHandler;
import org.eclipse.jetty.webapp.WebAppContext;
import java.io.File;
@@ -8,24 +13,47 @@ import java.security.ProtectionDomain;
public class JettyLauncher {
public static void main(String[] args) throws Exception {
System.setProperty("java.awt.headless", "true");
String host = null;
int port = 8080;
InetSocketAddress address = null;
String contextPath = "/";
String tmpDirPath="";
boolean forceHttps = false;
for(String arg: args) {
if(arg.startsWith("--") && arg.contains("=")) {
String[] dim = arg.split("=");
if(dim.length >= 2) {
if(dim[0].equals("--host")) {
host = dim[1];
} else if(dim[0].equals("--port")) {
port = Integer.parseInt(dim[1]);
} else if(dim[0].equals("--prefix")) {
contextPath = dim[1];
} else if(dim[0].equals("--gitbucket.home")){
System.setProperty("gitbucket.home", dim[1]);
switch (dim[0]) {
case "--host":
host = dim[1];
break;
case "--port":
port = Integer.parseInt(dim[1]);
break;
case "--prefix":
contextPath = dim[1];
if (!contextPath.startsWith("/")) {
contextPath = "/" + contextPath;
}
break;
case "--max_file_size":
System.setProperty("gitbucket.maxFileSize", dim[1]);
break;
case "--gitbucket.home":
System.setProperty("gitbucket.home", dim[1]);
break;
case "--temp_dir":
tmpDirPath = dim[1];
break;
case "--plugin_dir":
System.setProperty("gitbucket.pluginDir", dim[1]);
break;
case "--validate_password":
System.setProperty("gitbucket.validate.password", dim[1]);
break;
}
}
}
@@ -48,14 +76,38 @@ public class JettyLauncher {
// connector.setPort(port);
// server.addConnector(connector);
// Disabling Server header
for (Connector connector : server.getConnectors()) {
for (ConnectionFactory factory : connector.getConnectionFactories()) {
if (factory instanceof HttpConnectionFactory) {
((HttpConnectionFactory) factory).getHttpConfiguration().setSendServerVersion(false);
}
}
}
WebAppContext context = new WebAppContext();
File tmpDir = new File(getGitBucketHome(), "tmp");
if(!tmpDir.exists()){
tmpDir.mkdirs();
File tmpDir;
if(tmpDirPath.equals("")){
tmpDir = new File(getGitBucketHome(), "tmp");
if(!tmpDir.exists()){
tmpDir.mkdirs();
}
} else {
tmpDir = new File(tmpDirPath);
if(!tmpDir.exists()){
throw new java.io.FileNotFoundException(
String.format("temp_dir \"%s\" not found", tmpDirPath));
} else if(!tmpDir.isDirectory()) {
throw new IllegalArgumentException(
String.format("temp_dir \"%s\" is not a directory", tmpDirPath));
}
}
context.setTempDirectory(tmpDir);
// Disabling the directory listing feature.
context.setInitParameter("org.eclipse.jetty.servlet.Default.dirAllowed", "false");
ProtectionDomain domain = JettyLauncher.class.getProtectionDomain();
URL location = domain.getCodeSource().getLocation();
@@ -67,7 +119,9 @@ public class JettyLauncher {
context.setInitParameter("org.scalatra.ForceHttps", "true");
}
server.setHandler(context);
Handler handler = addStatisticsHandler(context);
server.setHandler(handler);
server.setStopAtShutdown(true);
server.setStopTimeout(7_000);
server.start();
@@ -86,14 +140,11 @@ public class JettyLauncher {
return new File(System.getProperty("user.home"), ".gitbucket");
}
private static void deleteDirectory(File dir){
for(File file: dir.listFiles()){
if(file.isFile()){
file.delete();
} else if(file.isDirectory()){
deleteDirectory(file);
}
}
dir.delete();
private static Handler addStatisticsHandler(Handler handler) {
// The graceful shutdown is implemented via the statistics handler.
// See the following: https://bugs.eclipse.org/bugs/show_bug.cgi?id=420142
final StatisticsHandler statisticsHandler = new StatisticsHandler();
statisticsHandler.setHandler(handler);
return statisticsHandler;
}
}

View File

@@ -0,0 +1,14 @@
<?xml version="1.0" encoding="UTF-8"?>
<changeSet>
<createTable tableName="DEPLOY_KEY">
<column name="USER_NAME" type="varchar(100)" nullable="false"/>
<column name="REPOSITORY_NAME" type="varchar(100)" nullable="false"/>
<column name="DEPLOY_KEY_ID" type="int" nullable="false" autoIncrement="true" unique="true"/>
<column name="TITLE" type="varchar(100)" nullable="false"/>
<column name="PUBLIC_KEY" type="text" nullable="false"/>
<column name="ALLOW_WRITE" type="boolean" nullable="false" defaultValueBoolean="false"/>
</createTable>
<addPrimaryKey constraintName="IDX_DEPLOY_KEY_PK" tableName="DEPLOY_KEY" columnNames="USER_NAME, REPOSITORY_NAME, DEPLOY_KEY_ID"/>
<addForeignKeyConstraint constraintName="IDX_DEPLOY_KEY_FK0" baseTableName="DEPLOY_KEY" baseColumnNames="USER_NAME, REPOSITORY_NAME" referencedTableName="REPOSITORY" referencedColumnNames="USER_NAME, REPOSITORY_NAME"/>
</changeSet>

View File

@@ -0,0 +1,26 @@
CREATE OR REPLACE VIEW ISSUE_OUTLINE_VIEW AS
SELECT
A.USER_NAME,
A.REPOSITORY_NAME,
A.ISSUE_ID,
COALESCE(B.COMMENT_COUNT, 0) + COALESCE(C.COMMENT_COUNT, 0) AS COMMENT_COUNT,
COALESCE(D.ORDERING, 9999) AS PRIORITY
FROM ISSUE A
LEFT OUTER JOIN (
SELECT USER_NAME, REPOSITORY_NAME, ISSUE_ID, COUNT(COMMENT_ID) AS COMMENT_COUNT FROM ISSUE_COMMENT
WHERE ACTION IN ('comment', 'close_comment', 'reopen_comment')
GROUP BY USER_NAME, REPOSITORY_NAME, ISSUE_ID
) B
ON (A.USER_NAME = B.USER_NAME AND A.REPOSITORY_NAME = B.REPOSITORY_NAME AND A.ISSUE_ID = B.ISSUE_ID)
LEFT OUTER JOIN (
SELECT USER_NAME, REPOSITORY_NAME, ISSUE_ID, COUNT(COMMENT_ID) AS COMMENT_COUNT FROM COMMIT_COMMENT
GROUP BY USER_NAME, REPOSITORY_NAME, ISSUE_ID
) C
ON (A.USER_NAME = C.USER_NAME AND A.REPOSITORY_NAME = C.REPOSITORY_NAME AND A.ISSUE_ID = C.ISSUE_ID)
LEFT OUTER JOIN PRIORITY D
ON (A.PRIORITY_ID = D.PRIORITY_ID);

View File

@@ -0,0 +1,38 @@
<?xml version="1.0" encoding="UTF-8"?>
<changeSet>
<createTable tableName="PRIORITY">
<column name="USER_NAME" type="varchar(100)" nullable="false"/>
<column name="REPOSITORY_NAME" type="varchar(100)" nullable="false"/>
<column name="PRIORITY_ID" type="int" nullable="false" autoIncrement="true" unique="true"/>
<column name="PRIORITY_NAME" type="varchar(100)" nullable="false"/>
<column name="DESCRIPTION" type="varchar(255)" nullable="true"/>
<column name="ORDERING" type="int" nullable="false"/>
<column name="IS_DEFAULT" type="boolean" nullable="false"/>
<column name="COLOR" type="char(6)" nullable="false"/>
</createTable>
<addPrimaryKey constraintName="IDX_PRIORITY_PK" tableName="PRIORITY" columnNames="USER_NAME, REPOSITORY_NAME, PRIORITY_ID"/>
<addForeignKeyConstraint constraintName="IDX_PRIORITY_FK0" baseTableName="PRIORITY" baseColumnNames="USER_NAME, REPOSITORY_NAME" referencedTableName="REPOSITORY" referencedColumnNames="USER_NAME, REPOSITORY_NAME"/>
<addColumn tableName="ISSUE">
<column name="PRIORITY_ID" type="int" nullable="true" />
</addColumn>
<addForeignKeyConstraint constraintName="IDX_ISSUE_FK3" baseTableName="ISSUE" baseColumnNames="PRIORITY_ID" referencedTableName="PRIORITY" referencedColumnNames="PRIORITY_ID"/>
<createTable tableName="ACCOUNT_WEB_HOOK">
<column name="USER_NAME" type="varchar(100)" nullable="false"/>
<column name="URL" type="varchar(200)" nullable="false"/>
<column name="TOKEN" type="varchar(100)" nullable="true"/>
<column name="CTYPE" type="varchar(10)" nullable="true"/>
</createTable>
<addPrimaryKey constraintName="IDX_ACCOUNT_WEB_HOOK_PK" tableName="ACCOUNT_WEB_HOOK" columnNames="USER_NAME, URL"/>
<addForeignKeyConstraint constraintName="IDX_ACCOUNT_WEB_HOOK_FK0" baseTableName="ACCOUNT_WEB_HOOK" baseColumnNames="USER_NAME" referencedTableName="ACCOUNT" referencedColumnNames="USER_NAME"/>
<createTable tableName="ACCOUNT_WEB_HOOK_EVENT">
<column name="USER_NAME" type="varchar(100)" nullable="false"/>
<column name="URL" type="varchar(200)" nullable="false"/>
<column name="EVENT" type="varchar(30)" nullable="false"/>
</createTable>
</changeSet>

View File

@@ -0,0 +1,39 @@
<?xml version="1.0" encoding="UTF-8"?>
<changeSet>
<createTable tableName="RELEASE">
<column name="USER_NAME" type="varchar(100)" nullable="false"/>
<column name="REPOSITORY_NAME" type="varchar(100)" nullable="false"/>
<column name="TAG" type="varchar(100)" nullable="false"/>
<column name="NAME" type="varchar(100)" nullable="false"/>
<column name="AUTHOR" type="varchar(100)" nullable="false"/>
<column name="CONTENT" type="text" nullable="true"/>
<column name="REGISTERED_DATE" type="datetime" nullable="false"/>
<column name="UPDATED_DATE" type="datetime" nullable="false"/>
</createTable>
<addPrimaryKey constraintName="IDX_RELEASE_PK" tableName="RELEASE" columnNames="USER_NAME, REPOSITORY_NAME, TAG"/>
<addForeignKeyConstraint constraintName="IDX_RELEASE_FK0" baseTableName="RELEASE" baseColumnNames="USER_NAME, REPOSITORY_NAME" referencedTableName="REPOSITORY" referencedColumnNames="USER_NAME, REPOSITORY_NAME"/>
<createTable tableName="RELEASE_ASSET">
<column name="USER_NAME" type="varchar(100)" nullable="false"/>
<column name="REPOSITORY_NAME" type="varchar(100)" nullable="false"/>
<column name="TAG" type="varchar(100)" nullable="false"/>
<column name="RELEASE_ASSET_ID" type="int" nullable="false" autoIncrement="true" unique="true"/>
<column name="FILE_NAME" type="varchar(260)" nullable="false"/>
<column name="LABEL" type="varchar(100)" nullable="true"/>
<column name="SIZE" type="bigint" nullable="false"/>
<column name="UPLOADER" type="varchar(100)" nullable="false"/>
<column name="REGISTERED_DATE" type="datetime" nullable="false"/>
<column name="UPDATED_DATE" type="datetime" nullable="false"/>
</createTable>
<addPrimaryKey constraintName="IDX_RELEASE_ASSET_PK" tableName="RELEASE_ASSET" columnNames="USER_NAME, REPOSITORY_NAME, TAG, FILE_NAME"/>
<addForeignKeyConstraint constraintName="IDX_RELEASE_ASSET_FK1" baseTableName="RELEASE_ASSET" baseColumnNames="USER_NAME, REPOSITORY_NAME, TAG" referencedTableName="RELEASE" referencedColumnNames="USER_NAME, REPOSITORY_NAME, TAG"/>
<createTable tableName="ACCOUNT_FEDERATION">
<column name="ISSUER" type="varchar(100)" nullable="false"/>
<column name="SUBJECT" type="varchar(100)" nullable="false"/>
<column name="USER_NAME" type="varchar(100)" nullable="false"/>
</createTable>
<addPrimaryKey constraintName="IDX_ACCOUNT_FEDERATION_PK" tableName="ACCOUNT_FEDERATION" columnNames="ISSUER, SUBJECT"/>
<addForeignKeyConstraint constraintName="IDX_ACCOUNT_FEDERATION_FK0" baseTableName="ACCOUNT_FEDERATION" baseColumnNames="USER_NAME" referencedTableName="ACCOUNT" referencedColumnNames="USER_NAME"/>
</changeSet>

View File

@@ -0,0 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<changeSet>
<addColumn tableName="ACCOUNT">
<column name="DESCRIPTION" type="text" nullable="true" />
</addColumn>
</changeSet>

View File

@@ -2,7 +2,7 @@
import java.util.EnumSet
import javax.servlet._
import gitbucket.core.controller._
import gitbucket.core.controller.{ReleaseController, _}
import gitbucket.core.plugin.PluginRegistry
import gitbucket.core.service.SystemSettingsService
import gitbucket.core.servlet._
@@ -25,29 +25,33 @@ class ScalatraBootstrap extends LifeCycle with SystemSettingsService {
context.getFilterRegistration("gitAuthenticationFilter").addMappingForUrlPatterns(EnumSet.allOf(classOf[DispatcherType]), true, "/git/*")
context.addFilter("apiAuthenticationFilter", new ApiAuthenticationFilter)
context.getFilterRegistration("apiAuthenticationFilter").addMappingForUrlPatterns(EnumSet.allOf(classOf[DispatcherType]), true, "/api/v3/*")
context.addFilter("ghCompatRepositoryAccessFilter", new GHCompatRepositoryAccessFilter)
context.getFilterRegistration("ghCompatRepositoryAccessFilter").addMappingForUrlPatterns(EnumSet.allOf(classOf[DispatcherType]), true, "/*")
// Register controllers
context.mount(new AnonymousAccessController, "/*")
context.mount(new PreProcessController, "/*")
PluginRegistry().getControllers.foreach { case (controller, path) =>
context.mount(controller, path)
}
context.addFilter("pluginControllerFilter", new PluginControllerFilter)
context.getFilterRegistration("pluginControllerFilter").addMappingForUrlPatterns(EnumSet.allOf(classOf[DispatcherType]), true, "/*")
context.mount(new IndexController, "/")
context.mount(new ApiController, "/api/v3")
context.mount(new FileUploadController, "/upload")
context.mount(new SystemSettingsController, "/admin")
context.mount(new DashboardController, "/*")
context.mount(new AccountController, "/*")
context.mount(new RepositoryViewerController, "/*")
context.mount(new WikiController, "/*")
context.mount(new LabelsController, "/*")
context.mount(new MilestonesController, "/*")
context.mount(new IssuesController, "/*")
context.mount(new PullRequestsController, "/*")
context.mount(new RepositorySettingsController, "/*")
val filter = new CompositeScalatraFilter()
filter.mount(new IndexController, "/")
filter.mount(new ApiController, "/api/v3")
filter.mount(new SystemSettingsController, "/admin")
filter.mount(new DashboardController, "/*")
filter.mount(new AccountController, "/*")
filter.mount(new RepositoryViewerController, "/*")
filter.mount(new WikiController, "/*")
filter.mount(new LabelsController, "/*")
filter.mount(new PrioritiesController, "/*")
filter.mount(new MilestonesController, "/*")
filter.mount(new IssuesController, "/*")
filter.mount(new PullRequestsController, "/*")
filter.mount(new ReleaseController, "/*")
filter.mount(new RepositorySettingsController, "/*")
context.addFilter("compositeScalatraFilter", filter)
context.getFilterRegistration("compositeScalatraFilter").addMappingForUrlPatterns(EnumSet.allOf(classOf[DispatcherType]), true, "/*")
// Create GITBUCKET_HOME directory if it does not exist
val dir = new java.io.File(Directory.GitBucketHome)

View File

@@ -23,5 +23,33 @@ object GitBucketCoreModule extends Module("gitbucket-core",
new LiquibaseMigration("update/gitbucket-core_4.7.xml"),
new SqlMigration("update/gitbucket-core_4.7.sql")
),
new Version("4.7.1")
new Version("4.7.1"),
new Version("4.8"),
new Version("4.9.0",
new LiquibaseMigration("update/gitbucket-core_4.9.xml")
),
new Version("4.10.0"),
new Version("4.11.0",
new LiquibaseMigration("update/gitbucket-core_4.11.xml")
),
new Version("4.12.0"),
new Version("4.12.1"),
new Version("4.13.0"),
new Version("4.14.0",
new LiquibaseMigration("update/gitbucket-core_4.14.xml"),
new SqlMigration("update/gitbucket-core_4.14.sql")
),
new Version("4.14.1"),
new Version("4.15.0"),
new Version("4.16.0"),
new Version("4.17.0"),
new Version("4.18.0"),
new Version("4.19.0"),
new Version("4.19.1"),
new Version("4.19.2"),
new Version("4.19.3"),
new Version("4.20.0"),
new Version("4.21.0",
new LiquibaseMigration("update/gitbucket-core_4.21.xml")
)
)

View File

@@ -8,7 +8,7 @@ import gitbucket.core.util.RepositoryName
*/
case class ApiBranch(
name: String,
// commit: ApiBranchCommit,
commit: ApiBranchCommit,
protection: ApiBranchProtection)(repositoryName:RepositoryName) extends FieldSerializable {
def _links = Map(
"self" -> ApiPath(s"/api/v3/repos/${repositoryName.fullName}/branches/${name}"),

View File

@@ -35,23 +35,23 @@ case class ApiCommit(
object ApiCommit{
def apply(git: Git, repositoryName: RepositoryName, commit: CommitInfo, urlIsHtmlUrl: Boolean = false): ApiCommit = {
val diffs = JGitUtil.getDiffs(git, commit.id, false)
val diffs = JGitUtil.getDiffs(git, None, commit.id, false, false)
ApiCommit(
id = commit.id,
message = commit.fullMessage,
timestamp = commit.commitTime,
added = diffs._1.collect {
added = diffs.collect {
case x if x.changeType == DiffEntry.ChangeType.ADD => x.newPath
},
removed = diffs._1.collect {
removed = diffs.collect {
case x if x.changeType == DiffEntry.ChangeType.DELETE => x.oldPath
},
modified = diffs._1.collect {
modified = diffs.collect {
case x if x.changeType != DiffEntry.ChangeType.ADD && x.changeType != DiffEntry.ChangeType.DELETE => x.newPath
},
author = ApiPersonIdent.author(commit),
committer = ApiPersonIdent.committer(commit)
)(repositoryName, urlIsHtmlUrl)
}
def forPushPayload(git: Git, repositoryName: RepositoryName, commit: CommitInfo): ApiCommit = apply(git, repositoryName, commit, true)
def forWebhookPayload(git: Git, repositoryName: RepositoryName, commit: CommitInfo): ApiCommit = apply(git, repositoryName, commit, true)
}

View File

@@ -0,0 +1,124 @@
package gitbucket.core.api
import gitbucket.core.model.Account
import gitbucket.core.util.JGitUtil.{CommitInfo, DiffInfo}
import gitbucket.core.util.RepositoryName
import org.eclipse.jgit.diff.DiffEntry.ChangeType
import ApiCommits._
case class ApiCommits(
url: ApiPath,
sha: String,
html_url: ApiPath,
comment_url: ApiPath,
commit: Commit,
author: ApiUser,
committer: ApiUser,
parents: Seq[Tree],
stats: Stats,
files: Seq[File]
)
object ApiCommits {
case class Commit(
url: ApiPath,
author: ApiPersonIdent,
committer: ApiPersonIdent,
message: String,
comment_count: Int,
tree: Tree
)
case class Tree(
url: ApiPath,
sha: String
)
case class Stats(
additions: Int,
deletions: Int,
total: Int
)
case class File(
filename: String,
additions: Int,
deletions: Int,
changes: Int,
status: String,
raw_url: ApiPath,
blob_url: ApiPath,
patch: String
)
def apply(repositoryName: RepositoryName, commitInfo: CommitInfo, diffs: Seq[DiffInfo], author: Account, committer: Account,
commentCount: Int): ApiCommits = {
val files = diffs.map { diff =>
var additions = 0
var deletions = 0
diff.patch.getOrElse("").split("\n").foreach { line =>
if(line.startsWith("+")) additions = additions + 1
if(line.startsWith("-")) deletions = deletions + 1
}
File(
filename = if(diff.changeType == ChangeType.DELETE){ diff.oldPath } else { diff.newPath },
additions = additions,
deletions = deletions,
changes = additions + deletions,
status = diff.changeType match {
case ChangeType.ADD => "added"
case ChangeType.MODIFY => "modified"
case ChangeType.DELETE => "deleted"
case ChangeType.RENAME => "renamed"
case ChangeType.COPY => "copied"
},
raw_url = if(diff.changeType == ChangeType.DELETE){
ApiPath(s"/${repositoryName.fullName}/raw/${commitInfo.parents.head}/${diff.oldPath}")
} else {
ApiPath(s"/${repositoryName.fullName}/raw/${commitInfo.id}/${diff.newPath}")
},
blob_url = if(diff.changeType == ChangeType.DELETE){
ApiPath(s"/${repositoryName.fullName}/blob/${commitInfo.parents.head}/${diff.oldPath}")
} else {
ApiPath(s"/${repositoryName.fullName}/blob/${commitInfo.id}/${diff.newPath}")
},
patch = diff.patch.getOrElse("")
)
}
ApiCommits(
url = ApiPath(s"/api/v3/repos/${repositoryName.fullName}/commits/${commitInfo.id}"),
sha = commitInfo.id,
html_url = ApiPath(s"${repositoryName.fullName}/commit/${commitInfo.id}"),
comment_url = ApiPath(""),
commit = Commit(
url = ApiPath(s"/api/v3/repos/${repositoryName.fullName}/commits/${commitInfo.id}"),
author = ApiPersonIdent.author(commitInfo),
committer = ApiPersonIdent.committer(commitInfo),
message = commitInfo.shortMessage,
comment_count = commentCount,
tree = Tree(
url = ApiPath(s"/api/v3/repos/${repositoryName.fullName}/tree/${commitInfo.id}"), // TODO This endpoint has not been implemented yet.
sha = commitInfo.id
)
),
author = ApiUser(author),
committer = ApiUser(committer),
parents = commitInfo.parents.map { parent =>
Tree(
url = ApiPath(s"/api/v3/repos/${repositoryName.fullName}/tree/${parent}"), // TODO This endpoint has not been implemented yet.
sha = parent
)
},
stats = Stats(
additions = files.map(_.additions).sum,
deletions = files.map(_.deletions).sum,
total = files.map(_.additions).sum + files.map(_.deletions).sum
),
files = files
)
}
}

View File

@@ -1,18 +1,28 @@
package gitbucket.core.api
import gitbucket.core.util.JGitUtil.FileInfo
import org.apache.commons.codec.binary.Base64
import java.util.Base64
case class ApiContents(`type`: String, name: String, content: Option[String], encoding: Option[String])
import gitbucket.core.util.JGitUtil.FileInfo
import gitbucket.core.util.RepositoryName
case class ApiContents(
`type`: String,
name: String,
path: String,
sha: String,
content: Option[String],
encoding: Option[String])(repositoryName: RepositoryName){
val download_url = ApiPath(s"/api/v3/repos/${repositoryName.fullName}/raw/${sha}/${path}")
}
object ApiContents{
def apply(fileInfo: FileInfo, content: Option[Array[Byte]]): ApiContents = {
def apply(fileInfo: FileInfo, repositoryName: RepositoryName, content: Option[Array[Byte]]): ApiContents = {
if(fileInfo.isDirectory) {
ApiContents("dir", fileInfo.name, None, None)
ApiContents("dir", fileInfo.name, fileInfo.path, fileInfo.commitId, None, None)(repositoryName)
} else {
content.map(arr =>
ApiContents("file", fileInfo.name, Some(Base64.encodeBase64String(arr)), Some("base64"))
).getOrElse(ApiContents("file", fileInfo.name, None, None))
ApiContents("file", fileInfo.name, fileInfo.path, fileInfo.commitId, Some(Base64.getEncoder.encodeToString(arr)), Some("base64"))(repositoryName)
).getOrElse(ApiContents("file", fileInfo.name, fileInfo.path, fileInfo.commitId, None, None)(repositoryName))
}
}
}

View File

@@ -1,6 +1,13 @@
package gitbucket.core.api
/**
* path for api url. if set path '/repos/aa/bb' then, expand 'http://server:post/repos/aa/bb' when converted to json.
* Path for API url.
* If set path '/repos/aa/bb' then, expand 'http://server:port/repos/aa/bb' when converted to json.
*/
case class ApiPath(path: String)
/**
* Path for git repository via SSH.
* If set path '/aa/bb.git' then, expand 'git@server:port/aa/bb.git' when converted to json.
*/
case class SshPath(path: String)

View File

@@ -1,23 +1,26 @@
package gitbucket.core.api
import gitbucket.core.model.{Issue, PullRequest}
import gitbucket.core.model.{Account, Issue, IssueComment, PullRequest}
import java.util.Date
/**
* https://developer.github.com/v3/pulls/
*/
case class ApiPullRequest(
number: Int,
state: String,
updated_at: Date,
created_at: Date,
head: ApiPullRequest.Commit,
base: ApiPullRequest.Commit,
mergeable: Option[Boolean],
merged: Boolean,
merged_at: Option[Date],
merged_by: Option[ApiUser],
title: String,
body: String,
user: ApiUser) {
user: ApiUser,
assignee: Option[ApiUser]){
val html_url = ApiPath(s"${base.repo.html_url.path}/pull/${number}")
//val diff_url = ApiPath(s"${base.repo.html_url.path}/pull/${number}.diff")
//val patch_url = ApiPath(s"${base.repo.html_url.path}/pull/${number}.patch")
@@ -31,9 +34,18 @@ case class ApiPullRequest(
}
object ApiPullRequest{
def apply(issue: Issue, pullRequest: PullRequest, headRepo: ApiRepository, baseRepo: ApiRepository, user: ApiUser): ApiPullRequest =
def apply(
issue: Issue,
pullRequest: PullRequest,
headRepo: ApiRepository,
baseRepo: ApiRepository,
user: ApiUser,
assignee: Option[ApiUser],
mergedComment: Option[(IssueComment, Account)]
): ApiPullRequest =
ApiPullRequest(
number = issue.issueId,
state = if (issue.closed) "closed" else "open",
updated_at = issue.updatedDate,
created_at = issue.registeredDate,
head = Commit(
@@ -45,16 +57,21 @@ object ApiPullRequest{
ref = pullRequest.branch,
repo = baseRepo)(issue.userName),
mergeable = None, // TODO: need check mergeable.
merged = mergedComment.isDefined,
merged_at = mergedComment.map { case (comment, _) => comment.registeredDate },
merged_by = mergedComment.map { case (_, account) => ApiUser(account) },
title = issue.title,
body = issue.content.getOrElse(""),
user = user
user = user,
assignee = assignee
)
case class Commit(
sha: String,
ref: String,
repo: ApiRepository)(baseOwner:String){
val label = if( baseOwner == repo.owner.login ){ ref }else{ s"${repo.owner.login}:${ref}" }
val label = if( baseOwner == repo.owner.login ){ ref } else { s"${repo.owner.login}:${ref}" }
val user = repo.owner
}
}

View File

@@ -24,6 +24,7 @@ case class ApiRepository(
val http_url = ApiPath(s"/git/${full_name}.git")
val clone_url = ApiPath(s"/git/${full_name}.git")
val html_url = ApiPath(s"/${full_name}")
val ssh_url = Some(SshPath(s":${full_name}.git"))
}
object ApiRepository{
@@ -37,7 +38,7 @@ object ApiRepository{
name = repository.repositoryName,
full_name = s"${repository.userName}/${repository.repositoryName}",
description = repository.description.getOrElse(""),
watchers = 0,
watchers = watchers,
forks = forkedCount,
`private` = repository.isPrivate,
default_branch = repository.defaultBranch,
@@ -50,7 +51,18 @@ object ApiRepository{
def apply(repositoryInfo: RepositoryInfo, owner: Account): ApiRepository =
this(repositoryInfo.repository, ApiUser(owner))
def forPushPayload(repositoryInfo: RepositoryInfo, owner: ApiUser): ApiRepository =
def forWebhookPayload(repositoryInfo: RepositoryInfo, owner: ApiUser): ApiRepository =
ApiRepository(repositoryInfo.repository, owner, forkedCount=repositoryInfo.forkedCount, urlIsHtmlUrl=true)
def forDummyPayload(owner: ApiUser): ApiRepository =
ApiRepository(
name = "dummy",
full_name = s"${owner.login}/dummy",
description = "",
watchers = 0,
forks = 0,
`private` = false,
default_branch = "master",
owner = owner
)(true)
}

View File

@@ -19,8 +19,8 @@ case class CreateAStatus(
def isValid: Boolean = {
CommitState.valueOf(state).isDefined &&
// only http
target_url.filterNot(f => "\\Ahttps?://".r.findPrefixOf(f).isDefined && f.length<255).isEmpty &&
context.filterNot(f => f.length<255).isEmpty &&
description.filterNot(f => f.length<1000).isEmpty
target_url.forall(f => "\\Ahttps?://".r.findPrefixOf(f).isDefined && f.length < 255) &&
context.forall(f => f.length < 255) &&
description.forall(f => f.length < 1000)
}
}

View File

@@ -0,0 +1,11 @@
package gitbucket.core.api
/**
* https://developer.github.com/v3/issues/#create-an-issue
*/
case class CreateAnIssue(
title: String,
body: Option[String],
assignees: List[String],
milestone: Option[Int],
labels: List[String])

View File

@@ -1,23 +1,24 @@
package gitbucket.core.api
import org.joda.time.DateTime
import org.joda.time.DateTimeZone
import org.joda.time.format._
import java.time._
import java.time.format.DateTimeFormatter
import java.util.Date
import scala.util.Try
import org.json4s._
import org.json4s.jackson.Serialization
import java.util.Date
import scala.util.Try
object JsonFormat {
case class Context(baseUrl: String)
case class Context(baseUrl: String, sshUrl: Option[String])
val parserISO = DateTimeFormat.forPattern("yyyy-MM-dd'T'HH:mm:ss'Z'")
val parserISO = DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss'Z'")
val jsonFormats = Serialization.formats(NoTypeHints) + new CustomSerializer[Date](format =>
(
{ case JString(s) => Try(parserISO.parseDateTime(s)).toOption.map(_.toDate).getOrElse(throw new MappingException("Can't convert " + s + " to Date")) },
{ case x: Date => JString(parserISO.print(new DateTime(x).withZone(DateTimeZone.UTC))) }
{ case JString(s) => Try(Date.from(Instant.parse(s))).getOrElse(throw new MappingException("Can't convert " + s + " to Date")) },
{ case x: Date => JString(OffsetDateTime.ofInstant(x.toInstant, ZoneId.of("UTC")).format(parserISO)) }
)
) + FieldSerializer[ApiUser]() +
FieldSerializer[ApiPullRequest]() +
@@ -31,24 +32,33 @@ object JsonFormat {
FieldSerializer[ApiPullRequest.Commit]() +
FieldSerializer[ApiIssue]() +
FieldSerializer[ApiComment]() +
FieldSerializer[ApiContents]() +
FieldSerializer[ApiLabel]() +
FieldSerializer[ApiCommits]() +
FieldSerializer[ApiCommits.Commit]() +
FieldSerializer[ApiCommits.Tree]() +
FieldSerializer[ApiCommits.Stats]() +
FieldSerializer[ApiCommits.File]() +
ApiBranchProtection.enforcementLevelSerializer
def apiPathSerializer(c: Context) = new CustomSerializer[ApiPath](format =>
(
{
case JString(s) if s.startsWith(c.baseUrl) => ApiPath(s.substring(c.baseUrl.length))
case JString(s) => throw new MappingException("Can't convert " + s + " to ApiPath")
},
{
case ApiPath(path) => JString(c.baseUrl + path)
}
)
)
def apiPathSerializer(c: Context) = new CustomSerializer[ApiPath](_ => ({
case JString(s) if s.startsWith(c.baseUrl) => ApiPath(s.substring(c.baseUrl.length))
case JString(s) => throw new MappingException("Can't convert " + s + " to ApiPath")
}, {
case ApiPath(path) => JString(c.baseUrl + path)
}))
def sshPathSerializer(c: Context) = new CustomSerializer[SshPath](_ => ({
case JString(s) if c.sshUrl.exists(sshUrl => s.startsWith(sshUrl)) => SshPath(s.substring(c.sshUrl.get.length))
case JString(s) => throw new MappingException("Can't convert " + s + " to ApiPath")
}, {
case SshPath(path) => c.sshUrl.map { sshUrl => JString(sshUrl + path) } getOrElse JNothing
}))
/**
* convert object to json string
*/
def apply(obj: AnyRef)(implicit c: Context): String = Serialization.write(obj)(jsonFormats + apiPathSerializer(c))
def apply(obj: AnyRef)(implicit c: Context): String =
Serialization.write(obj)(jsonFormats + apiPathSerializer(c) + sshPathSerializer(c))
}

View File

@@ -2,37 +2,36 @@ package gitbucket.core.controller
import gitbucket.core.account.html
import gitbucket.core.helper
import gitbucket.core.model.GroupMember
import gitbucket.core.model.{AccountWebHook, GroupMember, RepositoryWebHook, Role, WebHook, WebHookContentType}
import gitbucket.core.plugin.PluginRegistry
import gitbucket.core.service._
import gitbucket.core.service.WebHookService._
import gitbucket.core.ssh.SshUtil
import gitbucket.core.util.ControlUtil._
import gitbucket.core.util.SyntaxSugars._
import gitbucket.core.util.Directory._
import gitbucket.core.util.Implicits._
import gitbucket.core.util.StringUtil._
import gitbucket.core.util._
import io.github.gitbucket.scalatra.forms._
import org.apache.commons.io.FileUtils
import org.scalatra.i18n.Messages
import org.scalatra.BadRequest
import org.scalatra.forms._
class AccountController extends AccountControllerBase
with AccountService with RepositoryService with ActivityService with WikiService with LabelsService with SshKeyService
with OneselfAuthenticator with UsersAuthenticator with GroupManagerAuthenticator with ReadableUsersAuthenticator
with AccessTokenService with WebHookService with RepositoryCreationService
with AccessTokenService with WebHookService with PrioritiesService with RepositoryCreationService
trait AccountControllerBase extends AccountManagementControllerBase {
self: AccountService with RepositoryService with ActivityService with WikiService with LabelsService with SshKeyService
with OneselfAuthenticator with UsersAuthenticator with GroupManagerAuthenticator with ReadableUsersAuthenticator
with AccessTokenService with WebHookService with RepositoryCreationService =>
with AccessTokenService with WebHookService with PrioritiesService with RepositoryCreationService =>
case class AccountNewForm(userName: String, password: String, fullName: String, mailAddress: String,
url: Option[String], fileId: Option[String])
description: Option[String], url: Option[String], fileId: Option[String])
case class AccountEditForm(password: Option[String], fullName: String, mailAddress: String,
url: Option[String], fileId: Option[String], clearImage: Boolean)
description: Option[String], url: Option[String], fileId: Option[String], clearImage: Boolean)
case class SshKeyForm(title: String, publicKey: String)
@@ -40,17 +39,19 @@ trait AccountControllerBase extends AccountManagementControllerBase {
val newForm = mapping(
"userName" -> trim(label("User name" , text(required, maxlength(100), identifier, uniqueUserName, reservedNames))),
"password" -> trim(label("Password" , text(required, maxlength(20)))),
"password" -> trim(label("Password" , text(required, maxlength(20), password))),
"fullName" -> trim(label("Full Name" , text(required, maxlength(100)))),
"mailAddress" -> trim(label("Mail Address" , text(required, maxlength(100), uniqueMailAddress()))),
"description" -> trim(label("bio" , optional(text()))),
"url" -> trim(label("URL" , optional(text(maxlength(200))))),
"fileId" -> trim(label("File ID" , optional(text())))
)(AccountNewForm.apply)
val editForm = mapping(
"password" -> trim(label("Password" , optional(text(maxlength(20))))),
"password" -> trim(label("Password" , optional(text(maxlength(20), password)))),
"fullName" -> trim(label("Full Name" , text(required, maxlength(100)))),
"mailAddress" -> trim(label("Mail Address" , text(required, maxlength(100), uniqueMailAddress("userName")))),
"description" -> trim(label("bio" , optional(text()))),
"url" -> trim(label("URL" , optional(text(maxlength(200))))),
"fileId" -> trim(label("File ID" , optional(text()))),
"clearImage" -> trim(label("Clear image" , boolean()))
@@ -58,40 +59,43 @@ trait AccountControllerBase extends AccountManagementControllerBase {
val sshKeyForm = mapping(
"title" -> trim(label("Title", text(required, maxlength(100)))),
"publicKey" -> trim(label("Key" , text(required, validPublicKey)))
"publicKey" -> trim2(label("Key" , text(required, validPublicKey)))
)(SshKeyForm.apply)
val personalTokenForm = mapping(
"note" -> trim(label("Token", text(required, maxlength(100))))
"note" -> trim(label("Token", text(required, maxlength(100))))
)(PersonalTokenForm.apply)
case class NewGroupForm(groupName: String, url: Option[String], fileId: Option[String], members: String)
case class EditGroupForm(groupName: String, url: Option[String], fileId: Option[String], members: String, clearImage: Boolean)
case class NewGroupForm(groupName: String, description: Option[String], url: Option[String], fileId: Option[String], members: String)
case class EditGroupForm(groupName: String, description: Option[String], url: Option[String], fileId: Option[String], members: String, clearImage: Boolean)
val newGroupForm = mapping(
"groupName" -> trim(label("Group name" ,text(required, maxlength(100), identifier, uniqueUserName, reservedNames))),
"url" -> trim(label("URL" ,optional(text(maxlength(200))))),
"fileId" -> trim(label("File ID" ,optional(text()))),
"members" -> trim(label("Members" ,text(required, members)))
"groupName" -> trim(label("Group name" ,text(required, maxlength(100), identifier, uniqueUserName, reservedNames))),
"description" -> trim(label("Group description", optional(text()))),
"url" -> trim(label("URL" ,optional(text(maxlength(200))))),
"fileId" -> trim(label("File ID" ,optional(text()))),
"members" -> trim(label("Members" ,text(required, members)))
)(NewGroupForm.apply)
val editGroupForm = mapping(
"groupName" -> trim(label("Group name" ,text(required, maxlength(100), identifier))),
"url" -> trim(label("URL" ,optional(text(maxlength(200))))),
"fileId" -> trim(label("File ID" ,optional(text()))),
"members" -> trim(label("Members" ,text(required, members))),
"clearImage" -> trim(label("Clear image" ,boolean()))
"groupName" -> trim(label("Group name" ,text(required, maxlength(100), identifier))),
"description" -> trim(label("Group description", optional(text()))),
"url" -> trim(label("URL" ,optional(text(maxlength(200))))),
"fileId" -> trim(label("File ID" ,optional(text()))),
"members" -> trim(label("Members" ,text(required, members))),
"clearImage" -> trim(label("Clear image" ,boolean()))
)(EditGroupForm.apply)
case class RepositoryCreationForm(owner: String, name: String, description: Option[String], isPrivate: Boolean, createReadme: Boolean)
case class RepositoryCreationForm(owner: String, name: String, description: Option[String], isPrivate: Boolean, initOption: String, sourceUrl: Option[String])
case class ForkRepositoryForm(owner: String, name: String)
val newRepositoryForm = mapping(
"owner" -> trim(label("Owner" , text(required, maxlength(100), identifier, existsAccount))),
"name" -> trim(label("Repository name", text(required, maxlength(100), repository, uniqueRepository))),
"description" -> trim(label("Description" , optional(text()))),
"isPrivate" -> trim(label("Repository Type", boolean())),
"createReadme" -> trim(label("Create README" , boolean()))
"owner" -> trim(label("Owner", text(required, maxlength(100), identifier, existsAccount))),
"name" -> trim(label("Repository name", text(required, maxlength(100), repository, uniqueRepository))),
"description" -> trim(label("Description", optional(text()))),
"isPrivate" -> trim(label("Repository Type", boolean())),
"initOption" -> trim(label("Initialize option", text(required))),
"sourceUrl" -> trim(label("Source URL", optionalRequired(_.value("initOption") == "COPY", text())))
)(RepositoryCreationForm.apply)
val forkRepositoryForm = mapping(
@@ -105,6 +109,48 @@ trait AccountControllerBase extends AccountManagementControllerBase {
"account" -> trim(label("Group/User name", text(required, validAccountName)))
)(AccountForm.apply)
// for account web hook url addition.
case class AccountWebHookForm(url: String, events: Set[WebHook.Event], ctype: WebHookContentType, token: Option[String])
def accountWebHookForm(update:Boolean) = mapping(
"url" -> trim(label("url", text(required, accountWebHook(update)))),
"events" -> accountWebhookEvents,
"ctype" -> label("ctype", text()),
"token" -> optional(trim(label("token", text(maxlength(100)))))
)(
(url, events, ctype, token) => AccountWebHookForm(url, events, WebHookContentType.valueOf(ctype), token)
)
/**
* Provides duplication check for web hook url. duplicated from RepositorySettingsController.scala
*/
private def accountWebHook(needExists: Boolean): Constraint = new Constraint(){
override def validate(name: String, value: String, messages: Messages): Option[String] =
if(getAccountWebHook(params("userName"), value).isDefined != needExists){
Some(if(needExists){
"URL had not been registered yet."
} else {
"URL had been registered already."
})
} else {
None
}
}
private def accountWebhookEvents = new ValueType[Set[WebHook.Event]]{
def convert(name: String, params: Map[String, Seq[String]], messages: Messages): Set[WebHook.Event] = {
WebHook.Event.values.flatMap { t =>
params.optionValue(name + "." + t.name).map(_ => t)
}.toSet
}
def validate(name: String, params: Map[String, Seq[String]], messages: Messages): Seq[(String, String)] =
if(convert(name, params, messages).isEmpty){
Seq(name -> messages("error.required").format(name))
} else {
Nil
}
}
/**
* Displays user information.
*/
@@ -145,10 +191,20 @@ trait AccountControllerBase extends AccountManagementControllerBase {
get("/:userName/_avatar"){
val userName = params("userName")
getAccountByUserName(userName).flatMap(_.image).map { image =>
RawData(FileUtil.getMimeType(image), new java.io.File(getUserUploadDir(userName), image))
} getOrElse {
contentType = "image/png"
contentType = "image/png"
getAccountByUserName(userName).flatMap{ account =>
response.setDateHeader("Last-Modified", account.updatedDate.getTime)
account.image.map{ image =>
Some(RawData(FileUtil.getMimeType(image), new java.io.File(getUserUploadDir(userName), image)))
}.getOrElse{
if (account.isGroupAccount) {
TextAvatarUtil.textGroupAvatar(account.fullName)
} else {
TextAvatarUtil.textAvatar(account.fullName)
}
}
}.getOrElse{
response.setHeader("Cache-Control", "max-age=3600")
Thread.currentThread.getContextClassLoader.getResourceAsStream("noimage.png")
}
}
@@ -167,6 +223,7 @@ trait AccountControllerBase extends AccountManagementControllerBase {
password = form.password.map(sha1).getOrElse(account.password),
fullName = form.fullName,
mailAddress = form.mailAddress,
description = form.description,
url = form.url))
updateImage(userName, form.fileId, form.clearImage)
@@ -176,6 +233,10 @@ trait AccountControllerBase extends AccountManagementControllerBase {
} getOrElse NotFound()
})
get("/captures/(.*)".r) {
multiParams("captures").head
}
get("/:userName/_delete")(oneselfOnly {
val userName = params("userName")
@@ -191,9 +252,13 @@ trait AccountControllerBase extends AccountManagementControllerBase {
// FileUtils.deleteDirectory(getWikiRepositoryDir(userName, repositoryName))
// FileUtils.deleteDirectory(getTemporaryDir(userName, repositoryName))
// }
// // Remove from GROUP_MEMBER, COLLABORATOR and REPOSITORY
// Remove from GROUP_MEMBER and COLLABORATOR
removeUserRelatedData(userName)
updateAccount(account.copy(isRemoved = true))
// call hooks
PluginRegistry().getAccountHooks.foreach(_.deleted(userName))
session.invalidate
redirect("/")
}
@@ -254,6 +319,113 @@ trait AccountControllerBase extends AccountManagementControllerBase {
redirect(s"/${userName}/_application")
})
get("/:userName/_hooks")(oneselfOnly {
val userName = params("userName")
getAccountByUserName(userName).map { account =>
gitbucket.core.account.html.hooks(account, getAccountWebHooks(account.userName), flash.get("info"))
} getOrElse NotFound()
})
/**
* Display the account web hook edit page.
*/
get("/:userName/_hooks/new")(oneselfOnly {
val userName = params("userName")
getAccountByUserName(userName).map { account =>
val webhook = AccountWebHook(userName, "", WebHookContentType.FORM, None)
html.edithook(webhook, Set(WebHook.Push), account, true)
} getOrElse NotFound()
})
/**
* Add the account web hook URL.
*/
post("/:userName/_hooks/new", accountWebHookForm(false))(oneselfOnly { form =>
val userName = params("userName")
addAccountWebHook(userName, form.url, form.events, form.ctype, form.token)
flash += "info" -> s"Webhook ${form.url} created"
redirect(s"/${userName}/_hooks")
})
/**
* Delete the account web hook URL.
*/
get("/:userName/_hooks/delete")(oneselfOnly {
val userName = params("userName")
deleteAccountWebHook(userName, params("url"))
flash += "info" -> s"Webhook ${params("url")} deleted"
redirect(s"/${userName}/_hooks")
})
/**
* Display the account web hook edit page.
*/
get("/:userName/_hooks/edit")(oneselfOnly {
val userName = params("userName")
getAccountByUserName(userName).flatMap { account =>
getAccountWebHook(userName, params("url")).map { case (webhook, events) =>
html.edithook(webhook, events, account, false)
}
} getOrElse NotFound()
})
/**
* Update account web hook settings.
*/
post("/:userName/_hooks/edit", accountWebHookForm(true))(oneselfOnly { form =>
val userName = params("userName")
updateAccountWebHook(userName, form.url, form.events, form.ctype, form.token)
flash += "info" -> s"webhook ${form.url} updated"
redirect(s"/${userName}/_hooks")
})
/**
* Send the test request to registered account web hook URLs.
*/
ajaxPost("/:userName/_hooks/test")(oneselfOnly {
// TODO Is it possible to merge with [[RepositorySettingsController.ajaxPost]]?
import scala.concurrent.duration._
import scala.concurrent._
import scala.util.control.NonFatal
import org.apache.http.util.EntityUtils
import scala.concurrent.ExecutionContext.Implicits.global
def _headers(h: Array[org.apache.http.Header]): Array[Array[String]] = h.map { h => Array(h.getName, h.getValue) }
val userName = params("userName")
val url = params("url")
val token = Some(params("token"))
val ctype = WebHookContentType.valueOf(params("ctype"))
val dummyWebHookInfo = RepositoryWebHook(userName, "dummy", url, ctype, token)
val dummyPayload = {
val ownerAccount = getAccountByUserName(userName).get
WebHookPushPayload.createDummyPayload(ownerAccount)
}
val (webHook, json, reqFuture, resFuture) = callWebHook(WebHook.Push, List(dummyWebHookInfo), dummyPayload).head
val toErrorMap: PartialFunction[Throwable, Map[String,String]] = {
case e: java.net.UnknownHostException => Map("error"-> ("Unknown host " + e.getMessage))
case e: java.lang.IllegalArgumentException => Map("error"-> ("invalid url"))
case e: org.apache.http.client.ClientProtocolException => Map("error"-> ("invalid url"))
case NonFatal(e) => Map("error"-> (e.getClass + " "+ e.getMessage))
}
contentType = formats("json")
org.json4s.jackson.Serialization.write(Map(
"url" -> url,
"request" -> Await.result(reqFuture.map(req => Map(
"headers" -> _headers(req.getAllHeaders),
"payload" -> json
)).recover(toErrorMap), 20 seconds),
"response" -> Await.result(resFuture.map(res => Map(
"status" -> res.getStatusLine(),
"body" -> EntityUtils.toString(res.getEntity()),
"headers" -> _headers(res.getAllHeaders())
)).recover(toErrorMap), 20 seconds)
))
})
get("/register"){
if(context.settings.allowAccountRegistration){
if(context.loginAccount.isDefined){
@@ -266,18 +438,18 @@ trait AccountControllerBase extends AccountManagementControllerBase {
post("/register", newForm){ form =>
if(context.settings.allowAccountRegistration){
createAccount(form.userName, sha1(form.password), form.fullName, form.mailAddress, false, form.url)
createAccount(form.userName, sha1(form.password), form.fullName, form.mailAddress, false, form.description, form.url)
updateImage(form.userName, form.fileId, false)
redirect("/signin")
} else NotFound()
}
get("/groups/new")(usersOnly {
html.group(None, List(GroupMember("", context.loginAccount.get.userName, true)))
html.creategroup(List(GroupMember("", context.loginAccount.get.userName, true)))
})
post("/groups/new", newGroupForm)(usersOnly { form =>
createGroup(form.groupName, form.url)
createGroup(form.groupName, form.description, form.url)
updateGroupMembers(form.groupName, form.members.split(",").map {
_.split(":") match {
case Array(userName, isManager) => (userName, isManager.toBoolean)
@@ -289,7 +461,9 @@ trait AccountControllerBase extends AccountManagementControllerBase {
get("/:groupName/_editgroup")(managersOnly {
defining(params("groupName")){ groupName =>
html.group(getAccountByUserName(groupName, true), getGroupMembers(groupName))
getAccountByUserName(groupName, true).map { account =>
html.editgroup(account, getGroupMembers(groupName), flash.get("info"))
} getOrElse NotFound()
}
})
@@ -297,13 +471,17 @@ trait AccountControllerBase extends AccountManagementControllerBase {
defining(params("groupName")){ groupName =>
// Remove from GROUP_MEMBER
updateGroupMembers(groupName, Nil)
// Remove repositories
getRepositoryNamesOfUser(groupName).foreach { repositoryName =>
deleteRepository(groupName, repositoryName)
FileUtils.deleteDirectory(getRepositoryDir(groupName, repositoryName))
FileUtils.deleteDirectory(getWikiRepositoryDir(groupName, repositoryName))
FileUtils.deleteDirectory(getTemporaryDir(groupName, repositoryName))
// Disable group
getAccountByUserName(groupName, false).foreach { account =>
updateGroup(groupName, account.description, account.url, true)
}
// // Remove repositories
// getRepositoryNamesOfUser(groupName).foreach { repositoryName =>
// deleteRepository(groupName, repositoryName)
// FileUtils.deleteDirectory(getRepositoryDir(groupName, repositoryName))
// FileUtils.deleteDirectory(getWikiRepositoryDir(groupName, repositoryName))
// FileUtils.deleteDirectory(getTemporaryDir(groupName, repositoryName))
// }
}
redirect("/")
})
@@ -315,7 +493,7 @@ trait AccountControllerBase extends AccountManagementControllerBase {
}
}.toList){ case (groupName, members) =>
getAccountByUserName(groupName, true).map { account =>
updateGroup(groupName, form.url, false)
updateGroup(groupName, form.description, form.url, false)
// Update GROUP_MEMBER
updateGroupMembers(form.groupName, members)
@@ -328,7 +506,9 @@ trait AccountControllerBase extends AccountManagementControllerBase {
// }
updateImage(form.groupName, form.fileId, form.clearImage)
redirect(s"/${form.groupName}")
flash += "info" -> "Account information has been updated."
redirect(s"/${groupName}/_editgroup")
} getOrElse NotFound()
}
@@ -347,12 +527,12 @@ trait AccountControllerBase extends AccountManagementControllerBase {
post("/new", newRepositoryForm)(usersOnly { form =>
LockUtil.lock(s"${form.owner}/${form.name}"){
if(getRepository(form.owner, form.name).isEmpty){
createRepository(context.loginAccount.get, form.owner, form.name, form.description, form.isPrivate, form.createReadme)
createRepository(context.loginAccount.get, form.owner, form.name, form.description, form.isPrivate, form.initOption, form.sourceUrl)
}
// redirect to the repository
redirect(s"/${form.owner}/${form.name}")
}
// redirect to the repository
redirect(s"/${form.owner}/${form.name}")
})
get("/:owner/:repository/fork")(readableUsersOnly { repository =>
@@ -381,53 +561,15 @@ trait AccountControllerBase extends AccountManagementControllerBase {
val loginUserName = loginAccount.userName
val accountName = form.accountName
LockUtil.lock(s"${accountName}/${repository.name}"){
if(getRepository(accountName, repository.name).isDefined ||
(accountName != loginUserName && !getGroupsByUserName(loginUserName).contains(accountName))){
// redirect to the repository if repository already exists
redirect(s"/${accountName}/${repository.name}")
} else {
// Insert to the database at first
val originUserName = repository.repository.originUserName.getOrElse(repository.owner)
val originRepositoryName = repository.repository.originRepositoryName.getOrElse(repository.name)
insertRepository(
repositoryName = repository.name,
userName = accountName,
description = repository.repository.description,
isPrivate = repository.repository.isPrivate,
originRepositoryName = Some(originRepositoryName),
originUserName = Some(originUserName),
parentRepositoryName = Some(repository.name),
parentUserName = Some(repository.owner)
)
// // Add collaborators for group repository
// val ownerAccount = getAccountByUserName(accountName).get
// if(ownerAccount.isGroupAccount){
// getGroupMembers(accountName).foreach { member =>
// addCollaborator(accountName, repository.name, member.userName)
// }
// }
// Insert default labels
insertDefaultLabels(accountName, repository.name)
// clone repository actually
JGitUtil.cloneRepository(
getRepositoryDir(repository.owner, repository.name),
getRepositoryDir(accountName, repository.name))
// Create Wiki repository
JGitUtil.cloneRepository(
getWikiRepositoryDir(repository.owner, repository.name),
getWikiRepositoryDir(accountName, repository.name))
// Record activity
recordForkActivity(repository.owner, repository.name, loginUserName, accountName)
// redirect to the repository
redirect(s"/${accountName}/${repository.name}")
}
if (getRepository(accountName, repository.name).isDefined ||
(accountName != loginUserName && !getGroupsByUserName(loginUserName).contains(accountName))) {
// redirect to the repository if repository already exists
redirect(s"/${accountName}/${repository.name}")
} else {
// fork repository asynchronously
forkRepository(accountName, repository, loginUserName)
// redirect to the repository
redirect(s"/${accountName}/${repository.name}")
}
} else BadRequest()
})
@@ -438,10 +580,14 @@ trait AccountControllerBase extends AccountManagementControllerBase {
}
private def uniqueRepository: Constraint = new Constraint(){
override def validate(name: String, value: String, params: Map[String, String], messages: Messages): Option[String] =
params.get("owner").flatMap { userName =>
getRepositoryNamesOfUser(userName).find(_ == value).map(_ => "Repository already exists.")
override def validate(name: String, value: String, params: Map[String, Seq[String]], messages: Messages): Option[String] = {
for {
userName <- params.optionValue("owner")
_ <- getRepositoryNamesOfUser(userName).find(_ == value)
} yield {
"Repository already exists."
}
}
}
private def members: Constraint = new Constraint(){

View File

@@ -1,14 +0,0 @@
package gitbucket.core.controller
class AnonymousAccessController extends AnonymousAccessControllerBase
trait AnonymousAccessControllerBase extends ControllerBase {
get(!context.settings.allowAnonymousAccess, context.loginAccount.isEmpty) {
if(!context.currentPath.startsWith("/assets") && !context.currentPath.startsWith("/signin") &&
!context.currentPath.startsWith("/register")) {
Unauthorized()
} else {
pass()
}
}
}

View File

@@ -5,15 +5,19 @@ import gitbucket.core.model._
import gitbucket.core.service.IssuesService.IssueSearchCondition
import gitbucket.core.service.PullRequestService._
import gitbucket.core.service._
import gitbucket.core.util.ControlUtil._
import gitbucket.core.util.Directory._
import gitbucket.core.util.JGitUtil._
import gitbucket.core.util._
import gitbucket.core.util.Implicits._
import gitbucket.core.view.helpers.{renderMarkup, isRenderable}
import gitbucket.core.util.JGitUtil._
import gitbucket.core.util.SyntaxSugars._
import gitbucket.core.util._
import gitbucket.core.view.helpers.{isRenderable, renderMarkup}
import org.eclipse.jgit.api.Git
import org.scalatra.{NoContent, UnprocessableEntity, Created}
import org.eclipse.jgit.revwalk.RevWalk
import org.scalatra.{Created, NoContent, UnprocessableEntity}
import scala.collection.JavaConverters._
import scala.concurrent.Await
import scala.concurrent.duration.Duration
class ApiController extends ApiControllerBase
with RepositoryService
@@ -21,15 +25,19 @@ class ApiController extends ApiControllerBase
with ProtectedBranchService
with IssuesService
with LabelsService
with MilestonesService
with PullRequestService
with CommitsService
with CommitStatusService
with RepositoryCreationService
with IssueCreationService
with HandleCommentService
with WebHookService
with WebHookPullRequestService
with WebHookIssueCommentService
with WikiService
with ActivityService
with PrioritiesService
with OwnerAuthenticator
with UsersAuthenticator
with GroupManagerAuthenticator
@@ -43,10 +51,14 @@ trait ApiControllerBase extends ControllerBase {
with ProtectedBranchService
with IssuesService
with LabelsService
with MilestonesService
with PullRequestService
with CommitsService
with CommitStatusService
with RepositoryCreationService
with IssueCreationService
with HandleCommentService
with PrioritiesService
with OwnerAuthenticator
with UsersAuthenticator
with GroupManagerAuthenticator
@@ -54,6 +66,13 @@ trait ApiControllerBase extends ControllerBase {
with ReadableUsersAuthenticator
with WritableUsersAuthenticator =>
/**
* 404 for non-implemented api
*/
get("/api/v3/*") {
NotFound()
}
/**
* https://developer.github.com/v3/#root-endpoint
*/
@@ -72,9 +91,10 @@ trait ApiControllerBase extends ControllerBase {
/**
* https://developer.github.com/v3/users/#get-a-single-user
* This API also returns group information (as GitHub).
*/
get("/api/v3/users/:userName") {
getAccountByUserName(params("userName")).filterNot(account => account.isGroupAccount).map { account =>
getAccountByUserName(params("userName")).map { account =>
JsonFormat(ApiUser(account))
} getOrElse NotFound()
}
@@ -102,10 +122,24 @@ trait ApiControllerBase extends ControllerBase {
defaultBranch = repository.repository.defaultBranch,
origin = repository.repository.originUserName.isEmpty
).map { br =>
ApiBranchForList(br.name, ApiBranchCommit(br.commitId))
ApiBranchForList(br.name, ApiBranchCommit(br.commitId))
})
})
/**
* https://developer.github.com/v3/repos/branches/#get-branch
*/
get ("/api/v3/repos/:owner/:repo/branches/*")(referrersOnly { repository =>
//import gitbucket.core.api._
(for{
branch <- params.get("splat") if repository.branchList.contains(branch)
br <- getBranches(repository.owner, repository.name, repository.repository.defaultBranch, repository.repository.originUserName.isEmpty).find(_.name == branch)
} yield {
val protection = getProtectedBranchInfo(repository.owner, repository.name, branch)
JsonFormat(ApiBranch(branch, ApiBranchCommit(br.commitId), ApiBranchProtection(protection))(RepositoryName(repository)))
}) getOrElse NotFound()
})
/*
* https://developer.github.com/v3/repos/contents/#get-contents
*/
@@ -132,9 +166,12 @@ trait ApiControllerBase extends ControllerBase {
val largeFile = params.get("large_file").exists(s => s.equals("true"))
val content = getContentFromId(git, f.id, largeFile)
request.getHeader("Accept") match {
case "application/vnd.github.v3.raw" =>
case "application/vnd.github.v3.raw" => {
contentType = "application/vnd.github.v3.raw"
content
case "application/vnd.github.v3.html" if isRenderable(f.name) =>
}
case "application/vnd.github.v3.html" if isRenderable(f.name) => {
contentType = "application/vnd.github.v3.html"
content.map(c =>
List(
"<div data-path=\"", path, "\" id=\"file\">", "<article>",
@@ -142,7 +179,9 @@ trait ApiControllerBase extends ControllerBase {
"</article>", "</div>"
).mkString
)
case "application/vnd.github.v3.html" =>
}
case "application/vnd.github.v3.html" => {
contentType = "application/vnd.github.v3.html"
content.map(c =>
List(
"<div data-path=\"", path, "\" id=\"file\">", "<div class=\"plain\">", "<pre>",
@@ -150,12 +189,13 @@ trait ApiControllerBase extends ControllerBase {
"</pre>", "</div>", "</div>"
).mkString
)
}
case _ =>
Some(JsonFormat(ApiContents(f, content)))
Some(JsonFormat(ApiContents(f, RepositoryName(repository), content)))
}
}).getOrElse(NotFound())
} else { // directory
JsonFormat(fileList.map{f => ApiContents(f, None)})
JsonFormat(fileList.map{f => ApiContents(f, RepositoryName(repository), None)})
}
}
})
@@ -163,13 +203,24 @@ trait ApiControllerBase extends ControllerBase {
/*
* https://developer.github.com/v3/git/refs/#get-a-reference
*/
get("/api/v3/repos/:owner/:repo/git/*") (referrersOnly { repository =>
get("/api/v3/repos/:owner/:repo/git/refs/*") (referrersOnly { repository =>
val revstr = multiParams("splat").head
using(Git.open(getRepositoryDir(params("owner"), params("repo")))) { git =>
//JsonFormat( (revstr, git.getRepository().resolve(revstr)) )
// getRef is deprecated by jgit-4.2. use exactRef() or findRef()
val sha = git.getRepository().getRef(revstr).getObjectId().name()
JsonFormat(ApiRef(revstr, ApiObject(sha)))
val ref = git.getRepository().findRef(revstr)
if(ref != null){
val sha = ref.getObjectId().name()
JsonFormat(ApiRef(revstr, ApiObject(sha)))
} else {
val refs = git.getRepository().getAllRefs().asScala
.collect { case (str, ref) if str.startsWith("refs/" + revstr) => ref }
JsonFormat(refs.map { ref =>
val sha = ref.getObjectId().name()
ApiRef(revstr, ApiObject(sha))
})
}
}
})
@@ -211,7 +262,8 @@ trait ApiControllerBase extends ControllerBase {
} yield {
LockUtil.lock(s"${owner}/${data.name}") {
if(getRepository(owner, data.name).isEmpty){
createRepository(context.loginAccount.get, owner, data.name, data.description, data.`private`, data.auto_init)
val f = createRepository(context.loginAccount.get, owner, data.name, data.description, data.`private`, data.auto_init)
Await.result(f, Duration.Inf)
val repository = getRepository(owner, data.name).get
JsonFormat(ApiRepository(repository, ApiUser(getAccountByUserName(owner).get)))
} else {
@@ -235,7 +287,8 @@ trait ApiControllerBase extends ControllerBase {
} yield {
LockUtil.lock(s"${groupName}/${data.name}") {
if(getRepository(groupName, data.name).isEmpty){
createRepository(context.loginAccount.get, groupName, data.name, data.description, data.`private`, data.auto_init)
val f = createRepository(context.loginAccount.get, groupName, data.name, data.description, data.`private`, data.auto_init)
Await.result(f, Duration.Inf)
val repository = getRepository(groupName, data.name).get
JsonFormat(ApiRepository(repository, ApiUser(getAccountByUserName(groupName).get)))
} else {
@@ -251,18 +304,19 @@ trait ApiControllerBase extends ControllerBase {
/**
* https://developer.github.com/v3/repos/#enabling-and-disabling-branch-protection
*/
patch("/api/v3/repos/:owner/:repo/branches/:branch")(ownerOnly { repository =>
patch("/api/v3/repos/:owner/:repo/branches/*")(ownerOnly { repository =>
import gitbucket.core.api._
(for{
branch <- params.get("branch") if repository.branchList.find(_ == branch).isDefined
branch <- params.get("splat") if repository.branchList.contains(branch)
protection <- extractFromJsonBody[ApiBranchProtection.EnablingAndDisabling].map(_.protection)
br <- getBranches(repository.owner, repository.name, repository.repository.defaultBranch, repository.repository.originUserName.isEmpty).find(_.name == branch)
} yield {
if(protection.enabled){
enableBranchProtection(repository.owner, repository.name, branch, protection.status.enforcement_level == ApiBranchProtection.Everyone, protection.status.contexts)
} else {
disableBranchProtection(repository.owner, repository.name, branch)
}
JsonFormat(ApiBranch(branch, protection)(RepositoryName(repository)))
JsonFormat(ApiBranch(branch, ApiBranchCommit(br.commitId), protection)(RepositoryName(repository)))
}) getOrElse NotFound()
})
@@ -276,13 +330,76 @@ trait ApiControllerBase extends ControllerBase {
org.scalatra.NotFound(ApiError("Rate limiting is not enabled."))
}
/**
* https://developer.github.com/v3/issues/#list-issues-for-a-repository
*/
get("/api/v3/repos/:owner/:repository/issues")(referrersOnly { repository =>
val page = IssueSearchCondition.page(request)
// TODO: more api spec condition
val condition = IssueSearchCondition(request)
val baseOwner = getAccountByUserName(repository.owner).get
val issues: List[(Issue, Account)] =
searchIssueByApi(
condition = condition,
offset = (page - 1) * PullRequestLimit,
limit = PullRequestLimit,
repos = repository.owner -> repository.name
)
JsonFormat(issues.map { case (issue, issueUser) =>
ApiIssue(
issue = issue,
repositoryName = RepositoryName(repository),
user = ApiUser(issueUser)
)
})
})
/**
* https://developer.github.com/v3/issues/#get-a-single-issue
*/
get("/api/v3/repos/:owner/:repository/issues/:id")(referrersOnly { repository =>
(for{
issueId <- params("id").toIntOpt
issue <- getIssue(repository.owner, repository.name, issueId.toString)
openedUser <- getAccountByUserName(issue.openedUserName)
} yield {
JsonFormat(ApiIssue(issue, RepositoryName(repository), ApiUser(openedUser)))
}) getOrElse NotFound()
})
/**
* https://developer.github.com/v3/issues/#create-an-issue
*/
post("/api/v3/repos/:owner/:repository/issues")(readableUsersOnly { repository =>
if(isIssueEditable(repository)){ // TODO Should this check is provided by authenticator?
(for{
data <- extractFromJsonBody[CreateAnIssue]
loginAccount <- context.loginAccount
} yield {
val milestone = data.milestone.flatMap(getMilestone(repository.owner, repository.name, _))
val issue = createIssue(
repository,
data.title,
data.body,
data.assignees.headOption,
milestone.map(_.milestoneId),
None,
data.labels,
loginAccount)
JsonFormat(ApiIssue(issue, RepositoryName(repository), ApiUser(loginAccount)))
}) getOrElse NotFound()
} else Unauthorized()
})
/**
* https://developer.github.com/v3/issues/comments/#list-comments-on-an-issue
*/
get("/api/v3/repos/:owner/:repository/issues/:id/comments")(referrersOnly { repository =>
(for{
issueId <- params("id").toIntOpt
comments = getCommentsForApi(repository.owner, repository.name, issueId.toInt)
issueId <- params("id").toIntOpt
comments = getCommentsForApi(repository.owner, repository.name, issueId)
} yield {
JsonFormat(comments.map{ case (issueComment, user, issue) => ApiComment(issueComment, RepositoryName(repository), issueId, ApiUser(user), issue.isPullRequest) })
}) getOrElse NotFound()
@@ -363,12 +480,14 @@ trait ApiControllerBase extends ControllerBase {
updateLabel(repository.owner, repository.name, label.labelId, data.name, data.color)
JsonFormat(ApiLabel(
getLabel(repository.owner, repository.name, label.labelId).get,
RepositoryName(repository)))
RepositoryName(repository)
))
} else {
// TODO ApiError should support errors field to enhance compatibility of GitHub API
UnprocessableEntity(ApiError(
"Validation Failed",
Some("https://developer.github.com/v3/issues/labels/#create-a-label")))
Some("https://developer.github.com/v3/issues/labels/#create-a-label")
))
}
} getOrElse NotFound()
}
@@ -397,7 +516,7 @@ trait ApiControllerBase extends ControllerBase {
val condition = IssueSearchCondition(request)
val baseOwner = getAccountByUserName(repository.owner).get
val issues: List[(Issue, Account, Int, PullRequest, Repository, Account)] =
val issues: List[(Issue, Account, Int, PullRequest, Repository, Account, Option[Account])] =
searchPullRequestByApi(
condition = condition,
offset = (page - 1) * PullRequestLimit,
@@ -405,13 +524,15 @@ trait ApiControllerBase extends ControllerBase {
repos = repository.owner -> repository.name
)
JsonFormat(issues.map { case (issue, issueUser, commentCount, pullRequest, headRepo, headOwner) =>
JsonFormat(issues.map { case (issue, issueUser, commentCount, pullRequest, headRepo, headOwner, assignee) =>
ApiPullRequest(
issue,
pullRequest,
ApiRepository(headRepo, ApiUser(headOwner)),
ApiRepository(repository, ApiUser(baseOwner)),
ApiUser(issueUser)
issue = issue,
pullRequest = pullRequest,
headRepo = ApiRepository(headRepo, ApiUser(headOwner)),
baseRepo = ApiRepository(repository, ApiUser(baseOwner)),
user = ApiUser(issueUser),
assignee = assignee.map(ApiUser.apply),
mergedComment = getMergedComment(repository.owner, repository.name, issue.issueId)
)
})
})
@@ -421,20 +542,24 @@ trait ApiControllerBase extends ControllerBase {
*/
get("/api/v3/repos/:owner/:repository/pulls/:id")(referrersOnly { repository =>
(for{
issueId <- params("id").toIntOpt
issueId <- params("id").toIntOpt
(issue, pullRequest) <- getPullRequest(repository.owner, repository.name, issueId)
users = getAccountsByUserNames(Set(repository.owner, pullRequest.requestUserName, issue.openedUserName), Set())
users = getAccountsByUserNames(Set(repository.owner, pullRequest.requestUserName, issue.openedUserName), Set.empty)
baseOwner <- users.get(repository.owner)
headOwner <- users.get(pullRequest.requestUserName)
issueUser <- users.get(issue.openedUserName)
assignee = issue.assignedUserName.flatMap { userName => getAccountByUserName(userName, false) }
headRepo <- getRepository(pullRequest.requestUserName, pullRequest.requestRepositoryName)
} yield {
JsonFormat(ApiPullRequest(
issue,
pullRequest,
ApiRepository(headRepo, ApiUser(headOwner)),
ApiRepository(repository, ApiUser(baseOwner)),
ApiUser(issueUser)))
issue = issue,
pullRequest = pullRequest,
headRepo = ApiRepository(headRepo, ApiUser(headOwner)),
baseRepo = ApiRepository(repository, ApiUser(baseOwner)),
user = ApiUser(issueUser),
assignee = assignee.map(ApiUser.apply),
mergedComment = getMergedComment(repository.owner, repository.name, issue.issueId)
))
}) getOrElse NotFound()
})
@@ -450,7 +575,7 @@ trait ApiControllerBase extends ControllerBase {
val oldId = git.getRepository.resolve(pullreq.commitIdFrom)
val newId = git.getRepository.resolve(pullreq.commitIdTo)
val repoFullName = RepositoryName(repository)
val commits = git.log.addRange(oldId, newId).call.iterator.asScala.map(c => ApiCommitListItem(new CommitInfo(c), repoFullName)).toList
val commits = git.log.addRange(oldId, newId).call.iterator.asScala.map { c => ApiCommitListItem(new CommitInfo(c), repoFullName) }.toList
JsonFormat(commits)
}
}
@@ -469,14 +594,14 @@ trait ApiControllerBase extends ControllerBase {
*/
post("/api/v3/repos/:owner/:repo/statuses/:sha")(writableUsersOnly { repository =>
(for{
ref <- params.get("sha")
sha <- JGitUtil.getShaByRef(repository.owner, repository.name, ref)
data <- extractFromJsonBody[CreateAStatus] if data.isValid
creator <- context.loginAccount
state <- CommitState.valueOf(data.state)
statusId = createCommitStatus(repository.owner, repository.name, sha, data.context.getOrElse("default"),
state, data.target_url, data.description, new java.util.Date(), creator)
status <- getCommitStatus(repository.owner, repository.name, statusId)
ref <- params.get("sha")
sha <- JGitUtil.getShaByRef(repository.owner, repository.name, ref)
data <- extractFromJsonBody[CreateAStatus] if data.isValid
creator <- context.loginAccount
state <- CommitState.valueOf(data.state)
statusId = createCommitStatus(repository.owner, repository.name, sha, data.context.getOrElse("default"),
state, data.target_url, data.description, new java.util.Date(), creator)
status <- getCommitStatus(repository.owner, repository.name, statusId)
} yield {
JsonFormat(ApiCommitStatus(status, ApiUser(creator)))
}) getOrElse NotFound()
@@ -514,17 +639,77 @@ trait ApiControllerBase extends ControllerBase {
*/
get("/api/v3/repos/:owner/:repo/commits/:ref/status")(referrersOnly { repository =>
(for{
ref <- params.get("ref")
ref <- params.get("ref")
owner <- getAccountByUserName(repository.owner)
sha <- JGitUtil.getShaByRef(repository.owner, repository.name, ref)
sha <- JGitUtil.getShaByRef(repository.owner, repository.name, ref)
} yield {
val statuses = getCommitStatuesWithCreator(repository.owner, repository.name, sha)
JsonFormat(ApiCombinedCommitStatus(sha, statuses, ApiRepository(repository, owner)))
}) getOrElse NotFound()
})
/**
* https://developer.github.com/v3/repos/commits/#get-a-single-commit
*/
get("/api/v3/repos/:owner/:repo/commits/:sha")(referrersOnly { repository =>
val owner = repository.owner
val name = repository.name
val sha = params("sha")
using(Git.open(getRepositoryDir(owner, name))){ git =>
val repo = git.getRepository
val objectId = repo.resolve(sha)
val commitInfo = using(new RevWalk(repo)){ revWalk =>
new CommitInfo(revWalk.parseCommit(objectId))
}
JsonFormat(ApiCommits(
repositoryName = RepositoryName(repository),
commitInfo = commitInfo,
diffs = JGitUtil.getDiffs(git, Some(commitInfo.parents.head), commitInfo.id, false, true),
author = getAccount(commitInfo.authorName, commitInfo.authorEmailAddress),
committer = getAccount(commitInfo.committerName, commitInfo.committerEmailAddress),
commentCount = getCommitComment(repository.owner, repository.name, sha).size
))
}
})
private def getAccount(userName: String, email: String): Account = {
getAccountByMailAddress(email).getOrElse {
Account(
userName = userName,
fullName = userName,
mailAddress = email,
password = "xxx",
isAdmin = false,
url = None,
registeredDate = new java.util.Date(),
updatedDate = new java.util.Date(),
lastLoginDate = None,
image = None,
isGroupAccount = false,
isRemoved = true,
description = None
)
}
}
private def isEditable(owner: String, repository: String, author: String)(implicit context: Context): Boolean =
hasDeveloperRole(owner, repository, context.loginAccount) || author == context.loginAccount.get.userName
/**
* non-GitHub compatible API for Jenkins-Plugin
*/
get("/api/v3/repos/:owner/:repo/raw/*")(referrersOnly { repository =>
val (id, path) = repository.splitPath(multiParams("splat").head)
using(Git.open(getRepositoryDir(repository.owner, repository.name))){ git =>
val revCommit = JGitUtil.getRevCommitFromId(git, git.getRepository.resolve(id))
getPathObjectId(git, path, revCommit).map { objectId =>
responseRawFile(git, objectId, path, repository)
} getOrElse NotFound()
}
})
}

View File

@@ -1,63 +1,54 @@
package gitbucket.core.controller
import java.io.FileInputStream
import gitbucket.core.api.ApiError
import gitbucket.core.model.Account
import gitbucket.core.service.{AccountService, SystemSettingsService}
import gitbucket.core.util.ControlUtil._
import gitbucket.core.service.{AccountService, RepositoryService, SystemSettingsService}
import gitbucket.core.util.SyntaxSugars._
import gitbucket.core.util.Directory._
import gitbucket.core.util.Implicits._
import gitbucket.core.util._
import io.github.gitbucket.scalatra.forms._
import org.apache.commons.io.FileUtils
import org.json4s._
import org.scalatra._
import org.scalatra.i18n._
import org.scalatra.json._
import org.scalatra.forms._
import javax.servlet.http.{HttpServletRequest, HttpServletResponse}
import javax.servlet.{FilterChain, ServletRequest, ServletResponse}
import javax.servlet.http.{HttpServletResponse, HttpServletRequest}
import javax.servlet.{FilterChain, ServletResponse, ServletRequest}
import is.tagomor.woothee.Classifier
import scala.util.Try
import net.coobird.thumbnailator.Thumbnails
import org.eclipse.jgit.api.Git
import org.eclipse.jgit.lib.ObjectId
import org.eclipse.jgit.revwalk.RevCommit
import org.eclipse.jgit.treewalk._
import org.apache.commons.io.IOUtils
import org.slf4j.LoggerFactory
/**
* Provides generic features for controller implementations.
*/
abstract class ControllerBase extends ScalatraFilter
with ClientSideValidationFormSupport with JacksonJsonSupport with I18nSupport with FlashMapSupport with Validations
with ValidationSupport with JacksonJsonSupport with I18nSupport with FlashMapSupport with Validations
with SystemSettingsService {
private val logger = LoggerFactory.getLogger(getClass)
implicit val jsonFormats = gitbucket.core.api.JsonFormat.jsonFormats
before("/api/v3/*") {
contentType = formats("json")
}
// TODO Scala 2.11
// // Don't set content type via Accept header.
// override def format(implicit request: HttpServletRequest) = ""
override def doFilter(request: ServletRequest, response: ServletResponse, chain: FilterChain): Unit = try {
val httpRequest = request.asInstanceOf[HttpServletRequest]
val httpResponse = response.asInstanceOf[HttpServletResponse]
val context = request.getServletContext.getContextPath
val path = httpRequest.getRequestURI.substring(context.length)
val httpRequest = request.asInstanceOf[HttpServletRequest]
val context = request.getServletContext.getContextPath
val path = httpRequest.getRequestURI.substring(context.length)
if(path.startsWith("/console/")){
val account = httpRequest.getSession.getAttribute(Keys.Session.LoginAccount).asInstanceOf[Account]
val baseUrl = this.baseUrl(httpRequest)
if(account == null){
// Redirect to login form
httpResponse.sendRedirect(baseUrl + "/signin?redirect=" + StringUtil.urlEncode(path))
} else if(account.isAdmin){
// H2 Console (administrators only)
chain.doFilter(request, response)
} else {
// Redirect to dashboard
httpResponse.sendRedirect(baseUrl + "/")
}
} else if(path.startsWith("/git/")){
if(path.startsWith("/git/") || path.startsWith("/git-lfs/")){
// Git repository
chain.doFilter(request, response)
} else {
@@ -123,12 +114,24 @@ abstract class ControllerBase extends ScalatraFilter
org.scalatra.NotFound(gitbucket.core.html.error("Not Found"))
}
private def isBrowser(userAgent: String): Boolean = {
if(userAgent == null || userAgent.isEmpty){
false
} else {
val data = Classifier.parse(userAgent)
val category = data.get("category")
category == "pc" || category == "smartphone" || category == "mobilephone"
}
}
protected def Unauthorized()(implicit context: Context) =
if(request.hasAttribute(Keys.Request.Ajax)){
org.scalatra.Unauthorized()
} else if(request.hasAttribute(Keys.Request.APIv3)){
contentType = formats("json")
org.scalatra.Unauthorized(ApiError("Requires authentication"))
} else if(!isBrowser(request.getHeader("USER-AGENT"))){
org.scalatra.Unauthorized()
} else {
if(context.loginAccount.isDefined){
org.scalatra.Unauthorized(redirect("/"))
@@ -145,7 +148,20 @@ abstract class ControllerBase extends ScalatraFilter
}
}
// TODO Scala 2.11
error{
case e => {
logger.error(s"Catch unhandled error in request: ${request}", e)
if(request.hasAttribute(Keys.Request.Ajax)){
org.scalatra.InternalServerError()
} else if(request.hasAttribute(Keys.Request.APIv3)){
contentType = formats("json")
org.scalatra.InternalServerError(ApiError("Internal Server Error"))
} else {
org.scalatra.InternalServerError(gitbucket.core.html.error("Internal Server Error", Some(e)))
}
}
}
override def url(path: String, params: Iterable[(String, Any)] = Iterable.empty,
includeContextPath: Boolean = true, includeServletPath: Boolean = true,
absolutize: Boolean = true, withSessionId: Boolean = true)
@@ -153,6 +169,18 @@ abstract class ControllerBase extends ScalatraFilter
if (path.startsWith("http")) path
else baseUrl + super.url(path, params, false, false, false)
/**
* Extends scalatra-form's trim rule to eliminate CR and LF.
*/
protected def trim2[T](valueType: SingleValueType[T]): SingleValueType[T] = new SingleValueType[T](){
def convert(value: String, messages: Messages): T = valueType.convert(trim(value), messages)
override def validate(name: String, value: String, params: Map[String, Seq[String]], messages: Messages): Seq[(String, String)] =
valueType.validate(name, trim(value), params, messages)
private def trim(value: String): String = if(value == null) null else value.replace("\r\n", "").trim
}
/**
* Use this method to response the raw data against XSS.
*/
@@ -174,6 +202,49 @@ abstract class ControllerBase extends ScalatraFilter
case _ => Some(parse(request.body))
}).filterNot(_ == JNothing).flatMap(j => Try(j.extract[A]).toOption)
}
protected def getPathObjectId(git: Git, path: String, revCommit: RevCommit): Option[ObjectId] = {
@scala.annotation.tailrec
def _getPathObjectId(path: String, walk: TreeWalk): Option[ObjectId] = walk.next match {
case true if(walk.getPathString == path) => Some(walk.getObjectId(0))
case true => _getPathObjectId(path, walk)
case false => None
}
using(new TreeWalk(git.getRepository)){ treeWalk =>
treeWalk.addTree(revCommit.getTree)
treeWalk.setRecursive(true)
_getPathObjectId(path, treeWalk)
}
}
protected def responseRawFile(git: Git, objectId: ObjectId, path: String,
repository: RepositoryService.RepositoryInfo): Unit = {
JGitUtil.getObjectLoaderFromId(git, objectId){ loader =>
contentType = FileUtil.getMimeType(path)
if(loader.isLarge){
response.setContentLength(loader.getSize.toInt)
loader.copyTo(response.outputStream)
} else {
val bytes = loader.getCachedBytes
val text = new String(bytes, "UTF-8")
val attrs = JGitUtil.getLfsObjects(text)
if(attrs.nonEmpty) {
response.setContentLength(attrs("size").toInt)
val oid = attrs("oid").split(":")(1)
using(new FileInputStream(FileUtil.getLfsFilePath(repository.owner, repository.name, oid))){ in =>
IOUtils.copy(in, response.getOutputStream)
}
} else {
response.setContentLength(loader.getSize.toInt)
response.getOutputStream.write(bytes)
}
}
}
}
}
/**
@@ -225,10 +296,13 @@ trait AccountManagementControllerBase extends ControllerBase {
} else {
fileId.map { fileId =>
val filename = "avatar." + FileUtil.getExtension(session.getAndRemove(Keys.Session.Upload(fileId)).get)
FileUtils.moveFile(
new java.io.File(getTemporaryDir(session.getId), fileId),
new java.io.File(getUserUploadDir(userName), filename)
)
val uploadDir = getUserUploadDir(userName)
if(!uploadDir.exists){
uploadDir.mkdirs()
}
Thumbnails.of(new java.io.File(getTemporaryDir(session.getId), fileId))
.size(324, 324)
.toFile(new java.io.File(uploadDir, filename))
updateAvatarImage(userName, Some(filename))
}
}
@@ -239,13 +313,14 @@ trait AccountManagementControllerBase extends ControllerBase {
}
protected def uniqueMailAddress(paramName: String = ""): Constraint = new Constraint(){
override def validate(name: String, value: String, params: Map[String, String], messages: Messages): Option[String] =
override def validate(name: String, value: String, params: Map[String, Seq[String]], messages: Messages): Option[String] = {
getAccountByMailAddress(value, true)
.filter { x => if(paramName.isEmpty) true else Some(x.userName) != params.get(paramName) }
.filter { x => if(paramName.isEmpty) true else Some(x.userName) != params.optionValue(paramName) }
.map { _ => "Mail address is already registered." }
}
}
val allReservedNames = Set("git", "admin", "upload", "api")
val allReservedNames = Set("git", "admin", "upload", "api", "assets", "plugin-assets", "signin", "signout", "register", "activities.atom", "sidebar-collapse", "groups", "new")
protected def reservedNames(): Constraint = new Constraint(){
override def validate(name: String, value: String, messages: Messages): Option[String] = if(allReservedNames.contains(value)){
Some(s"${value} is reserved")

View File

@@ -1,13 +1,13 @@
package gitbucket.core.controller
import gitbucket.core.dashboard.html
import gitbucket.core.service.{RepositoryService, PullRequestService, AccountService, IssuesService}
import gitbucket.core.util.{StringUtil, Keys, UsersAuthenticator}
import gitbucket.core.service._
import gitbucket.core.util.{Keys, UsersAuthenticator}
import gitbucket.core.util.Implicits._
import gitbucket.core.service.IssuesService._
class DashboardController extends DashboardControllerBase
with IssuesService with PullRequestService with RepositoryService with AccountService
with IssuesService with PullRequestService with RepositoryService with AccountService with CommitsService
with UsersAuthenticator
trait DashboardControllerBase extends ControllerBase {
@@ -76,7 +76,7 @@ trait DashboardControllerBase extends ControllerBase {
},
filter,
getGroupNames(userName),
getVisibleRepositories(context.loginAccount, withoutPhysicalInfo = true),
Nil,
getUserRepositories(userName, withoutPhysicalInfo = true))
}
@@ -101,7 +101,7 @@ trait DashboardControllerBase extends ControllerBase {
},
filter,
getGroupNames(userName),
getVisibleRepositories(context.loginAccount, withoutPhysicalInfo = true),
Nil,
getUserRepositories(userName, withoutPhysicalInfo = true))
}

View File

@@ -1,28 +1,31 @@
package gitbucket.core.controller
import gitbucket.core.model.Account
import gitbucket.core.service.{AccountService, RepositoryService}
import gitbucket.core.service.{AccountService, RepositoryService, ReleaseService}
import gitbucket.core.servlet.Database
import gitbucket.core.util._
import gitbucket.core.util.ControlUtil._
import gitbucket.core.util.SyntaxSugars._
import gitbucket.core.util.Directory._
import gitbucket.core.util.Implicits._
import org.eclipse.jgit.api.Git
import org.eclipse.jgit.dircache.DirCache
import org.eclipse.jgit.lib.{FileMode, Constants}
import org.scalatra
import org.eclipse.jgit.lib.{Constants, FileMode}
import org.scalatra._
import org.scalatra.servlet.{MultipartConfig, FileUploadSupport, FileItem}
import org.apache.commons.io.{IOUtils, FileUtils}
import org.scalatra.servlet.{FileItem, FileUploadSupport, MultipartConfig}
import org.apache.commons.io.{FileUtils, IOUtils}
/**
* Provides Ajax based file upload functionality.
*
* This servlet saves uploaded file.
*/
class FileUploadController extends ScalatraServlet with FileUploadSupport with RepositoryService with AccountService {
class FileUploadController extends ScalatraServlet
with FileUploadSupport
with RepositoryService
with AccountService
with ReleaseService{
configureMultipartHandling(MultipartConfig(maxFileSize = Some(3 * 1024 * 1024)))
configureMultipartHandling(MultipartConfig(maxFileSize = Some(FileUtil.MaxFileSize)))
post("/image"){
execute({ (file, fileId) =>
@@ -31,12 +34,19 @@ class FileUploadController extends ScalatraServlet with FileUploadSupport with R
}, FileUtil.isImage)
}
post("/tmp"){
execute({ (file, fileId) =>
FileUtils.writeByteArrayToFile(new java.io.File(getTemporaryDir(session.getId), fileId), file.get)
session += Keys.Session.Upload(fileId) -> file.name
}, _ => true)
}
post("/file/:owner/:repository"){
execute({ (file, fileId) =>
FileUtils.writeByteArrayToFile(new java.io.File(
getAttachedDir(params("owner"), params("repository")),
fileId + "." + FileUtil.getExtension(file.getName)), file.get)
}, FileUtil.isUploadableType)
}, _ => true)
}
post("/wiki/:owner/:repository"){
@@ -46,7 +56,7 @@ class FileUploadController extends ScalatraServlet with FileUploadSupport with R
val repository = params("repository")
// Check whether logged-in user is collaborator
collaboratorsOnly(owner, repository, loginAccount){
onlyWikiEditable(owner, repository, loginAccount){
execute({ (file, fileId) =>
val fileName = file.getName
LockUtil.lock(s"${owner}/${repository}/wiki") {
@@ -68,16 +78,30 @@ class FileUploadController extends ScalatraServlet with FileUploadSupport with R
builder.finish()
val newHeadId = JGitUtil.createNewCommit(git, inserter, headId, builder.getDirCache.writeTree(inserter),
Constants.HEAD, loginAccount.userName, loginAccount.mailAddress, s"Uploaded ${fileName}")
Constants.HEAD, loginAccount.fullName, loginAccount.mailAddress, s"Uploaded ${fileName}")
fileName
}
}
}, FileUtil.isUploadableType)
}, _ => true)
}
} getOrElse BadRequest()
}
post("/release/:owner/:repository/:tag"){
session.get(Keys.Session.LoginAccount).collect { case _: Account =>
val owner = params("owner")
val repository = params("repository")
val tag = params("tag")
execute({ (file, fileId) =>
FileUtils.writeByteArrayToFile(
new java.io.File(getReleaseFilesDir(owner, repository), tag + "/" + fileId),
file.get
)
}, _ => true)
}.getOrElse(BadRequest())
}
post("/import") {
import JDBCUtil._
session.get(Keys.Session.LoginAccount).collect { case loginAccount: Account if loginAccount.isAdmin =>
@@ -88,19 +112,24 @@ class FileUploadController extends ScalatraServlet with FileUploadSupport with R
redirect("/admin/data")
}
private def collaboratorsOnly(owner: String, repository: String, loginAccount: Account)(action: => Any): Any = {
private def onlyWikiEditable(owner: String, repository: String, loginAccount: Account)(action: => Any): Any = {
implicit val session = Database.getSession(request)
loginAccount match {
case x if(x.isAdmin) => action
case x if(getCollaborators(owner, repository).contains(x.userName)) => action
case _ => BadRequest()
getRepository(owner, repository) match {
case Some(x) => x.repository.options.wikiOption match {
case "ALL" if !x.repository.isPrivate => action
case "PUBLIC" if hasGuestRole(owner, repository, Some(loginAccount)) => action
case "PRIVATE" if hasDeveloperRole(owner, repository, Some(loginAccount)) => action
case _ => BadRequest()
}
case None => BadRequest()
}
}
private def execute(f: (FileItem, String) => Unit, mimeTypeChcker: (String) => Boolean) = fileParams.get("file") match {
private def execute(f: (FileItem, String) => Unit , mimeTypeChcker: (String) => Boolean) = fileParams.get("file") match {
case Some(file) if(mimeTypeChcker(file.name)) =>
defining(FileUtil.generateFileId){ fileId =>
f(file, fileId)
contentType = "text/plain"
Ok(fileId)
}
case _ => BadRequest()

View File

@@ -1,39 +1,57 @@
package gitbucket.core.controller
import java.net.URI
import com.nimbusds.oauth2.sdk.id.State
import com.nimbusds.openid.connect.sdk.Nonce
import gitbucket.core.helper.xml
import gitbucket.core.model.Account
import gitbucket.core.service._
import gitbucket.core.util.Implicits._
import gitbucket.core.util.ControlUtil._
import gitbucket.core.util.{Keys, LDAPUtil, ReferrerAuthenticator, StringUtil, UsersAuthenticator}
import io.github.gitbucket.scalatra.forms._
import gitbucket.core.util.SyntaxSugars._
import gitbucket.core.util.{Keys, LDAPUtil, ReferrerAuthenticator, UsersAuthenticator}
import org.scalatra.Ok
import org.scalatra.forms._
class IndexController extends IndexControllerBase
with RepositoryService with ActivityService with AccountService with RepositorySearchService with IssuesService
with UsersAuthenticator with ReferrerAuthenticator
class IndexController extends IndexControllerBase
with RepositoryService
with ActivityService
with AccountService
with RepositorySearchService
with IssuesService
with UsersAuthenticator
with ReferrerAuthenticator
with AccountFederationService
with OpenIDConnectService
trait IndexControllerBase extends ControllerBase {
self: RepositoryService with ActivityService with AccountService with RepositorySearchService
with UsersAuthenticator with ReferrerAuthenticator =>
self: RepositoryService
with ActivityService
with AccountService
with RepositorySearchService
with UsersAuthenticator
with ReferrerAuthenticator
with OpenIDConnectService =>
case class SignInForm(userName: String, password: String)
case class SignInForm(userName: String, password: String, hash: Option[String])
val signinForm = mapping(
"userName" -> trim(label("Username", text(required))),
"password" -> trim(label("Password", text(required)))
"password" -> trim(label("Password", text(required))),
"hash" -> trim(optional(text()))
)(SignInForm.apply)
val searchForm = mapping(
"query" -> trim(text(required)),
"owner" -> trim(text(required)),
"repository" -> trim(text(required))
)(SearchForm.apply)
case class SearchForm(query: String, owner: String, repository: String)
// val searchForm = mapping(
// "query" -> trim(text(required)),
// "owner" -> trim(text(required)),
// "repository" -> trim(text(required))
// )(SearchForm.apply)
//
// case class SearchForm(query: String, owner: String, repository: String)
case class OidcContext(state: State, nonce: Nonce, redirectBackURI: String)
get("/"){
context.loginAccount.map { account =>
@@ -49,13 +67,64 @@ trait IndexControllerBase extends ControllerBase {
if(redirect.isDefined && redirect.get.startsWith("/")){
flash += Keys.Flash.Redirect -> redirect.get
}
gitbucket.core.html.signin()
gitbucket.core.html.signin(flash.get("userName"), flash.get("password"), flash.get("error"))
}
post("/signin", signinForm){ form =>
authenticate(context.settings, form.userName, form.password) match {
case Some(account) => signin(account)
case None => redirect("/signin")
case Some(account) =>
flash.get(Keys.Flash.Redirect) match {
case Some(redirectUrl: String) => signin(account, redirectUrl + form.hash.getOrElse(""))
case _ => signin(account)
}
case None =>
flash += "userName" -> form.userName
flash += "password" -> form.password
flash += "error" -> "Sorry, your Username and/or Password is incorrect. Please try again."
redirect("/signin")
}
}
/**
* Initiate an OpenID Connect authentication request.
*/
post("/signin/oidc") {
context.settings.oidc.map { oidc =>
val redirectURI = new URI(s"$baseUrl/signin/oidc")
val authenticationRequest = createOIDCAuthenticationRequest(oidc.issuer, oidc.clientID, redirectURI)
val redirectBackURI = flash.get(Keys.Flash.Redirect) match {
case Some(redirectBackURI: String) => redirectBackURI + params.getOrElse("hash", "")
case _ => "/"
}
session.setAttribute(Keys.Session.OidcContext, OidcContext(authenticationRequest.getState, authenticationRequest.getNonce, redirectBackURI))
redirect(authenticationRequest.toURI.toString)
} getOrElse {
NotFound()
}
}
/**
* Handle an OpenID Connect authentication response.
*/
get("/signin/oidc") {
context.settings.oidc.map { oidc =>
val redirectURI = new URI(s"$baseUrl/signin/oidc")
session.get(Keys.Session.OidcContext) match {
case Some(context: OidcContext) =>
authenticate(params, redirectURI, context.state, context.nonce, oidc) map { account =>
signin(account, context.redirectBackURI)
} orElse {
flash += "error" -> "Sorry, authentication failed. Please try again."
session.invalidate()
redirect("/signin")
}
case _ =>
flash += "error" -> "Sorry, something wrong. Please try again."
session.invalidate()
redirect("/signin")
}
} getOrElse {
NotFound()
}
}
@@ -69,7 +138,7 @@ trait IndexControllerBase extends ControllerBase {
xml.feed(getRecentActivities())
}
get("/sidebar-collapse"){
post("/sidebar-collapse"){
if(params("collapse") == "true"){
session.setAttribute("sidebar-collapse", "true")
} else {
@@ -79,9 +148,9 @@ trait IndexControllerBase extends ControllerBase {
}
/**
* Set account information into HttpSession and redirect.
*/
private def signin(account: Account) = {
* Set account information into HttpSession and redirect.
*/
private def signin(account: Account, redirectUrl: String = "/") = {
session.setAttribute(Keys.Session.LoginAccount, account)
updateLastLoginDate(account.userName)
@@ -89,14 +158,10 @@ trait IndexControllerBase extends ControllerBase {
redirect("/" + account.userName + "/_edit")
}
flash.get(Keys.Flash.Redirect).asInstanceOf[Option[String]].map { redirectUrl =>
if(redirectUrl.stripSuffix("/") == request.getContextPath){
redirect("/")
} else {
redirect(redirectUrl)
}
}.getOrElse {
if (redirectUrl.stripSuffix("/") == request.getContextPath) {
redirect("/")
} else {
redirect(redirectUrl)
}
}
@@ -115,7 +180,12 @@ trait IndexControllerBase extends ControllerBase {
case (true, false) => !t.isGroupAccount
case (false, true) => t.isGroupAccount
case (false, false) => false
}}.map { t => t.userName }
}}.map { t =>
Map(
"label" -> s"<b>@${t.userName}</b> ${t.fullName}",
"value" -> t.userName
)
}
))
)
})
@@ -130,15 +200,10 @@ trait IndexControllerBase extends ControllerBase {
} getOrElse ""
})
// TODO Move to RepositoryViwerController?
post("/search", searchForm){ form =>
redirect(s"/${form.owner}/${form.repository}/search?q=${StringUtil.urlEncode(form.query)}")
}
// TODO Move to RepositoryViwerController?
get("/:owner/:repository/search")(referrersOnly { repository =>
defining(params("q").trim, params.getOrElse("type", "code")){ case (query, target) =>
val page = try {
defining(params.getOrElse("q", "").trim, params.getOrElse("type", "code")){ case (query, target) =>
val page = try {
val i = params.getOrElse("page", "1").toInt
if(i <= 0) 1 else i
} catch {
@@ -147,23 +212,31 @@ trait IndexControllerBase extends ControllerBase {
target.toLowerCase match {
case "issue" => gitbucket.core.search.html.issues(
countFiles(repository.owner, repository.name, query),
searchIssues(repository.owner, repository.name, query),
countWikiPages(repository.owner, repository.name, query),
if(query.nonEmpty) searchIssues(repository.owner, repository.name, query) else Nil,
query, page, repository)
case "wiki" => gitbucket.core.search.html.wiki(
countFiles(repository.owner, repository.name, query),
countIssues(repository.owner, repository.name, query),
searchWikiPages(repository.owner, repository.name, query),
if(query.nonEmpty) searchWikiPages(repository.owner, repository.name, query) else Nil,
query, page, repository)
case _ => gitbucket.core.search.html.code(
searchFiles(repository.owner, repository.name, query),
countIssues(repository.owner, repository.name, query),
countWikiPages(repository.owner, repository.name, query),
if(query.nonEmpty) searchFiles(repository.owner, repository.name, query) else Nil,
query, page, repository)
}
}
})
get("/search"){
val query = params.getOrElse("query", "").trim.toLowerCase
val visibleRepositories = getVisibleRepositories(context.loginAccount, repositoryUserName = None, withoutPhysicalInfo = true)
val repositories = visibleRepositories.filter { repository =>
repository.name.toLowerCase.indexOf(query) >= 0 || repository.owner.toLowerCase.indexOf(query) >= 0
}
context.loginAccount.map { account =>
gitbucket.core.search.html.repositories(query, repositories, Nil, getUserRepositories(account.userName, withoutPhysicalInfo = true))
}.getOrElse {
gitbucket.core.search.html.repositories(query, repositories, visibleRepositories, Nil)
}
}
}

View File

@@ -2,27 +2,51 @@ package gitbucket.core.controller
import gitbucket.core.issues.html
import gitbucket.core.service.IssuesService._
import gitbucket.core.service.RepositoryService.RepositoryInfo
import gitbucket.core.service._
import gitbucket.core.util.ControlUtil._
import gitbucket.core.util.SyntaxSugars._
import gitbucket.core.util.Implicits._
import gitbucket.core.util._
import gitbucket.core.view
import gitbucket.core.view.Markdown
import io.github.gitbucket.scalatra.forms._
import org.scalatra.Ok
import org.scalatra.forms._
import org.scalatra.{BadRequest, Ok}
class IssuesController extends IssuesControllerBase
with IssuesService with RepositoryService with AccountService with LabelsService with MilestonesService with ActivityService with HandleCommentService
with ReadableUsersAuthenticator with ReferrerAuthenticator with WritableUsersAuthenticator with PullRequestService with WebHookIssueCommentService
with IssuesService
with RepositoryService
with AccountService
with LabelsService
with MilestonesService
with ActivityService
with HandleCommentService
with IssueCreationService
with ReadableUsersAuthenticator
with ReferrerAuthenticator
with WritableUsersAuthenticator
with PullRequestService
with WebHookIssueCommentService
with CommitsService
with PrioritiesService
trait IssuesControllerBase extends ControllerBase {
self: IssuesService with RepositoryService with AccountService with LabelsService with MilestonesService with ActivityService with HandleCommentService
with ReadableUsersAuthenticator with ReferrerAuthenticator with WritableUsersAuthenticator with PullRequestService with WebHookIssueCommentService =>
self: IssuesService
with RepositoryService
with AccountService
with LabelsService
with MilestonesService
with ActivityService
with HandleCommentService
with IssueCreationService
with ReadableUsersAuthenticator
with ReferrerAuthenticator
with WritableUsersAuthenticator
with PullRequestService
with WebHookIssueCommentService
with PrioritiesService =>
case class IssueCreateForm(title: String, content: Option[String],
assignedUserName: Option[String], milestoneId: Option[Int], labelNames: Option[String])
assignedUserName: Option[String], milestoneId: Option[Int], priorityId: Option[Int], labelNames: Option[String])
case class CommentForm(issueId: Int, content: String)
case class IssueStateForm(issueId: Int, content: Option[String])
@@ -31,6 +55,7 @@ trait IssuesControllerBase extends ControllerBase {
"content" -> trim(optional(text())),
"assignedUserName" -> trim(optional(text())),
"milestoneId" -> trim(optional(number())),
"priorityId" -> trim(optional(number())),
"labelNames" -> trim(optional(text()))
)(IssueCreateForm.apply)
@@ -54,7 +79,7 @@ trait IssuesControllerBase extends ControllerBase {
get("/:owner/:repository/issues")(referrersOnly { repository =>
val q = request.getParameter("q")
if(Option(q).exists(_.contains("is:pr"))){
redirect(s"/${repository.owner}/${repository.name}/pulls?q=" + StringUtil.urlEncode(q))
redirect(s"/${repository.owner}/${repository.name}/pulls?q=${StringUtil.urlEncode(q)}")
} else {
searchIssues(repository)
}
@@ -62,75 +87,55 @@ trait IssuesControllerBase extends ControllerBase {
get("/:owner/:repository/issues/:id")(referrersOnly { repository =>
defining(repository.owner, repository.name, params("id")){ case (owner, name, issueId) =>
getIssue(owner, name, issueId) map {
html.issue(
_,
getComments(owner, name, issueId.toInt),
getIssueLabels(owner, name, issueId.toInt),
getAssignableUserNames(owner, name),
getMilestonesWithIssueCount(owner, name),
getLabels(owner, name),
isEditable(repository),
isManageable(repository),
repository)
getIssue(owner, name, issueId) map { issue =>
if(issue.isPullRequest){
redirect(s"/${repository.owner}/${repository.name}/pull/${issueId}")
} else {
html.issue(
issue,
getComments(owner, name, issueId.toInt),
getIssueLabels(owner, name, issueId.toInt),
getAssignableUserNames(owner, name),
getMilestonesWithIssueCount(owner, name),
getPriorities(owner, name),
getLabels(owner, name),
isIssueEditable(repository),
isIssueManageable(repository),
repository)
}
} getOrElse NotFound()
}
})
get("/:owner/:repository/issues/new")(readableUsersOnly { repository =>
if(isEditable(repository)){ // TODO Should this check is provided by authenticator?
if(isIssueEditable(repository)){ // TODO Should this check is provided by authenticator?
defining(repository.owner, repository.name){ case (owner, name) =>
html.create(
getAssignableUserNames(owner, name),
getMilestones(owner, name),
getPriorities(owner, name),
getDefaultPriority(owner, name),
getLabels(owner, name),
isManageable(repository),
isIssueManageable(repository),
getContentTemplate(repository, "ISSUE_TEMPLATE"),
repository)
}
} else Unauthorized()
})
post("/:owner/:repository/issues/new", issueCreateForm)(readableUsersOnly { (form, repository) =>
if(isEditable(repository)){ // TODO Should this check is provided by authenticator?
defining(repository.owner, repository.name){ case (owner, name) =>
val manageable = isManageable(repository)
val userName = context.loginAccount.get.userName
if(isIssueEditable(repository)){ // TODO Should this check is provided by authenticator?
val issue = createIssue(
repository,
form.title,
form.content,
form.assignedUserName,
form.milestoneId,
form.priorityId,
form.labelNames.toArray.flatMap(_.split(",")),
context.loginAccount.get)
// insert issue
val issueId = createIssue(owner, name, userName, form.title, form.content,
if (manageable) form.assignedUserName else None,
if (manageable) form.milestoneId else None)
// insert labels
if (manageable) {
form.labelNames.map { value =>
val labels = getLabels(owner, name)
value.split(",").foreach { labelName =>
labels.find(_.labelName == labelName).map { label =>
registerIssueLabel(owner, name, issueId, label.labelId)
}
}
}
}
// record activity
recordCreateIssueActivity(owner, name, userName, issueId, form.title)
getIssue(owner, name, issueId.toString).foreach { issue =>
// extract references and create refer comment
createReferComment(owner, name, issue, form.title + " " + form.content.getOrElse(""), context.loginAccount.get)
// call web hooks
callIssuesWebHook("opened", repository, issue, context.baseUrl, context.loginAccount.get)
// notifications
Notifier().toNotify(repository, issue, form.content.getOrElse("")) {
Notifier.msgIssue(s"${context.baseUrl}/${owner}/${name}/issues/${issueId}")
}
}
redirect(s"/${owner}/${name}/issues/${issueId}")
}
redirect(s"/${issue.userName}/${issue.repositoryName}/issues/${issue.issueId}")
} else Unauthorized()
})
@@ -188,7 +193,7 @@ trait IssuesControllerBase extends ControllerBase {
defining(repository.owner, repository.name){ case (owner, name) =>
getComment(owner, name, params("id")).map { comment =>
if(isEditableContent(owner, name, comment.commentedUserName)){
updateComment(comment.commentId, form.content)
updateComment(comment.issueId, comment.commentId, form.content)
redirect(s"/${owner}/${name}/issue_comments/_data/${comment.commentId}")
} else Unauthorized()
} getOrElse NotFound()
@@ -199,7 +204,7 @@ trait IssuesControllerBase extends ControllerBase {
defining(repository.owner, repository.name){ case (owner, name) =>
getComment(owner, name, params("id")).map { comment =>
if(isEditableContent(owner, name, comment.commentedUserName)){
Ok(deleteComment(comment.commentId))
Ok(deleteComment(comment.issueId, comment.commentId))
} else Unauthorized()
} getOrElse NotFound()
}
@@ -293,6 +298,11 @@ trait IssuesControllerBase extends ControllerBase {
} getOrElse Ok()
})
ajaxPost("/:owner/:repository/issues/:id/priority")(writableUsersOnly { repository =>
updatePriorityId(repository.owner, repository.name, params("id").toInt, priorityId("priorityId"))
Ok("updated")
})
post("/:owner/:repository/issues/batchedit/state")(writableUsersOnly { repository =>
defining(params.get("value")){ action =>
action match {
@@ -306,7 +316,7 @@ trait IssuesControllerBase extends ControllerBase {
handleComment(issue, None, repository, Some("close"))
}
}
case _ => // TODO BadRequest
case _ => BadRequest()
}
}
})
@@ -337,6 +347,14 @@ trait IssuesControllerBase extends ControllerBase {
}
})
post("/:owner/:repository/issues/batchedit/priority")(writableUsersOnly { repository =>
defining(priorityId("value")){ value =>
executeBatch(repository) {
updatePriorityId(repository.owner, repository.name, _, value)
}
}
})
get("/:owner/:repository/_attached/:file")(referrersOnly { repository =>
(Directory.getAttachedDir(repository.owner, repository.name) match {
case dir if(dir.exists && dir.isDirectory) =>
@@ -350,6 +368,7 @@ trait IssuesControllerBase extends ControllerBase {
val assignedUserName = (key: String) => params.get(key) filter (_.trim != "")
val milestoneId: String => Option[Int] = (key: String) => params.get(key).flatMap(_.toIntOpt)
val priorityId: String => Option[Int] = (key: String) => params.get(key).flatMap(_.toIntOpt)
private def executeBatch(repository: RepositoryService.RepositoryInfo)(execute: Int => Unit) = {
params("checked").split(',') map(_.toInt) foreach execute
@@ -372,32 +391,14 @@ trait IssuesControllerBase extends ControllerBase {
page,
getAssignableUserNames(owner, repoName),
getMilestones(owner, repoName),
getPriorities(owner, repoName),
getLabels(owner, repoName),
countIssue(condition.copy(state = "open" ), false, owner -> repoName),
countIssue(condition.copy(state = "closed"), false, owner -> repoName),
condition,
repository,
isEditable(repository),
isManageable(repository))
}
}
/**
* Tests whether an logged-in user can manage issues.
*/
private def isManageable(repository: RepositoryInfo)(implicit context: Context): Boolean = {
hasDeveloperRole(repository.owner, repository.name, context.loginAccount)
}
/**
* Tests whether an logged-in user can post issues.
*/
private def isEditable(repository: RepositoryInfo)(implicit context: Context): Boolean = {
repository.repository.options.issuesOption match {
case "ALL" => !repository.repository.isPrivate && context.loginAccount.isDefined
case "PUBLIC" => hasGuestRole(repository.owner, repository.name, context.loginAccount)
case "PRIVATE" => hasDeveloperRole(repository.owner, repository.name, context.loginAccount)
case "DISABLE" => false
isIssueEditable(repository),
isIssueManageable(repository))
}
}
@@ -407,5 +408,4 @@ trait IssuesControllerBase extends ControllerBase {
private def isEditableContent(owner: String, repository: String, author: String)(implicit context: Context): Boolean = {
hasDeveloperRole(owner, repository, context.loginAccount) || author == context.loginAccount.get.userName
}
}

View File

@@ -4,7 +4,8 @@ import gitbucket.core.issues.labels.html
import gitbucket.core.service.{RepositoryService, AccountService, IssuesService, LabelsService}
import gitbucket.core.util.{ReferrerAuthenticator, WritableUsersAuthenticator}
import gitbucket.core.util.Implicits._
import io.github.gitbucket.scalatra.forms._
import gitbucket.core.util.SyntaxSugars._
import org.scalatra.forms._
import org.scalatra.i18n.Messages
import org.scalatra.Ok
@@ -82,10 +83,10 @@ trait LabelsControllerBase extends ControllerBase {
}
private def uniqueLabelName: Constraint = new Constraint(){
override def validate(name: String, value: String, params: Map[String, String], messages: Messages): Option[String] = {
val owner = params("owner")
val repository = params("repository")
params.get("labelId").map { labelId =>
override def validate(name: String, value: String, params: Map[String, Seq[String]], messages: Messages): Option[String] = {
val owner = params.value("owner")
val repository = params.value("repository")
params.optionValue("labelId").map { labelId =>
getLabel(owner, repository, value).filter(_.labelId != labelId.toInt).map(_ => "Name has already been taken.")
}.getOrElse {
getLabel(owner, repository, value).map(_ => "Name has already been taken.")

View File

@@ -4,7 +4,7 @@ import gitbucket.core.issues.milestones.html
import gitbucket.core.service.{RepositoryService, MilestonesService, AccountService}
import gitbucket.core.util.{ReferrerAuthenticator, WritableUsersAuthenticator}
import gitbucket.core.util.Implicits._
import io.github.gitbucket.scalatra.forms._
import org.scalatra.forms._
class MilestonesController extends MilestonesControllerBase
with MilestonesService with RepositoryService with AccountService

View File

@@ -0,0 +1,40 @@
package gitbucket.core.controller
import org.scalatra.MovedPermanently
class PreProcessController extends PreProcessControllerBase
trait PreProcessControllerBase extends ControllerBase {
/**
* Provides GitHub compatible URLs for Git client.
*
* <ul>
* <li>git clone http://localhost:8080/owner/repo</li>
* <li>git clone http://localhost:8080/owner/repo.git</li>
* </ul>
*
* @see https://git-scm.com/book/en/v2/Git-Internals-Transfer-Protocols
*/
get("/*/*/info/refs") {
val query = Option(request.getQueryString).map("?" + _).getOrElse("")
halt(MovedPermanently(baseUrl + "/git" + request.getRequestURI + query))
}
/**
* Filter requests from anonymous users.
*
* If anonymous access is allowed, pass all requests.
* But if it's not allowed, demands authentication except some paths.
*/
get(!context.settings.allowAnonymousAccess, context.loginAccount.isEmpty) {
if(!context.currentPath.startsWith("/assets") && !context.currentPath.startsWith("/signin") &&
!context.currentPath.startsWith("/register") && !context.currentPath.endsWith("/info/refs")) {
Unauthorized()
} else {
pass()
}
}
}

View File

@@ -0,0 +1,112 @@
package gitbucket.core.controller
import gitbucket.core.issues.priorities.html
import gitbucket.core.service.{RepositoryService, AccountService, IssuesService, PrioritiesService}
import gitbucket.core.util.{ReferrerAuthenticator, WritableUsersAuthenticator}
import gitbucket.core.util.Implicits._
import gitbucket.core.util.SyntaxSugars._
import org.scalatra.forms._
import org.scalatra.i18n.Messages
import org.scalatra.Ok
class PrioritiesController extends PrioritiesControllerBase
with PrioritiesService with IssuesService with RepositoryService with AccountService
with ReferrerAuthenticator with WritableUsersAuthenticator
trait PrioritiesControllerBase extends ControllerBase {
self: PrioritiesService with IssuesService with RepositoryService
with ReferrerAuthenticator with WritableUsersAuthenticator =>
case class PriorityForm(priorityName: String, description: Option[String], color: String)
val priorityForm = mapping(
"priorityName" -> trim(label("Priority name", text(required, priorityName, uniquePriorityName, maxlength(100)))),
"description" -> trim(label("Description", optional(text(maxlength(255))))),
"priorityColor" -> trim(label("Color", text(required, color)))
)(PriorityForm.apply)
get("/:owner/:repository/issues/priorities")(referrersOnly { repository =>
html.list(
getPriorities(repository.owner, repository.name),
countIssueGroupByPriorities(repository.owner, repository.name, IssuesService.IssueSearchCondition(), Map.empty),
repository,
hasDeveloperRole(repository.owner, repository.name, context.loginAccount))
})
ajaxGet("/:owner/:repository/issues/priorities/new")(writableUsersOnly { repository =>
html.edit(None, repository)
})
ajaxPost("/:owner/:repository/issues/priorities/new", priorityForm)(writableUsersOnly { (form, repository) =>
val priorityId = createPriority(repository.owner, repository.name, form.priorityName, form.description, form.color.substring(1))
html.priority(
getPriority(repository.owner, repository.name, priorityId).get,
countIssueGroupByPriorities(repository.owner, repository.name, IssuesService.IssueSearchCondition(), Map.empty),
repository,
hasDeveloperRole(repository.owner, repository.name, context.loginAccount))
})
ajaxGet("/:owner/:repository/issues/priorities/:priorityId/edit")(writableUsersOnly { repository =>
getPriority(repository.owner, repository.name, params("priorityId").toInt).map { priority =>
html.edit(Some(priority), repository)
} getOrElse NotFound()
})
ajaxPost("/:owner/:repository/issues/priorities/:priorityId/edit", priorityForm)(writableUsersOnly { (form, repository) =>
updatePriority(repository.owner, repository.name, params("priorityId").toInt, form.priorityName, form.description, form.color.substring(1))
html.priority(
getPriority(repository.owner, repository.name, params("priorityId").toInt).get,
countIssueGroupByPriorities(repository.owner, repository.name, IssuesService.IssueSearchCondition(), Map.empty),
repository,
hasDeveloperRole(repository.owner, repository.name, context.loginAccount))
})
ajaxPost("/:owner/:repository/issues/priorities/reorder")(writableUsersOnly { (repository) =>
reorderPriorities(repository.owner, repository.name, params("order")
.split(",")
.map(id => id.toInt)
.zipWithIndex
.toMap)
Ok()
})
ajaxPost("/:owner/:repository/issues/priorities/default")(writableUsersOnly { (repository) =>
setDefaultPriority(repository.owner, repository.name, priorityId("priorityId"))
Ok()
})
ajaxPost("/:owner/:repository/issues/priorities/:priorityId/delete")(writableUsersOnly { repository =>
deletePriority(repository.owner, repository.name, params("priorityId").toInt)
Ok()
})
val priorityId: String => Option[Int] = (key: String) => params.get(key).flatMap(_.toIntOpt)
/**
* Constraint for the identifier such as user name, repository name or page name.
*/
private def priorityName: Constraint = new Constraint(){
override def validate(name: String, value: String, messages: Messages): Option[String] =
if(value.contains(',')){
Some(s"${name} contains invalid character.")
} else if(value.startsWith("_") || value.startsWith("-")){
Some(s"${name} starts with invalid character.")
} else {
None
}
}
private def uniquePriorityName: Constraint = new Constraint(){
override def validate(name: String, value: String, params: Map[String, Seq[String]], messages: Messages): Option[String] = {
val owner = params.value("owner")
val repository = params.value("repository")
params.optionValue("priorityId").map { priorityId =>
getPriority(owner, repository, value).filter(_.priorityId != priorityId.toInt).map(_ => "Name has already been taken.")
}.getOrElse {
getPriority(owner, repository, value).map(_ => "Name has already been taken.")
}
}
}
}

View File

@@ -1,6 +1,7 @@
package gitbucket.core.controller
import gitbucket.core.model.WebHook
import gitbucket.core.plugin.PluginRegistry
import gitbucket.core.pulls.html
import gitbucket.core.service.CommitStatusService
import gitbucket.core.service.MergeService
@@ -8,16 +9,14 @@ import gitbucket.core.service.IssuesService._
import gitbucket.core.service.PullRequestService._
import gitbucket.core.service.RepositoryService.RepositoryInfo
import gitbucket.core.service._
import gitbucket.core.util.ControlUtil._
import gitbucket.core.util.SyntaxSugars._
import gitbucket.core.util.Directory._
import gitbucket.core.util.Implicits._
import gitbucket.core.util.JGitUtil._
import gitbucket.core.util._
import gitbucket.core.view
import gitbucket.core.view.helpers
import io.github.gitbucket.scalatra.forms._
import org.scalatra.forms._
import org.eclipse.jgit.api.Git
import org.eclipse.jgit.lib.PersonIdent
import org.eclipse.jgit.revwalk.RevWalk
import scala.collection.JavaConverters._
@@ -26,14 +25,14 @@ class PullRequestsController extends PullRequestsControllerBase
with RepositoryService with AccountService with IssuesService with PullRequestService with MilestonesService with LabelsService
with CommitsService with ActivityService with WebHookPullRequestService
with ReadableUsersAuthenticator with ReferrerAuthenticator with WritableUsersAuthenticator
with CommitStatusService with MergeService with ProtectedBranchService
with CommitStatusService with MergeService with ProtectedBranchService with PrioritiesService
trait PullRequestsControllerBase extends ControllerBase {
self: RepositoryService with AccountService with IssuesService with MilestonesService with LabelsService
with CommitsService with ActivityService with PullRequestService with WebHookPullRequestService
with ReadableUsersAuthenticator with ReferrerAuthenticator with WritableUsersAuthenticator
with CommitStatusService with MergeService with ProtectedBranchService =>
with CommitStatusService with MergeService with ProtectedBranchService with PrioritiesService =>
val pullRequestForm = mapping(
"title" -> trim(label("Title" , text(required, maxlength(100)))),
@@ -47,11 +46,13 @@ trait PullRequestsControllerBase extends ControllerBase {
"commitIdTo" -> trim(text(required, maxlength(40))),
"assignedUserName" -> trim(optional(text())),
"milestoneId" -> trim(optional(number())),
"priorityId" -> trim(optional(number())),
"labelNames" -> trim(optional(text()))
)(PullRequestForm.apply)
val mergeForm = mapping(
"message" -> trim(label("Message", text(required)))
"message" -> trim(label("Message", text(required))),
"strategy" -> trim(label("Strategy", text(required)))
)(MergeForm.apply)
case class PullRequestForm(
@@ -66,10 +67,11 @@ trait PullRequestsControllerBase extends ControllerBase {
commitIdTo: String,
assignedUserName: Option[String],
milestoneId: Option[Int],
priorityId: Option[Int],
labelNames: Option[String]
)
case class MergeForm(message: String)
case class MergeForm(message: String, strategy: String)
get("/:owner/:repository/pulls")(referrersOnly { repository =>
val q = request.getParameter("q")
@@ -95,12 +97,15 @@ trait PullRequestsControllerBase extends ControllerBase {
getIssueLabels(owner, name, issueId),
getAssignableUserNames(owner, name),
getMilestonesWithIssueCount(owner, name),
getPriorities(owner, name),
getLabels(owner, name),
commits,
diffs,
isEditable(repository),
isManageable(repository),
hasDeveloperRole(pullreq.requestUserName, pullreq.requestRepositoryName, context.loginAccount),
repository,
getRepository(pullreq.requestUserName, pullreq.requestRepositoryName),
flash.toMap.map(f => f._1 -> f._2.toString))
}
}
@@ -112,13 +117,13 @@ trait PullRequestsControllerBase extends ControllerBase {
val owner = repository.owner
val name = repository.name
getPullRequest(owner, name, issueId) map { case(issue, pullreq) =>
val hasConflict = LockUtil.lock(s"${owner}/${name}"){
val conflictMessage = LockUtil.lock(s"${owner}/${name}"){
checkConflict(owner, name, pullreq.branch, issueId)
}
val hasMergePermission = hasDeveloperRole(owner, name, context.loginAccount)
val branchProtection = getProtectedBranchInfo(owner, name, pullreq.branch)
val mergeStatus = PullRequestService.MergeStatus(
hasConflict = hasConflict,
conflictMessage = conflictMessage,
commitStatues = getCommitStatues(owner, name, pullreq.commitIdTo),
branchProtection = branchProtection,
branchIsOutOfDate = JGitUtil.getShaByRef(owner, name, pullreq.branch) != Some(pullreq.commitIdFrom),
@@ -141,22 +146,36 @@ trait PullRequestsControllerBase extends ControllerBase {
} getOrElse NotFound()
})
get("/:owner/:repository/pull/:id/delete/*")(writableUsersOnly { repository =>
params("id").toIntOpt.map { issueId =>
val branchName = multiParams("splat").head
val userName = context.loginAccount.get.userName
if(repository.repository.defaultBranch != branchName){
using(Git.open(getRepositoryDir(repository.owner, repository.name))){ git =>
git.branchDelete().setForce(true).setBranchNames(branchName).call()
recordDeleteBranchActivity(repository.owner, repository.name, userName, branchName)
get("/:owner/:repository/pull/:id/delete_branch")(readableUsersOnly { baseRepository =>
(for {
issueId <- params("id").toIntOpt
loginAccount <- context.loginAccount
(issue, pullreq) <- getPullRequest(baseRepository.owner, baseRepository.name, issueId)
owner = pullreq.requestUserName
name = pullreq.requestRepositoryName
if hasDeveloperRole(owner, name, context.loginAccount)
} yield {
val repository = getRepository(owner, name).get
val branchProtection = getProtectedBranchInfo(owner, name, pullreq.requestBranch)
if(branchProtection.enabled){
flash += "error" -> s"branch ${pullreq.requestBranch} is protected."
} else {
if(repository.repository.defaultBranch != pullreq.requestBranch){
val userName = context.loginAccount.get.userName
using(Git.open(getRepositoryDir(repository.owner, repository.name))){ git =>
git.branchDelete().setForce(true).setBranchNames(pullreq.requestBranch).call()
recordDeleteBranchActivity(repository.owner, repository.name, userName, pullreq.requestBranch)
}
createComment(baseRepository.owner, baseRepository.name, userName, issueId, pullreq.requestBranch, "delete_branch")
} else {
flash += "error" -> s"""Can't delete the default branch "${pullreq.requestBranch}"."""
}
}
createComment(repository.owner, repository.name, userName, issueId, branchName, "delete_branch")
redirect(s"/${repository.owner}/${repository.name}/pull/${issueId}")
} getOrElse NotFound()
redirect(s"/${baseRepository.owner}/${baseRepository.name}/pull/${issueId}")
}) getOrElse NotFound()
})
post("/:owner/:repository/pull/:id/update_branch")(writableUsersOnly { baseRepository =>
post("/:owner/:repository/pull/:id/update_branch")(readableUsersOnly { baseRepository =>
(for {
issueId <- params("id").toIntOpt
loginAccount <- context.loginAccount
@@ -220,7 +239,7 @@ trait PullRequestsControllerBase extends ControllerBase {
}
}
}
redirect(s"/${repository.owner}/${repository.name}/pull/${issueId}")
redirect(s"/${baseRepository.owner}/${baseRepository.name}/pull/${issueId}")
}) getOrElse NotFound()
})
@@ -234,21 +253,37 @@ trait PullRequestsControllerBase extends ControllerBase {
using(Git.open(getRepositoryDir(owner, name))) { git =>
// mark issue as merged and close.
val loginAccount = context.loginAccount.get
createComment(owner, name, loginAccount.userName, issueId, form.message, "merge")
val commentId = createComment(owner, name, loginAccount.userName, issueId, form.message, "merge")
createComment(owner, name, loginAccount.userName, issueId, "Close", "close")
updateClosed(owner, name, issueId, true)
// record activity
recordMergeActivity(owner, name, loginAccount.userName, issueId, form.message)
// merge git repository
mergePullRequest(git, pullreq.branch, issueId,
s"Merge pull request #${issueId} from ${pullreq.requestUserName}/${pullreq.requestBranch}\n\n" + form.message,
new PersonIdent(loginAccount.fullName, loginAccount.mailAddress))
val (commits, _) = getRequestCompareInfo(owner, name, pullreq.commitIdFrom,
pullreq.requestUserName, pullreq.requestRepositoryName, pullreq.commitIdTo)
val revCommits = using(new RevWalk( git.getRepository )){ revWalk =>
commits.flatten.map { commit =>
revWalk.parseCommit(git.getRepository.resolve(commit.id))
}
}.reverse
// merge git repository
form.strategy match {
case "merge-commit" =>
mergePullRequest(git, pullreq.branch, issueId,
s"Merge pull request #${issueId} from ${pullreq.requestUserName}/${pullreq.requestBranch}\n\n" + form.message,
new PersonIdent(loginAccount.fullName, loginAccount.mailAddress))
case "rebase" =>
rebasePullRequest(git, pullreq.branch, issueId, revCommits,
new PersonIdent(loginAccount.fullName, loginAccount.mailAddress))
case "squash" =>
squashPullRequest(git, pullreq.branch, issueId,
s"${issue.title} (#${issueId})\n\n" + form.message,
new PersonIdent(loginAccount.fullName, loginAccount.mailAddress))
}
// close issue by content of pull request
val defaultBranch = getRepository(owner, name).get.repository.defaultBranch
if(pullreq.branch == defaultBranch){
@@ -264,9 +299,10 @@ trait PullRequestsControllerBase extends ControllerBase {
// call web hook
callPullRequestWebHook("closed", repository, issueId, context.baseUrl, context.loginAccount.get)
// notifications
Notifier().toNotify(repository, issue, "merge"){
Notifier.msgStatus(s"${context.baseUrl}/${owner}/${name}/pull/${issueId}")
// call hooks
PluginRegistry().getPullRequestHooks.foreach{ h =>
h.addedComment(commentId, form.message, issue, repository)
h.merged(issue, repository)
}
redirect(s"/${owner}/${name}/pull/${issueId}")
@@ -306,8 +342,8 @@ trait PullRequestsControllerBase extends ControllerBase {
get("/:owner/:repository/compare/*...*")(referrersOnly { forkedRepository =>
val Seq(origin, forked) = multiParams("splat")
val (originOwner, originId) = parseCompareIdentifie(origin, forkedRepository.owner)
val (forkedOwner, forkedId) = parseCompareIdentifie(forked, forkedRepository.owner)
val (originOwner, originId) = parseCompareIdentifier(origin, forkedRepository.owner)
val (forkedOwner, forkedId) = parseCompareIdentifier(forked, forkedRepository.owner)
(for(
originRepositoryName <- if(originOwner == forkedOwner) {
@@ -315,7 +351,7 @@ trait PullRequestsControllerBase extends ControllerBase {
Some(forkedRepository.name)
} else if(forkedRepository.repository.originUserName.isEmpty){
// when ForkedRepository is the original repository
getForkedRepositories(forkedRepository.owner, forkedRepository.name).find(_._1 == originOwner).map(_._2)
getForkedRepositories(forkedRepository.owner, forkedRepository.name).find(_.userName == originOwner).map(_.repositoryName)
} else if(Some(originOwner) == forkedRepository.repository.originUserName){
// Original repository
forkedRepository.repository.originRepositoryName
@@ -362,21 +398,26 @@ trait PullRequestsControllerBase extends ControllerBase {
title,
commits,
diffs,
(forkedRepository.repository.originUserName, forkedRepository.repository.originRepositoryName) match {
case (Some(userName), Some(repositoryName)) => (userName, repositoryName) :: getForkedRepositories(userName, repositoryName)
case _ => (forkedRepository.owner, forkedRepository.name) :: getForkedRepositories(forkedRepository.owner, forkedRepository.name)
},
((forkedRepository.repository.originUserName, forkedRepository.repository.originRepositoryName) match {
case (Some(userName), Some(repositoryName)) => getRepository(userName, repositoryName) match {
case Some(x) => x.repository :: getForkedRepositories(userName, repositoryName)
case None => getForkedRepositories(userName, repositoryName)
}
case _ => forkedRepository.repository :: getForkedRepositories(forkedRepository.owner, forkedRepository.name)
}).map { repository => (repository.userName, repository.repositoryName) },
commits.flatten.map(commit => getCommitComments(forkedRepository.owner, forkedRepository.name, commit.id, false)).flatten.toList,
originId,
forkedId,
oldId.getName,
newId.getName,
getContentTemplate(originRepository, "PULL_REQUEST_TEMPLATE"),
forkedRepository,
originRepository,
forkedRepository,
hasDeveloperRole(originRepository.owner, originRepository.name, context.loginAccount),
getAssignableUserNames(originRepository.owner, originRepository.name),
getMilestones(originRepository.owner, originRepository.name),
getPriorities(originRepository.owner, originRepository.name),
getLabels(originRepository.owner, originRepository.name)
)
}
@@ -391,15 +432,15 @@ trait PullRequestsControllerBase extends ControllerBase {
ajaxGet("/:owner/:repository/compare/*...*/mergecheck")(readableUsersOnly { forkedRepository =>
val Seq(origin, forked) = multiParams("splat")
val (originOwner, tmpOriginBranch) = parseCompareIdentifie(origin, forkedRepository.owner)
val (forkedOwner, tmpForkedBranch) = parseCompareIdentifie(forked, forkedRepository.owner)
val (originOwner, tmpOriginBranch) = parseCompareIdentifier(origin, forkedRepository.owner)
val (forkedOwner, tmpForkedBranch) = parseCompareIdentifier(forked, forkedRepository.owner)
(for(
originRepositoryName <- if(originOwner == forkedOwner){
Some(forkedRepository.name)
} else {
forkedRepository.repository.originRepositoryName.orElse {
getForkedRepositories(forkedRepository.owner, forkedRepository.name).find(_._1 == originOwner).map(_._2)
getForkedRepositories(forkedRepository.owner, forkedRepository.name).find(_.userName == originOwner).map(_.repositoryName)
}
};
originRepository <- getRepository(originOwner, originRepositoryName)
@@ -414,7 +455,7 @@ trait PullRequestsControllerBase extends ControllerBase {
checkConflict(originRepository.owner, originRepository.name, originBranch,
forkedRepository.owner, forkedRepository.name, forkedBranch)
}
html.mergecheck(conflict)
html.mergecheck(conflict.isDefined)
}
}) getOrElse NotFound()
})
@@ -422,75 +463,99 @@ trait PullRequestsControllerBase extends ControllerBase {
post("/:owner/:repository/pulls/new", pullRequestForm)(readableUsersOnly { (form, repository) =>
defining(repository.owner, repository.name){ case (owner, name) =>
val manageable = isManageable(repository)
val editable = isEditable(repository)
val loginUserName = context.loginAccount.get.userName
if(editable) {
val loginUserName = context.loginAccount.get.userName
val issueId = insertIssue(
owner = repository.owner,
repository = repository.name,
loginUser = loginUserName,
title = form.title,
content = form.content,
assignedUserName = if (manageable) form.assignedUserName else None,
milestoneId = if (manageable) form.milestoneId else None,
priorityId = if (manageable) form.priorityId else None,
isPullRequest = true)
val issueId = createIssue(
owner = repository.owner,
repository = repository.name,
loginUser = loginUserName,
title = form.title,
content = form.content,
assignedUserName = if (manageable) form.assignedUserName else None,
milestoneId = if (manageable) form.milestoneId else None,
isPullRequest = true)
createPullRequest(
originUserName = repository.owner,
originRepositoryName = repository.name,
issueId = issueId,
originBranch = form.targetBranch,
requestUserName = form.requestUserName,
requestRepositoryName = form.requestRepositoryName,
requestBranch = form.requestBranch,
commitIdFrom = form.commitIdFrom,
commitIdTo = form.commitIdTo)
createPullRequest(
originUserName = repository.owner,
originRepositoryName = repository.name,
issueId = issueId,
originBranch = form.targetBranch,
requestUserName = form.requestUserName,
requestRepositoryName = form.requestRepositoryName,
requestBranch = form.requestBranch,
commitIdFrom = form.commitIdFrom,
commitIdTo = form.commitIdTo)
// insert labels
if (manageable) {
form.labelNames.map { value =>
val labels = getLabels(owner, name)
value.split(",").foreach { labelName =>
labels.find(_.labelName == labelName).map { label =>
registerIssueLabel(repository.owner, repository.name, issueId, label.labelId)
}
// insert labels
if (manageable) {
form.labelNames.map { value =>
val labels = getLabels(owner, name)
value.split(",").foreach { labelName =>
labels.find(_.labelName == labelName).map { label =>
registerIssueLabel(repository.owner, repository.name, issueId, label.labelId)
}
}
}
}
// fetch requested branch
fetchAsPullRequest(owner, name, form.requestUserName, form.requestRepositoryName, form.requestBranch, issueId)
// fetch requested branch
fetchAsPullRequest(owner, name, form.requestUserName, form.requestRepositoryName, form.requestBranch, issueId)
// record activity
recordPullRequestActivity(owner, name, loginUserName, issueId, form.title)
// record activity
recordPullRequestActivity(owner, name, loginUserName, issueId, form.title)
// call web hook
callPullRequestWebHook("opened", repository, issueId, context.baseUrl, context.loginAccount.get)
// call web hook
callPullRequestWebHook("opened", repository, issueId, context.baseUrl, context.loginAccount.get)
getIssue(owner, name, issueId.toString) foreach { issue =>
// extract references and create refer comment
createReferComment(owner, name, issue, form.title + " " + form.content.getOrElse(""), context.loginAccount.get)
getIssue(owner, name, issueId.toString) foreach { issue =>
// extract references and create refer comment
createReferComment(owner, name, issue, form.title + " " + form.content.getOrElse(""), context.loginAccount.get)
// notifications
Notifier().toNotify(repository, issue, form.content.getOrElse("")) {
Notifier.msgPullRequest(s"${context.baseUrl}/${owner}/${name}/pull/${issueId}")
}
}
// call hooks
PluginRegistry().getPullRequestHooks.foreach(_.created(issue, repository))
}
redirect(s"/${owner}/${name}/pull/${issueId}")
} else Unauthorized()
redirect(s"/${owner}/${name}/pull/${issueId}")
}
})
ajaxGet("/:owner/:repository/pulls/proposals")(readableUsersOnly { repository =>
val branches = JGitUtil.getBranches(
owner = repository.owner,
name = repository.name,
defaultBranch = repository.repository.defaultBranch,
origin = repository.repository.originUserName.isEmpty
)
.filter(x => x.mergeInfo.map(_.ahead).getOrElse(0) > 0 && x.mergeInfo.map(_.behind).getOrElse(0) == 0)
.sortBy(br => (br.mergeInfo.isEmpty, br.commitTime))
.map(_.name)
.reverse
val targetRepository = (for {
parentUserName <- repository.repository.parentUserName
parentRepoName <- repository.repository.parentRepositoryName
parentRepository <- getRepository(parentUserName, parentRepoName)
} yield {
parentRepository
}).getOrElse {
repository
}
val proposedBranches = branches.filter { branch =>
getPullRequestsByRequest(repository.owner, repository.name, branch, None).isEmpty
}
html.proposals(proposedBranches, targetRepository, repository)
})
/**
* Parses branch identifier and extracts owner and branch name as tuple.
*
* - "owner:branch" to ("owner", "branch")
* - "branch" to ("defaultOwner", "branch")
*/
private def parseCompareIdentifie(value: String, defaultOwner: String): (String, String) =
private def parseCompareIdentifier(value: String, defaultOwner: String): (String, String) =
if(value.contains(':')){
val array = value.split(":")
(array(0), array(1))
@@ -498,26 +563,6 @@ trait PullRequestsControllerBase extends ControllerBase {
(defaultOwner, value)
}
private def getRequestCompareInfo(userName: String, repositoryName: String, branch: String,
requestUserName: String, requestRepositoryName: String, requestCommitId: String): (Seq[Seq[CommitInfo]], Seq[DiffInfo]) =
using(
Git.open(getRepositoryDir(userName, repositoryName)),
Git.open(getRepositoryDir(requestUserName, requestRepositoryName))
){ (oldGit, newGit) =>
val oldId = oldGit.getRepository.resolve(branch)
val newId = newGit.getRepository.resolve(requestCommitId)
val commits = newGit.log.addRange(oldId, newId).call.iterator.asScala.map { revCommit =>
new CommitInfo(revCommit)
}.toList.splitWith { (commit1, commit2) =>
helpers.date(commit1.commitTime) == view.helpers.date(commit2.commitTime)
}
val diffs = JGitUtil.getDiffs(newGit, oldId.getName, newId.getName, true)
(commits, diffs)
}
private def searchPullRequests(userName: Option[String], repository: RepositoryService.RepositoryInfo) =
defining(repository.owner, repository.name){ case (owner, repoName) =>
val page = IssueSearchCondition.page(request)
@@ -531,6 +576,7 @@ trait PullRequestsControllerBase extends ControllerBase {
page,
getAssignableUserNames(owner, repoName),
getMilestones(owner, repoName),
getPriorities(owner, repoName),
getLabels(owner, repoName),
countIssue(condition.copy(state = "open" ), true, owner -> repoName),
countIssue(condition.copy(state = "closed"), true, owner -> repoName),

View File

@@ -0,0 +1,151 @@
package gitbucket.core.controller
import java.io.File
import gitbucket.core.service.{AccountService, ActivityService, ReleaseService, RepositoryService}
import gitbucket.core.util.{FileUtil, ReadableUsersAuthenticator, ReferrerAuthenticator, WritableUsersAuthenticator}
import gitbucket.core.util.Directory._
import gitbucket.core.util.Implicits._
import org.scalatra.forms._
import gitbucket.core.releases.html
import org.apache.commons.io.FileUtils
import scala.collection.JavaConverters._
class ReleaseController extends ReleaseControllerBase
with RepositoryService
with AccountService
with ReleaseService
with ActivityService
with ReadableUsersAuthenticator
with ReferrerAuthenticator
with WritableUsersAuthenticator
trait ReleaseControllerBase extends ControllerBase {
self: RepositoryService
with AccountService
with ReleaseService
with ReadableUsersAuthenticator
with ReferrerAuthenticator
with WritableUsersAuthenticator
with ActivityService =>
case class ReleaseForm(
name: String,
content: Option[String]
)
val releaseForm = mapping(
"name" -> trim(text(required)),
"content" -> trim(optional(text()))
)(ReleaseForm.apply)
get("/:owner/:repository/releases")(referrersOnly {repository =>
val releases = getReleases(repository.owner, repository.name)
val assets = getReleaseAssetsMap(repository.owner, repository.name)
html.list(
repository,
repository.tags.reverse.map { tag =>
(tag, releases.find(_.tag == tag.name).map { release => (release, assets(release)) })
},
hasDeveloperRole(repository.owner, repository.name, context.loginAccount))
})
get("/:owner/:repository/releases/:tag")(referrersOnly { repository =>
val tag = params("tag")
getRelease(repository.owner, repository.name, tag).map { release =>
html.release(release, getReleaseAssets(repository.owner, repository.name, tag), hasDeveloperRole(repository.owner, repository.name, context.loginAccount), repository)
}.getOrElse(NotFound())
})
get("/:owner/:repository/releases/:tag/assets/:fileId")(referrersOnly {repository =>
val tag = params("tag")
val fileId = params("fileId")
(for {
_ <- repository.tags.find(_.name == tag)
_ <- getRelease(repository.owner, repository.name, tag)
asset <- getReleaseAsset(repository.owner, repository.name, tag, fileId)
} yield {
response.setHeader("Content-Disposition", s"attachment; filename=${asset.label}")
RawData(
FileUtil.getMimeType(asset.label),
new File(getReleaseFilesDir(repository.owner, repository.name), tag + "/" + fileId)
)
}).getOrElse(NotFound())
})
get("/:owner/:repository/releases/:tag/create")(writableUsersOnly {repository =>
html.form(repository, params("tag"), None)
})
post("/:owner/:repository/releases/:tag/create", releaseForm)(writableUsersOnly { (form, repository) =>
val tag = params("tag")
val loginAccount = context.loginAccount.get
// Insert into RELEASE
createRelease(repository.owner, repository.name, form.name, form.content, tag, loginAccount)
// Insert into RELEASE_ASSET
request.getParameterNames.asScala.filter(_.startsWith("file:")).foreach { paramName =>
val Array(_, fileId) = paramName.split(":")
val fileName = params(paramName)
val size = new java.io.File(getReleaseFilesDir(repository.owner, repository.name), tag + "/" + fileId).length
createReleaseAsset(repository.owner, repository.name, tag, fileId, fileName, size, loginAccount)
}
recordReleaseActivity(repository.owner, repository.name, loginAccount.userName, form.name)
redirect(s"/${repository.owner}/${repository.name}/releases/${tag}")
})
get("/:owner/:repository/releases/:tag/edit")(writableUsersOnly {repository =>
val tag = params("tag")
getRelease(repository.owner, repository.name, tag).map { release =>
html.form(repository, release.tag, Some(release, getReleaseAssets(repository.owner, repository.name, tag)))
}.getOrElse(NotFound())
})
post("/:owner/:repository/releases/:tag/edit", releaseForm)(writableUsersOnly { (form, repository) =>
val tag = params("tag")
val loginAccount = context.loginAccount.get
getRelease(repository.owner, repository.name, tag).map { release =>
// Update RELEASE
updateRelease(repository.owner, repository.name, tag, form.name, form.content)
// Delete and Insert RELEASE_ASSET
val assets = getReleaseAssets(repository.owner, repository.name, tag)
deleteReleaseAssets(repository.owner, repository.name, tag)
val fileIds = request.getParameterNames.asScala.filter(_.startsWith("file:")).map { paramName =>
val Array(_, fileId) = paramName.split(":")
val fileName = params(paramName)
val size = new java.io.File(getReleaseFilesDir(repository.owner, repository.name), release.tag + "/" + fileId).length
createReleaseAsset(repository.owner, repository.name, tag, fileId, fileName, size, loginAccount)
fileId
}
assets.foreach { asset =>
if(!fileIds.contains(asset.fileName)){
val file = new java.io.File(getReleaseFilesDir(repository.owner, repository.name), release.tag + "/" + asset.fileName)
FileUtils.forceDelete(file)
}
}
redirect(s"/${release.userName}/${release.repositoryName}/releases/${tag}")
}.getOrElse(NotFound())
})
post("/:owner/:repository/releases/:tag/delete")(writableUsersOnly { repository =>
val tag = params("tag")
getRelease(repository.owner, repository.name, tag).foreach { release =>
FileUtils.deleteDirectory(new File(getReleaseFilesDir(repository.owner, repository.name), release.tag))
}
deleteRelease(repository.owner, repository.name, tag)
redirect(s"/${repository.owner}/${repository.name}/releases")
})
}

View File

@@ -1,29 +1,33 @@
package gitbucket.core.controller
import java.time.{LocalDateTime, ZoneId, ZoneOffset}
import java.util.Date
import gitbucket.core.settings.html
import gitbucket.core.model.WebHook
import gitbucket.core.service.{RepositoryService, AccountService, WebHookService, ProtectedBranchService, CommitStatusService}
import gitbucket.core.model.{RepositoryWebHook, WebHook}
import gitbucket.core.service._
import gitbucket.core.service.WebHookService._
import gitbucket.core.util._
import gitbucket.core.util.JGitUtil._
import gitbucket.core.util.ControlUtil._
import gitbucket.core.util.SyntaxSugars._
import gitbucket.core.util.Implicits._
import gitbucket.core.util.Directory._
import io.github.gitbucket.scalatra.forms._
import org.scalatra.forms._
import org.apache.commons.io.FileUtils
import org.scalatra.i18n.Messages
import org.eclipse.jgit.api.Git
import org.eclipse.jgit.lib.Constants
import org.eclipse.jgit.lib.ObjectId
import gitbucket.core.model.WebHookContentType
import gitbucket.core.plugin.PluginRegistry
class RepositorySettingsController extends RepositorySettingsControllerBase
with RepositoryService with AccountService with WebHookService with ProtectedBranchService with CommitStatusService
with RepositoryService with AccountService with WebHookService with ProtectedBranchService with CommitStatusService with DeployKeyService
with OwnerAuthenticator with UsersAuthenticator
trait RepositorySettingsControllerBase extends ControllerBase {
self: RepositoryService with AccountService with WebHookService with ProtectedBranchService with CommitStatusService
self: RepositoryService with AccountService with WebHookService with ProtectedBranchService with CommitStatusService with DeployKeyService
with OwnerAuthenticator with UsersAuthenticator =>
// for repository options
@@ -37,9 +41,9 @@ trait RepositorySettingsControllerBase extends ControllerBase {
externalWikiUrl: Option[String],
allowFork: Boolean
)
val optionsForm = mapping(
"repositoryName" -> trim(label("Repository Name" , text(required, maxlength(100), identifier, renameRepositoryName))),
"repositoryName" -> trim(label("Repository Name" , text(required, maxlength(100), repository, renameRepositoryName))),
"description" -> trim(label("Description" , optional(text()))),
"isPrivate" -> trim(label("Repository Type" , boolean())),
"issuesOption" -> trim(label("Issues Option" , text(required, featureOption))),
@@ -56,12 +60,15 @@ trait RepositorySettingsControllerBase extends ControllerBase {
"defaultBranch" -> trim(label("Default Branch" , text(required, maxlength(100))))
)(DefaultBranchForm.apply)
// // for collaborator addition
// case class CollaboratorForm(userName: String)
//
// val collaboratorForm = mapping(
// "userName" -> trim(label("Username", text(required, collaborator)))
// )(CollaboratorForm.apply)
// for deploy key
case class DeployKeyForm(title: String, publicKey: String, allowWrite: Boolean)
val deployKeyForm = mapping(
"title" -> trim(label("Title", text(required, maxlength(100)))),
"publicKey" -> trim2(label("Key" , text(required))), // TODO duplication check in the repository?
"allowWrite" -> trim(label("Key" , boolean()))
)(DeployKeyForm.apply)
// for web hook url addition
case class WebHookForm(url: String, events: Set[WebHook.Event], ctype: WebHookContentType, token: Option[String])
@@ -88,14 +95,14 @@ trait RepositorySettingsControllerBase extends ControllerBase {
get("/:owner/:repository/settings")(ownerOnly { repository =>
redirect(s"/${repository.owner}/${repository.name}/settings/options")
})
/**
* Display the Options page.
*/
get("/:owner/:repository/settings/options")(ownerOnly {
html.options(_, flash.get("info"))
})
/**
* Save the repository options.
*/
@@ -119,12 +126,27 @@ trait RepositorySettingsControllerBase extends ControllerBase {
renameRepository(repository.owner, repository.name, repository.owner, form.repositoryName)
// Move git repository
defining(getRepositoryDir(repository.owner, repository.name)){ dir =>
FileUtils.moveDirectory(dir, getRepositoryDir(repository.owner, form.repositoryName))
if(dir.isDirectory){
FileUtils.moveDirectory(dir, getRepositoryDir(repository.owner, form.repositoryName))
}
}
// Move wiki repository
defining(getWikiRepositoryDir(repository.owner, repository.name)){ dir =>
FileUtils.moveDirectory(dir, getWikiRepositoryDir(repository.owner, form.repositoryName))
if(dir.isDirectory) {
FileUtils.moveDirectory(dir, getWikiRepositoryDir(repository.owner, form.repositoryName))
}
}
// Move files directory
defining(getRepositoryFilesDir(repository.owner, repository.name)){ dir =>
if(dir.isDirectory) {
FileUtils.moveDirectory(dir, getRepositoryFilesDir(repository.owner, form.repositoryName))
}
}
// Delete parent directory
FileUtil.deleteDirectoryIfEmpty(getRepositoryFilesDir(repository.owner, repository.name))
// Call hooks
PluginRegistry().getRepositoryHooks.foreach(_.renamed(repository.owner, repository.name, form.repositoryName))
}
flash += "info" -> "Repository settings has been updated."
redirect(s"/${repository.owner}/${form.repositoryName}/settings/options")
@@ -134,11 +156,11 @@ trait RepositorySettingsControllerBase extends ControllerBase {
get("/:owner/:repository/settings/branches")(ownerOnly { repository =>
val protecteions = getProtectedBranchList(repository.owner, repository.name)
html.branches(repository, protecteions, flash.get("info"))
});
})
/** Update default branch */
post("/:owner/:repository/settings/update_default_branch", defaultBranchForm)(ownerOnly { (form, repository) =>
if(repository.branchList.find(_ == form.defaultBranch).isEmpty){
if(!repository.branchList.contains(form.defaultBranch)){
redirect(s"/${repository.owner}/${repository.name}/settings/options")
} else {
saveRepositoryDefaultBranch(repository.owner, repository.name, form.defaultBranch)
@@ -155,11 +177,12 @@ trait RepositorySettingsControllerBase extends ControllerBase {
get("/:owner/:repository/settings/branches/:branch")(ownerOnly { repository =>
import gitbucket.core.api._
val branch = params("branch")
if(repository.branchList.find(_ == branch).isEmpty){
if(!repository.branchList.contains(branch)){
redirect(s"/${repository.owner}/${repository.name}/settings/branches")
} else {
val protection = ApiBranchProtection(getProtectedBranchInfo(repository.owner, repository.name, branch))
val lastWeeks = getRecentStatuesContexts(repository.owner, repository.name, org.joda.time.LocalDateTime.now.minusWeeks(1).toDate).toSet
val lastWeeks = getRecentStatuesContexts(repository.owner, repository.name,
Date.from(LocalDateTime.now.minusWeeks(1).toInstant(ZoneOffset.UTC))).toSet
val knownContexts = (lastWeeks ++ protection.status.contexts).toSeq.sortBy(identity)
html.branchprotection(repository, branch, protection, knownContexts, flash.get("info"))
}
@@ -196,8 +219,8 @@ trait RepositorySettingsControllerBase extends ControllerBase {
* Display the web hook edit page.
*/
get("/:owner/:repository/settings/hooks/new")(ownerOnly { repository =>
val webhook = WebHook(repository.owner, repository.name, "", WebHookContentType.FORM, None)
html.edithooks(webhook, Set(WebHook.Push), repository, flash.get("info"), true)
val webhook = RepositoryWebHook(repository.owner, repository.name, "", WebHookContentType.FORM, None)
html.edithook(webhook, Set(WebHook.Push), repository, true)
})
/**
@@ -235,10 +258,10 @@ trait RepositorySettingsControllerBase extends ControllerBase {
val url = params("url")
val token = Some(params("token"))
val ctype = WebHookContentType.valueOf(params("ctype"))
val dummyWebHookInfo = WebHook(repository.owner, repository.name, url, ctype, token)
val dummyWebHookInfo = RepositoryWebHook(repository.owner, repository.name, url, ctype, token)
val dummyPayload = {
val ownerAccount = getAccountByUserName(repository.owner).get
val commits = if(repository.commitCount == 0) List.empty else git.log
val commits = if(JGitUtil.isEmpty(git)) List.empty else git.log
.add(git.getRepository.resolve(repository.repository.defaultBranch))
.setMaxCount(4)
.call.iterator.asScala.map(new CommitInfo(_)).toList
@@ -272,7 +295,7 @@ trait RepositorySettingsControllerBase extends ControllerBase {
"headers" -> _headers(req.getAllHeaders),
"payload" -> json
)).recover(toErrorMap), 20 seconds),
"responce" -> Await.result(resFuture.map(res => Map(
"response" -> Await.result(resFuture.map(res => Map(
"status" -> res.getStatusLine(),
"body" -> EntityUtils.toString(res.getEntity()),
"headers" -> _headers(res.getAllHeaders())
@@ -286,7 +309,7 @@ trait RepositorySettingsControllerBase extends ControllerBase {
*/
get("/:owner/:repository/settings/hooks/edit")(ownerOnly { repository =>
getWebHook(repository.owner, repository.name, params("url")).map{ case (webhook, events) =>
html.edithooks(webhook, events, repository, flash.get("info"), false)
html.edithook(webhook, events, repository, false)
} getOrElse NotFound()
})
@@ -317,12 +340,25 @@ trait RepositorySettingsControllerBase extends ControllerBase {
renameRepository(repository.owner, repository.name, form.newOwner, repository.name)
// Move git repository
defining(getRepositoryDir(repository.owner, repository.name)){ dir =>
FileUtils.moveDirectory(dir, getRepositoryDir(form.newOwner, repository.name))
if(dir.isDirectory){
FileUtils.moveDirectory(dir, getRepositoryDir(form.newOwner, repository.name))
}
}
// Move wiki repository
defining(getWikiRepositoryDir(repository.owner, repository.name)){ dir =>
FileUtils.moveDirectory(dir, getWikiRepositoryDir(form.newOwner, repository.name))
if(dir.isDirectory) {
FileUtils.moveDirectory(dir, getWikiRepositoryDir(form.newOwner, repository.name))
}
}
// Move files directory
defining(getRepositoryFilesDir(repository.owner, repository.name)){ dir =>
if(dir.isDirectory) {
FileUtils.moveDirectory(dir, getRepositoryFilesDir(form.newOwner, repository.name))
}
}
// Call hooks
PluginRegistry().getRepositoryHooks.foreach(_.transferred(repository.owner, form.newOwner, repository.name))
}
}
redirect(s"/${form.newOwner}/${repository.name}")
@@ -333,12 +369,18 @@ trait RepositorySettingsControllerBase extends ControllerBase {
*/
post("/:owner/:repository/settings/delete")(ownerOnly { repository =>
LockUtil.lock(s"${repository.owner}/${repository.name}"){
// Delete the repository and related files
deleteRepository(repository.owner, repository.name)
FileUtils.deleteDirectory(getRepositoryDir(repository.owner, repository.name))
FileUtils.deleteDirectory(getWikiRepositoryDir(repository.owner, repository.name))
FileUtils.deleteDirectory(getTemporaryDir(repository.owner, repository.name))
FileUtils.deleteDirectory(getRepositoryFilesDir(repository.owner, repository.name))
// Call hooks
PluginRegistry().getRepositoryHooks.foreach(_.deleted(repository.owner, repository.name))
}
redirect(s"/${repository.owner}")
})
@@ -348,13 +390,31 @@ trait RepositorySettingsControllerBase extends ControllerBase {
post("/:owner/:repository/settings/gc")(ownerOnly { repository =>
LockUtil.lock(s"${repository.owner}/${repository.name}") {
using(Git.open(getRepositoryDir(repository.owner, repository.name))) { git =>
git.gc();
git.gc().call()
}
}
flash += "info" -> "Garbage collection has been executed."
redirect(s"/${repository.owner}/${repository.name}/settings/danger")
})
/** List deploy keys */
get("/:owner/:repository/settings/deploykey")(ownerOnly { repository =>
html.deploykey(repository, getDeployKeys(repository.owner, repository.name))
})
/** Register a deploy key */
post("/:owner/:repository/settings/deploykey", deployKeyForm)(ownerOnly { (form, repository) =>
addDeployKey(repository.owner, repository.name, form.title, form.publicKey, form.allowWrite)
redirect(s"/${repository.owner}/${repository.name}/settings/deploykey")
})
/** Delete a deploy key */
get("/:owner/:repository/settings/deploykey/delete/:id")(ownerOnly { repository =>
val deployKeyId = params("id").toInt
deleteDeployKey(repository.owner, repository.name, deployKeyId)
redirect(s"/${repository.owner}/${repository.name}/settings/deploykey")
})
/**
* Provides duplication check for web hook url.
*/
@@ -372,12 +432,12 @@ trait RepositorySettingsControllerBase extends ControllerBase {
}
private def webhookEvents = new ValueType[Set[WebHook.Event]]{
def convert(name: String, params: Map[String, String], messages: Messages): Set[WebHook.Event] = {
def convert(name: String, params: Map[String, Seq[String]], messages: Messages): Set[WebHook.Event] = {
WebHook.Event.values.flatMap { t =>
params.get(name + "." + t.name).map(_ => t)
}.toSet
}
def validate(name: String, params: Map[String, String], messages: Messages): Seq[(String, String)] = if(convert(name,params,messages).isEmpty){
def validate(name: String, params: Map[String, Seq[String]], messages: Messages): Seq[(String, String)] = if(convert(name,params,messages).isEmpty){
Seq(name -> messages("error.required").format(name))
} else {
Nil
@@ -403,19 +463,22 @@ trait RepositorySettingsControllerBase extends ControllerBase {
* Duplicate check for the rename repository name.
*/
private def renameRepositoryName: Constraint = new Constraint(){
override def validate(name: String, value: String, params: Map[String, String], messages: Messages): Option[String] =
params.get("repository").filter(_ != value).flatMap { _ =>
params.get("owner").flatMap { userName =>
getRepositoryNamesOfUser(userName).find(_ == value).map(_ => "Repository already exists.")
}
override def validate(name: String, value: String, params: Map[String, Seq[String]], messages: Messages): Option[String] = {
for {
repoName <- params.optionValue("repository") if repoName != value
userName <- params.optionValue("owner")
_ <- getRepositoryNamesOfUser(userName).find(_ == value)
} yield {
"Repository already exists."
}
}
}
/**
*
*/
private def featureOption: Constraint = new Constraint(){
override def validate(name: String, value: String, params: Map[String, String], messages: Messages): Option[String] =
override def validate(name: String, value: String, params: Map[String, Seq[String]], messages: Messages): Option[String] =
if(Seq("DISABLE", "PRIVATE", "PUBLIC", "ALL").contains(value)) None else Some("Option is invalid.")
}

View File

@@ -1,6 +1,7 @@
package gitbucket.core.controller
import javax.servlet.http.{HttpServletResponse, HttpServletRequest}
import java.io.File
import javax.servlet.http.{HttpServletRequest, HttpServletResponse}
import gitbucket.core.plugin.PluginRegistry
import gitbucket.core.repo.html
@@ -9,24 +10,24 @@ import gitbucket.core.service._
import gitbucket.core.util._
import gitbucket.core.util.JGitUtil._
import gitbucket.core.util.StringUtil._
import gitbucket.core.util.ControlUtil._
import gitbucket.core.util.SyntaxSugars._
import gitbucket.core.util.Implicits._
import gitbucket.core.util.Directory._
import gitbucket.core.model.{Account, WebHook}
import gitbucket.core.model.{Account, CommitState, CommitStatus, WebHook}
import gitbucket.core.service.WebHookService._
import gitbucket.core.view
import gitbucket.core.view.helpers
import io.github.gitbucket.scalatra.forms._
import org.scalatra.forms._
import org.apache.commons.io.FileUtils
import org.eclipse.jgit.api.{ArchiveCommand, Git}
import org.eclipse.jgit.archive.{TgzFormat, ZipFormat}
import org.eclipse.jgit.dircache.DirCache
import org.eclipse.jgit.dircache.{DirCache, DirCacheBuilder}
import org.eclipse.jgit.errors.MissingObjectException
import org.eclipse.jgit.lib._
import org.eclipse.jgit.revwalk.RevCommit
import org.eclipse.jgit.treewalk._
import org.eclipse.jgit.transport.{ReceiveCommand, ReceivePack}
import org.json4s.jackson.Serialization
import org.scalatra._
import org.scalatra.i18n.Messages
class RepositoryViewerController extends RepositoryViewerControllerBase
@@ -45,6 +46,13 @@ trait RepositoryViewerControllerBase extends ControllerBase {
ArchiveCommand.registerFormat("zip", new ZipFormat)
ArchiveCommand.registerFormat("tar.gz", new TgzFormat)
case class UploadForm(
branch: String,
path: String,
uploadFiles: String,
message: Option[String]
)
case class EditorForm(
branch: String,
path: String,
@@ -53,14 +61,16 @@ trait RepositoryViewerControllerBase extends ControllerBase {
charset: String,
lineSeparator: String,
newFileName: String,
oldFileName: Option[String]
oldFileName: Option[String],
commit: String
)
case class DeleteForm(
branch: String,
path: String,
message: Option[String],
fileName: String
fileName: String,
commit: String
)
case class CommentForm(
@@ -71,6 +81,13 @@ trait RepositoryViewerControllerBase extends ControllerBase {
issueId: Option[Int]
)
val uploadForm = mapping(
"branch" -> trim(label("Branch", text(required))),
"path" -> trim(label("Path", text())),
"uploadFiles" -> trim(label("Upload files", text(required))),
"message" -> trim(label("Message", optional(text()))),
)(UploadForm.apply)
val editorForm = mapping(
"branch" -> trim(label("Branch", text(required))),
"path" -> trim(label("Path", text())),
@@ -79,14 +96,16 @@ trait RepositoryViewerControllerBase extends ControllerBase {
"charset" -> trim(label("Charset", text(required))),
"lineSeparator" -> trim(label("Line Separator", text(required))),
"newFileName" -> trim(label("Filename", text(required))),
"oldFileName" -> trim(label("Old filename", optional(text())))
"oldFileName" -> trim(label("Old filename", optional(text()))),
"commit" -> trim(label("Commit", text(required, conflict)))
)(EditorForm.apply)
val deleteForm = mapping(
"branch" -> trim(label("Branch", text(required))),
"path" -> trim(label("Path", text())),
"message" -> trim(label("Message", optional(text()))),
"fileName" -> trim(label("Filename", text(required)))
"fileName" -> trim(label("Filename", text(required))),
"commit" -> trim(label("Commit", text(required, conflict)))
)(DeleteForm.apply)
val commentForm = mapping(
@@ -102,30 +121,60 @@ trait RepositoryViewerControllerBase extends ControllerBase {
*/
post("/:owner/:repository/_preview")(referrersOnly { repository =>
contentType = "text/html"
helpers.markdown(
markdown = params("content"),
repository = repository,
enableWikiLink = params("enableWikiLink").toBoolean,
enableRefsLink = params("enableRefsLink").toBoolean,
enableLineBreaks = params("enableLineBreaks").toBoolean,
enableTaskList = params("enableTaskList").toBoolean,
enableAnchor = false,
hasWritePermission = hasDeveloperRole(repository.owner, repository.name, context.loginAccount)
)
val filename = params.get("filename")
filename match {
case Some(f) => helpers.renderMarkup(
filePath = List(f),
fileContent = params("content"),
branch = "master",
repository = repository,
enableWikiLink = params("enableWikiLink").toBoolean,
enableRefsLink = params("enableRefsLink").toBoolean,
enableAnchor = false
)
case None => helpers.markdown(
markdown = params("content"),
repository = repository,
enableWikiLink = params("enableWikiLink").toBoolean,
enableRefsLink = params("enableRefsLink").toBoolean,
enableLineBreaks = params("enableLineBreaks").toBoolean,
enableTaskList = params("enableTaskList").toBoolean,
enableAnchor = false,
hasWritePermission = hasDeveloperRole(repository.owner, repository.name, context.loginAccount)
)
}
})
/**
* Displays the file list of the repository root and the default branch.
*/
get("/:owner/:repository") {
params.get("go-get") match {
case Some("1") => defining(request.paths){ paths =>
getRepository(paths(0), paths(1)).map(gitbucket.core.html.goget(_))getOrElse NotFound()
val owner = params("owner")
val repository = params("repository")
if (RepositoryCreationService.isCreating(owner, repository)) {
gitbucket.core.repo.html.creating(owner, repository)
} else {
params.get("go-get") match {
case Some("1") => defining(request.paths) { paths =>
getRepository(owner, repository).map(gitbucket.core.html.goget(_)) getOrElse NotFound()
}
case _ => referrersOnly(fileList(_))
}
case _ => referrersOnly(fileList(_))
}
}
ajaxGet("/:owner/:repository/creating") {
val owner = params("owner")
val repository = params("repository")
contentType = formats("json")
val creating = RepositoryCreationService.isCreating(owner, repository)
Serialization.write(Map(
"creating" -> creating,
"error" -> (if(creating) None else RepositoryCreationService.getCreationError(owner, repository))
))
}
/**
* Displays the file list of the specified path and branch.
*/
@@ -145,13 +194,24 @@ trait RepositoryViewerControllerBase extends ControllerBase {
val (branchName, path) = repository.splitPath(multiParams("splat").head)
val page = params.get("page").flatMap(_.toIntOpt).getOrElse(1)
def getStatuses(sha: String): List[CommitStatus] = {
getCommitStatues(repository.owner, repository.name, sha)
}
def getSummary(statuses: List[CommitStatus]): (CommitState, String) = {
val stateMap = statuses.groupBy(_.state)
val state = CommitState.combine(stateMap.keySet)
val summary = stateMap.map{ case (keyState, states) => states.size+" "+keyState.name }.mkString(", ")
state -> summary
}
using(Git.open(getRepositoryDir(repository.owner, repository.name))){ git =>
JGitUtil.getCommitLog(git, branchName, page, 30, path) match {
case Right((logs, hasNext)) =>
html.commits(if(path.isEmpty) Nil else path.split("/").toList, branchName, repository,
logs.splitWith{ (commit1, commit2) =>
view.helpers.date(commit1.commitTime) == view.helpers.date(commit2.commitTime)
}, page, hasNext, hasDeveloperRole(repository.owner, repository.name, context.loginAccount))
}, page, hasNext, hasDeveloperRole(repository.owner, repository.name, context.loginAccount), getStatuses, getSummary)
case Left(_) => NotFound()
}
}
@@ -160,11 +220,50 @@ trait RepositoryViewerControllerBase extends ControllerBase {
get("/:owner/:repository/new/*")(writableUsersOnly { repository =>
val (branch, path) = repository.splitPath(multiParams("splat").head)
val protectedBranch = getProtectedBranchInfo(repository.owner, repository.name, branch).needStatusCheck(context.loginAccount.get.userName)
html.editor(branch, repository, if(path.length == 0) Nil else path.split("/").toList,
None, JGitUtil.ContentInfo("text", None, Some("UTF-8")),
protectedBranch)
using(Git.open(getRepositoryDir(repository.owner, repository.name))) { git =>
val revCommit = JGitUtil.getRevCommitFromId(git, git.getRepository.resolve(branch))
html.editor(
branch = branch,
repository = repository,
pathList = if (path.length == 0) Nil else path.split("/").toList,
fileName = None,
content = JGitUtil.ContentInfo("text", None, None, Some("UTF-8")),
protectedBranch = protectedBranch,
commit = revCommit.getName
)
}
})
get("/:owner/:repository/upload/*")(writableUsersOnly { repository =>
val (branch, path) = repository.splitPath(multiParams("splat").head)
val protectedBranch = getProtectedBranchInfo(repository.owner, repository.name, branch).needStatusCheck(context.loginAccount.get.userName)
html.upload(branch, repository, if(path.length == 0) Nil else path.split("/").toList, protectedBranch)
})
post("/:owner/:repository/upload", uploadForm)(writableUsersOnly { (form, repository) =>
val files = form.uploadFiles.split("\n").map { line =>
val i = line.indexOf(':')
CommitFile(line.substring(0, i).trim, line.substring(i + 1).trim)
}
commitFiles(
repository = repository,
branch = form.branch,
path = form.path,
files = files,
message = form.message.getOrElse("Add files via upload")
)
if(form.path.length == 0){
redirect(s"/${repository.owner}/${repository.name}/tree/${form.branch}")
} else {
redirect(s"/${repository.owner}/${repository.name}/tree/${form.branch}/${form.path}")
}
})
get("/:owner/:repository/edit/*")(writableUsersOnly { repository =>
val (branch, path) = repository.splitPath(multiParams("splat").head)
val protectedBranch = getProtectedBranchInfo(repository.owner, repository.name, branch).needStatusCheck(context.loginAccount.get.userName)
@@ -174,9 +273,15 @@ trait RepositoryViewerControllerBase extends ControllerBase {
getPathObjectId(git, path, revCommit).map { objectId =>
val paths = path.split("/")
html.editor(branch, repository, paths.take(paths.size - 1).toList, Some(paths.last),
JGitUtil.getContentInfo(git, path, objectId),
protectedBranch)
html.editor(
branch = branch,
repository = repository,
pathList = paths.take(paths.size - 1).toList,
fileName = Some(paths.last),
content = JGitUtil.getContentInfo(git, path, objectId),
protectedBranch = protectedBranch,
commit = revCommit.getName
)
} getOrElse NotFound()
}
})
@@ -188,8 +293,14 @@ trait RepositoryViewerControllerBase extends ControllerBase {
getPathObjectId(git, path, revCommit).map { objectId =>
val paths = path.split("/")
html.delete(branch, repository, paths.take(paths.size - 1).toList, paths.last,
JGitUtil.getContentInfo(git, path, objectId))
html.delete(
branch = branch,
repository = repository,
pathList = paths.take(paths.size - 1).toList,
fileName = paths.last,
content = JGitUtil.getContentInfo(git, path, objectId),
commit = revCommit.getName
)
} getOrElse NotFound()
}
})
@@ -203,7 +314,8 @@ trait RepositoryViewerControllerBase extends ControllerBase {
oldFileName = None,
content = appendNewLine(convertLineSeparator(form.content, form.lineSeparator), form.lineSeparator),
charset = form.charset,
message = form.message.getOrElse(s"Create ${form.newFileName}")
message = form.message.getOrElse(s"Create ${form.newFileName}"),
commit = form.commit
)
redirect(s"/${repository.owner}/${repository.name}/blob/${form.branch}/${
@@ -220,21 +332,31 @@ trait RepositoryViewerControllerBase extends ControllerBase {
oldFileName = form.oldFileName,
content = appendNewLine(convertLineSeparator(form.content, form.lineSeparator), form.lineSeparator),
charset = form.charset,
message = if(form.oldFileName.exists(_ == form.newFileName)){
message = if (form.oldFileName.contains(form.newFileName)) {
form.message.getOrElse(s"Update ${form.newFileName}")
} else {
form.message.getOrElse(s"Rename ${form.oldFileName.get} to ${form.newFileName}")
}
},
commit = form.commit
)
redirect(s"/${repository.owner}/${repository.name}/blob/${form.branch}/${
if(form.path.length == 0) urlEncode(form.newFileName) else s"${form.path}/${urlEncode(form.newFileName)}"
redirect(s"/${repository.owner}/${repository.name}/blob/${urlEncode(form.branch)}/${
if (form.path.length == 0) urlEncode(form.newFileName) else s"${form.path}/${urlEncode(form.newFileName)}"
}")
})
post("/:owner/:repository/remove", deleteForm)(writableUsersOnly { (form, repository) =>
commitFile(repository, form.branch, form.path, None, Some(form.fileName), "", "",
form.message.getOrElse(s"Delete ${form.fileName}"))
commitFile(
repository = repository,
branch = form.branch,
path = form.path,
newFileName = None,
oldFileName = Some(form.fileName),
content = "",
charset = "",
message = form.message.getOrElse(s"Delete ${form.fileName}"),
commit = form.commit
)
redirect(s"/${repository.owner}/${repository.name}/tree/${form.branch}${if(form.path.length == 0) "" else form.path}")
})
@@ -243,13 +365,9 @@ trait RepositoryViewerControllerBase extends ControllerBase {
val (id, path) = repository.splitPath(multiParams("splat").head)
using(Git.open(getRepositoryDir(repository.owner, repository.name))){ git =>
val revCommit = JGitUtil.getRevCommitFromId(git, git.getRepository.resolve(id))
getPathObjectId(git, path, revCommit).flatMap { objectId =>
JGitUtil.getObjectLoaderFromId(git, objectId){ loader =>
contentType = FileUtil.getMimeType(path)
response.setContentLength(loader.getSize.toInt)
loader.copyTo(response.outputStream)
()
}
getPathObjectId(git, path, revCommit).map { objectId =>
responseRawFile(git, objectId, path, repository)
} getOrElse NotFound()
}
})
@@ -265,23 +383,27 @@ trait RepositoryViewerControllerBase extends ControllerBase {
getPathObjectId(git, path, revCommit).map { objectId =>
if(raw){
// Download (This route is left for backword compatibility)
JGitUtil.getObjectLoaderFromId(git, objectId){ loader =>
contentType = FileUtil.getMimeType(path)
response.setContentLength(loader.getSize.toInt)
loader.copyTo(response.outputStream)
()
} getOrElse NotFound()
responseRawFile(git, objectId, path, repository)
} else {
html.blob(id, repository, path.split("/").toList,
JGitUtil.getContentInfo(git, path, objectId),
new JGitUtil.CommitInfo(JGitUtil.getLastModifiedCommit(git, revCommit, path)),
hasDeveloperRole(repository.owner, repository.name, context.loginAccount),
request.paths(2) == "blame")
html.blob(
branch = id,
repository = repository,
pathList = path.split("/").toList,
content = JGitUtil.getContentInfo(git, path, objectId),
latestCommit = new JGitUtil.CommitInfo(JGitUtil.getLastModifiedCommit(git, revCommit, path)),
hasWritePermission = hasDeveloperRole(repository.owner, repository.name, context.loginAccount),
isBlame = request.paths(2) == "blame",
isLfsFile = isLfsFile(git, objectId)
)
}
} getOrElse NotFound()
}
})
private def isLfsFile(git: Git, objectId: ObjectId): Boolean = {
JGitUtil.getObjectLoaderFromId(git, objectId)(JGitUtil.isLfsPointer).getOrElse(false)
}
get("/:owner/:repository/blame/*"){
blobRoute.action()
}
@@ -294,7 +416,7 @@ trait RepositoryViewerControllerBase extends ControllerBase {
contentType = formats("json")
using(Git.open(getRepositoryDir(repository.owner, repository.name))){ git =>
val last = git.log.add(git.getRepository.resolve(id)).addPath(path).setMaxCount(1).call.iterator.next.name
Map(
Serialization.write(Map(
"root" -> s"${context.baseUrl}/${repository.owner}/${repository.name}",
"id" -> id,
"path" -> path,
@@ -309,8 +431,9 @@ trait RepositoryViewerControllerBase extends ControllerBase {
"prevPath" -> blame.prevPath,
"commited" -> blame.commitTime.getTime,
"message" -> blame.message,
"lines" -> blame.lines)
})
"lines" -> blame.lines
)
}))
}
})
@@ -323,14 +446,14 @@ trait RepositoryViewerControllerBase extends ControllerBase {
try {
using(Git.open(getRepositoryDir(repository.owner, repository.name))) { git =>
defining(JGitUtil.getRevCommitFromId(git, git.getRepository.resolve(id))) { revCommit =>
JGitUtil.getDiffs(git, id) match {
case (diffs, oldCommitId) =>
html.commit(id, new JGitUtil.CommitInfo(revCommit),
JGitUtil.getBranchesOfCommit(git, revCommit.getName),
JGitUtil.getTagsOfCommit(git, revCommit.getName),
getCommitComments(repository.owner, repository.name, id, false),
repository, diffs, oldCommitId, hasDeveloperRole(repository.owner, repository.name, context.loginAccount))
}
val diffs = JGitUtil.getDiffs(git, None, id, true, false)
val oldCommitId = JGitUtil.getParentCommitId(git, id)
html.commit(id, new JGitUtil.CommitInfo(revCommit),
JGitUtil.getBranchesOfCommit(git, revCommit.getName),
JGitUtil.getTagsOfCommit(git, revCommit.getName),
getCommitComments(repository.owner, repository.name, id, true),
repository, diffs, oldCommitId, hasDeveloperRole(repository.owner, repository.name, context.loginAccount))
}
}
} catch {
@@ -338,6 +461,31 @@ trait RepositoryViewerControllerBase extends ControllerBase {
}
})
get("/:owner/:repository/patch/:id")(referrersOnly { repository =>
try {
using(Git.open(getRepositoryDir(repository.owner, repository.name))) { git =>
val diff = JGitUtil.getPatch(git, None, params("id"))
contentType = formats("txt")
diff
}
} catch {
case e:MissingObjectException => NotFound()
}
})
get("/:owner/:repository/patch/*...*")(referrersOnly { repository =>
try {
val Seq(fromId, toId) = multiParams("splat")
using(Git.open(getRepositoryDir(repository.owner, repository.name))) { git =>
val diff = JGitUtil.getPatch(git, Some(fromId), toId)
contentType = formats("txt")
diff
}
} catch {
case e: MissingObjectException => NotFound()
}
})
post("/:owner/:repository/commit/:id/comment/new", commentForm)(readableUsersOnly { (form, repository) =>
val id = params("id")
createCommitComment(repository.owner, repository.name, id, context.loginAccount.get.userName, form.content,
@@ -370,9 +518,13 @@ trait RepositoryViewerControllerBase extends ControllerBase {
val comment = getCommitComment(repository.owner, repository.name, commentId.toString).get
form.issueId match {
case Some(issueId) =>
recordCommentPullRequestActivity(repository.owner, repository.name, context.loginAccount.get.userName, issueId, form.content)
callPullRequestReviewCommentWebHook("create", comment, repository, issueId, context.baseUrl, context.loginAccount.get)
case None => recordCommentCommitActivity(repository.owner, repository.name, context.loginAccount.get.userName, id, form.content)
getPullRequest(repository.owner, repository.name, issueId).foreach { case (issue, pullRequest) =>
recordCommentPullRequestActivity(repository.owner, repository.name, context.loginAccount.get.userName, issueId, form.content)
PluginRegistry().getPullRequestHooks.foreach(_.addedComment(commentId, form.content, issue, repository))
callPullRequestReviewCommentWebHook("create", comment, repository, issue, pullRequest, context.baseUrl, context.loginAccount.get)
}
case None =>
recordCommentCommitActivity(repository.owner, repository.name, context.loginAccount.get.userName, id, form.content)
}
helper.html.commitcomment(comment, hasDeveloperRole(repository.owner, repository.name, context.loginAccount), repository)
})
@@ -476,8 +628,8 @@ trait RepositoryViewerControllerBase extends ControllerBase {
/**
* Displays tags.
*/
get("/:owner/:repository/tags")(referrersOnly {
html.tags(_)
get("/:owner/:repository/tags")(referrersOnly { repository =>
redirect(s"${repository.owner}/${repository.name}/releases")
})
/**
@@ -501,7 +653,8 @@ trait RepositoryViewerControllerBase extends ControllerBase {
repository.repository.originRepositoryName.getOrElse(repository.name)),
getForkedRepositories(
repository.repository.originUserName.getOrElse(repository.owner),
repository.repository.originRepositoryName.getOrElse(repository.name)),
repository.repository.originRepositoryName.getOrElse(repository.name)
).map { repository => (repository.userName, repository.repositoryName) },
context.loginAccount match {
case None => List()
case account: Option[Account] => getGroupsByUserName(account.get.userName)
@@ -533,6 +686,140 @@ trait RepositoryViewerControllerBase extends ControllerBase {
}
})
case class UploadFiles(branch: String, path: String, fileIds: Map[String,String], message: String) {
lazy val isValid: Boolean = fileIds.nonEmpty
}
case class CommitFile(id: String, name: String)
private def commitFiles(repository: RepositoryService.RepositoryInfo,
files: Seq[CommitFile],
branch: String, path: String, message: String) = {
// prepend path to the filename
val newFiles = files.map { file =>
file.copy(name = if(path.length == 0) file.name else s"${path}/${file.name}")
}
_commitFile(repository, branch, message) { case (git, headTip, builder, inserter) =>
JGitUtil.processTree(git, headTip) { (path, tree) =>
if(!newFiles.exists(_.name.contains(path))) {
builder.add(JGitUtil.createDirCacheEntry(path, tree.getEntryFileMode, tree.getEntryObjectId))
}
}
newFiles.foreach { file =>
val bytes = FileUtils.readFileToByteArray(new File(getTemporaryDir(session.getId), file.id))
builder.add(JGitUtil.createDirCacheEntry(file.name,
FileMode.REGULAR_FILE, inserter.insert(Constants.OBJ_BLOB, bytes)))
builder.finish()
}
}
}
private def commitFile(repository: RepositoryService.RepositoryInfo,
branch: String, path: String, newFileName: Option[String], oldFileName: Option[String],
content: String, charset: String, message: String, commit: String) = {
val newPath = newFileName.map { newFileName => if(path.length == 0) newFileName else s"${path}/${newFileName}" }
val oldPath = oldFileName.map { oldFileName => if(path.length == 0) oldFileName else s"${path}/${oldFileName}" }
_commitFile(repository, branch, message){ case (git, headTip, builder, inserter) =>
if(headTip.getName == commit){
val permission = JGitUtil.processTree(git, headTip) { (path, tree) =>
// Add all entries except the editing file
if (!newPath.contains(path) && !oldPath.contains(path)) {
builder.add(JGitUtil.createDirCacheEntry(path, tree.getEntryFileMode, tree.getEntryObjectId))
}
// Retrieve permission if file exists to keep it
oldPath.collect { case x if x == path => tree.getEntryFileMode.getBits }
}.flatten.headOption
newPath.foreach { newPath =>
builder.add(JGitUtil.createDirCacheEntry(newPath,
permission.map { bits => FileMode.fromBits(bits) } getOrElse FileMode.REGULAR_FILE,
inserter.insert(Constants.OBJ_BLOB, content.getBytes(charset))))
}
builder.finish()
}
}
}
private def _commitFile(repository: RepositoryService.RepositoryInfo,
branch: String, message: String)(f: (Git, ObjectId, DirCacheBuilder, ObjectInserter) => Unit) = {
LockUtil.lock(s"${repository.owner}/${repository.name}") {
using(Git.open(getRepositoryDir(repository.owner, repository.name))) { git =>
val loginAccount = context.loginAccount.get
val builder = DirCache.newInCore.builder()
val inserter = git.getRepository.newObjectInserter()
val headName = s"refs/heads/${branch}"
val headTip = git.getRepository.resolve(headName)
f(git, headTip, builder, inserter)
val commitId = JGitUtil.createNewCommit(git, inserter, headTip, builder.getDirCache.writeTree(inserter),
headName, loginAccount.fullName, loginAccount.mailAddress, message)
inserter.flush()
inserter.close()
val receivePack = new ReceivePack(git.getRepository)
val receiveCommand = new ReceiveCommand(headTip, commitId, headName)
// call post commit hook
val error = PluginRegistry().getReceiveHooks.flatMap { hook =>
hook.preReceive(repository.owner, repository.name, receivePack, receiveCommand, loginAccount.userName)
}.headOption
error match {
case Some(error) =>
// commit is rejected
// TODO Notify commit failure to edited user
val refUpdate = git.getRepository.updateRef(headName)
refUpdate.setNewObjectId(headTip)
refUpdate.setForceUpdate(true)
refUpdate.update()
case None =>
// update refs
val refUpdate = git.getRepository.updateRef(headName)
refUpdate.setNewObjectId(commitId)
refUpdate.setForceUpdate(false)
refUpdate.setRefLogIdent(new PersonIdent(loginAccount.fullName, loginAccount.mailAddress))
refUpdate.update()
// update pull request
updatePullRequests(repository.owner, repository.name, branch)
// record activity
val commitInfo = new CommitInfo(JGitUtil.getRevCommitFromId(git, commitId))
recordPushActivity(repository.owner, repository.name, loginAccount.userName, branch, List(commitInfo))
// create issue comment by commit message
createIssueComment(repository.owner, repository.name, commitInfo)
// close issue by commit message
closeIssuesFromMessage(message, loginAccount.userName, repository.owner, repository.name)
// call post commit hook
PluginRegistry().getReceiveHooks.foreach { hook =>
hook.postReceive(repository.owner, repository.name, receivePack, receiveCommand, loginAccount.userName)
}
//call web hook
callPullRequestWebHookByRequestBranch("synchronize", repository, branch, context.baseUrl, loginAccount)
val commit = new JGitUtil.CommitInfo(JGitUtil.getRevCommitFromId(git, commitId))
callWebHookOf(repository.owner, repository.name, WebHook.Push) {
getAccountByUserName(repository.owner).map{ ownerAccount =>
WebHookPushPayload(git, loginAccount, headName, repository, List(commit), ownerAccount,
oldId = headTip, newId = commitId)
}
}
}
}
}
}
private val readmeFiles = PluginRegistry().renderableExtensions.map { extension =>
s"readme.${extension}"
} ++ Seq("readme.txt", "readme")
@@ -546,16 +833,16 @@ trait RepositoryViewerControllerBase extends ControllerBase {
* @return HTML of the file list
*/
private def fileList(repository: RepositoryService.RepositoryInfo, revstr: String = "", path: String = ".") = {
if(repository.commitCount == 0){
html.guide(repository, hasDeveloperRole(repository.owner, repository.name, context.loginAccount))
} else {
using(Git.open(getRepositoryDir(repository.owner, repository.name))){ git =>
using(Git.open(getRepositoryDir(repository.owner, repository.name))){ git =>
if(JGitUtil.isEmpty(git)){
html.guide(repository, hasDeveloperRole(repository.owner, repository.name, context.loginAccount))
} else {
// get specified commit
JGitUtil.getDefaultBranch(git, repository, revstr).map { case (objectId, revision) =>
defining(JGitUtil.getRevCommitFromId(git, objectId)) { revCommit =>
val lastModifiedCommit = if(path == ".") revCommit else JGitUtil.getLastModifiedCommit(git, revCommit, path)
// get files
val files = JGitUtil.getFileList(git, revision, path)
val files = JGitUtil.getFileList(git, revision, path, context.settings.baseUrl)
val parentPath = if (path == ".") Nil else path.split("/").toList
// process README.md or README.markdown
val readme = files.find { file =>
@@ -569,114 +856,29 @@ trait RepositoryViewerControllerBase extends ControllerBase {
html.files(revision, repository,
if(path == ".") Nil else path.split("/").toList, // current path
new JGitUtil.CommitInfo(lastModifiedCommit), // last modified commit
files, readme, hasDeveloperRole(repository.owner, repository.name, context.loginAccount),
JGitUtil.getCommitCount(repository.owner, repository.name, lastModifiedCommit.getName),
files,
readme,
hasDeveloperRole(repository.owner, repository.name, context.loginAccount),
getPullRequestFromBranch(repository.owner, repository.name, revstr, repository.repository.defaultBranch),
flash.get("info"), flash.get("error"))
flash.get("info"),
flash.get("error")
)
}
} getOrElse NotFound()
}
}
}
private def commitFile(repository: RepositoryService.RepositoryInfo,
branch: String, path: String, newFileName: Option[String], oldFileName: Option[String],
content: String, charset: String, message: String) = {
val newPath = newFileName.map { newFileName => if(path.length == 0) newFileName else s"${path}/${newFileName}" }
val oldPath = oldFileName.map { oldFileName => if(path.length == 0) oldFileName else s"${path}/${oldFileName}" }
LockUtil.lock(s"${repository.owner}/${repository.name}"){
using(Git.open(getRepositoryDir(repository.owner, repository.name))){ git =>
val loginAccount = context.loginAccount.get
val builder = DirCache.newInCore.builder()
val inserter = git.getRepository.newObjectInserter()
val headName = s"refs/heads/${branch}"
val headTip = git.getRepository.resolve(headName)
val permission = JGitUtil.processTree(git, headTip){ (path, tree) =>
// Add all entries except the editing file
if(!newPath.exists(_ == path) && !oldPath.exists(_ == path)){
builder.add(JGitUtil.createDirCacheEntry(path, tree.getEntryFileMode, tree.getEntryObjectId))
}
// Retrieve permission if file exists to keep it
oldPath.collect { case x if x == path => tree.getEntryFileMode.getBits }
}.flatten.headOption
newPath.foreach { newPath =>
builder.add(JGitUtil.createDirCacheEntry(newPath,
permission.map { bits => FileMode.fromBits(bits) } getOrElse FileMode.REGULAR_FILE,
inserter.insert(Constants.OBJ_BLOB, content.getBytes(charset))))
}
builder.finish()
val commitId = JGitUtil.createNewCommit(git, inserter, headTip, builder.getDirCache.writeTree(inserter),
headName, loginAccount.fullName, loginAccount.mailAddress, message)
inserter.flush()
inserter.close()
// update refs
val refUpdate = git.getRepository.updateRef(headName)
refUpdate.setNewObjectId(commitId)
refUpdate.setForceUpdate(false)
refUpdate.setRefLogIdent(new PersonIdent(loginAccount.fullName, loginAccount.mailAddress))
//refUpdate.setRefLogMessage("merged", true)
refUpdate.update()
// update pull request
updatePullRequests(repository.owner, repository.name, branch)
// record activity
val commitInfo = new CommitInfo(JGitUtil.getRevCommitFromId(git, commitId))
recordPushActivity(repository.owner, repository.name, loginAccount.userName, branch, List(commitInfo))
// create issue comment by commit message
createIssueComment(repository.owner, repository.name, commitInfo)
// close issue by commit message
closeIssuesFromMessage(message, loginAccount.userName, repository.owner, repository.name)
// call web hook
callPullRequestWebHookByRequestBranch("synchronize", repository, branch, context.baseUrl, loginAccount)
val commit = new JGitUtil.CommitInfo(JGitUtil.getRevCommitFromId(git, commitId))
callWebHookOf(repository.owner, repository.name, WebHook.Push) {
getAccountByUserName(repository.owner).map{ ownerAccount =>
WebHookPushPayload(git, loginAccount, headName, repository, List(commit), ownerAccount,
oldId = headTip, newId = commitId)
}
}
}
}
}
private def getPathObjectId(git: Git, path: String, revCommit: RevCommit): Option[ObjectId] = {
@scala.annotation.tailrec
def _getPathObjectId(path: String, walk: TreeWalk): Option[ObjectId] = walk.next match {
case true if(walk.getPathString == path) => Some(walk.getObjectId(0))
case true => _getPathObjectId(path, walk)
case false => None
}
using(new TreeWalk(git.getRepository)){ treeWalk =>
treeWalk.addTree(revCommit.getTree)
treeWalk.setRecursive(true)
_getPathObjectId(path, treeWalk)
}
}
private def archiveRepository(name: String, suffix: String, repository: RepositoryService.RepositoryInfo): Unit = {
val revision = name.stripSuffix(suffix)
val workDir = getDownloadWorkDir(repository.owner, repository.name, session.getId)
if(workDir.exists) {
FileUtils.deleteDirectory(workDir)
}
workDir.mkdirs
val filename = repository.name + "-" +
(if(revision.length == 40) revision.substring(0, 10) else revision).replace('/', '_') + suffix
using(Git.open(getRepositoryDir(repository.owner, repository.name))){ git =>
val revCommit = JGitUtil.getRevCommitFromId(git, git.getRepository.resolve(revision))
val oid = git.getRepository.resolve(revision)
val revCommit = JGitUtil.getRevCommitFromId(git, oid)
val sha1 = oid.getName()
val repositorySuffix = (if(sha1.startsWith(revision)) sha1 else revision).replace('/','-')
val filename = repository.name + "-" + repositorySuffix + suffix
contentType = "application/octet-stream"
response.setHeader("Content-Disposition", s"attachment; filename=${filename}")
@@ -684,7 +886,8 @@ trait RepositoryViewerControllerBase extends ControllerBase {
git.archive
.setFormat(suffix.tail)
.setTree(revCommit.getTree)
.setPrefix(repository.name + "-" + repositorySuffix + "/")
.setTree(revCommit)
.setOutputStream(response.getOutputStream)
.call()
}
@@ -693,6 +896,26 @@ trait RepositoryViewerControllerBase extends ControllerBase {
private def isEditable(owner: String, repository: String, author: String)(implicit context: Context): Boolean =
hasDeveloperRole(owner, repository, context.loginAccount) || author == context.loginAccount.get.userName
private def conflict: Constraint = new Constraint(){
override def validate(name: String, value: String, messages: Messages): Option[String] = {
val owner = params("owner")
val repository = params("repository")
val branch = params("branch")
LockUtil.lock(s"${owner}/${repository}") {
using(Git.open(getRepositoryDir(owner, repository))) { git =>
val headName = s"refs/heads/${branch}"
val headTip = git.getRepository.resolve(headName)
if(headTip.getName != value){
Some("Someone pushed new commits before you. Please reload this page and re-apply your changes.")
} else {
None
}
}
}
}
}
override protected def renderUncaughtException(e: Throwable)(implicit request: HttpServletRequest, response: HttpServletResponse): Unit = {
e.printStackTrace()
}

View File

@@ -2,23 +2,33 @@ package gitbucket.core.controller
import java.io.FileInputStream
import com.github.zafarkhaja.semver.{Version => Semver}
import gitbucket.core.GitBucketCoreModule
import gitbucket.core.admin.html
import gitbucket.core.service.{AccountService, RepositoryService, SystemSettingsService}
import gitbucket.core.util.{AdminAuthenticator, Mailer}
import gitbucket.core.plugin.{PluginInfoBase, PluginRegistry, PluginRepository}
import gitbucket.core.service.SystemSettingsService._
import gitbucket.core.service.{AccountService, RepositoryService}
import gitbucket.core.ssh.SshServer
import gitbucket.core.plugin.PluginRegistry
import SystemSettingsService._
import gitbucket.core.util.Implicits._
import gitbucket.core.util.ControlUtil._
import gitbucket.core.util.Directory._
import gitbucket.core.util.Implicits._
import gitbucket.core.util.StringUtil._
import io.github.gitbucket.scalatra.forms._
import org.apache.commons.io.{FileUtils, IOUtils}
import gitbucket.core.util.SyntaxSugars._
import gitbucket.core.util.{AdminAuthenticator, Mailer}
import org.apache.commons.io.IOUtils
import org.json4s.jackson.Serialization
import org.scalatra._
import org.scalatra.forms._
import org.scalatra.i18n.Messages
import scala.collection.JavaConverters._
import scala.collection.mutable.ListBuffer
class SystemSettingsController extends SystemSettingsControllerBase
with AccountService with RepositoryService with AdminAuthenticator
case class Table(name: String, columns: Seq[Column])
case class Column(name: String, primaryKey: Boolean)
trait SystemSettingsControllerBase extends AccountManagementControllerBase {
self: AccountService with RepositoryService with AdminAuthenticator =>
@@ -41,6 +51,7 @@ trait SystemSettingsControllerBase extends AccountManagementControllerBase {
"user" -> trim(label("SMTP User", optional(text()))),
"password" -> trim(label("SMTP Password", optional(text()))),
"ssl" -> trim(label("Enable SSL", optional(boolean()))),
"starttls" -> trim(label("Enable STARTTLS", optional(boolean()))),
"fromAddress" -> trim(label("FROM Address", optional(text()))),
"fromName" -> trim(label("FROM Name", optional(text())))
)(Smtp.apply)),
@@ -58,7 +69,15 @@ trait SystemSettingsControllerBase extends AccountManagementControllerBase {
"tls" -> trim(label("Enable TLS", optional(boolean()))),
"ssl" -> trim(label("Enable SSL", optional(boolean()))),
"keystore" -> trim(label("Keystore", optional(text())))
)(Ldap.apply))
)(Ldap.apply)),
"oidcAuthentication" -> trim(label("OIDC", boolean())),
"oidc" -> optionalIfNotChecked("oidcAuthentication", mapping(
"issuer" -> trim(label("Issuer", text(required))),
"clientID" -> trim(label("Client ID", text(required))),
"clientSecret" -> trim(label("Client secret", text(required))),
"jwsAlgorithm" -> trim(label("Signature algorithm", optional(text())))
)(OIDC.apply)),
"skinName" -> trim(label("AdminLTE skin name", text(required)))
)(SystemSettings.apply).verifying { settings =>
Vector(
if(settings.ssh && settings.baseUrl.isEmpty){
@@ -77,6 +96,7 @@ trait SystemSettingsControllerBase extends AccountManagementControllerBase {
"user" -> trim(label("SMTP User", optional(text()))),
"password" -> trim(label("SMTP Password", optional(text()))),
"ssl" -> trim(label("Enable SSL", optional(boolean()))),
"starttls" -> trim(label("Enable STARTTLS", optional(boolean()))),
"fromAddress" -> trim(label("FROM Address", optional(text()))),
"fromName" -> trim(label("FROM Name", optional(text())))
)(Smtp.apply),
@@ -89,35 +109,37 @@ trait SystemSettingsControllerBase extends AccountManagementControllerBase {
case class NewUserForm(userName: String, password: String, fullName: String,
mailAddress: String, isAdmin: Boolean,
url: Option[String], fileId: Option[String])
description: Option[String], url: Option[String], fileId: Option[String])
case class EditUserForm(userName: String, password: Option[String], fullName: String,
mailAddress: String, isAdmin: Boolean, url: Option[String],
mailAddress: String, isAdmin: Boolean, description: Option[String], url: Option[String],
fileId: Option[String], clearImage: Boolean, isRemoved: Boolean)
case class NewGroupForm(groupName: String, url: Option[String], fileId: Option[String],
case class NewGroupForm(groupName: String, description: Option[String], url: Option[String], fileId: Option[String],
members: String)
case class EditGroupForm(groupName: String, url: Option[String], fileId: Option[String],
case class EditGroupForm(groupName: String, description: Option[String], url: Option[String], fileId: Option[String],
members: String, clearImage: Boolean, isRemoved: Boolean)
val newUserForm = mapping(
"userName" -> trim(label("Username" ,text(required, maxlength(100), identifier, uniqueUserName, reservedNames))),
"password" -> trim(label("Password" ,text(required, maxlength(20)))),
"password" -> trim(label("Password" ,text(required, maxlength(20), password))),
"fullName" -> trim(label("Full Name" ,text(required, maxlength(100)))),
"mailAddress" -> trim(label("Mail Address" ,text(required, maxlength(100), uniqueMailAddress()))),
"isAdmin" -> trim(label("User Type" ,boolean())),
"description" -> trim(label("bio" ,optional(text()))),
"url" -> trim(label("URL" ,optional(text(maxlength(200))))),
"fileId" -> trim(label("File ID" ,optional(text())))
)(NewUserForm.apply)
val editUserForm = mapping(
"userName" -> trim(label("Username" ,text(required, maxlength(100), identifier))),
"password" -> trim(label("Password" ,optional(text(maxlength(20))))),
"password" -> trim(label("Password" ,optional(text(maxlength(20), password)))),
"fullName" -> trim(label("Full Name" ,text(required, maxlength(100)))),
"mailAddress" -> trim(label("Mail Address" ,text(required, maxlength(100), uniqueMailAddress("userName")))),
"isAdmin" -> trim(label("User Type" ,boolean())),
"description" -> trim(label("bio" ,optional(text()))),
"url" -> trim(label("URL" ,optional(text(maxlength(200))))),
"fileId" -> trim(label("File ID" ,optional(text()))),
"clearImage" -> trim(label("Clear image" ,boolean())),
@@ -126,6 +148,7 @@ trait SystemSettingsControllerBase extends AccountManagementControllerBase {
val newGroupForm = mapping(
"groupName" -> trim(label("Group name" ,text(required, maxlength(100), identifier, uniqueUserName, reservedNames))),
"description" -> trim(label("Group description", optional(text()))),
"url" -> trim(label("URL" ,optional(text(maxlength(200))))),
"fileId" -> trim(label("File ID" ,optional(text()))),
"members" -> trim(label("Members" ,text(required, members)))
@@ -133,6 +156,7 @@ trait SystemSettingsControllerBase extends AccountManagementControllerBase {
val editGroupForm = mapping(
"groupName" -> trim(label("Group name" ,text(required, maxlength(100), identifier))),
"description" -> trim(label("Group description", optional(text()))),
"url" -> trim(label("URL" ,optional(text(maxlength(200))))),
"fileId" -> trim(label("File ID" ,optional(text()))),
"members" -> trim(label("Members" ,text(required, members))),
@@ -141,6 +165,71 @@ trait SystemSettingsControllerBase extends AccountManagementControllerBase {
)(EditGroupForm.apply)
get("/admin/dbviewer")(adminOnly {
val conn = request2Session(request).conn
val meta = conn.getMetaData
val tables = ListBuffer[Table]()
using(meta.getTables(null, "%", "%", Array("TABLE", "VIEW"))){ rs =>
while(rs.next()){
val tableName = rs.getString("TABLE_NAME")
val pkColumns = ListBuffer[String]()
using(meta.getPrimaryKeys(null, null, tableName)){ rs =>
while(rs.next()){
pkColumns += rs.getString("COLUMN_NAME").toUpperCase
}
}
val columns = ListBuffer[Column]()
using(meta.getColumns(null, "%", tableName, "%")){ rs =>
while(rs.next()){
val columnName = rs.getString("COLUMN_NAME").toUpperCase
columns += Column(columnName, pkColumns.contains(columnName))
}
}
tables += Table(tableName.toUpperCase, columns)
}
}
html.dbviewer(tables)
})
post("/admin/dbviewer/_query")(adminOnly {
contentType = formats("json")
params.get("query").collectFirst { case query if query.trim.nonEmpty =>
val trimmedQuery = query.trim
if(trimmedQuery.nonEmpty){
try {
val conn = request2Session(request).conn
using(conn.prepareStatement(query)){ stmt =>
if(trimmedQuery.toUpperCase.startsWith("SELECT")){
using(stmt.executeQuery()){ rs =>
val meta = rs.getMetaData
val columns = for(i <- 1 to meta.getColumnCount) yield {
meta.getColumnName(i)
}
val result = ListBuffer[Map[String, String]]()
while(rs.next()){
val row = columns.map { columnName =>
columnName -> Option(rs.getObject(columnName)).map(_.toString).getOrElse("<NULL>")
}.toMap
result += row
}
Ok(Serialization.write(Map("type" -> "query", "columns" -> columns, "rows" -> result)))
}
} else {
val rows = stmt.executeUpdate()
Ok(Serialization.write(Map("type" -> "update", "rows" -> rows)))
}
}
} catch {
case e: Exception =>
Ok(Serialization.write(Map("type" -> "error", "message" -> e.toString)))
}
}
} getOrElse Ok(Serialization.write(Map("type" -> "error", "message" -> "query is empty")))
})
get("/admin/system")(adminOnly {
html.system(flash.get("info"))
})
@@ -163,8 +252,13 @@ trait SystemSettingsControllerBase extends AccountManagementControllerBase {
post("/admin/system/sendmail", sendMailForm)(adminOnly { form =>
try {
new Mailer(form.smtp).send(form.testAddress,
"Test message from GitBucket", "This is a test message from GitBucket.")
new Mailer(context.settings.copy(smtp = Some(form.smtp), notification = true)).send(
to = form.testAddress,
subject = "Test message from GitBucket",
textMsg = "This is a test message from GitBucket.",
htmlMsg = None,
loginAccount = context.loginAccount
)
"Test mail has been sent to: " + form.testAddress
@@ -174,18 +268,83 @@ trait SystemSettingsControllerBase extends AccountManagementControllerBase {
})
get("/admin/plugins")(adminOnly {
html.plugins(PluginRegistry().getPlugins())
// Installed plugins
val enabledPlugins = PluginRegistry().getPlugins()
val gitbucketVersion = Semver.valueOf(GitBucketCoreModule.getVersions.asScala.last.getVersion)
// Plugins in the local repository
val repositoryPlugins = PluginRepository.getPlugins()
.filterNot { meta =>
enabledPlugins.exists { plugin => plugin.pluginId == meta.id &&
Semver.valueOf(plugin.pluginVersion).greaterThanOrEqualTo(Semver.valueOf(meta.latestVersion.version))
}
}.map { meta =>
(meta, meta.versions.reverse.find { version => gitbucketVersion.satisfies(version.range) })
}.collect { case (meta, Some(version)) =>
new PluginInfoBase(
pluginId = meta.id,
pluginName = meta.name,
pluginVersion = version.version,
description = meta.description
)
}
// Merge
val plugins = enabledPlugins.map((_, true)) ++ repositoryPlugins.map((_, false))
html.plugins(plugins, flash.get("info"))
})
post("/admin/plugins/_reload")(adminOnly {
PluginRegistry.reload(request.getServletContext(), loadSystemSettings(), request2Session(request).conn)
flash += "info" -> "All plugins were reloaded."
redirect("/admin/plugins")
})
post("/admin/plugins/:pluginId/:version/_uninstall")(adminOnly {
val pluginId = params("pluginId")
val version = params("version")
PluginRegistry().getPlugins()
.collect { case plugin if (plugin.pluginId == pluginId && plugin.pluginVersion == version) => plugin }
.foreach { _ =>
PluginRegistry.uninstall(pluginId, request.getServletContext, loadSystemSettings(), request2Session(request).conn)
flash += "info" -> s"${pluginId} was uninstalled."
}
redirect("/admin/plugins")
})
post("/admin/plugins/:pluginId/:version/_install")(adminOnly {
val pluginId = params("pluginId")
val version = params("version")
/// TODO!!!!
PluginRepository.getPlugins()
.collect { case meta if meta.id == pluginId => (meta, meta.versions.find(_.version == version) )}
.foreach { case (meta, version) =>
version.foreach { version =>
// TODO Install version!
PluginRegistry.install(
new java.io.File(PluginHome, s".repository/${version.file}"),
request.getServletContext,
loadSystemSettings(),
request2Session(request).conn
)
flash += "info" -> s"${pluginId} was installed."
}
}
redirect("/admin/plugins")
})
get("/admin/users")(adminOnly {
val includeRemoved = params.get("includeRemoved").map(_.toBoolean).getOrElse(false)
val users = getAllUsers(includeRemoved)
val includeGroups = params.get("includeGroups").map(_.toBoolean).getOrElse(false)
val users = getAllUsers(includeRemoved, includeGroups)
val members = users.collect { case account if(account.isGroupAccount) =>
account.userName -> getGroupMembers(account.userName).map(_.userName)
}.toMap
html.userlist(users, members, includeRemoved)
html.userlist(users, members, includeRemoved, includeGroups)
})
get("/admin/users/_newuser")(adminOnly {
@@ -193,7 +352,7 @@ trait SystemSettingsControllerBase extends AccountManagementControllerBase {
})
post("/admin/users/_newuser", newUserForm)(adminOnly { form =>
createAccount(form.userName, sha1(form.password), form.fullName, form.mailAddress, form.isAdmin, form.url)
createAccount(form.userName, sha1(form.password), form.fullName, form.mailAddress, form.isAdmin, form.description, form.url)
updateImage(form.userName, form.fileId, false)
redirect("/admin/users")
})
@@ -218,7 +377,7 @@ trait SystemSettingsControllerBase extends AccountManagementControllerBase {
// FileUtils.deleteDirectory(getWikiRepositoryDir(userName, repositoryName))
// FileUtils.deleteDirectory(getTemporaryDir(userName, repositoryName))
// }
// Remove from GROUP_MEMBER, COLLABORATOR and REPOSITORY
// Remove from GROUP_MEMBER and COLLABORATOR
removeUserRelatedData(userName)
}
@@ -227,10 +386,15 @@ trait SystemSettingsControllerBase extends AccountManagementControllerBase {
fullName = form.fullName,
mailAddress = form.mailAddress,
isAdmin = form.isAdmin,
description = form.description,
url = form.url,
isRemoved = form.isRemoved))
updateImage(userName, form.fileId, form.clearImage)
// call hooks
if(form.isRemoved) PluginRegistry().getAccountHooks.foreach(_.deleted(userName))
redirect("/admin/users")
}
} getOrElse NotFound()
@@ -241,7 +405,7 @@ trait SystemSettingsControllerBase extends AccountManagementControllerBase {
})
post("/admin/users/_newgroup", newGroupForm)(adminOnly { form =>
createGroup(form.groupName, form.url)
createGroup(form.groupName, form.description, form.url)
updateGroupMembers(form.groupName, form.members.split(",").map {
_.split(":") match {
case Array(userName, isManager) => (userName, isManager.toBoolean)
@@ -264,18 +428,18 @@ trait SystemSettingsControllerBase extends AccountManagementControllerBase {
}
}.toList){ case (groupName, members) =>
getAccountByUserName(groupName, true).map { account =>
updateGroup(groupName, form.url, form.isRemoved)
updateGroup(groupName, form.description, form.url, form.isRemoved)
if(form.isRemoved){
// Remove from GROUP_MEMBER
updateGroupMembers(form.groupName, Nil)
// Remove repositories
getRepositoryNamesOfUser(form.groupName).foreach { repositoryName =>
deleteRepository(groupName, repositoryName)
FileUtils.deleteDirectory(getRepositoryDir(groupName, repositoryName))
FileUtils.deleteDirectory(getWikiRepositoryDir(groupName, repositoryName))
FileUtils.deleteDirectory(getTemporaryDir(groupName, repositoryName))
}
// // Remove repositories
// getRepositoryNamesOfUser(form.groupName).foreach { repositoryName =>
// deleteRepository(groupName, repositoryName)
// FileUtils.deleteDirectory(getRepositoryDir(groupName, repositoryName))
// FileUtils.deleteDirectory(getWikiRepositoryDir(groupName, repositoryName))
// FileUtils.deleteDirectory(getTemporaryDir(groupName, repositoryName))
// }
} else {
// Update GROUP_MEMBER
updateGroupMembers(form.groupName, members)

View File

@@ -0,0 +1,91 @@
package gitbucket.core.controller
import org.json4s.{JField, JObject, JString}
import org.scalatra._
import org.scalatra.json._
import org.scalatra.forms._
import org.scalatra.i18n.I18nSupport
import org.scalatra.servlet.ServletBase
/**
* Extends scalatra-forms to support the client-side validation and Ajax requests as well.
*/
trait ValidationSupport extends FormSupport { self: ServletBase with JacksonJsonSupport with I18nSupport =>
def get[T](path: String, form: ValueType[T])(action: T => Any): Route = {
registerValidate(path, form)
get(path){
validate(form)(errors => BadRequest(), form => action(form))
}
}
def post[T](path: String, form: ValueType[T])(action: T => Any): Route = {
registerValidate(path, form)
post(path){
validate(form)(errors => BadRequest(), form => action(form))
}
}
def put[T](path: String, form: ValueType[T])(action: T => Any): Route = {
registerValidate(path, form)
put(path){
validate(form)(errors => BadRequest(), form => action(form))
}
}
def delete[T](path: String, form: ValueType[T])(action: T => Any): Route = {
registerValidate(path, form)
delete(path){
validate(form)(errors => BadRequest(), form => action(form))
}
}
def ajaxGet[T](path: String, form: ValueType[T])(action: T => Any): Route = {
get(path){
validate(form)(errors => ajaxError(errors), form => action(form))
}
}
def ajaxPost[T](path: String, form: ValueType[T])(action: T => Any): Route = {
post(path){
validate(form)(errors => ajaxError(errors), form => action(form))
}
}
def ajaxDelete[T](path: String, form: ValueType[T])(action: T => Any): Route = {
delete(path){
validate(form)(errors => ajaxError(errors), form => action(form))
}
}
def ajaxPut[T](path: String, form: ValueType[T])(action: T => Any): Route = {
put(path){
validate(form)(errors => ajaxError(errors), form => action(form))
}
}
private def registerValidate[T](path: String, form: ValueType[T]) = {
post(path.replaceFirst("/$", "") + "/validate"){
contentType = "application/json"
toJson(form.validate("", multiParams, messages))
}
}
/**
* Responds errors for ajax requests.
*/
private def ajaxError(errors: Seq[(String, String)]): JObject = {
status = 400
contentType = "application/json"
toJson(errors)
}
/**
* Converts errors to JSON.
*/
private def toJson(errors: Seq[(String, String)]): JObject =
JObject(errors.map { case (key, value) =>
JField(key, JString(value))
}.toList)
}

View File

@@ -1,26 +1,29 @@
package gitbucket.core.controller
import gitbucket.core.model.WebHook
import gitbucket.core.service.RepositoryService.RepositoryInfo
import gitbucket.core.service.WebHookService.WebHookGollumPayload
import gitbucket.core.wiki.html
import gitbucket.core.service.{AccountService, ActivityService, RepositoryService, WikiService}
import gitbucket.core.service._
import gitbucket.core.util._
import gitbucket.core.util.StringUtil._
import gitbucket.core.util.ControlUtil._
import gitbucket.core.util.SyntaxSugars._
import gitbucket.core.util.Implicits._
import gitbucket.core.util.Directory._
import io.github.gitbucket.scalatra.forms._
import org.scalatra.forms._
import org.eclipse.jgit.api.Git
import org.scalatra.i18n.Messages
class WikiController extends WikiControllerBase
with WikiService with RepositoryService with AccountService with ActivityService
class WikiController extends WikiControllerBase
with WikiService with RepositoryService with AccountService with ActivityService with WebHookService
with ReadableUsersAuthenticator with ReferrerAuthenticator
trait WikiControllerBase extends ControllerBase {
self: WikiService with RepositoryService with ActivityService with ReadableUsersAuthenticator with ReferrerAuthenticator =>
self: WikiService with RepositoryService with AccountService with ActivityService with WebHookService
with ReadableUsersAuthenticator with ReferrerAuthenticator =>
case class WikiPageEditForm(pageName: String, content: String, message: Option[String], currentPageName: String, id: String)
val newForm = mapping(
"pageName" -> trim(label("Page name" , text(required, maxlength(40), pagename, unique))),
"content" -> trim(label("Content" , text(required, conflictForNew))),
@@ -28,7 +31,7 @@ trait WikiControllerBase extends ControllerBase {
"currentPageName" -> trim(label("Current page name" , text())),
"id" -> trim(label("Latest commit id" , text()))
)(WikiPageEditForm.apply)
val editForm = mapping(
"pageName" -> trim(label("Page name" , text(required, maxlength(40), pagename))),
"content" -> trim(label("Content" , text(required, conflictForEdit))),
@@ -36,7 +39,7 @@ trait WikiControllerBase extends ControllerBase {
"currentPageName" -> trim(label("Current page name" , text(required))),
"id" -> trim(label("Latest commit id" , text(required)))
)(WikiPageEditForm.apply)
get("/:owner/:repository/wiki")(referrersOnly { repository =>
getWikiPage(repository.owner, repository.name, "Home").map { page =>
html.page("Home", page, getWikiPageList(repository.owner, repository.name),
@@ -45,7 +48,7 @@ trait WikiControllerBase extends ControllerBase {
getWikiPage(repository.owner, repository.name, "_Footer"))
} getOrElse redirect(s"/${repository.owner}/${repository.name}/wiki/Home/_edit")
})
get("/:owner/:repository/wiki/:page")(referrersOnly { repository =>
val pageName = StringUtil.urlDecode(params("page"))
@@ -56,7 +59,7 @@ trait WikiControllerBase extends ControllerBase {
getWikiPage(repository.owner, repository.name, "_Footer"))
} getOrElse redirect(s"/${repository.owner}/${repository.name}/wiki/${StringUtil.urlEncode(pageName)}/_edit")
})
get("/:owner/:repository/wiki/:page/_history")(referrersOnly { repository =>
val pageName = StringUtil.urlDecode(params("page"))
@@ -67,22 +70,22 @@ trait WikiControllerBase extends ControllerBase {
}
}
})
get("/:owner/:repository/wiki/:page/_compare/:commitId")(referrersOnly { repository =>
val pageName = StringUtil.urlDecode(params("page"))
val Array(from, to) = params("commitId").split("\\.\\.\\.")
using(Git.open(getWikiRepositoryDir(repository.owner, repository.name))){ git =>
html.compare(Some(pageName), from, to, JGitUtil.getDiffs(git, from, to, true).filter(_.newPath == pageName + ".md"), repository,
html.compare(Some(pageName), from, to, JGitUtil.getDiffs(git, Some(from), to, true, false).filter(_.newPath == pageName + ".md"), repository,
isEditable(repository), flash.get("info"))
}
})
get("/:owner/:repository/wiki/_compare/:commitId")(referrersOnly { repository =>
val Array(from, to) = params("commitId").split("\\.\\.\\.")
using(Git.open(getWikiRepositoryDir(repository.owner, repository.name))){ git =>
html.compare(None, from, to, JGitUtil.getDiffs(git, from, to, true), repository,
html.compare(None, from, to, JGitUtil.getDiffs(git, Some(from), to, true, false), repository,
isEditable(repository), flash.get("info"))
}
})
@@ -120,7 +123,7 @@ trait WikiControllerBase extends ControllerBase {
html.edit(pageName, getWikiPage(repository.owner, repository.name, pageName), repository)
} else Unauthorized()
})
post("/:owner/:repository/wiki/_edit", editForm)(readableUsersOnly { (form, repository) =>
if(isEditable(repository)){
defining(context.loginAccount.get){ loginAccount =>
@@ -136,6 +139,11 @@ trait WikiControllerBase extends ControllerBase {
).map { commitId =>
updateLastActivityDate(repository.owner, repository.name)
recordEditWikiPageActivity(repository.owner, repository.name, loginAccount.userName, form.pageName, commitId)
callWebHookOf(repository.owner, repository.name, WebHook.Gollum){
getAccountByUserName(repository.owner).map { repositoryUser =>
WebHookGollumPayload("edited", form.pageName, commitId, repository, repositoryUser, loginAccount)
}
}
}
if(notReservedPageName(form.pageName)) {
redirect(s"/${repository.owner}/${repository.name}/wiki/${StringUtil.urlEncode(form.pageName)}")
@@ -145,21 +153,34 @@ trait WikiControllerBase extends ControllerBase {
}
} else Unauthorized()
})
get("/:owner/:repository/wiki/_new")(readableUsersOnly { repository =>
if(isEditable(repository)){
html.edit("", None, repository)
} else Unauthorized()
})
post("/:owner/:repository/wiki/_new", newForm)(readableUsersOnly { (form, repository) =>
if(isEditable(repository)){
defining(context.loginAccount.get){ loginAccount =>
saveWikiPage(repository.owner, repository.name, form.currentPageName, form.pageName,
form.content, loginAccount, form.message.getOrElse(""), None)
updateLastActivityDate(repository.owner, repository.name)
recordCreateWikiPageActivity(repository.owner, repository.name, loginAccount.userName, form.pageName)
saveWikiPage(
repository.owner,
repository.name,
form.currentPageName,
form.pageName,
form.content,
loginAccount,
form.message.getOrElse(""),
None
).map { commitId =>
updateLastActivityDate(repository.owner, repository.name)
recordCreateWikiPageActivity(repository.owner, repository.name, loginAccount.userName, form.pageName)
callWebHookOf(repository.owner, repository.name, WebHook.Gollum){
getAccountByUserName(repository.owner).map { repositoryUser =>
WebHookGollumPayload("created", form.pageName, commitId, repository, repositoryUser, loginAccount)
}
}
}
if(notReservedPageName(form.pageName)) {
redirect(s"/${repository.owner}/${repository.name}/wiki/${StringUtil.urlEncode(form.pageName)}")
@@ -169,7 +190,7 @@ trait WikiControllerBase extends ControllerBase {
}
} else Unauthorized()
})
get("/:owner/:repository/wiki/:page/_delete")(readableUsersOnly { repository =>
if(isEditable(repository)){
val pageName = StringUtil.urlDecode(params("page"))
@@ -186,7 +207,7 @@ trait WikiControllerBase extends ControllerBase {
get("/:owner/:repository/wiki/_pages")(referrersOnly { repository =>
html.pages(getWikiPageList(repository.owner, repository.name), repository, isEditable(repository))
})
get("/:owner/:repository/wiki/_history")(referrersOnly { repository =>
using(Git.open(getWikiRepositoryDir(repository.owner, repository.name))){ git =>
JGitUtil.getCommitLog(git, "master") match {
@@ -198,15 +219,18 @@ trait WikiControllerBase extends ControllerBase {
get("/:owner/:repository/wiki/_blob/*")(referrersOnly { repository =>
val path = multiParams("splat").head
using(Git.open(getWikiRepositoryDir(repository.owner, repository.name))){ git =>
val revCommit = JGitUtil.getRevCommitFromId(git, git.getRepository.resolve("master"))
getFileContent(repository.owner, repository.name, path).map { bytes =>
RawData(FileUtil.getContentType(path, bytes), bytes)
} getOrElse NotFound()
getPathObjectId(git, path, revCommit).map { objectId =>
responseRawFile(git, objectId, path, repository)
} getOrElse NotFound()
}
})
private def unique: Constraint = new Constraint(){
override def validate(name: String, value: String, params: Map[String, String], messages: Messages): Option[String] =
getWikiPageList(params("owner"), params("repository")).find(_ == value).map(_ => "Page already exists.")
override def validate(name: String, value: String, params: Map[String, Seq[String]], messages: Messages): Option[String] =
getWikiPageList(params.value("owner"), params.value("repository")).find(_ == value).map(_ => "Page already exists.")
}
private def pagename: Constraint = new Constraint(){

View File

@@ -2,7 +2,8 @@ package gitbucket.core.model
trait AccessTokenComponent { self: Profile =>
import profile.simple._
import profile.api._
lazy val AccessTokens = TableQuery[AccessTokens]
class AccessTokens(tag: Tag) extends Table[AccessToken](tag, "ACCESS_TOKEN") {

View File

@@ -1,7 +1,7 @@
package gitbucket.core.model
trait AccountComponent { self: Profile =>
import profile.simple._
import profile.api._
import self._
lazy val Accounts = TableQuery[Accounts]
@@ -19,7 +19,8 @@ trait AccountComponent { self: Profile =>
val image = column[String]("IMAGE")
val groupAccount = column[Boolean]("GROUP_ACCOUNT")
val removed = column[Boolean]("REMOVED")
def * = (userName, fullName, mailAddress, password, isAdmin, url.?, registeredDate, updatedDate, lastLoginDate.?, image.?, groupAccount, removed) <> (Account.tupled, Account.unapply)
val description = column[String]("DESCRIPTION")
def * = (userName, fullName, mailAddress, password, isAdmin, url.?, registeredDate, updatedDate, lastLoginDate.?, image.?, groupAccount, removed, description.?) <> (Account.tupled, Account.unapply)
}
}
@@ -35,5 +36,6 @@ case class Account(
lastLoginDate: Option[java.util.Date],
image: Option[String],
isGroupAccount: Boolean,
isRemoved: Boolean
isRemoved: Boolean,
description: Option[String]
)

View File

@@ -0,0 +1,19 @@
package gitbucket.core.model
trait AccountFederationComponent { self: Profile =>
import profile.api._
lazy val AccountFederations = TableQuery[AccountFederations]
class AccountFederations(tag: Tag) extends Table[AccountFederation](tag, "ACCOUNT_FEDERATION") {
val issuer = column[String]("ISSUER")
val subject = column[String]("SUBJECT")
val userName = column[String]("USER_NAME")
def * = (issuer, subject, userName) <> (AccountFederation.tupled, AccountFederation.unapply)
def byPrimaryKey(issuer: String, subject: String): Rep[Boolean] =
(this.issuer === issuer.bind) && (this.subject === subject.bind)
}
}
case class AccountFederation(issuer: String, subject: String, userName: String)

View File

@@ -0,0 +1,25 @@
package gitbucket.core.model
trait AccountWebHookComponent extends TemplateComponent { self: Profile =>
import profile.api._
private implicit val whContentTypeColumnType = MappedColumnType.base[WebHookContentType, String](whct => whct.code , code => WebHookContentType.valueOf(code))
lazy val AccountWebHooks = TableQuery[AccountWebHooks]
class AccountWebHooks(tag: Tag) extends Table[AccountWebHook](tag, "ACCOUNT_WEB_HOOK") with BasicTemplate {
val url = column[String]("URL")
val token = column[Option[String]]("TOKEN")
val ctype = column[WebHookContentType]("CTYPE")
def * = (userName, url, ctype, token) <> ((AccountWebHook.apply _).tupled, AccountWebHook.unapply)
def byPrimaryKey(userName: String, url: String) = (this.userName === userName.bind) && (this.url === url.bind)
}
}
case class AccountWebHook(
userName: String,
url: String,
ctype: WebHookContentType,
token: Option[String]
) extends WebHook

View File

@@ -0,0 +1,34 @@
package gitbucket.core.model
trait AccountWebHookEventComponent extends TemplateComponent {
self: Profile =>
import profile.api._
import gitbucket.core.model.Profile.AccountWebHooks
lazy val AccountWebHookEvents = TableQuery[AccountWebHookEvents]
class AccountWebHookEvents(tag: Tag) extends Table[AccountWebHookEvent](tag, "ACCOUNT_WEB_HOOK_EVENT") with BasicTemplate {
val url = column[String]("URL")
val event = column[WebHook.Event]("EVENT")
def * = (userName, url, event) <> ((AccountWebHookEvent.apply _).tupled, AccountWebHookEvent.unapply)
def byAccountWebHook(userName: String, url: String) = (this.userName === userName.bind) && (this.url === url.bind)
def byAccountWebHook(owner: Rep[String], url: Rep[String]) =
(this.userName === userName) && (this.url === url)
def byAccountWebHook(webhook: AccountWebHooks) =
(this.userName === webhook.userName) && (this.url === webhook.url)
def byPrimaryKey(userName: String, url: String, event: WebHook.Event) =
(this.userName === userName.bind) && (this.url === url.bind) && (this.event === event.bind)
}
}
case class AccountWebHookEvent(
userName: String,
url: String,
event: WebHook.Event
)

View File

@@ -1,7 +1,7 @@
package gitbucket.core.model
trait ActivityComponent extends TemplateComponent { self: Profile =>
import profile.simple._
import profile.api._
import self._
lazy val Activities = TableQuery[Activities]

View File

@@ -1,16 +1,20 @@
package gitbucket.core.model
protected[model] trait TemplateComponent { self: Profile =>
import profile.simple._
import profile.api._
trait BasicTemplate { self: Table[_] =>
val userName = column[String]("USER_NAME")
val repositoryName = column[String]("REPOSITORY_NAME")
def byAccount(userName: String) = (this.userName === userName.bind)
def byAccount(userName: Rep[String]) = (this.userName === userName)
def byRepository(owner: String, repository: String) =
(userName === owner.bind) && (repositoryName === repository.bind)
def byRepository(userName: Column[String], repositoryName: Column[String]) =
def byRepository(userName: Rep[String], repositoryName: Rep[String]) =
(this.userName === userName) && (this.repositoryName === repositoryName)
}
@@ -20,7 +24,7 @@ protected[model] trait TemplateComponent { self: Profile =>
def byIssue(owner: String, repository: String, issueId: Int) =
byRepository(owner, repository) && (this.issueId === issueId.bind)
def byIssue(userName: Column[String], repositoryName: Column[String], issueId: Column[Int]) =
def byIssue(userName: Rep[String], repositoryName: Rep[String], issueId: Rep[Int]) =
byRepository(userName, repositoryName) && (this.issueId === issueId)
}
@@ -31,20 +35,34 @@ protected[model] trait TemplateComponent { self: Profile =>
def byLabel(owner: String, repository: String, labelId: Int) =
byRepository(owner, repository) && (this.labelId === labelId.bind)
def byLabel(userName: Column[String], repositoryName: Column[String], labelId: Column[Int]) =
def byLabel(userName: Rep[String], repositoryName: Rep[String], labelId: Rep[Int]) =
byRepository(userName, repositoryName) && (this.labelId === labelId)
def byLabel(owner: String, repository: String, labelName: String) =
byRepository(owner, repository) && (this.labelName === labelName.bind)
}
trait PriorityTemplate extends BasicTemplate { self: Table[_] =>
val priorityId = column[Int]("PRIORITY_ID")
val priorityName = column[String]("PRIORITY_NAME")
def byPriority(owner: String, repository: String, priorityId: Int) =
byRepository(owner, repository) && (this.priorityId === priorityId.bind)
def byPriority(userName: Rep[String], repositoryName: Rep[String], priorityId: Rep[Int]) =
byRepository(userName, repositoryName) && (this.priorityId === priorityId)
def byPriority(owner: String, repository: String, priorityName: String) =
byRepository(owner, repository) && (this.priorityName === priorityName.bind)
}
trait MilestoneTemplate extends BasicTemplate { self: Table[_] =>
val milestoneId = column[Int]("MILESTONE_ID")
def byMilestone(owner: String, repository: String, milestoneId: Int) =
byRepository(owner, repository) && (this.milestoneId === milestoneId.bind)
def byMilestone(userName: Column[String], repositoryName: Column[String], milestoneId: Column[Int]) =
def byMilestone(userName: Rep[String], repositoryName: Rep[String], milestoneId: Rep[Int]) =
byRepository(userName, repositoryName) && (this.milestoneId === milestoneId)
}
@@ -54,13 +72,13 @@ protected[model] trait TemplateComponent { self: Profile =>
def byCommit(owner: String, repository: String, commitId: String) =
byRepository(owner, repository) && (this.commitId === commitId)
def byCommit(owner: Column[String], repository: Column[String], commitId: Column[String]) =
def byCommit(owner: Rep[String], repository: Rep[String], commitId: Rep[String]) =
byRepository(userName, repositoryName) && (this.commitId === commitId)
}
trait BranchTemplate extends BasicTemplate{ self: Table[_] =>
val branch = column[String]("BRANCH")
def byBranch(owner: String, repository: String, branchName: String) = byRepository(owner, repository) && (branch === branchName.bind)
def byBranch(owner: Column[String], repository: Column[String], branchName: Column[String]) = byRepository(owner, repository) && (this.branch === branchName)
def byBranch(owner: Rep[String], repository: Rep[String], branchName: Rep[String]) = byRepository(owner, repository) && (this.branch === branchName)
}
}

View File

@@ -1,7 +1,7 @@
package gitbucket.core.model
trait CollaboratorComponent extends TemplateComponent { self: Profile =>
import profile.simple._
import profile.api._
lazy val Collaborators = TableQuery[Collaborators]
@@ -37,4 +37,4 @@ object Role {
//
// def valueOf(name: String): Option[Permission] = map.get(name)
}
}

View File

@@ -6,12 +6,10 @@ trait Comment {
}
trait IssueCommentComponent extends TemplateComponent { self: Profile =>
import profile.simple._
import profile.api._
import self._
lazy val IssueComments = new TableQuery(tag => new IssueComments(tag)){
def autoInc = this returning this.map(_.commentId)
}
lazy val IssueComments = TableQuery[IssueComments]
class IssueComments(tag: Tag) extends Table[IssueComment](tag, "ISSUE_COMMENT") with IssueTemplate {
val commentId = column[Int]("COMMENT_ID", O AutoInc)
@@ -39,12 +37,10 @@ case class IssueComment (
) extends Comment
trait CommitCommentComponent extends TemplateComponent { self: Profile =>
import profile.simple._
import profile.api._
import self._
lazy val CommitComments = new TableQuery(tag => new CommitComments(tag)){
def autoInc = this returning this.map(_.commentId)
}
lazy val CommitComments = TableQuery[CommitComments]
class CommitComments(tag: Tag) extends Table[CommitComment](tag, "COMMIT_COMMENT") with CommitTemplate {
val commentId = column[Int]("COMMENT_ID", O AutoInc)

View File

@@ -1,10 +1,7 @@
package gitbucket.core.model
import scala.slick.lifted.MappedTo
import scala.slick.jdbc._
trait CommitStatusComponent extends TemplateComponent { self: Profile =>
import profile.simple._
import profile.api._
import self._
implicit val commitStateColumnType = MappedColumnType.base[CommitState, String](b => b.name , i => CommitState(i))
@@ -90,7 +87,5 @@ object CommitState {
}
}
implicit val getResult: GetResult[CommitState] = GetResult(r => CommitState(r.<<))
implicit val getResultOpt: GetResult[Option[CommitState]] = GetResult(r => r.<<?[String].map(CommitState(_)))
}

View File

@@ -0,0 +1,27 @@
package gitbucket.core.model
trait DeployKeyComponent extends TemplateComponent { self: Profile =>
import profile.api._
lazy val DeployKeys = TableQuery[DeployKeys]
class DeployKeys(tag: Tag) extends Table[DeployKey](tag, "DEPLOY_KEY") with BasicTemplate {
val deployKeyId = column[Int]("DEPLOY_KEY_ID", O AutoInc)
val title = column[String]("TITLE")
val publicKey = column[String]("PUBLIC_KEY")
val allowWrite = column[Boolean]("ALLOW_WRITE")
def * = (userName, repositoryName, deployKeyId, title, publicKey, allowWrite) <> (DeployKey.tupled, DeployKey.unapply)
def byPrimaryKey(userName: String, repositoryName: String, deployKeyId: Int) =
(this.userName === userName.bind) && (this.repositoryName === repositoryName.bind) && (this.deployKeyId === deployKeyId.bind)
}
}
case class DeployKey(
userName: String,
repositoryName: String,
deployKeyId: Int = 0,
title: String,
publicKey: String,
allowWrite: Boolean
)

View File

@@ -1,7 +1,7 @@
package gitbucket.core.model
trait GroupMemberComponent { self: Profile =>
import profile.simple._
import profile.api._
lazy val GroupMembers = TableQuery[GroupMembers]

View File

@@ -1,7 +1,7 @@
package gitbucket.core.model
trait IssueComponent extends TemplateComponent { self: Profile =>
import profile.simple._
import profile.api._
import self._
lazy val IssueId = TableQuery[IssueId]
@@ -13,12 +13,13 @@ trait IssueComponent extends TemplateComponent { self: Profile =>
def byPrimaryKey(owner: String, repository: String) = byRepository(owner, repository)
}
class IssueOutline(tag: Tag) extends Table[(String, String, Int, Int)](tag, "ISSUE_OUTLINE_VIEW") with IssueTemplate {
class IssueOutline(tag: Tag) extends Table[(String, String, Int, Int, Int)](tag, "ISSUE_OUTLINE_VIEW") with IssueTemplate {
val commentCount = column[Int]("COMMENT_COUNT")
def * = (userName, repositoryName, issueId, commentCount)
val priority = column[Int]("PRIORITY")
def * = (userName, repositoryName, issueId, commentCount, priority)
}
class Issues(tag: Tag) extends Table[Issue](tag, "ISSUE") with IssueTemplate with MilestoneTemplate {
class Issues(tag: Tag) extends Table[Issue](tag, "ISSUE") with IssueTemplate with MilestoneTemplate with PriorityTemplate {
val openedUserName = column[String]("OPENED_USER_NAME")
val assignedUserName = column[String]("ASSIGNED_USER_NAME")
val title = column[String]("TITLE")
@@ -27,7 +28,7 @@ trait IssueComponent extends TemplateComponent { self: Profile =>
val registeredDate = column[java.util.Date]("REGISTERED_DATE")
val updatedDate = column[java.util.Date]("UPDATED_DATE")
val pullRequest = column[Boolean]("PULL_REQUEST")
def * = (userName, repositoryName, issueId, openedUserName, milestoneId.?, assignedUserName.?, title, content.?, closed, registeredDate, updatedDate, pullRequest) <> (Issue.tupled, Issue.unapply)
def * = (userName, repositoryName, issueId, openedUserName, milestoneId.?, priorityId.?, assignedUserName.?, title, content.?, closed, registeredDate, updatedDate, pullRequest) <> (Issue.tupled, Issue.unapply)
def byPrimaryKey(owner: String, repository: String, issueId: Int) = byIssue(owner, repository, issueId)
}
@@ -39,6 +40,7 @@ case class Issue(
issueId: Int,
openedUserName: String,
milestoneId: Option[Int],
priorityId: Option[Int],
assignedUserName: Option[String],
title: String,
content: Option[String],

View File

@@ -1,7 +1,7 @@
package gitbucket.core.model
trait IssueLabelComponent extends TemplateComponent { self: Profile =>
import profile.simple._
import profile.api._
lazy val IssueLabels = TableQuery[IssueLabels]

View File

@@ -1,7 +1,7 @@
package gitbucket.core.model
trait LabelComponent extends TemplateComponent { self: Profile =>
import profile.simple._
import profile.api._
lazy val Labels = TableQuery[Labels]
@@ -12,7 +12,7 @@ trait LabelComponent extends TemplateComponent { self: Profile =>
def * = (userName, repositoryName, labelId, labelName, color) <> (Label.tupled, Label.unapply)
def byPrimaryKey(owner: String, repository: String, labelId: Int) = byLabel(owner, repository, labelId)
def byPrimaryKey(userName: Column[String], repositoryName: Column[String], labelId: Column[Int]) = byLabel(userName, repositoryName, labelId)
def byPrimaryKey(userName: Rep[String], repositoryName: Rep[String], labelId: Rep[Int]) = byLabel(userName, repositoryName, labelId)
}
}

View File

@@ -1,7 +1,7 @@
package gitbucket.core.model
trait MilestoneComponent extends TemplateComponent { self: Profile =>
import profile.simple._
import profile.api._
import self._
lazy val Milestones = TableQuery[Milestones]
@@ -9,13 +9,13 @@ trait MilestoneComponent extends TemplateComponent { self: Profile =>
class Milestones(tag: Tag) extends Table[Milestone](tag, "MILESTONE") with MilestoneTemplate {
override val milestoneId = column[Int]("MILESTONE_ID", O AutoInc)
val title = column[String]("TITLE")
val description = column[String]("DESCRIPTION")
val dueDate = column[java.util.Date]("DUE_DATE")
val closedDate = column[java.util.Date]("CLOSED_DATE")
def * = (userName, repositoryName, milestoneId, title, description.?, dueDate.?, closedDate.?) <> (Milestone.tupled, Milestone.unapply)
val description = column[Option[String]]("DESCRIPTION")
val dueDate = column[Option[java.util.Date]]("DUE_DATE")
val closedDate = column[Option[java.util.Date]]("CLOSED_DATE")
def * = (userName, repositoryName, milestoneId, title, description, dueDate, closedDate) <> (Milestone.tupled, Milestone.unapply)
def byPrimaryKey(owner: String, repository: String, milestoneId: Int) = byMilestone(owner, repository, milestoneId)
def byPrimaryKey(userName: Column[String], repositoryName: Column[String], milestoneId: Column[Int]) = byMilestone(userName, repositoryName, milestoneId)
def byPrimaryKey(userName: Rep[String], repositoryName: Rep[String], milestoneId: Rep[Int]) = byMilestone(userName, repositoryName, milestoneId)
}
}

View File

@@ -0,0 +1,43 @@
package gitbucket.core.model
trait PriorityComponent extends TemplateComponent { self: Profile =>
import profile.api._
lazy val Priorities = TableQuery[Priorities]
class Priorities(tag: Tag) extends Table[Priority](tag, "PRIORITY") with PriorityTemplate {
override val priorityId = column[Int]("PRIORITY_ID", O AutoInc)
override val priorityName = column[String]("PRIORITY_NAME")
val description = column[String]("DESCRIPTION")
val ordering = column[Int]("ORDERING")
val isDefault = column[Boolean]("IS_DEFAULT")
val color = column[String]("COLOR")
def * = (userName, repositoryName, priorityId, priorityName, description.?, isDefault, ordering, color) <> (Priority.tupled, Priority.unapply)
def byPrimaryKey(owner: String, repository: String, priorityId: Int) = byPriority(owner, repository, priorityId)
def byPrimaryKey(userName: Rep[String], repositoryName: Rep[String], priorityId: Rep[Int]) = byPriority(userName, repositoryName, priorityId)
}
}
case class Priority (
userName: String,
repositoryName: String,
priorityId: Int = 0,
priorityName: String,
description: Option[String],
isDefault: Boolean,
ordering: Int = 0,
color: String){
val fontColor = {
val r = color.substring(0, 2)
val g = color.substring(2, 4)
val b = color.substring(4, 6)
if(Integer.parseInt(r, 16) + Integer.parseInt(g, 16) + Integer.parseInt(b, 16) > 408){
"000000"
} else {
"ffffff"
}
}
}

View File

@@ -1,10 +1,11 @@
package gitbucket.core.model
import com.github.takezoe.slick.blocking.BlockingJdbcProfile
import gitbucket.core.util.DatabaseConfig
trait Profile {
val profile: slick.driver.JdbcProfile
import profile.simple._
val profile: BlockingJdbcProfile
import profile.blockingApi._
/**
* java.util.Date Mapped Column Types
@@ -14,11 +15,16 @@ trait Profile {
t => new java.util.Date(t.getTime)
)
/**
* WebHookBase.Event Column Types
*/
implicit val eventColumnType = MappedColumnType.base[WebHook.Event, String](_.name, WebHook.Event.valueOf(_))
/**
* Extends Column to add conditional condition
*/
implicit class RichColumn(c1: Column[Boolean]){
def &&(c2: => Column[Boolean], guard: => Boolean): Column[Boolean] = if(guard) c1 && c2 else c1
implicit class RichColumn(c1: Rep[Boolean]){
def &&(c2: => Rep[Boolean], guard: => Boolean): Rep[Boolean] = if(guard) c1 && c2 else c1
}
/**
@@ -46,12 +52,19 @@ trait CoreProfile extends ProfileProvider with Profile
with IssueCommentComponent
with IssueLabelComponent
with LabelComponent
with PriorityComponent
with MilestoneComponent
with PullRequestComponent
with RepositoryComponent
with SshKeyComponent
with WebHookComponent
with WebHookEventComponent
with RepositoryWebHookComponent
with RepositoryWebHookEventComponent
with AccountWebHookComponent
with AccountWebHookEventComponent
with AccountFederationComponent
with ProtectedBranchComponent
with DeployKeyComponent
with ReleaseComponent
with ReleaseAssetComponent
object Profile extends CoreProfile

View File

@@ -1,10 +1,7 @@
package gitbucket.core.model
import scala.slick.lifted.MappedTo
import scala.slick.jdbc._
trait ProtectedBranchComponent extends TemplateComponent { self: Profile =>
import profile.simple._
import profile.api._
import self._
lazy val ProtectedBranches = TableQuery[ProtectedBranches]
@@ -12,7 +9,7 @@ trait ProtectedBranchComponent extends TemplateComponent { self: Profile =>
val statusCheckAdmin = column[Boolean]("STATUS_CHECK_ADMIN")
def * = (userName, repositoryName, branch, statusCheckAdmin) <> (ProtectedBranch.tupled, ProtectedBranch.unapply)
def byPrimaryKey(userName: String, repositoryName: String, branch: String) = byBranch(userName, repositoryName, branch)
def byPrimaryKey(userName: Column[String], repositoryName: Column[String], branch: Column[String]) = byBranch(userName, repositoryName, branch)
def byPrimaryKey(userName: Rep[String], repositoryName: Rep[String], branch: Rep[String]) = byBranch(userName, repositoryName, branch)
}
lazy val ProtectedBranchContexts = TableQuery[ProtectedBranchContexts]

View File

@@ -1,7 +1,7 @@
package gitbucket.core.model
trait PullRequestComponent extends TemplateComponent { self: Profile =>
import profile.simple._
import profile.api._
lazy val PullRequests = TableQuery[PullRequests]
@@ -15,7 +15,7 @@ trait PullRequestComponent extends TemplateComponent { self: Profile =>
def * = (userName, repositoryName, issueId, branch, requestUserName, requestRepositoryName, requestBranch, commitIdFrom, commitIdTo) <> (PullRequest.tupled, PullRequest.unapply)
def byPrimaryKey(userName: String, repositoryName: String, issueId: Int) = byIssue(userName, repositoryName, issueId)
def byPrimaryKey(userName: Column[String], repositoryName: Column[String], issueId: Column[Int]) = byIssue(userName, repositoryName, issueId)
def byPrimaryKey(userName: Rep[String], repositoryName: Rep[String], issueId: Rep[Int]) = byIssue(userName, repositoryName, issueId)
}
}

View File

@@ -0,0 +1,34 @@
package gitbucket.core.model
trait ReleaseComponent extends TemplateComponent {
self: Profile =>
import profile.api._
import self._
lazy val Releases = TableQuery[Releases]
class Releases(tag_ : Tag) extends Table[Release](tag_, "RELEASE") with BasicTemplate {
val name = column[String]("NAME")
val tag = column[String]("TAG")
val author = column[String]("AUTHOR")
val content = column[Option[String]]("CONTENT")
val registeredDate = column[java.util.Date]("REGISTERED_DATE")
val updatedDate = column[java.util.Date]("UPDATED_DATE")
def * = (userName, repositoryName, name, tag, author, content, registeredDate, updatedDate) <> (Release.tupled, Release.unapply)
def byPrimaryKey(owner: String, repository: String, tag: String) = byTag(owner, repository, tag)
def byTag(owner: String, repository: String, tag: String) = byRepository(owner, repository) && (this.tag === tag.bind)
}
}
case class Release(
userName: String,
repositoryName: String,
name: String,
tag: String,
author: String,
content: Option[String],
registeredDate: java.util.Date,
updatedDate: java.util.Date
)

View File

@@ -0,0 +1,40 @@
package gitbucket.core.model
import java.util.Date
trait ReleaseAssetComponent extends TemplateComponent {
self: Profile =>
import profile.api._
import self._
lazy val ReleaseAssets = TableQuery[ReleaseAssets]
class ReleaseAssets(tag_ : Tag) extends Table[ReleaseAsset](tag_, "RELEASE_ASSET") with BasicTemplate {
val tag = column[String]("TAG")
val releaseAssetId = column[Int]("RELEASE_ASSET_ID", O AutoInc)
val fileName = column[String]("FILE_NAME")
val label = column[String]("LABEL")
val size = column[Long]("SIZE")
val uploader = column[String]("UPLOADER")
val registeredDate = column[Date]("REGISTERED_DATE")
val updatedDate = column[Date]("UPDATED_DATE")
def * = (userName, repositoryName, tag, releaseAssetId, fileName, label, size, uploader, registeredDate, updatedDate) <> (ReleaseAsset.tupled, ReleaseAsset.unapply)
def byPrimaryKey(owner: String, repository: String, tag: String, fileName: String) = byTag(owner, repository, tag) && (this.fileName === fileName.bind)
def byTag(owner: String, repository: String, tag: String) = byRepository(owner, repository) && (this.tag === tag.bind)
}
}
case class ReleaseAsset(
userName: String,
repositoryName: String,
tag: String,
releaseAssetId: Int = 0,
fileName: String,
label: String,
size: Long,
uploader: String,
registeredDate: Date,
updatedDate: Date
)

View File

@@ -1,7 +1,7 @@
package gitbucket.core.model
trait RepositoryComponent extends TemplateComponent { self: Profile =>
import profile.simple._
import profile.api._
import self._
lazy val Repositories = TableQuery[Repositories]

View File

@@ -0,0 +1,27 @@
package gitbucket.core.model
trait RepositoryWebHookComponent extends TemplateComponent { self: Profile =>
import profile.api._
implicit val whContentTypeColumnType = MappedColumnType.base[WebHookContentType, String](whct => whct.code , code => WebHookContentType.valueOf(code))
lazy val RepositoryWebHooks = TableQuery[RepositoryWebHooks]
class RepositoryWebHooks(tag: Tag) extends Table[RepositoryWebHook](tag, "WEB_HOOK") with BasicTemplate {
val url = column[String]("URL")
val token = column[Option[String]]("TOKEN")
val ctype = column[WebHookContentType]("CTYPE")
def * = (userName, repositoryName, url, ctype, token) <> ((RepositoryWebHook.apply _).tupled, RepositoryWebHook.unapply)
def byPrimaryKey(owner: String, repository: String, url: String) = byRepository(owner, repository) && (this.url === url.bind)
}
}
case class RepositoryWebHook(
userName: String,
repositoryName: String,
url: String,
ctype: WebHookContentType,
token: Option[String]
) extends WebHook

View File

@@ -0,0 +1,28 @@
package gitbucket.core.model
trait RepositoryWebHookEventComponent extends TemplateComponent { self: Profile =>
import profile.api._
import gitbucket.core.model.Profile.RepositoryWebHooks
lazy val RepositoryWebHookEvents = TableQuery[RepositoryWebHookEvents]
class RepositoryWebHookEvents(tag: Tag) extends Table[RepositoryWebHookEvent](tag, "WEB_HOOK_EVENT") with BasicTemplate {
val url = column[String]("URL")
val event = column[WebHook.Event]("EVENT")
def * = (userName, repositoryName, url, event) <> ((RepositoryWebHookEvent.apply _).tupled, RepositoryWebHookEvent.unapply)
def byRepositoryWebHook(owner: String, repository: String, url: String) = byRepository(owner, repository) && (this.url === url.bind)
def byRepositoryWebHook(owner: Rep[String], repository: Rep[String], url: Rep[String]) =
byRepository(userName, repositoryName) && (this.url === url)
def byRepositoryWebHook(webhook: RepositoryWebHooks) =
byRepository(webhook.userName, webhook.repositoryName) && (this.url === webhook.url)
def byPrimaryKey(owner: String, repository: String, url: String, event: WebHook.Event) = byRepositoryWebHook(owner, repository, url) && (this.event === event.bind)
}
}
case class RepositoryWebHookEvent(
userName: String,
repositoryName: String,
url: String,
event: WebHook.Event
)

View File

@@ -1,7 +1,7 @@
package gitbucket.core.model
trait SshKeyComponent { self: Profile =>
import profile.simple._
import profile.api._
lazy val SshKeys = TableQuery[SshKeys]

View File

@@ -1,27 +1,9 @@
package gitbucket.core.model
trait WebHookComponent extends TemplateComponent { self: Profile =>
import profile.simple._
implicit val whContentTypeColumnType = MappedColumnType.base[WebHookContentType, String](whct => whct.code , code => WebHookContentType.valueOf(code))
lazy val WebHooks = TableQuery[WebHooks]
class WebHooks(tag: Tag) extends Table[WebHook](tag, "WEB_HOOK") with BasicTemplate {
val url = column[String]("URL")
val token = column[Option[String]]("TOKEN", O.Nullable)
val ctype = column[WebHookContentType]("CTYPE", O.NotNull)
def * = (userName, repositoryName, url, ctype, token) <> ((WebHook.apply _).tupled, WebHook.unapply)
def byPrimaryKey(owner: String, repository: String, url: String) = byRepository(owner, repository) && (this.url === url.bind)
}
}
case class WebHookContentType(val code: String, val ctype: String)
abstract sealed case class WebHookContentType(code: String, ctype: String)
object WebHookContentType {
object JSON extends WebHookContentType("json", "application/json")
object FORM extends WebHookContentType("form", "application/x-www-form-urlencoded")
val values: Vector[WebHookContentType] = Vector(JSON, FORM)
@@ -34,16 +16,15 @@ object WebHookContentType {
def valueOpt(code: String): Option[WebHookContentType] = map.get(code)
}
case class WebHook(
userName: String,
repositoryName: String,
url: String,
ctype: WebHookContentType,
token: Option[String]
)
trait WebHook{
val url: String
val ctype: WebHookContentType
val token: Option[String]
}
object WebHook {
sealed class Event(var name: String)
abstract sealed class Event(val name: String)
case object CommitComment extends Event("commit_comment")
case object Create extends Event("create")
case object Delete extends Event("delete")
@@ -63,9 +44,31 @@ object WebHook {
case object Status extends Event("status")
case object TeamAdd extends Event("team_add")
case object Watch extends Event("watch")
object Event{
val values = List(CommitComment,Create,Delete,Deployment,DeploymentStatus,Fork,Gollum,IssueComment,Issues,Member,PageBuild,Public,PullRequest,PullRequestReviewComment,Push,Release,Status,TeamAdd,Watch)
private val map:Map[String,Event] = values.map(e => e.name -> e).toMap
val values = List(
CommitComment,
Create,
Delete,
Deployment,
DeploymentStatus,
Fork,
Gollum,
IssueComment,
Issues,
Member,
PageBuild,
Public,
PullRequest,
PullRequestReviewComment,
Push,
Release,
Status,
TeamAdd,
Watch
)
private val map: Map[String,Event] = values.map(e => e.name -> e).toMap
def valueOf(name: String): Event = map(name)
def valueOpt(name: String): Option[Event] = map.get(name)
}

View File

@@ -1,30 +0,0 @@
package gitbucket.core.model
trait WebHookEventComponent extends TemplateComponent { self: Profile =>
import profile.simple._
import gitbucket.core.model.Profile.WebHooks
lazy val WebHookEvents = TableQuery[WebHookEvents]
implicit val typedType = MappedColumnType.base[WebHook.Event, String](_.name, WebHook.Event.valueOf(_))
class WebHookEvents(tag: Tag) extends Table[WebHookEvent](tag, "WEB_HOOK_EVENT") with BasicTemplate {
val url = column[String]("URL")
val event = column[WebHook.Event]("EVENT")
def * = (userName, repositoryName, url, event) <> ((WebHookEvent.apply _).tupled, WebHookEvent.unapply)
def byWebHook(owner: String, repository: String, url: String) = byRepository(owner, repository) && (this.url === url.bind)
def byWebHook(owner: Column[String], repository: Column[String], url: Column[String]) =
byRepository(userName, repositoryName) && (this.url === url)
def byWebHook(webhook: WebHooks) =
byRepository(webhook.userName, webhook.repositoryName) && (this.url === webhook.url)
def byPrimaryKey(owner: String, repository: String, url: String, event: WebHook.Event) = byWebHook(owner, repository, url) && (this.event === event.bind)
}
}
case class WebHookEvent(
userName: String,
repositoryName: String,
url: String,
event: WebHook.Event
)

View File

@@ -0,0 +1,10 @@
package gitbucket.core.plugin
import gitbucket.core.model.Profile._
import profile.api._
trait AccountHook {
def deleted(userName: String)(implicit session: Session): Unit = ()
}

View File

@@ -0,0 +1,22 @@
package gitbucket.core.plugin
import gitbucket.core.controller.Context
import gitbucket.core.model.Issue
import gitbucket.core.service.RepositoryService.RepositoryInfo
import gitbucket.core.model.Profile._
import profile.api._
trait IssueHook {
def created(issue: Issue, repository: RepositoryInfo)(implicit session: Session, context: Context): Unit = ()
def addedComment(commentId: Int, content: String, issue: Issue, repository: RepositoryInfo)(implicit session: Session, context: Context): Unit = ()
def closed(issue: Issue, repository: RepositoryInfo)(implicit session: Session, context: Context): Unit = ()
def reopened(issue: Issue, repository: RepositoryInfo)(implicit session: Session, context: Context): Unit = ()
}
trait PullRequestHook extends IssueHook {
def merged(issue: Issue, repository: RepositoryInfo)(implicit session: Session, context: Context): Unit = ()
}

View File

@@ -1,12 +1,15 @@
package gitbucket.core.plugin
import javax.servlet.ServletContext
import gitbucket.core.controller.{Context, ControllerBase}
import gitbucket.core.model.Account
import gitbucket.core.model.{Account, Issue}
import gitbucket.core.service.RepositoryService.RepositoryInfo
import gitbucket.core.service.SystemSettingsService.SystemSettings
import gitbucket.core.util.ControlUtil._
import gitbucket.core.util.SyntaxSugars._
import io.github.gitbucket.solidbase.model.Version
import org.apache.sshd.server.Command
import play.twirl.api.Html
/**
* Trait for define plugin interface.
@@ -69,6 +72,16 @@ abstract class Plugin {
*/
def repositoryRoutings(registry: PluginRegistry, context: ServletContext, settings: SystemSettings): Seq[GitRepositoryRouting] = Nil
/**
* Override to add account hooks.
*/
val accountHooks: Seq[AccountHook] = Nil
/**
* Override to add account hooks.
*/
def accountHooks(registry: PluginRegistry, context: ServletContext, settings: SystemSettings): Seq[AccountHook] = Nil
/**
* Override to add receive hooks.
*/
@@ -79,6 +92,46 @@ abstract class Plugin {
*/
def receiveHooks(registry: PluginRegistry, context: ServletContext, settings: SystemSettings): Seq[ReceiveHook] = Nil
/**
* Override to add repository hooks.
*/
val repositoryHooks: Seq[RepositoryHook] = Nil
/**
* Override to add repository hooks.
*/
def repositoryHooks(registry: PluginRegistry, context: ServletContext, settings: SystemSettings): Seq[RepositoryHook] = Nil
/**
* Override to add issue hooks.
*/
val issueHooks: Seq[IssueHook] = Nil
/**
* Override to add issue hooks.
*/
def issueHooks(registry: PluginRegistry, context: ServletContext, settings: SystemSettings): Seq[IssueHook] = Nil
/**
* Override to add pull request hooks.
*/
val pullRequestHooks: Seq[PullRequestHook] = Nil
/**
* Override to add pull request hooks.
*/
def pullRequestHooks(registry: PluginRegistry, context: ServletContext, settings: SystemSettings): Seq[PullRequestHook] = Nil
/**
* Override to add repository headers.
*/
val repositoryHeaders: Seq[(RepositoryInfo, Context) => Option[Html]] = Nil
/**
* Override to add repository headers.
*/
def repositoryHeaders(registry: PluginRegistry, context: ServletContext, settings: SystemSettings): Seq[(RepositoryInfo, Context) => Option[Html]] = Nil
/**
* Override to add global menus.
*/
@@ -149,6 +202,16 @@ abstract class Plugin {
*/
def dashboardTabs(registry: PluginRegistry, context: ServletContext, settings: SystemSettings): Seq[(Context) => Option[Link]] = Nil
/**
* Override to add issue sidebars.
*/
val issueSidebars: Seq[(Issue, RepositoryInfo, Context) => Option[Html]] = Nil
/**
* Override to add issue sidebars.
*/
def issueSidebars(registry: PluginRegistry, context: ServletContext, settings: SystemSettings): Seq[(Issue, RepositoryInfo, Context) => Option[Html]] = Nil
/**
* Override to add assets mappings.
*/
@@ -179,6 +242,17 @@ abstract class Plugin {
*/
def suggestionProviders(registry: PluginRegistry, context: ServletContext, settings: SystemSettings): Seq[SuggestionProvider] = Nil
/**
* Override to add ssh command providers.
*/
val sshCommandProviders: Seq[PartialFunction[String, Command]] = Nil
/**
* Override to add ssh command providers.
*/
def sshCommandProviders(registry: PluginRegistry, context: ServletContext, settings: SystemSettings): Seq[PartialFunction[String, Command]] = Nil
/**
* This method is invoked in initialization of plugin system.
* Register plugin functionality to PluginRegistry.
@@ -199,9 +273,24 @@ abstract class Plugin {
(repositoryRoutings ++ repositoryRoutings(registry, context, settings)).foreach { routing =>
registry.addRepositoryRouting(routing)
}
(accountHooks ++ accountHooks(registry, context, settings)).foreach { accountHook =>
registry.addAccountHook(accountHook)
}
(receiveHooks ++ receiveHooks(registry, context, settings)).foreach { receiveHook =>
registry.addReceiveHook(receiveHook)
}
(repositoryHooks ++ repositoryHooks(registry, context, settings)).foreach { repositoryHook =>
registry.addRepositoryHook(repositoryHook)
}
(issueHooks ++ issueHooks(registry, context, settings)).foreach { issueHook =>
registry.addIssueHook(issueHook)
}
(pullRequestHooks ++ pullRequestHooks(registry, context, settings)).foreach { pullRequestHook =>
registry.addPullRequestHook(pullRequestHook)
}
(repositoryHeaders ++ repositoryHeaders(registry, context, settings)).foreach { repositoryHeader =>
registry.addRepositoryHeader(repositoryHeader)
}
(globalMenus ++ globalMenus(registry, context, settings)).foreach { globalMenu =>
registry.addGlobalMenu(globalMenu)
}
@@ -223,6 +312,9 @@ abstract class Plugin {
(dashboardTabs ++ dashboardTabs(registry, context, settings)).foreach { dashboardTab =>
registry.addDashboardTab(dashboardTab)
}
(issueSidebars ++ issueSidebars(registry, context, settings)).foreach { issueSidebarComponent =>
registry.addIssueSidebar(issueSidebarComponent)
}
(assetsMappings ++ assetsMappings(registry, context, settings)).foreach { assetMapping =>
registry.addAssetsMapping((assetMapping._1, assetMapping._2, getClass.getClassLoader))
}
@@ -232,14 +324,23 @@ abstract class Plugin {
(suggestionProviders ++ suggestionProviders(registry, context, settings)).foreach { suggestionProvider =>
registry.addSuggestionProvider(suggestionProvider)
}
(sshCommandProviders ++ sshCommandProviders(registry, context, settings)).foreach { sshCommandProvider =>
registry.addSshCommandProvider(sshCommandProvider)
}
}
/**
* This method is invoked in shutdown of plugin system.
* This method is invoked when the plugin system is shutting down.
* If the plugin has any resources, release them in this method.
*/
def shutdown(registry: PluginRegistry, context: ServletContext, settings: SystemSettings): Unit = {}
// /**
// * This method is invoked when this plugin is uninstalled.
// * Cleanup database or any other resources in this method if necessary.
// */
// def uninstall(registry: PluginRegistry, context: ServletContext, settings: SystemSettings): Unit = {}
/**
* Helper method to get a resource from classpath.
*/

Some files were not shown because too many files have changed in this diff Show More