Nemcio/GitBucket
1
0
Fork 0
mirror of https://github.com/gitbucket/gitbucket.git synced 2025-11-03 20:15:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

(refs #1554)Enable DB session for plugin git repo authentication

Browse Source
This commit is contained in:
Naoki Takezoe
2017-04-25 13:53:50 +09:00
parent 5337b29532
commit f46f5909f1
1 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/main/scala/gitbucket/core/servlet/GitAuthenticationFilter.scala
View File

@@ -51,8 +51,7 @@ class GitAuthenticationFilter extends Filter with RepositoryService with Account
private def pluginRepository(request: HttpServletRequest, response: HttpServletResponse, chain: FilterChain, private def pluginRepository(request: HttpServletRequest, response: HttpServletResponse, chain: FilterChain,
settings: SystemSettings, isUpdating: Boolean, filter: GitRepositoryFilter): Unit = { settings: SystemSettings, isUpdating: Boolean, filter: GitRepositoryFilter): Unit = {
implicit val r = request Database() withSession { implicit session =>
val account = for { val account = for {
auth <- Option(request.getHeader("Authorization")) auth <- Option(request.getHeader("Authorization"))
Array(username, password) = AuthUtil.decodeAuthHeader(auth).split(":", 2) Array(username, password) = AuthUtil.decodeAuthHeader(auth).split(":", 2)
@@ -62,12 +61,13 @@ class GitAuthenticationFilter extends Filter with RepositoryService with Account
account account
} }
if(filter.filter(request.gitRepositoryPath, account.map(_.userName), settings, isUpdating)){ if (filter.filter(request.gitRepositoryPath, account.map(_.userName), settings, isUpdating)) {
chain.doFilter(request, response) chain.doFilter(request, response)
} else { } else {
AuthUtil.requireAuth(response) AuthUtil.requireAuth(response)
} }
} }
}
private def defaultRepository(request: HttpServletRequest, response: HttpServletResponse, chain: FilterChain, private def defaultRepository(request: HttpServletRequest, response: HttpServletResponse, chain: FilterChain,
settings: SystemSettings, isUpdating: Boolean): Unit = { settings: SystemSettings, isUpdating: Boolean): Unit = {