refactoring. avoid Option#get

This commit is contained in:
xuwei-k
2013-10-14 01:18:31 +09:00
parent 7de0a3fd70
commit d772fc3ba2

View File

@@ -9,13 +9,10 @@ trait PullRequestService { self: IssuesService =>
import PullRequestService._ import PullRequestService._
def getPullRequest(owner: String, repository: String, issueId: Int): Option[(Issue, PullRequest)] = def getPullRequest(owner: String, repository: String, issueId: Int): Option[(Issue, PullRequest)] =
defining(getIssue(owner, repository, issueId.toString)){ issue => getIssue(owner, repository, issueId.toString).flatMap{ issue =>
if(issue.isDefined){ Query(PullRequests).filter(_.byPrimaryKey(owner, repository, issueId)).firstOption.map{
Query(PullRequests).filter(_.byPrimaryKey(owner, repository, issueId)).firstOption match { pullreq => (issue, pullreq)
case Some(pullreq) => Some((issue.get, pullreq))
case None => None
} }
} else None
} }
def getPullRequestCountGroupByUser(closed: Boolean, owner: String, repository: Option[String]): List[PullRequestCount] = def getPullRequestCountGroupByUser(closed: Boolean, owner: String, repository: Option[String]): List[PullRequestCount] =