Fixup

src/main/scala/gitbucket/core/view/helpers.scala

@@ -412,30 +412,4 @@ object helpers extends AvatarImageProvider with LinkConverter with RequestCache
    */
   def readableSize(size: Option[Long]): String = FileUtil.readableSize(size.getOrElse(0))
 
-
-  /**
-    *
-    * @param icon icon name: fa-* or octicon-*, for compatibility, it accepts name of octicon without octicon- prefix.
-    * @return icon tag String
-    */
-  def menuicon(icon:String): Html = {
-    icon match {
-      case i if i.startsWith("fa-") =>
-        Html(s"""<i class="menu-icon fa ${i}"></i>""")
-      case i if i.startsWith("octicon-") =>
-        Html(s"""<i class="menu-icon octicon ${i}"></i>""")
-      case i =>
-        Html(s"""<i class="menu-icon octicon octicon-${i}"></i>""")
-    }
-  }
-
-  /**
-    * make menu icon with octicon/font-awesome with Option[String]
-    * @param icon icon name: fa-* or octicon-*, for compatibility, it accepts name of octicon without octicon- prefix.
-    * @param defaultIcon default name for icon == None
-    * @return icon tag String
-    */
-  def menuicon(icon: Option[String], defaultIcon: String): Html = {
-    menuicon(icon.getOrElse(defaultIcon))
-  }
 }

src/main/twirl/gitbucket/core/account/application.scala.html

@@ -2,7 +2,6 @@
   personalTokens: List[gitbucket.core.model.AccessToken],
   gneratedToken: Option[(gitbucket.core.model.AccessToken, String)])(implicit context: gitbucket.core.controller.Context)
 @gitbucket.core.html.main("Applications"){
-<div class="container body">
   @gitbucket.core.account.html.menu("application", context.settings.ssh){
     <div class="panel panel-default">
       <div class="panel-heading strong">Personal access tokens</div>
@@ -49,5 +48,4 @@
       </div>
     </form>
   }
-</div>
 }

src/main/twirl/gitbucket/core/account/edit.scala.html

@@ -2,7 +2,6 @@
 @import gitbucket.core.util.LDAPUtil
 @import gitbucket.core.view.helpers
 @gitbucket.core.html.main("Edit your profile"){
-<div class="container body">
   @gitbucket.core.account.html.menu("profile", context.settings.ssh){
     @gitbucket.core.helper.html.information(info)
     @gitbucket.core.helper.html.error(error)
@@ -61,7 +60,6 @@
       </div>
     </form>
   }
-</div>
 }
 <script>
 $(function(){

src/main/twirl/gitbucket/core/account/menu.scala.html

@@ -1,33 +1,32 @@
 @(active: String, ssh: Boolean)(body: Html)(implicit context: gitbucket.core.controller.Context)
-@import gitbucket.core.view.helpers
 <div class="main-sidebar">
   <div class="sidebar">
     <ul class="sidebar-menu">
-      <li@if(active=="profile"){ class="active"}>
+      <li class="menu-item-hover @if(active=="profile"){active}">
         <a href="@context.path/@context.loginAccount.get.userName/_edit">
-          @helpers.menuicon("octicon-person")
+          <i class="menu-icon octicon octicon-person"></i>
           <span>Profile</span>
         </a>
       </li>
       @if(ssh){
-      <li@if(active=="ssh"){ class="active"}>
+      <li class="menu-item-hover @if(active=="ssh"){active}">
         <a href="@context.path/@context.loginAccount.get.userName/_ssh">
-          @helpers.menuicon("key")
+          <i class="menu-icon octicon octicon-key"></i>
           <span>SSH Keys</span>
         </a>
       </li>
       }
-      <li@if(active=="application"){ class="active"}>
+      <li class="menu-item-hover @if(active=="application"){active}">
         <a href="@context.path/@context.loginAccount.get.userName/_application">
-          @helpers.menuicon("rocket")
+          <i class="menu-icon octicon octicon-rocket"></i>
           <span>Applications</span>
         </a>
       </li>
       @gitbucket.core.plugin.PluginRegistry().getAccountSettingMenus.map { menu =>
         @menu(context).map { link =>
-          <li@if(active==link.id){ class="active"}>
+          <li class="menu-item-hover @if(active==link.id){active}">
             <a href="@context.path/@link.path">
-              @helpers.menuicon(link.icon, "octicon-plug")
+              <i class="menu-icon octicon octicon-plug"></i>
               <span>@link.label</span>
             </a>
           </li>

src/main/twirl/gitbucket/core/account/ssh.scala.html

@@ -1,7 +1,6 @@
 @(account: gitbucket.core.model.Account, sshKeys: List[gitbucket.core.model.SshKey])(implicit context: gitbucket.core.controller.Context)
 @import gitbucket.core.ssh.SshUtil
 @gitbucket.core.html.main("SSH Keys"){
-<div class="container body">
   @gitbucket.core.account.html.menu("ssh", context.settings.ssh){
     <div class="panel panel-default">
       <div class="panel-heading strong">SSH Keys</div>
@@ -37,5 +36,4 @@
       </div>
     </form>
   }
-</div>
 }

src/main/twirl/gitbucket/core/admin/menu.scala.html

@@ -1,37 +1,42 @@
 @(active: String)(body: Html)(implicit context: gitbucket.core.controller.Context)
-@import gitbucket.core.view.helpers
 <div class="main-sidebar">
   <div class="sidebar">
     <ul class="sidebar-menu" id="system-admin-menu-container">
-      <li@if(active=="users"){ class="active"}>
+      <li class="menu-item-hover @if(active=="users"){active}">
         <a href="@context.path/admin/users">
-          @helpers.menuicon("octicon-person")<span>User management</span>
+          <i class="menu-icon octicon octicon-person"></i>
+          <span>User management</span>
         </a>
       </li>
-      <li@if(active=="system"){ class="active"}>
+      <li class="menu-item-hover @if(active=="system"){active}">
         <a href="@context.path/admin/system">
-          @helpers.menuicon("octicon-gear")<span>System settings</span></a>
+          <i class="menu-icon octicon octicon-gear"></i>
+          <span>System settings</span></a>
       </li>
-      <li@if(active=="plugins"){ class="active"}>
+      <li class="menu-item-hover @if(active=="plugins"){active}">
         <a href="@context.path/admin/plugins">
-          @helpers.menuicon("octicon-plug")<span>Plugins</span>
+          <i class="menu-icon octicon octicon-plug"></i>
+          <span>Plugins</span>
         </a>
       </li>
-      <li@if(active=="data"){ class="active"}>
+      <li class="menu-item-hover @if(active=="data"){active}">
         <a href="@context.path/admin/data">
-          @helpers.menuicon("octicon-database")<span>Data export / import</span>
+          <i class="menu-icon octicon octicon-database"></i>
+          <span>Data export / import</span>
         </a>
       </li>
-      <li>
+      <li class="menu-item-hover">
         <a href="@context.path/console/login.jsp" target="_blank">
-          @helpers.menuicon("octicon-database")<span>H2 console</span>
+          <i class="menu-icon octicon octicon-database"></i>
+          <span>H2 console</span>
         </a>
       </li>
       @gitbucket.core.plugin.PluginRegistry().getSystemSettingMenus.map { menu =>
         @menu(context).map { link =>
           <li@if(active==link.id){ class="active"}>
             <a href="@context.path/@link.path">
-              @helpers.menuicon(link.icon, "octicon-plug")<span>@link.label</span>
+              <i class="menu-icon octicon octicon-plug"></i>
+              <span>@link.label</span>
             </a>
           </li>
         }

src/main/twirl/gitbucket/core/dashboard/sidebar.scala.html

@@ -14,7 +14,7 @@
     } else {
       <li><form class="sidebar-form"><input type="text" id="filter-box" class="form-control input-sm" placeholder="Find repository"/></form></li>
       @userRepositories.zipWithIndex.map { case (repository, i) =>
-        <li class="repo-link treeview">
+        <li class="menu-item-hover">
           @if(repository.owner == context.loginAccount.get.userName){
             <a href="@helpers.url(repository)">@gitbucket.core.helper.html.repositoryicon(repository, false) <span class="strong">@repository.name</span></a>
           } else {
@@ -30,7 +30,7 @@
     } else {
       <li><form class="sidebar-form"><input type="text" id="filter-box" class="form-control input-sm" placeholder="Find repository"/></form></li>
       @recentRepositories.zipWithIndex.map { case (repository, i) =>
-        <li class="repo-link treeview">
+        <li class="menu-item-hover">
           <a href="@helpers.url(repository)">@gitbucket.core.helper.html.repositoryicon(repository, false) <span>@repository.owner/<span class="strong">@repository.name</span></span></a>
         </li>
       }

src/main/twirl/gitbucket/core/main.scala.html

@@ -38,7 +38,7 @@
     }
     <script src="@helpers.assets("/vendors/AdminLTE-2.3.8/js/app.js")" type="text/javascript"></script>
   </head>
-  <body class="skin-blue page-load sidebar-mini @if(context.sidebarCollapse){sidebar-collapse}">
+  <body class="skin-blue page-load @if(body.toString.contains("menu-item-hover")){sidebar-mini} @if(context.sidebarCollapse){sidebar-collapse}">
     <div class="wrapper">
       <header class="main-header">
         <a href="@context.path/" class="logo">

src/main/twirl/gitbucket/core/menu.scala.html

@@ -6,22 +6,28 @@
 @import gitbucket.core.view.helpers
 
 @menuitem(path: String, name: String, label: String, icon: String, count: Int = 0) = {
-  <li class = "treeview @if(active == name){active}">
+  <li class = "menu-item-hover @if(active == name){active}">
     @if(path.startsWith("http")){
       <a href="@path" target="_blank">
-        @helpers.menuicon(icon)
-        <span>@label</span> @if(count > 0){ <span class="label label-primary pull-right-container">@count</span> }
+        <i class="menu-icon octicon octicon-@icon"></i>
+        <span>@label</span>
+        @if(count > 0){
+          <span class="pull-right-container"><span class="label label-primary pull-right-container">@count</span></span>
+        }
       </a>
     } else {
       <a href="@helpers.url(repository)@path">
-        @helpers.menuicon(icon)
-          <span>@label</span> @if(count > 0) { <span class="label label-primary pull-right-container">@count</span> }
+        <i class="menu-icon octicon octicon-@icon"></i>
+        <span>@label</span>
+        @if(count > 0) {
+          <span class="pull-right-container"><span class="label label-primary pull-right">@count</span></span>
+        }
       </a>
     }
   </li>
 }
 
-  <div class="main-sidebar">
+<div class="main-sidebar">
   <div class="sidebar">
     <ul class="sidebar-menu">
       @menuitem("", "files", "Files", "code")
@@ -59,8 +65,8 @@
       }
     </ul>
   </div>
-  </div>
-  <div class="content-wrapper">
+</div>
+<div class="content-wrapper">
   <div class="content body clearfix">
     <div class="headbar">
       <div class="container">
@@ -85,6 +91,5 @@
     </div>
     @body
   </div>
-  </div>
 </div>
 

src/main/webapp/assets/common/css/gitbucket.css

@@ -264,16 +264,6 @@ div.box-content {
   border-radius: 3px;
 }
 
-li.repo-link, li.page-link {
-  padding-top: 4px;
-  padding-bottom: 4px;
-  white-space: nowrap;
-  text-overflow: ellipsis;
-}
-body:not(.sidebar-collapse) li.repo-link, li.page-link{
-  overflow: hidden;
-}
-
 div.box-content-bottom {
   background-color: white;
   border: 1px solid #d8d8d8;
@@ -1845,19 +1835,14 @@ body.page-load * {
   transition: none !important;
 }
 
-body.sidebar-collapse .main-sidebar li.treeview:not(:hover) span.label.pull-right-container {
+body.sidebar-collapse .main-sidebar li.menu-item-hover:not(:hover) span.pull-right-container {
   display: inline !important;
   position: absolute;
-  top: 9px;
-  right: 7px;
-  text-align: center;
+  top: 8px;
+  right: 0px;
   font-size: 9px;
-  padding: 2px 3px;
-  line-height: .9;
 }
 
-body.sidebar-collapse .main-sidebar li.treeview:hover span.label.pull-right-container {
-  left: 180px !important;
-  margin-left: 0px;
-  padding: 12px 20px 12px 20px;
+body.sidebar-collapse .main-sidebar li.treeview:not(:hover) span.pull-right-container span.label {
+  padding: 2px 4px;
 }