(refs #28)Look up Gravatar if user icon is not configured.

2025-11-01 11:06:06 +01:00 · 2013-07-11 03:51:50 +09:00
parent 072290e544
commit 796a276b65
17 changed files with 53 additions and 27 deletions
--- a/src/main/scala/app/AccountController.scala
+++ b/src/main/scala/app/AccountController.scala
@@ -58,10 +58,10 @@ trait AccountControllerBase extends AccountManagementControllerBase with FlashMa
    getAccountByUserName(userName).flatMap(_.image).map { image =>
      contentType = FileUtil.getMimeType(image)
      new java.io.File(getUserUploadDir(userName), image)
-    } getOrElse {
-      contentType = "image/png"
-      Thread.currentThread.getContextClassLoader.getResourceAsStream("noimage.png")
-    }
+//    } getOrElse {
+//      contentType = "image/png"
+//      Thread.currentThread.getContextClassLoader.getResourceAsStream("noimage.png")
+    } getOrElse NotFound
  }

  get("/:userName/_edit")(oneselfOnly {
--- a/src/main/scala/app/ControllerBase.scala
+++ b/src/main/scala/app/ControllerBase.scala
@@ -10,6 +10,7 @@ import org.apache.commons.io.FileUtils
 import model.Account
 import scala.Some
 import service.AccountService
+import javax.servlet.http.HttpServletRequest

 /**
 * Provides generic features for controller implementations.
@@ -22,7 +23,7 @@ abstract class ControllerBase extends ScalatraFilter
  /**
   * Returns the context object for the request.
   */
-  implicit def context: Context = Context(servletContext.getContextPath, LoginAccount, currentURL)
+  implicit def context: Context = Context(servletContext.getContextPath, LoginAccount, currentURL, request)

  private def currentURL: String = {
    val queryString = request.getQueryString
@@ -94,7 +95,7 @@ abstract class ControllerBase extends ScalatraFilter
 /**
 * Context object for the current request.
 */
-case class Context(path: String, loginAccount: Option[Account], currentUrl: String)
+case class Context(path: String, loginAccount: Option[Account], currentUrl: String, request: HttpServletRequest)

 /**
 * Base trait for controllers which manages account information.
--- a/src/main/scala/util/StringUtil.scala
+++ b/src/main/scala/util/StringUtil.scala
@@ -8,4 +8,10 @@ object StringUtil {
    md.digest.map(b => "%02x".format(b)).mkString
  }

+  def md5(value: String): String = {
+    val md = java.security.MessageDigest.getInstance("MD5")
+    md.update(value.getBytes)
+    md.digest.map(b => "%02x".format(b)).mkString
+  }
+
 }
--- a/src/main/scala/view/helpers.scala
+++ b/src/main/scala/view/helpers.scala
@@ -2,6 +2,8 @@ package view
 import java.util.Date
 import java.text.SimpleDateFormat
 import twirl.api.Html
+import util.StringUtil
+import service.AccountService

 /**
 * Provides helper methods for Twirl templates.
@@ -73,6 +75,29 @@ object helpers {
      // convert commit id to link
      .replaceAll("(^|\\W)([a-f0-9]{40})(\\W|$)", "$1<a href=\"%s/%s/%s/commit/$2\">$2</a>$3").format(context.path, repository.owner, repository.name))

+  /**
+   * Returns &lt;img&gt; which displays the avatar icon.
+   * Looks up Gravatar if avatar icon has not been configured in user settings.
+   */
+  def avatar(userName: String, size: Int, tooltip: Boolean = false)(implicit context: app.Context): Html = {
+    val account = Option(context.request.getAttribute("cache.account." + userName).asInstanceOf[model.Account]).orElse {
+      new AccountService {}.getAccountByUserName(userName).map { account =>
+        context.request.setAttribute("cache.account." + userName, account)
+        account
+      }
+    }
+    val src = account.collect { case account if(account.image.isEmpty) =>
+      s"""http://www.gravatar.com/avatar/${StringUtil.md5(account.mailAddress)}?s=${size}"""
+    } getOrElse {
+      s"""${context.path}/${userName}/_avatar"""
+    }
+    if(tooltip){
+      Html(s"""<img src=${src} class="avatar" style="width: ${size}px; height: ${size}:px" data-toggle="tooltip" title=${userName}/>""")
+    } else {
+      Html(s"""<img src=${src} class="avatar" style="width: ${size}px; height: ${size}:px" />""")
+    }
+  }
+
  /**
   * Implicit conversion to add mkHtml() to Seq[Html].
   */
--- a/src/main/twirl/account/activity.scala.html
+++ b/src/main/twirl/account/activity.scala.html
@@ -6,7 +6,7 @@
    <div class="row-fluid">
      <div class="span4">
        <div class="block">
-          <div class="account-image">@helper.html.avatar(account.userName, 200)</div>
+          <div class="account-image">@avatar(account.userName, 200)</div>
          <div class="block-header">@account.userName</div>
        </div>
        <div class="block">
--- a/src/main/twirl/account/repositories.scala.html
+++ b/src/main/twirl/account/repositories.scala.html
@@ -6,7 +6,7 @@
    <div class="row-fluid">
      <div class="span4">
        <div class="block">
-          <div class="account-image">@helper.html.avatar(account.userName, 200)</div>
+          <div class="account-image">@avatar(account.userName, 200)</div>
          <div class="block-header">@account.userName</div>
        </div>
        <div class="block">
--- a/src/main/twirl/admin/users/list.scala.html
+++ b/src/main/twirl/admin/users/list.scala.html
@@ -14,7 +14,7 @@
              <a href="@path/admin/users/@account.userName/_edit">Edit</a>
            </div>
            <div class="strong">
-              @helper.html.avatar(account.userName, 20)
+              @avatar(account.userName, 20)
              <a href="@url(account.userName)">@account.userName</a>
              @if(account.isAdmin){
                (Administrator)
--- a/src/main/twirl/helper/activities.scala.html
+++ b/src/main/twirl/helper/activities.scala.html
@@ -8,7 +8,7 @@
    <div class="block">
      <div class="muted small">@datetime(activity.activityDate)</div>
      <div class="strong">
-        @helper.html.avatar(activity.activityUserName, 16)
+        @avatar(activity.activityUserName, 16)
        @activityMessage(activity.message)
      </div>
      @activity.additionalInfo.map { additionalInfo =>
--- a/src/main/twirl/helper/avatar.scala.html
+++ b/src/main/twirl/helper/avatar.scala.html
@@ -1,8 +0,0 @@
-@(userName: String, size: Int, tooltip: Boolean = false)(implicit context: app.Context)
-@import context._
-@import view.helpers._
-@if(tooltip){
-  <img src="@url(userName)/_avatar" data-toggle="tooltip" title="@userName" class="avatar" style="width: @(size)px; height: @(size)px;"/>
-} else {
-  <img src="@url(userName)/_avatar" class="avatar" style="width: @(size)px; height: @(size)px;"/>
-}
--- a/src/main/twirl/helper/uploadavatar.scala.html
+++ b/src/main/twirl/helper/uploadavatar.scala.html
@@ -4,7 +4,9 @@
  @if(account.nonEmpty && account.get.image.nonEmpty){
    <img src="@path/@account.get.userName/_avatar" style="with: 120px; height: 120px;"/>
  } else {
-    <div id="clickable">No Image</div>
+    <div id="clickable">
+      <a href="https://www.gravatar.com/" target="_blank">Gravatar</a> is used
+    </div>
  }
 </div>
@if(account.nonEmpty && account.get.image.nonEmpty){
--- a/src/main/twirl/issues/create.scala.html
+++ b/src/main/twirl/issues/create.scala.html
@@ -23,7 +23,7 @@
                <li><a href="javascript:void(0);" class="assign" data-name=""><i class="icon-remove-circle"></i> Clear assignee</a></li>
                <li class="divider"></li>
                @collaborators.map { collaborator =>
-                  <li><a href="javascript:void(0);" class="assign" data-name="@collaborator"><i class="icon-while"></i>@helper.html.avatar(collaborator, 20) @collaborator</a></li>
+                  <li><a href="javascript:void(0);" class="assign" data-name="@collaborator"><i class="icon-while"></i>@avatar(collaborator, 20) @collaborator</a></li>
                }
              }
            }
--- a/src/main/twirl/issues/issue.scala.html
+++ b/src/main/twirl/issues/issue.scala.html
@@ -31,7 +31,7 @@
          <div class="issue-info">
            <span id="label-assigned">
              @issue.assignedUserName.map { userName =>
-                @helper.html.avatar(userName, 20) <a href="@url(userName)" class="username strong">@userName</a> is assigned
+                @avatar(userName, 20) <a href="@url(userName)" class="username strong">@userName</a> is assigned
              }.getOrElse("No one is assigned")
            </span>
            @if(hasWritePermission){
@@ -39,7 +39,7 @@
                <li><a href="javascript:void(0);" class="assign" data-name=""><i class="icon-remove-circle"></i> Clear assignee</a></li>
                <li class="divider"></li>
                @collaborators.map { collaborator =>
-                  <li><a href="javascript:void(0);" class="assign" data-name="@collaborator"><i class="icon-white"></i>@helper.html.avatar(collaborator, 20) @collaborator</a></li>
+                  <li><a href="javascript:void(0);" class="assign" data-name="@collaborator"><i class="icon-white"></i>@avatar(collaborator, 20) @collaborator</a></li>
                }
              }
            }
--- a/src/main/twirl/issues/list.scala.html
+++ b/src/main/twirl/issues/list.scala.html
@@ -219,7 +219,7 @@
              }
              <span class="pull-right muted">
                @issue.assignedUserName.map { userName =>
-                  @helper.html.avatar(userName, 20, true)
+                  @avatar(userName, 20, true)
                }
                #@issue.issueId
              </span>
--- a/src/main/twirl/repo/commit.scala.html
+++ b/src/main/twirl/repo/commit.scala.html
@@ -43,7 +43,7 @@
    </tr>
    <tr>
      <td>
-        @helper.html.avatar(commit.committer, 20)
+        @avatar(commit.committer, 20)
        <a href="@url(commit.committer)" class="username strong">@commit.committer</a>
        <span class="muted">@datetime(commit.time)</span>
        <div class="pull-right monospace small" style="text-align: right;">
--- a/src/main/twirl/repo/commits.scala.html
+++ b/src/main/twirl/repo/commits.scala.html
@@ -38,7 +38,7 @@
            <a href="@url(repository)/tree/@commit.id" class="small">Browse code</a>
          </div>
          <div>
-            <div class="commit-avatar-image">@helper.html.avatar(commit.committer, 40)</div>
+            <div class="commit-avatar-image">@avatar(commit.committer, 40)</div>
            <a href="@url(repository)/commit/@commit.id" class="commit-message" style="font-weight: bold;">@link(commit.summary, repository)</a>
            @if(commit.description.isDefined){
              <a href="javascript:void(0)" onclick="$('#description-@commit.id').toggle();" class="omit">...</a>
--- a/src/main/twirl/repo/files.scala.html
+++ b/src/main/twirl/repo/files.scala.html
@@ -36,7 +36,7 @@
      <tr>
        <td colspan="4" class="latest-commit">
          <div>
-            @helper.html.avatar(latestCommit.committer, 20)
+            @avatar(latestCommit.committer, 20)
            <a href="@url(latestCommit.committer)" class="username strong">@latestCommit.committer</a>
            <span class="muted">@datetime(latestCommit.time)</span>
            <div class="pull-right align-right monospace">
--- a/src/main/twirl/wiki/history.scala.html
+++ b/src/main/twirl/wiki/history.scala.html
@@ -35,7 +35,7 @@
    @commits.map { commit =>
      <tr>
        <td width="0%"><input type="checkbox" name="commitId" value="@commit.id"></td>
-        <td>@helper.html.avatar(commit.committer, 20)<a href="@url(commit.committer)">@commit.committer</a></td>
+        <td>@avatar(commit.committer, 20)<a href="@url(commit.committer)">@commit.committer</a></td>
        <td width="80%">
          <span class="muted">@datetime(commit.time):</span>
          @commit.shortMessage