mirror of
https://github.com/gitbucket/gitbucket.git
synced 2025-11-03 03:55:58 +01:00
Improve pull request comments presentation
This commit is contained in:
@@ -1,6 +1,6 @@
|
||||
package gitbucket.core.controller
|
||||
|
||||
import gitbucket.core.model.WebHook
|
||||
import gitbucket.core.model.{CommitComment, IssueComment, WebHook}
|
||||
import gitbucket.core.plugin.PluginRegistry
|
||||
import gitbucket.core.pulls.html
|
||||
import gitbucket.core.service.CommitStatusService
|
||||
@@ -117,14 +117,25 @@ trait PullRequestsControllerBase extends ControllerBase {
|
||||
git =>
|
||||
val (commits, diffs) =
|
||||
getRequestCompareInfo(owner, name, pullreq.commitIdFrom, owner, name, pullreq.commitIdTo)
|
||||
html.pullreq(
|
||||
issue,
|
||||
pullreq,
|
||||
(commits.flatten
|
||||
|
||||
val comments = (commits.flatten
|
||||
.map(commit => getCommitComments(owner, name, commit.id, true))
|
||||
.flatten
|
||||
.toList ::: getComments(owner, name, issueId))
|
||||
.sortWith((a, b) => a.registeredDate before b.registeredDate),
|
||||
.groupBy {
|
||||
case x: IssueComment => (None, None, None)
|
||||
case x: CommitComment => (x.fileName, x.oldLine, x.newLine)
|
||||
}
|
||||
.toSeq
|
||||
.sortWith {
|
||||
case ((key1, comments1), (key2, comments2)) =>
|
||||
comments1.head.registeredDate before comments2.head.registeredDate
|
||||
}
|
||||
|
||||
html.pullreq(
|
||||
issue,
|
||||
pullreq,
|
||||
comments,
|
||||
getIssueLabels(owner, name, issueId),
|
||||
getAssignableUserNames(owner, name),
|
||||
getMilestonesWithIssueCount(owner, name),
|
||||
|
||||
Reference in New Issue
Block a user