refactorings

src/routes/api/notes.js

@@ -127,69 +127,6 @@ function setNoteTypeMime(req) {
     note.save();
 }
 
-function getRelationMap(req) {
-    const {relationMapNoteId, noteIds} = req.body;
-
-    const resp = {
-        // noteId => title
-        noteTitles: {},
-        relations: [],
-        // relation name => inverse relation name
-        inverseRelations: {
-            'internalLink': 'internalLink'
-        }
-    };
-
-    if (noteIds.length === 0) {
-        return resp;
-    }
-
-    const questionMarks = noteIds.map(noteId => '?').join(',');
-
-    const relationMapNote = becca.getNote(relationMapNoteId);
-
-    const displayRelationsVal = relationMapNote.getLabelValue('displayRelations');
-    const displayRelations = !displayRelationsVal ? [] : displayRelationsVal
-        .split(",")
-        .map(token => token.trim());
-
-    const hideRelationsVal = relationMapNote.getLabelValue('hideRelations');
-    const hideRelations = !hideRelationsVal ? [] : hideRelationsVal
-        .split(",")
-        .map(token => token.trim());
-
-    const foundNoteIds = sql.getColumn(`SELECT noteId FROM notes WHERE isDeleted = 0 AND noteId IN (${questionMarks})`, noteIds);
-    const notes = becca.getNotes(foundNoteIds);
-
-    for (const note of notes) {
-        resp.noteTitles[note.noteId] = note.title;
-
-        resp.relations = resp.relations.concat(note.getRelations()
-            .filter(relation => !relation.isAutoLink() || displayRelations.includes(relation.name))
-            .filter(relation => displayRelations.length > 0
-                ? displayRelations.includes(relation.name)
-                : !hideRelations.includes(relation.name))
-            .filter(relation => noteIds.includes(relation.value))
-            .map(relation => ({
-                attributeId: relation.attributeId,
-                sourceNoteId: relation.noteId,
-                targetNoteId: relation.value,
-                name: relation.name
-            })));
-
-        for (const relationDefinition of note.getRelationDefinitions()) {
-            const def = relationDefinition.getDefinition();
-
-            if (def.inverseRelation) {
-                resp.inverseRelations[relationDefinition.getDefinedName()] = def.inverseRelation;
-                resp.inverseRelations[def.inverseRelation] = relationDefinition.getDefinedName();
-            }
-        }
-    }
-
-    return resp;
-}
-
 function changeTitle(req) {
     const noteId = req.params.noteId;
     const title = req.body.title;
@@ -273,6 +210,7 @@ function getDeleteNotesPreview(req) {
     if (noteIdsToBeDeleted.size > 0) {
         sql.fillParamList(noteIdsToBeDeleted);
 
+        // FIXME: No need to do this in database, can be done with becca data
         brokenRelations = sql.getRows(`
             SELECT attr.noteId, attr.name, attr.value
             FROM attributes attr
@@ -334,7 +272,6 @@ module.exports = {
     sortChildNotes,
     protectNote,
     setNoteTypeMime,
-    getRelationMap,
     changeTitle,
     duplicateSubtree,
     eraseDeletedNotesNow,