chore(client): review from Copilot

This commit is contained in:
Elian Doran
2025-11-09 15:13:57 +02:00
parent 1257e46852
commit ae1c8f0a0b
16 changed files with 17 additions and 19 deletions

View File

@@ -12,7 +12,6 @@ import type FNote from "../entities/fnote.js";
import type { CKTextEditor } from "@triliumnext/ckeditor5"; import type { CKTextEditor } from "@triliumnext/ckeditor5";
import type CodeMirror from "@triliumnext/codemirror"; import type CodeMirror from "@triliumnext/codemirror";
import { closeActiveDialog } from "../services/dialog.js"; import { closeActiveDialog } from "../services/dialog.js";
import { TypeWidget } from "../widgets/note_types.jsx";
import { ReactWrappedWidget } from "../widgets/basic_widget.js"; import { ReactWrappedWidget } from "../widgets/basic_widget.js";
export interface SetNoteOpts { export interface SetNoteOpts {

View File

@@ -1,4 +1,4 @@
import { useNoteContext, useTriliumEvent, useTriliumEvents } from "./react/hooks" import { useNoteContext, useTriliumEvent } from "./react/hooks"
import FNote from "../entities/fnote"; import FNote from "../entities/fnote";
import protected_session_holder from "../services/protected_session_holder"; import protected_session_holder from "../services/protected_session_holder";
import { useEffect, useRef, useState } from "preact/hooks"; import { useEffect, useRef, useState } from "preact/hooks";

View File

@@ -38,7 +38,7 @@ export default function AddLinkDialog() {
} else { } else {
setLinkType("reference-link"); setLinkType("reference-link");
} }
}, [ opts ]) }, [ opts ]);
async function setDefaultLinkTitle(noteId: string) { async function setDefaultLinkTitle(noteId: string) {
const noteTitle = await tree.getNoteTitle(noteId); const noteTitle = await tree.getNoteTitle(noteId);

View File

@@ -142,7 +142,7 @@ export default function NoteMap({ note, widgetMode, parentRef }: NoteMapProps) {
<div ref={styleResolverRef} class="style-resolver" /> <div ref={styleResolverRef} class="style-resolver" />
<div ref={containerRef} className="note-map-container" /> <div ref={containerRef} className="note-map-container" />
</div> </div>
) );
} }
function MapTypeSwitcher({ icon, text, type, currentMapType, setMapType }: { function MapTypeSwitcher({ icon, text, type, currentMapType, setMapType }: {

View File

@@ -167,7 +167,7 @@ export function setupRendering(graph: ForceGraph<NoteMapNodeObject, NoteMapLinkO
.linkWidth((link) => (highlightLinks.has(link) ? 3 : 0.4)) .linkWidth((link) => (highlightLinks.has(link) ? 3 : 0.4))
.linkColor((link) => (highlightLinks.has(link) ? cssData.textColor : cssData.mutedTextColor)) .linkColor((link) => (highlightLinks.has(link) ? cssData.textColor : cssData.mutedTextColor))
.linkDirectionalArrowLength(4) .linkDirectionalArrowLength(4)
.linkDirectionalArrowRelPos(0.95) .linkDirectionalArrowRelPos(0.95);
// Link-specific config // Link-specific config
if (mapType) { if (mapType) {

View File

@@ -1,12 +1,12 @@
import { CSSProperties } from "preact/compat"; import { CSSProperties } from "preact/compat";
import { DragData } from "../note_tree"; import { DragData } from "../note_tree";
import { FilterLabelsByType, KeyboardActionNames, OptionNames, RelationNames } from "@triliumnext/commons"; import { FilterLabelsByType, KeyboardActionNames, OptionNames, RelationNames } from "@triliumnext/commons";
import { Inputs, MutableRef, useCallback, useContext, useDebugValue, useEffect, useLayoutEffect, useMemo, useRef, useState } from "preact/hooks"; import { MutableRef, useCallback, useContext, useDebugValue, useEffect, useLayoutEffect, useMemo, useRef, useState } from "preact/hooks";
import { ParentComponent, refToJQuerySelector } from "./react_utils"; import { ParentComponent, refToJQuerySelector } from "./react_utils";
import { RefObject, VNode } from "preact"; import { RefObject, VNode } from "preact";
import { Tooltip } from "bootstrap"; import { Tooltip } from "bootstrap";
import { ViewMode, ViewScope } from "../../services/link"; import { ViewScope } from "../../services/link";
import appContext, { CommandListenerData, EventData, EventNames } from "../../components/app_context"; import appContext, { EventData, EventNames } from "../../components/app_context";
import attributes from "../../services/attributes"; import attributes from "../../services/attributes";
import BasicWidget, { ReactWrappedWidget } from "../basic_widget"; import BasicWidget, { ReactWrappedWidget } from "../basic_widget";
import Component from "../../components/component"; import Component from "../../components/component";

View File

@@ -1,4 +1,4 @@
import { useEffect, useRef, useState } from "preact/hooks"; import { useEffect, useRef } from "preact/hooks";
import { useEditorSpacedUpdate, useLegacyWidget } from "../react/hooks"; import { useEditorSpacedUpdate, useLegacyWidget } from "../react/hooks";
import { type TypeWidgetProps } from "./type_widget"; import { type TypeWidgetProps } from "./type_widget";
import LlmChatPanel from "../llm_chat"; import LlmChatPanel from "../llm_chat";

View File

@@ -1,4 +1,4 @@
import { useCallback, useContext, useEffect, useRef, useState } from "preact/hooks"; import { useContext, useEffect, useRef, useState } from "preact/hooks";
import { t } from "../../services/i18n"; import { t } from "../../services/i18n";
import FormGroup from "../react/FormGroup"; import FormGroup from "../react/FormGroup";
import NoteAutocomplete from "../react/NoteAutocomplete"; import NoteAutocomplete from "../react/NoteAutocomplete";

View File

@@ -1,4 +1,3 @@
import { VNode } from "preact";
import { useNoteBlob } from "../react/hooks"; import { useNoteBlob } from "../react/hooks";
import "./File.css"; import "./File.css";
import { TypeWidgetProps } from "./type_widget"; import { TypeWidgetProps } from "./type_widget";

View File

@@ -1,6 +1,6 @@
import { useEffect, useRef, useState } from "preact/hooks"; import { useEffect, useRef, useState } from "preact/hooks";
import { createImageSrcUrl } from "../../services/utils"; import { createImageSrcUrl } from "../../services/utils";
import { useNoteBlob, useTriliumEvent, useUniqueName } from "../react/hooks"; import { useTriliumEvent, useUniqueName } from "../react/hooks";
import "./Image.css"; import "./Image.css";
import { TypeWidgetProps } from "./type_widget"; import { TypeWidgetProps } from "./type_widget";
import WheelZoom from 'vanilla-js-wheel-zoom'; import WheelZoom from 'vanilla-js-wheel-zoom';

View File

@@ -7,7 +7,7 @@ import nodeMenu from "@mind-elixir/node-menu";
import "mind-elixir/style"; import "mind-elixir/style";
import "@mind-elixir/node-menu/dist/style.css"; import "@mind-elixir/node-menu/dist/style.css";
import "./MindMap.css"; import "./MindMap.css";
import { useEditorSpacedUpdate, useNoteLabelBoolean, useSyncedRef, useTriliumEvent, useTriliumEvents, useTriliumOptionBool } from "../react/hooks"; import { useEditorSpacedUpdate, useNoteLabelBoolean, useSyncedRef, useTriliumEvent, useTriliumEvents } from "../react/hooks";
import { refToJQuerySelector } from "../react/react_utils"; import { refToJQuerySelector } from "../react/react_utils";
import utils from "../../services/utils"; import utils from "../../services/utils";

View File

@@ -202,5 +202,5 @@ export function CodeEditor({ parentComponent, ntxId, containerRef: externalConta
initialized.current.resolve(); initialized.current.resolve();
onInitialized?.(); onInitialized?.();
}} }}
/> />;
} }

View File

@@ -3,7 +3,7 @@ import { t } from "../../../services/i18n";
import SplitEditor, { PreviewButton, SplitEditorProps } from "./SplitEditor"; import SplitEditor, { PreviewButton, SplitEditorProps } from "./SplitEditor";
import { RawHtmlBlock } from "../../react/RawHtml"; import { RawHtmlBlock } from "../../react/RawHtml";
import server from "../../../services/server"; import server from "../../../services/server";
import svgPanZoom, { zoomIn } from "svg-pan-zoom"; import svgPanZoom from "svg-pan-zoom";
import { RefObject } from "preact"; import { RefObject } from "preact";
import { useElementSize, useTriliumEvent } from "../../react/hooks"; import { useElementSize, useTriliumEvent } from "../../react/hooks";
import utils from "../../../services/utils"; import utils from "../../../services/utils";

View File

@@ -10,7 +10,7 @@ import panzoom, { PanZoomOptions } from "panzoom";
import dialog from "../../../services/dialog"; import dialog from "../../../services/dialog";
import server from "../../../services/server"; import server from "../../../services/server";
import toast from "../../../services/toast"; import toast from "../../../services/toast";
import { CreateChildrenResponse, RelationMapPostResponse, RelationMapRelation } from "@triliumnext/commons"; import { CreateChildrenResponse, RelationMapPostResponse } from "@triliumnext/commons";
import RelationMapApi, { ClientRelation, MapData, MapDataNoteEntry, RelationType } from "./api"; import RelationMapApi, { ClientRelation, MapData, MapDataNoteEntry, RelationType } from "./api";
import setupOverlays, { uniDirectionalOverlays } from "./overlays"; import setupOverlays, { uniDirectionalOverlays } from "./overlays";
import { JsPlumb } from "./jsplumb"; import { JsPlumb } from "./jsplumb";
@@ -157,7 +157,7 @@ export default function RelationMap({ note, noteContext, ntxId }: TypeWidgetProp
))} ))}
</JsPlumb> </JsPlumb>
</div> </div>
) );
} }
function usePanZoom({ ntxId, containerRef, options, transformData, onTransform }: { function usePanZoom({ ntxId, containerRef, options, transformData, onTransform }: {

View File

@@ -141,7 +141,7 @@ export default function CKEditorWithWatchdog({ containerRef: externalContainerRe
async loadReferenceLinkTitle($el: JQuery<HTMLElement>, href: string | null = null) { async loadReferenceLinkTitle($el: JQuery<HTMLElement>, href: string | null = null) {
await link.loadReferenceLinkTitle($el, href); await link.loadReferenceLinkTitle($el, href);
} }
}) });
useEffect(() => { useEffect(() => {
const container = containerRef.current; const container = containerRef.current;

View File

@@ -258,7 +258,7 @@ export default function EditableText({ note, parentComponent, ntxId, noteContext
<EditableTextTouchBar watchdogRef={watchdogRef} refreshTouchBarRef={refreshTouchBarRef} /> <EditableTextTouchBar watchdogRef={watchdogRef} refreshTouchBarRef={refreshTouchBarRef} />
</> </>
) );
} }
function useTemplates() { function useTemplates() {