Dockery/Trilium
1
0
Fork 0
mirror of https://github.com/zadam/trilium.git synced 2025-10-31 18:36:30 +01:00
Code Issues Packages Projects Releases Activity

refactor(share_settings): get rid of save() method

Browse Source 
there's no need to execute PUT requests for *all* Share Settings, when any option changes

moved the code to inside the "change" event handlers
This commit is contained in:
Panagiotis Papadopoulos
2025-04-18 02:05:40 +02:00
parent 56fc2d9b30
commit ab901a5d32
1 changed files with 7 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/public/app/widgets/type_widgets/options/other/share_settings.ts
View File

@@ -61,9 +61,10 @@ export default class ShareSettingsOptions extends OptionsWidget {
this.$shareRootCheck = this.$widget.find(".share-root-check");
this.$shareRootStatus = this.$widget.find(".share-root-status");
this.$redirectBareDomain.on('change', () => {
this.$redirectBareDomain.on('change', async () => {
const redirectBareDomain = this.$redirectBareDomain.is(":checked");
this.save();
await this.updateOption<"redirectBareDomain">("redirectBareDomain", redirectBareDomain.toString());
// Show/hide share root status section based on redirectBareDomain checkbox
this.$shareRootCheck.toggle(redirectBareDomain);
@@ -72,14 +73,14 @@ export default class ShareSettingsOptions extends OptionsWidget {
}
});
this.$showLoginInShareTheme.on('change', () => {
this.$showLoginInShareTheme.on('change', async () => {
const showLoginInShareTheme = this.$showLoginInShareTheme.is(":checked");
this.save();
await this.updateOption<"showLoginInShareTheme">("showLoginInShareTheme", showLoginInShareTheme.toString());
});
this.$useCleanUrls.on('change', () => {
this.$useCleanUrls.on('change', async () => {
const useCleanUrls = this.$useCleanUrls.is(":checked");
this.save();
await this.updateOption<"useCleanUrls">("useCleanUrls", useCleanUrls.toString());
});
this.$sharePath.on('change', async () => {
@@ -131,22 +132,4 @@ export default class ShareSettingsOptions extends OptionsWidget {
$button.prop("disabled", false);
}
}
async save() {
const redirectBareDomain = this.$redirectBareDomain.is(":checked");
await this.updateOption<"redirectBareDomain">("redirectBareDomain", redirectBareDomain.toString());
const showLoginInShareTheme = this.$showLoginInShareTheme.is(":checked");
await this.updateOption<"showLoginInShareTheme">("showLoginInShareTheme", showLoginInShareTheme.toString());
const useCleanUrls = this.$useCleanUrls.is(":checked");
await this.updateOption<"useCleanUrls">("useCleanUrls", useCleanUrls.toString());
// Ensure sharePath always starts with a slash
let sharePath = this.$sharePath.val() as string;
if (sharePath && !sharePath.startsWith('/')) {
sharePath = '/' + sharePath;
}
await this.updateOption<"sharePath">("sharePath", sharePath);
}
}