Dockery/Trilium
1
0
Fork 0
mirror of https://github.com/zadam/trilium.git synced 2025-11-02 03:16:11 +01:00
Code Issues Packages Projects Releases Activity

feat(quick_search): remove some old variables that are no longer used now

Browse Source
This commit is contained in:
perf3ct
2025-08-27 22:33:38 +00:00
parent 6c26fa709e
commit 93e8459d4b
2 changed files with 6 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
apps/server/src/services/search/expressions/note_content_fulltext.ts
View File

@@ -281,11 +281,6 @@ class NoteContentFulltextExp extends Expression {
return false;
}
// Warn about large word counts but still attempt matching
if (words.length > FUZZY_SEARCH_CONFIG.PERFORMANCE_WARNING_WORDS) {
console.info(`Large word count for phrase matching: ${words.length} words - may take longer but will attempt full matching`);
}
// Find positions of each token
const tokenPositions: number[][] = this.tokens.map(token => {
const normalizedToken = normalizeSearchText(token);

29
apps/server/src/services/search/utils/text_utils.ts
View File

@@ -14,17 +14,11 @@ export const FUZZY_SEARCH_CONFIG = {
MAX_EDIT_DISTANCE: 2,
// Maximum proximity distance for phrase matching (in words)
MAX_PHRASE_PROXIMITY: 10,
// Large note threshold - above this, use optimized search strategy
// Large note threshold - above this, use optimized search strategy (fuzzy on title only)
LARGE_NOTE_THRESHOLD: 50000, // 50K words - switch to title-only fuzzy for performance
// Absolute hard limits for extreme cases - only to prevent system crashes
ABSOLUTE_MAX_CONTENT_SIZE: 100 * 1024 * 1024, // 100MB - extreme upper limit to prevent OOM
ABSOLUTE_MAX_WORD_COUNT: 2000000, // 2M words - extreme upper limit for word processing
// Performance warning thresholds - inform user but still attempt search
PERFORMANCE_WARNING_SIZE: 5 * 1024 * 1024, // 5MB - warn about potential performance impact
PERFORMANCE_WARNING_WORDS: 100000, // 100K words - warn about word count impact
// Progressive processing thresholds for very large content
PROGRESSIVE_PROCESSING_SIZE: 10 * 1024 * 1024, // 10MB - use progressive processing
PROGRESSIVE_PROCESSING_WORDS: 500000, // 500K words - use progressive processing
// Performance thresholds
EARLY_TERMINATION_THRESHOLD: 3,
} as const;
@@ -206,7 +200,8 @@ export function validateFuzzySearchTokens(tokens: string[], operator: string): {
/**
* Validates and preprocesses content for search operations.
* Philosophy: Try to search everything! Only block truly extreme cases that could crash the system.
* Only blocks truly extreme cases that could crash the system.
* Large notes (>50K words) are handled with optimized search strategy instead.
*
* @param content The content to validate and preprocess
* @param noteId The note ID (for logging purposes)
@@ -224,12 +219,7 @@ export function validateAndPreprocessContent(content: string, noteId?: string):
return content.substring(0, FUZZY_SEARCH_CONFIG.ABSOLUTE_MAX_CONTENT_SIZE);
}
// Warn about very large content but still process it
if (content.length > FUZZY_SEARCH_CONFIG.PERFORMANCE_WARNING_SIZE) {
console.info(`Large content for note ${noteId || 'unknown'}: ${content.length} bytes - processing may take time but will attempt full search`);
}
// For word count, be even more permissive - only block truly extreme cases
// For word count, only block truly extreme cases
const wordCount = content.split(/\s+/).length;
if (wordCount > FUZZY_SEARCH_CONFIG.ABSOLUTE_MAX_WORD_COUNT) {
console.error(`Word count exceeds absolute system limit for note ${noteId || 'unknown'}: ${wordCount} words - this could cause system instability`);
@@ -237,15 +227,8 @@ export function validateAndPreprocessContent(content: string, noteId?: string):
return content.split(/\s+/).slice(0, FUZZY_SEARCH_CONFIG.ABSOLUTE_MAX_WORD_COUNT).join(' ');
}
// Warn about high word counts but still process them
if (wordCount > FUZZY_SEARCH_CONFIG.PERFORMANCE_WARNING_WORDS) {
console.info(`High word count for note ${noteId || 'unknown'}: ${wordCount} words - phrase matching may take time but will attempt full search`);
}
// Progressive processing warning for very large content
if (content.length > FUZZY_SEARCH_CONFIG.PROGRESSIVE_PROCESSING_SIZE || wordCount > FUZZY_SEARCH_CONFIG.PROGRESSIVE_PROCESSING_WORDS) {
console.info(`Very large content for note ${noteId || 'unknown'} - using progressive processing to maintain responsiveness`);
}
// Notes above LARGE_NOTE_THRESHOLD will use optimized search strategy
// (handled in note_content_fulltext.ts)
return content;
}