db setup fixes

src/entities/note.js

@@ -95,16 +95,17 @@ class Note extends Entity {
                     this.content = "";
                 }
             }
+        }
 
         if (this.isStringNote()) {
-                this.content = this.content === null
+            return this.content === null
                 ? ""
                 : this.content.toString("UTF-8");
         }
-        }
-
+        else {
             return this.content;
         }
+    }
 
     /** @returns {Promise<*>} */
     async getJsonContent() {

src/entities/note_revision.js

@@ -89,16 +89,17 @@ class NoteRevision extends Entity {
                     this.content = "";
                 }
             }
+        }
 
         if (this.isStringNote()) {
-                this.content = this.content === null
+            return this.content === null
                 ? ""
                 : this.content.toString("UTF-8");
         }
-        }
-
+        else {
             return this.content;
         }
+    }
 
     /** @returns {Promise} */
     async setContent(content) {

src/public/javascripts/services/utils.js

@@ -256,6 +256,10 @@ function openDialog($dialog) {
 }
 
 function isHtmlEmpty(html) {
+    if (!html) {
+        return true;
+    }
+
     html = html.toLowerCase();
 
     return $("<div>").html(html).text().trim().length === 0

src/routes/api/notes.js

@@ -15,7 +15,7 @@ async function getNote(req) {
     }
 
     if (note.isStringNote()) {
-        await note.getContent();
+        note.content = await note.getContent();
 
         if (note.type === 'file') {
             note.content = note.content.substr(0, 10000);

src/services/notes.js

@@ -668,7 +668,7 @@ async function scanForLinks(note) {
         await note.setContent(newContent);
     }
     catch (e) {
-        log.error(`Could not scan for links note ${noteId}: ${e.message}`);
+        log.error(`Could not scan for links note ${note.noteId}: ${e.message} ${e.stack}`);
     }
 }