Dockery/Trilium
1
0
Fork 0
mirror of https://github.com/zadam/trilium.git synced 2025-12-21 07:39:55 +01:00
Code Issues Packages Projects Releases Activity

fix(popup_editor): respect user's read-only choice (closes #7715)

Browse Source
This commit is contained in:
Elian Doran
2025-11-25 08:19:48 +02:00
parent 3afe6df9f2
commit 24361ccd97
17 changed files with 241 additions and 119 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
apps/client/src/widgets/dialogs/PopupEditor.tsx
View File

@@ -15,6 +15,8 @@ import PromotedAttributes from "../PromotedAttributes";
import FloatingButtons from "../FloatingButtons";
import { DESKTOP_FLOATING_BUTTONS, MOBILE_FLOATING_BUTTONS, POPUP_HIDDEN_FLOATING_BUTTONS } from "../FloatingButtonsDefinitions";
import utils from "../../services/utils";
import tree from "../../services/tree";
import froca from "../../services/froca";
export default function PopupEditor() {
const [ shown, setShown ] = useState(false);
@@ -28,9 +30,19 @@ export default function PopupEditor() {
useTriliumEvent("openInPopup", async ({ noteIdOrPath }) => {
const noteContext = new NoteContext("_popup-editor");
const resolvedNotePath = await tree.resolveNotePath(noteIdOrPath, noteContext.hoistedNoteId);
if (!resolvedNotePath) return;
const noteId = tree.getNoteIdAndParentIdFromUrl(resolvedNotePath);
if (!noteId.noteId) return;
const note = await froca.getNote(noteId.noteId);
if (!note) return;
const hasUserSetNoteReadOnly = note.hasLabel("readOnly");
await noteContext.setNote(noteIdOrPath, {
viewScope: {
readOnlyTemporarilyDisabled: true
// Override auto-readonly notes to be editable, but respect user's choice to have a read-only note.
readOnlyTemporarilyDisabled: !hasUserSetNoteReadOnly
}
});