Merge pull request #3000 from sigaloid/master

Add config setting to disable update check

src/public/app/widgets/buttons/global_menu.js

@@ -1,6 +1,7 @@
 import BasicWidget from "../basic_widget.js";
 import utils from "../../services/utils.js";
 import UpdateAvailableWidget from "./update_available.js";
+import options from "../../services/options.js";
 
 const TPL = `
 <div class="dropdown global-menu dropright">
@@ -156,12 +157,14 @@ export default class GlobalMenuWidget extends BasicWidget {
     }
 
     async updateVersionStatus() {
-        const latestVersion = await this.fetchLatestVersion();
+        if (options.get("checkForUpdates") == 'true') {
+            const latestVersion = await this.fetchLatestVersion();
 
-        this.updateAvailableWidget.updateVersionStatus(latestVersion);
+            this.updateAvailableWidget.updateVersionStatus(latestVersion);
 
-        this.$updateToLatestVersionButton.toggle(latestVersion > glob.triliumVersion);
+            this.$updateToLatestVersionButton.toggle(latestVersion > glob.triliumVersion);
-        this.$updateToLatestVersionButton.find(".version-text").text(`Version ${latestVersion} is available, click to download.`);
+            this.$updateToLatestVersionButton.find(".version-text").text(`Version ${latestVersion} is available, click to download.`);
+        }
     }
 
     async fetchLatestVersion() {

src/public/app/widgets/dialogs/options/other.js

@@ -116,7 +116,17 @@ const TPL = `
         <label for="auto-readonly-size-code">Automatic readonly size (code notes)</label>
         <input class="form-control" id="auto-readonly-size-code" type="number" min="0">
     </div>
-</div>`;
+</div>
+<div>
+<h4>Network connections</h4>
+    
+<div class="form-group">
+    <input id="check-for-updates" type="checkbox" name="check-for-updates">
+    <label for="check-for-updates">Check for updates automatically</label>
+</div>
+</div>
+
+`;
 
 export default class ProtectedSessionOptions {
     constructor() {
@@ -142,7 +152,7 @@ export default class ProtectedSessionOptions {
         this.$availableLanguageCodes = $("#available-language-codes");
 
         if (utils.isElectron()) {
-            const {webContents} = utils.dynamicRequire('@electron/remote').getCurrentWindow();
+            const { webContents } = utils.dynamicRequire('@electron/remote').getCurrentWindow();
 
             this.$availableLanguageCodes.text(webContents.session.availableSpellCheckerLanguages.join(', '));
         }
@@ -250,6 +260,14 @@ export default class ProtectedSessionOptions {
 
             this.setImageCompression(isChecked);
         });
+
+        this.$checkForUpdates = $("#check-for-updates");
+        this.$checkForUpdates.on("change", () => {
+            const isChecked = this.$checkForUpdates.prop("checked");
+            const opts = { 'checkForUpdates': isChecked ? 'true' : 'false' };
+
+            server.put('options', opts).then(() => toastService.showMessage("Options changed have been saved."));
+        });
     }
 
     optionsLoaded(options) {
@@ -272,5 +290,10 @@ export default class ProtectedSessionOptions {
         const compressImages = options['compressImages'] === 'true';
         this.$enableImageCompression.prop('checked', compressImages);
         this.setImageCompression(compressImages);
+
+
+        const checkForUpdates = options['checkForUpdates'] === 'true';
+        this.$checkForUpdates.prop('checked', checkForUpdates);
+
     }
 }

src/routes/api/options.js

@@ -57,7 +57,8 @@ const ALLOWED_OPTIONS = new Set([
     'maxContentWidth',
     'compressImages',
     'downloadImagesAutomatically',
-    'minTocHeadings'
+    'minTocHeadings',
+    'checkForUpdates'
 ]);
 
 function getOptions() {

src/routes/login.js

@@ -5,6 +5,7 @@ const optionService = require('../services/options');
 const myScryptService = require('../services/my_scrypt');
 const log = require('../services/log');
 const passwordService = require("../services/password");
+const options = require('../services/options');
 
 function loginPage(req, res) {
     res.render('login', { failedAuth: false });
@@ -36,6 +37,7 @@ function setPassword(req, res) {
         return;
     }
 
+    options.setOption("checkForUpdates", req.body['check-for-updates'] == 'on');
     passwordService.setPassword(password1);
 
     res.redirect('login');

src/services/options_init.js

@@ -85,7 +85,8 @@ const defaultOptions = [
     { name: 'maxContentWidth', value: '1200', isSynced: false },
     { name: 'compressImages', value: 'true', isSynced: true },
     { name: 'downloadImagesAutomatically', value: 'true', isSynced: true },
-    { name: 'minTocHeadings', value: '5', isSynced: true }
+    { name: 'minTocHeadings', value: '5', isSynced: true },
+    { name: 'checkForUpdates', value: 'true', isSynced: true },
 ];
 
 function initStartupOptions() {

src/views/set_password.ejs

@@ -33,6 +33,11 @@
                     <input id="password" name="password2" placeholder="" class="form-control" type="password">
                 </div>
             </div>
+            <div class="form-group">
+                <input checked id="check-for-updates" type="checkbox" name="check-for-updates">
+                <label for="check-for-updates">Check for updates automatically</label>
+            </div>
+
             <div class="form-group">
                 <button class="btn btn-success">Set password</button>
             </div>