not generating externalLink labels anymore since there can be too many and benefit is too small

src/entities/note.js

@@ -812,10 +812,8 @@ class Note extends Entity {
             FROM attributes 
             WHERE noteId = ? AND 
                   isDeleted = 0 AND
-                  ((type = 'relation' AND 
+                  type = 'relation' AND
-                    name IN ('internalLink', 'imageLink', 'relationMapLink', 'includeNoteLink'))
+                  name IN ('internalLink', 'imageLink', 'relationMapLink', 'includeNoteLink')`, [this.noteId]);
-                  OR
-                   (type = 'label' AND name = 'externalLink'))`, [this.noteId]);
     }
 
     /**

src/public/javascripts/widgets/attributes.js

@@ -69,19 +69,7 @@ export default class AttributesWidget extends CollapsibleWidget {
     async renderAttributes(attributes, $container) {
         for (const attribute of attributes) {
             if (attribute.type === 'label') {
-                if (attribute.name === 'externalLink') {
-                    $container.append('@' + attribute.name + "=");
-                    $container.append(
-                        $('<a>')
-                            .text(attribute.value)
-                            .attr('href', attribute.value)
-                            .addClass('external')
-                    );
-                    $container.append(" ");
-                }
-                else {
                 $container.append(utils.formatLabel(attribute) + " ");
-                }
             } else if (attribute.type === 'relation') {
                 if (attribute.value) {
                     $container.append('@' + attribute.name + "=");

src/services/import/tar.js

@@ -152,11 +152,6 @@ async function importTar(taskContext, fileBuffer, importRootNote) {
                 continue;
             }
 
-            if (attr.type === 'label' && attr.name === 'externalLink') {
-                // also created automatically
-                continue;
-            }
-
             if (attr.type === 'relation') {
                 attr.value = getNewNoteId(attr.value);
             }

src/services/import/zip.js

@@ -154,11 +154,6 @@ async function importZip(taskContext, fileBuffer, importRootNote) {
                 continue;
             }
 
-            if (attr.type === 'label' && attr.name === 'externalLink') {
-                // also created automatically
-                continue;
-            }
-
             if (attr.type === 'relation') {
                 attr.value = getNewNoteId(attr.value);
             }

src/services/notes.js

@@ -225,20 +225,6 @@ function findInternalLinks(content, foundLinks) {
     return content.replace(/href="[^"]*#root/g, 'href="#root');
 }
 
-function findExternalLinks(content, foundLinks) {
-    const re = /href="([a-zA-Z]+:\/\/[^"]*)"/g;
-    let match;
-
-    while (match = re.exec(content)) {
-        foundLinks.push({
-            name: 'externalLink',
-            value: match[1]
-        });
-    }
-
-    return content;
-}
-
 function findIncludeNoteLinks(content, foundLinks) {
     const re = /<section class="include-note" data-note-id="([a-zA-Z0-9]+)">/g;
     let match;
@@ -392,7 +378,6 @@ async function saveLinks(note, content) {
     if (note.type === 'text') {
         content = findImageLinks(content, foundLinks);
         content = findInternalLinks(content, foundLinks);
-        content = findExternalLinks(content, foundLinks);
         content = findIncludeNoteLinks(content, foundLinks);
 
         content = await downloadImages(note.noteId, content);
@@ -407,12 +392,10 @@ async function saveLinks(note, content) {
     const existingLinks = await note.getLinks();
 
     for (const foundLink of foundLinks) {
-        if (foundLink.name !== 'externalLink') {
         const targetNote = await repository.getNote(foundLink.value);
         if (!targetNote || targetNote.isDeleted) {
             continue;
         }
-        }
 
         const existingLink = existingLinks.find(existingLink =>
             existingLink.value === foundLink.value
@@ -421,7 +404,7 @@ async function saveLinks(note, content) {
         if (!existingLink) {
             const newLink = await new Attribute({
                 noteId: note.noteId,
-                type: foundLink.name === 'externalLink' ? 'label' : 'relation',
+                type: 'relation',
                 name: foundLink.name,
                 value: foundLink.value,
             }).save();