Feature: Remove unused tests and add tests for DRF-api

core/tests/helpers.py

@@ -1,11 +1,7 @@
 from django.conf import settings
-from django.contrib.auth.models import Permission
 from django.core.files.images import ImageFile
-from django.db.models.query import QuerySet
-from django.test import TestCase
 from django_images.models import Thumbnail
 
-import factory
 from taggit.models import Tag
 
 from core.models import Pin, Image
@@ -15,78 +11,33 @@ from users.models import User
 TEST_IMAGE_PATH = 'logo.png'
 
 
-class UserFactory(factory.Factory):
-    FACTORY_FOR = User
-
-    username = factory.Sequence(lambda n: 'user_{}'.format(n))
-    email = factory.Sequence(lambda n: 'user_{}@example.com'.format(n))
-
-    @factory.post_generation(extract_prefix='password')
-    def set_password(self, create, extracted, **kwargs):
-        self.set_password(extracted)
-        self.save()
-
-    @factory.post_generation(extract_prefix='user_permissions')
-    def set_user_permissions(self, create, extracted, **kwargs):
-        self.user_permissions = Permission.objects.filter(codename__in=['add_pin', 'add_image'])
+def create_user(username):
+    user, _ = User.objects.get_or_create(
+        username='user_{}'.format(username),
+        defaults={
+            "email": 'user_{}@example.com'.format(username)
+        }
+    )
+    user.set_password("password")
+    user.save()
+    return user
 
 
-class TagFactory(factory.Factory):
-    FACTORY_FOR = Tag
-
-    name = factory.Sequence(lambda n: 'tag_{}'.format(n))
+def create_tag(name):
+    return Tag.objects.get_or_create(
+        name='tag_{}'.format(name),
+        slug='tag_{}'.format(name),
+    )
 
 
-class ImageFactory(factory.Factory):
-    FACTORY_FOR = Image
-
-    image = factory.LazyAttribute(lambda a: ImageFile(open(TEST_IMAGE_PATH, 'rb')))
-
-    @factory.post_generation()
-    def create_thumbnails(self, create, extracted, **kwargs):
-        for size in settings.IMAGE_SIZES.keys():
-            Thumbnail.objects.get_or_create_at_size(self.pk, size)
+def create_image():
+    image = Image.objects.create(image=ImageFile(open(TEST_IMAGE_PATH, 'rb')))
+    for size in settings.IMAGE_SIZES.keys():
+        Thumbnail.objects.get_or_create_at_size(image.pk, size)
+    return image
 
 
-class PinFactory(factory.Factory):
-    FACTORY_FOR = Pin
-
-    submitter = factory.SubFactory(UserFactory)
-    image = factory.SubFactory(ImageFactory)
-
-    @factory.post_generation(extract_prefix='tags')
-    def add_tags(self, create, extracted, **kwargs):
-        if isinstance(extracted, Tag):
-            self.tags.add(extracted)
-        elif isinstance(extracted, list):
-            self.tags.add(*extracted)
-        elif isinstance(extracted, QuerySet):
-            self.tags = extracted
-        else:
-            self.tags.add(TagFactory())
-
-
-class PinFactoryTest(TestCase):
-    def test_default_tags(self):
-        tags = PinFactory.create().tags.all()
-        self.assertTrue(all([tag.name.startswith('tag_') for tag in tags]))
-        self.assertEqual(tags.count(), 1)
-
-    def test_custom_tag(self):
-        custom = 'custom_tag'
-        self.assertEqual(PinFactory(tags=Tag.objects.create(name=custom)).tags.get(pk=1).name, custom)
-
-    def test_custom_tags_list(self):
-        tags = TagFactory.create_batch(2)
-        PinFactory(tags=tags)
-        self.assertEqual(Tag.objects.count(), 2)
-
-    def test_custom_tags_queryset(self):
-        TagFactory.create_batch(2)
-        tags = Tag.objects.all()
-        PinFactory(tags=tags)
-        self.assertEqual(Tag.objects.count(), 2)
-
-    def test_empty_tags(self):
-        PinFactory(tags=[])
-        self.assertEqual(Tag.objects.count(), 0)
+def create_pin(user, image, tags):
+    pin = Pin.objects.create(submitter=user, image=image)
+    pin.tags.set(*tags)
+    return pin