From f7d3489938f09be8a32406258204df58867d98c3 Mon Sep 17 00:00:00 2001
From: Manuel Ruwe <manuel.ruwe@bluewin.ch>
Date: Fri, 30 Dec 2022 17:13:54 +0100
Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Fix=20form=20validation=20and=20?=
 =?UTF-8?q?missing=20integration=20types?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../Tabs/GeneralTab/GeneralTab.tsx            |  3 ---
 .../InputElements/GenericSecretInput.tsx      |  6 +++++-
 .../InputElements/IntegrationSelector.tsx     | 21 ++++++++++++++++++-
 3 files changed, 25 insertions(+), 5 deletions(-)

diff --git a/src/components/Dashboard/Modals/EditAppModal/Tabs/GeneralTab/GeneralTab.tsx b/src/components/Dashboard/Modals/EditAppModal/Tabs/GeneralTab/GeneralTab.tsx
index 56a4e5e54..73c8db39a 100644
--- a/src/components/Dashboard/Modals/EditAppModal/Tabs/GeneralTab/GeneralTab.tsx
+++ b/src/components/Dashboard/Modals/EditAppModal/Tabs/GeneralTab/GeneralTab.tsx
@@ -21,7 +21,6 @@ export const GeneralTab = ({ form, openTab }: GeneralTabProps) => {
         placeholder="My example app"
         variant="default"
         withAsterisk
-        required
         {...form.getInputProps('name')}
       />
       <TextInput
@@ -31,7 +30,6 @@ export const GeneralTab = ({ form, openTab }: GeneralTabProps) => {
         placeholder="https://google.com"
         variant="default"
         withAsterisk
-        required
         {...form.getInputProps('url')}
         onChange={(e) => {
           form.setFieldValue('behaviour.externalUrl', e.target.value);
@@ -44,7 +42,6 @@ export const GeneralTab = ({ form, openTab }: GeneralTabProps) => {
         description={t('general.externalAddress.description')}
         placeholder="https://homarr.mywebsite.com/"
         variant="default"
-        required
         {...form.getInputProps('behaviour.externalUrl')}
       />
     </Tabs.Panel>
diff --git a/src/components/Dashboard/Modals/EditAppModal/Tabs/IntegrationTab/Components/InputElements/GenericSecretInput.tsx b/src/components/Dashboard/Modals/EditAppModal/Tabs/IntegrationTab/Components/InputElements/GenericSecretInput.tsx
index d768bda1b..778fc61b3 100644
--- a/src/components/Dashboard/Modals/EditAppModal/Tabs/IntegrationTab/Components/InputElements/GenericSecretInput.tsx
+++ b/src/components/Dashboard/Modals/EditAppModal/Tabs/IntegrationTab/Components/InputElements/GenericSecretInput.tsx
@@ -56,7 +56,11 @@ export const GenericSecretInput = ({
               {t('integration.secrets.clear')}
             </Button>
             {displayUpdateField === true ? (
-              <PasswordInput placeholder="new secret" width={200} {...props} />
+              <PasswordInput
+                placeholder="new secret"
+                styles={{ root: { width: 200 } }}
+                {...props}
+              />
             ) : (
               <Button onClick={() => setDisplayUpdateField(true)} variant="light">
                 {t('integration.secrets.update')}
diff --git a/src/components/Dashboard/Modals/EditAppModal/Tabs/IntegrationTab/Components/InputElements/IntegrationSelector.tsx b/src/components/Dashboard/Modals/EditAppModal/Tabs/IntegrationTab/Components/InputElements/IntegrationSelector.tsx
index 29dd32b16..41bf862cd 100644
--- a/src/components/Dashboard/Modals/EditAppModal/Tabs/IntegrationTab/Components/InputElements/IntegrationSelector.tsx
+++ b/src/components/Dashboard/Modals/EditAppModal/Tabs/IntegrationTab/Components/InputElements/IntegrationSelector.tsx
@@ -19,7 +19,6 @@ interface IntegrationSelectorProps {
 export const IntegrationSelector = ({ form }: IntegrationSelectorProps) => {
   const { t } = useTranslation('layout/modals/add-app');
 
-  // TODO: read this out from integrations dynamically.
   const data: SelectItem[] = [
     {
       value: 'sabnzbd',
@@ -51,6 +50,26 @@ export const IntegrationSelector = ({ form }: IntegrationSelectorProps) => {
       image: 'https://cdn.jsdelivr.net/gh/walkxhub/dashboard-icons/png/overseerr.png',
       label: 'Overseerr',
     },
+    {
+      value: 'sonarr',
+      image: 'https://cdn.jsdelivr.net/gh/walkxhub/dashboard-icons/png/sonarr.png',
+      label: 'Sonarr',
+    },
+    {
+      value: 'radarr',
+      image: 'https://cdn.jsdelivr.net/gh/walkxhub/dashboard-icons/png/radarr.png',
+      label: 'Radarr',
+    },
+    {
+      value: 'lidarr',
+      image: 'https://cdn.jsdelivr.net/gh/walkxhub/dashboard-icons/png/lidarr.png',
+      label: 'Lidarr',
+    },
+    {
+      value: 'readarr',
+      image: 'https://cdn.jsdelivr.net/gh/walkxhub/dashboard-icons/png/readarr.png',
+      label: 'Readarr',
+    },
   ].filter((x) => Object.keys(integrationFieldProperties).includes(x.value));
 
   const getNewProperties = (value: string | null): AppIntegrationPropertyType[] => {