🐛 Fix conditional useEffect causing crash

This commit is contained in:
Manuel Ruwe
2022-12-11 20:46:18 +01:00
parent e6bca05c90
commit c7719b7ad0

View File

@@ -45,6 +45,24 @@ export const IconSelector = ({
const [searchTerm, setSearchTerm] = useState<string>('');
const { classes } = useStyles();
const [debouncedValue] = useDebouncedValue(form.values.name, 500);
useEffect(() => {
if (allowServiceNamePropagation !== true) {
return;
}
const matchingDebouncedIcon = data?.find(
(x) => replaceCharacters(x.fileName.split('.')[0]) === replaceCharacters(form.values.name)
);
if (!matchingDebouncedIcon) {
return;
}
form.setFieldValue('appearance.iconUrl', matchingDebouncedIcon.url);
}, [form.values.name]);
if (isLoading || !data) {
return <Loader />;
}
@@ -58,24 +76,6 @@ export const IconSelector = ({
const isTruncated =
slicedFilteredItems.length > 0 && slicedFilteredItems.length !== filteredItems.length;
const [debouncedValue] = useDebouncedValue(form.values.name, 500);
useEffect(() => {
if (allowServiceNamePropagation !== true) {
return;
}
const matchingDebouncedIcon = data.find(
(x) => replaceCharacters(x.fileName.split('.')[0]) === replaceCharacters(debouncedValue)
);
if (!matchingDebouncedIcon) {
return;
}
form.setFieldValue('appearance.iconUrl', matchingDebouncedIcon.url);
}, [debouncedValue]);
return (
<Popover width={310}>
<Popover.Target>