From 319fb477444bae5cd4c847af9ebf9e35359fbb03 Mon Sep 17 00:00:00 2001 From: Meier Lukas Date: Tue, 5 Nov 2024 21:06:40 +0100 Subject: [PATCH] fix: change node-version for composite setup action to 22, remove unnecessary installation of node from docker deployment (#1429) --- .github/workflows/deployment-docker-image.yml | 25 +++---------------- tooling/github/setup/action.yml | 2 +- 2 files changed, 5 insertions(+), 22 deletions(-) diff --git a/.github/workflows/deployment-docker-image.yml b/.github/workflows/deployment-docker-image.yml index 35275a8da..f00513efd 100644 --- a/.github/workflows/deployment-docker-image.yml +++ b/.github/workflows/deployment-docker-image.yml @@ -33,9 +33,6 @@ jobs: deploy: name: Deploy docker image runs-on: ubuntu-latest - strategy: - matrix: - node-version: [20] steps: - name: Discord notification if: ${{ github.events.inputs.send-notifications != false }} @@ -57,21 +54,7 @@ jobs: DISCORD_WEBHOOK: ${{ secrets.DISCORD_WEBHOOK }} uses: Ilshidur/action-discord@master with: - args: "Semver computed next tag to be ${{ steps.semver.outputs.next }}. Current is ${{ steps.semver.outputs.current }}" - - uses: pnpm/action-setup@v2 - with: - version: 8 - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v4 - with: - node-version: ${{ matrix.node-version }} - - name: Discord notification - if: ${{ github.events.inputs.send-notifications != false }} - env: - DISCORD_WEBHOOK: ${{ secrets.DISCORD_WEBHOOK }} - uses: Ilshidur/action-discord@master - with: - args: "Built application artifacts. Building images..." + args: "Semver computed next tag to be ${{ steps.semver.outputs.next }}. Current is ${{ steps.semver.outputs.current }}. Building images..." - name: Log in to the Container registry uses: docker/login-action@v3 with: @@ -90,9 +73,9 @@ jobs: tags: | type=raw,value=alpha type=raw,value=early-adopters -# tags: | -# type=raw,value=latest -# type=raw,value=${{ steps.semver.outputs.next }} + # tags: | + # type=raw,value=latest + # type=raw,value=${{ steps.semver.outputs.next }} - name: Build and push id: buildPushAction uses: docker/build-push-action@v6 diff --git a/tooling/github/setup/action.yml b/tooling/github/setup/action.yml index 6e29909be..e5a50b4ce 100644 --- a/tooling/github/setup/action.yml +++ b/tooling/github/setup/action.yml @@ -7,7 +7,7 @@ runs: - uses: pnpm/action-setup@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 22 cache: "pnpm" - shell: bash